linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: manual merge of the imx-mxs tree with the net tree
@ 2023-10-11 23:14 Stephen Rothwell
  2023-10-12  0:43 ` Shawn Guo
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2023-10-11 23:14 UTC (permalink / raw)
  To: Shawn Guo, David Miller, Jakub Kicinski, Paolo Abeni
  Cc: Networking, Frank Li, Haibo Chen, Linux Kernel Mailing List,
	Linux Next Mailing List, Marc Kleine-Budde

[-- Attachment #1: Type: text/plain, Size: 3483 bytes --]

Hi all,

Today's linux-next merge of the imx-mxs tree got a conflict in:

  arch/arm64/boot/dts/freescale/imx93.dtsi

between commit:

  23ed2be5404d ("arm64: dts: imx93: add the Flex-CAN stop mode by GPR")

from the net tree and commit:

  d34d2aa594d0 ("arm64: dts: imx93: add edma1 and edma2")

from the imx-mxs tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc arch/arm64/boot/dts/freescale/imx93.dtsi
index dcf6e4846ac9,4a0d604fd0db..000000000000
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@@ -185,7 -185,47 +185,47 @@@
  			#size-cells = <1>;
  			ranges;
  
+ 			edma1: dma-controller@44000000 {
+ 				compatible = "fsl,imx93-edma3";
+ 				reg = <0x44000000 0x200000>;
+ 				#dma-cells = <3>;
+ 				dma-channels = <31>;
+ 				interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>,  //  0: Reserved
+ 					     <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>,  //  1: CANFD1
+ 					     <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>,  //  2: Reserved
+ 					     <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>,  //  3: GPIO1 CH0
+ 					     <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>,  //  4: GPIO1 CH1
+ 					     <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>, //  5: I3C1 TO Bus
+ 					     <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>, //  6: I3C1 From Bus
+ 					     <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>, //  7: LPI2C1 M TX
+ 					     <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>, //  8: LPI2C1 S TX
+ 					     <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>, //  9: LPI2C2 M RX
+ 					     <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>, // 10: LPI2C2 S RX
+ 					     <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>, // 11: LPSPI1 TX
+ 					     <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>, // 12: LPSPI1 RX
+ 					     <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>, // 13: LPSPI2 TX
+ 					     <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>, // 14: LPSPI2 RX
+ 					     <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>, // 15: LPTMR1
+ 					     <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>, // 16: LPUART1 TX
+ 					     <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>, // 17: LPUART1 RX
+ 					     <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>, // 18: LPUART2 TX
+ 					     <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>, // 19: LPUART2 RX
+ 					     <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>, // 20: S400
+ 					     <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>, // 21: SAI TX
+ 					     <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>, // 22: SAI RX
+ 					     <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>, // 23: TPM1 CH0/CH2
+ 					     <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>, // 24: TPM1 CH1/CH3
+ 					     <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>, // 25: TPM1 Overflow
+ 					     <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>, // 26: TMP2 CH0/CH2
+ 					     <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>, // 27: TMP2 CH1/CH3
+ 					     <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, // 28: TMP2 Overflow
+ 					     <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>, // 29: PDM
+ 					     <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>; // 30: ADC1
+ 				clocks = <&clk IMX93_CLK_EDMA1_GATE>;
+ 				clock-names = "dma";
+ 			};
+ 
 -			anomix_ns_gpr: syscon@44210000 {
 +			aonmix_ns_gpr: syscon@44210000 {
  				compatible = "fsl,imx93-aonmix-ns-syscfg", "syscon";
  				reg = <0x44210000 0x1000>;
  			};

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: linux-next: manual merge of the imx-mxs tree with the net tree
  2023-10-11 23:14 linux-next: manual merge of the imx-mxs tree with the net tree Stephen Rothwell
@ 2023-10-12  0:43 ` Shawn Guo
  2023-10-12  7:28   ` Marc Kleine-Budde
  0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2023-10-12  0:43 UTC (permalink / raw)
  To: Stephen Rothwell, Marc Kleine-Budde
  Cc: David Miller, Jakub Kicinski, Paolo Abeni, Networking, Frank Li,
	Haibo Chen, Linux Kernel Mailing List, Linux Next Mailing List

On Thu, Oct 12, 2023 at 10:14:34AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Today's linux-next merge of the imx-mxs tree got a conflict in:
> 
>   arch/arm64/boot/dts/freescale/imx93.dtsi
> 
> between commit:
> 
>   23ed2be5404d ("arm64: dts: imx93: add the Flex-CAN stop mode by GPR")

Marc,

Is there any particular reason why this dts change needs to go via net
tree?  Otherwise, could you drop it from net and let it go via i.MX tree?

Shawn

> 
> from the net tree and commit:
> 
>   d34d2aa594d0 ("arm64: dts: imx93: add edma1 and edma2")
> 
> from the imx-mxs tree.
> 
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging.  You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: linux-next: manual merge of the imx-mxs tree with the net tree
  2023-10-12  0:43 ` Shawn Guo
@ 2023-10-12  7:28   ` Marc Kleine-Budde
  0 siblings, 0 replies; 3+ messages in thread
From: Marc Kleine-Budde @ 2023-10-12  7:28 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Stephen Rothwell, David Miller, Jakub Kicinski, Paolo Abeni,
	Networking, Frank Li, Haibo Chen, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1323 bytes --]

On 12.10.2023 08:43:56, Shawn Guo wrote:
> On Thu, Oct 12, 2023 at 10:14:34AM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Today's linux-next merge of the imx-mxs tree got a conflict in:
> > 
> >   arch/arm64/boot/dts/freescale/imx93.dtsi
> > 
> > between commit:
> > 
> >   23ed2be5404d ("arm64: dts: imx93: add the Flex-CAN stop mode by GPR")
> 
> Marc,
> 
> Is there any particular reason why this dts change needs to go via net
> tree?  Otherwise, could you drop it from net and let it go via i.MX tree?

As far as I understand the problem, the imx93 A0 silicon was supposed to
have a functional auto-stop mode for the flexcan peripheral. But wakeup
stress tests show that it doesn't work reliable. So this and the
following patch switched the imx93 back to the "old" stop-mode via GPR,
which needs a DT update.

| 23ed2be5404d ("arm64: dts: imx93: add the Flex-CAN stop mode by GPR")
| 63ead535570f ("can: flexcan: remove the auto stop mode for IMX93")

See the description of 63ead535570f for more details.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-12  7:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-11 23:14 linux-next: manual merge of the imx-mxs tree with the net tree Stephen Rothwell
2023-10-12  0:43 ` Shawn Guo
2023-10-12  7:28   ` Marc Kleine-Budde

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).