* [PATCH V1 0/4] Enable TRNG for SA8775P and SC7280
@ 2023-10-15 19:38 Om Prakash Singh
2023-10-15 19:38 ` [PATCH V1 1/4] dt-bindings: crypto: qcom,prng: document SA8775P Om Prakash Singh
` (5 more replies)
0 siblings, 6 replies; 10+ messages in thread
From: Om Prakash Singh @ 2023-10-15 19:38 UTC (permalink / raw)
To: quic_omprsing
Cc: neil.armstrong, konrad.dybcio, agross, andersson, conor+dt,
davem, devicetree, herbert, krzysztof.kozlowski+dt,
linux-arm-msm, linux-crypto, linux-kernel, marijn.suijten,
robh+dt, vkoul
Add device-tree nodes to enable TRNG for SA8775P and SC7280
*** BLURB HERE ***
Om Prakash Singh (4):
dt-bindings: crypto: qcom,prng: document SA8775P
dt-bindings: crypto: qcom,prng: document SC7280
arm64: dts: qcom: sa8775p: add TRNG node
arm64: dts: qcom: sc7280: add TRNG node
Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 2 ++
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
arch/arm64/boot/dts/qcom/sc7280.dtsi | 5 +++++
3 files changed, 12 insertions(+)
--
2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH V1 1/4] dt-bindings: crypto: qcom,prng: document SA8775P
2023-10-15 19:38 [PATCH V1 0/4] Enable TRNG for SA8775P and SC7280 Om Prakash Singh
@ 2023-10-15 19:38 ` Om Prakash Singh
2023-10-16 2:41 ` Bjorn Andersson
2023-10-15 19:38 ` [PATCH V1 2/4] dt-bindings: crypto: qcom,prng: document SC7280 Om Prakash Singh
` (4 subsequent siblings)
5 siblings, 1 reply; 10+ messages in thread
From: Om Prakash Singh @ 2023-10-15 19:38 UTC (permalink / raw)
To: quic_omprsing
Cc: neil.armstrong, konrad.dybcio, agross, andersson, conor+dt,
davem, devicetree, herbert, krzysztof.kozlowski+dt,
linux-arm-msm, linux-crypto, linux-kernel, marijn.suijten,
robh+dt, vkoul
Document SA8775P compatible for the True Random Number Generator.
Signed-off-by: Om Prakash Singh <quic_omprsing@quicinc.com>
---
Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
index 633993f801c6..85e6b1c199f5 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
@@ -19,6 +19,7 @@ properties:
- enum:
- qcom,sm8450-trng
- qcom,sm8550-trng
+ - qcom,sa8775p-trng
- const: qcom,trng
reg:
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH V1 2/4] dt-bindings: crypto: qcom,prng: document SC7280
2023-10-15 19:38 [PATCH V1 0/4] Enable TRNG for SA8775P and SC7280 Om Prakash Singh
2023-10-15 19:38 ` [PATCH V1 1/4] dt-bindings: crypto: qcom,prng: document SA8775P Om Prakash Singh
@ 2023-10-15 19:38 ` Om Prakash Singh
2023-10-16 5:23 ` Krzysztof Kozlowski
2023-10-15 19:39 ` [PATCH V1 3/4] arm64: dts: qcom: sa8775p: add TRNG node Om Prakash Singh
` (3 subsequent siblings)
5 siblings, 1 reply; 10+ messages in thread
From: Om Prakash Singh @ 2023-10-15 19:38 UTC (permalink / raw)
To: quic_omprsing
Cc: neil.armstrong, konrad.dybcio, agross, andersson, conor+dt,
davem, devicetree, herbert, krzysztof.kozlowski+dt,
linux-arm-msm, linux-crypto, linux-kernel, marijn.suijten,
robh+dt, vkoul
Document SC7280 compatible for the True Random Number Generator.
Signed-off-by: Om Prakash Singh <quic_omprsing@quicinc.com>
---
Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
index 85e6b1c199f5..d52355fbd1d6 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
@@ -20,6 +20,7 @@ properties:
- qcom,sm8450-trng
- qcom,sm8550-trng
- qcom,sa8775p-trng
+ - qcom,sc7280-trng
- const: qcom,trng
reg:
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH V1 3/4] arm64: dts: qcom: sa8775p: add TRNG node
2023-10-15 19:38 [PATCH V1 0/4] Enable TRNG for SA8775P and SC7280 Om Prakash Singh
2023-10-15 19:38 ` [PATCH V1 1/4] dt-bindings: crypto: qcom,prng: document SA8775P Om Prakash Singh
2023-10-15 19:38 ` [PATCH V1 2/4] dt-bindings: crypto: qcom,prng: document SC7280 Om Prakash Singh
@ 2023-10-15 19:39 ` Om Prakash Singh
2023-10-15 19:39 ` [PATCH V1 4/4] arm64: dts: qcom: sc7280: " Om Prakash Singh
` (2 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Om Prakash Singh @ 2023-10-15 19:39 UTC (permalink / raw)
To: quic_omprsing
Cc: neil.armstrong, konrad.dybcio, agross, andersson, conor+dt,
davem, devicetree, herbert, krzysztof.kozlowski+dt,
linux-arm-msm, linux-crypto, linux-kernel, marijn.suijten,
robh+dt, vkoul
The sa8775p SoC has a True Random Number Generator, add the node with
the correct compatible set.
Signed-off-by: Om Prakash Singh <quic_omprsing@quicinc.com>
---
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index 9f4f58e831a4..874780b42a68 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -2391,6 +2391,11 @@ ethernet0: ethernet@23040000 {
status = "disabled";
};
+
+ rng: rng@10d2000 {
+ compatible = "qcom,sa8775p-trng", "qcom,trng";
+ reg = <0 0x10d2000 0 0x1000>;
+ };
};
arch_timer: timer {
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH V1 4/4] arm64: dts: qcom: sc7280: add TRNG node
2023-10-15 19:38 [PATCH V1 0/4] Enable TRNG for SA8775P and SC7280 Om Prakash Singh
` (2 preceding siblings ...)
2023-10-15 19:39 ` [PATCH V1 3/4] arm64: dts: qcom: sa8775p: add TRNG node Om Prakash Singh
@ 2023-10-15 19:39 ` Om Prakash Singh
2023-10-16 3:32 ` (subset) [PATCH V1 0/4] Enable TRNG for SA8775P and SC7280 Bjorn Andersson
2023-10-17 16:29 ` Konrad Dybcio
5 siblings, 0 replies; 10+ messages in thread
From: Om Prakash Singh @ 2023-10-15 19:39 UTC (permalink / raw)
To: quic_omprsing
Cc: neil.armstrong, konrad.dybcio, agross, andersson, conor+dt,
davem, devicetree, herbert, krzysztof.kozlowski+dt,
linux-arm-msm, linux-crypto, linux-kernel, marijn.suijten,
robh+dt, vkoul
The sc7280 SoC has a True Random Number Generator, add the node with
the correct compatible set.
Signed-off-by: Om Prakash Singh <quic_omprsing@quicinc.com>
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 925428a5f6ae..dc4332296a3e 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -5368,6 +5368,11 @@ cpufreq_hw: cpufreq@18591000 {
#freq-domain-cells = <1>;
#clock-cells = <1>;
};
+
+ rng: rng@10d3000 {
+ compatible = "qcom,sc7280-trng", "qcom,trng";
+ reg = <0 0x10d3000 0 0x1000>;
+ };
};
thermal_zones: thermal-zones {
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH V1 1/4] dt-bindings: crypto: qcom,prng: document SA8775P
2023-10-15 19:38 ` [PATCH V1 1/4] dt-bindings: crypto: qcom,prng: document SA8775P Om Prakash Singh
@ 2023-10-16 2:41 ` Bjorn Andersson
0 siblings, 0 replies; 10+ messages in thread
From: Bjorn Andersson @ 2023-10-16 2:41 UTC (permalink / raw)
To: Om Prakash Singh
Cc: neil.armstrong, konrad.dybcio, agross, conor+dt, davem,
devicetree, herbert, krzysztof.kozlowski+dt, linux-arm-msm,
linux-crypto, linux-kernel, marijn.suijten, robh+dt, vkoul
On Mon, Oct 16, 2023 at 01:08:58AM +0530, Om Prakash Singh wrote:
> Document SA8775P compatible for the True Random Number Generator.
>
> Signed-off-by: Om Prakash Singh <quic_omprsing@quicinc.com>
> ---
> Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> index 633993f801c6..85e6b1c199f5 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> @@ -19,6 +19,7 @@ properties:
> - enum:
> - qcom,sm8450-trng
> - qcom,sm8550-trng
> + - qcom,sa8775p-trng
Please maintain the alphabetical sort order of entries like this.
On the two DeviceTree patches, we keep nodes sorted by address, followed
by node name, and then label. And we keep the address padded to 8 digits
to make it easier to keep them sorted. I've corrected that and picked
the 2 (i.e. all 4) DeviceTree patches.
So please fix above, and resubmit the two binding updates from this
series (and you can submit that as one change, no need to keep as
separate patches).
Regards,
Bjorn
> - const: qcom,trng
>
> reg:
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: (subset) [PATCH V1 0/4] Enable TRNG for SA8775P and SC7280
2023-10-15 19:38 [PATCH V1 0/4] Enable TRNG for SA8775P and SC7280 Om Prakash Singh
` (3 preceding siblings ...)
2023-10-15 19:39 ` [PATCH V1 4/4] arm64: dts: qcom: sc7280: " Om Prakash Singh
@ 2023-10-16 3:32 ` Bjorn Andersson
2023-10-17 16:29 ` Konrad Dybcio
5 siblings, 0 replies; 10+ messages in thread
From: Bjorn Andersson @ 2023-10-16 3:32 UTC (permalink / raw)
To: Om Prakash Singh
Cc: neil.armstrong, konrad.dybcio, agross, conor+dt, davem,
devicetree, herbert, krzysztof.kozlowski+dt, linux-arm-msm,
linux-crypto, linux-kernel, marijn.suijten, robh+dt, vkoul
On Mon, 16 Oct 2023 01:08:57 +0530, Om Prakash Singh wrote:
> Add device-tree nodes to enable TRNG for SA8775P and SC7280
>
> *** BLURB HERE ***
>
> Om Prakash Singh (4):
> dt-bindings: crypto: qcom,prng: document SA8775P
> dt-bindings: crypto: qcom,prng: document SC7280
> arm64: dts: qcom: sa8775p: add TRNG node
> arm64: dts: qcom: sc7280: add TRNG node
>
> [...]
Applied, thanks!
[3/4] arm64: dts: qcom: sa8775p: add TRNG node
commit: 2d04f31103921b8c21756ff9eeba32e3ece1a276
[4/4] arm64: dts: qcom: sc7280: add TRNG node
commit: d9f33f465114b8d1ecbd5d0b5a4d5f7e709094d9
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V1 2/4] dt-bindings: crypto: qcom,prng: document SC7280
2023-10-15 19:38 ` [PATCH V1 2/4] dt-bindings: crypto: qcom,prng: document SC7280 Om Prakash Singh
@ 2023-10-16 5:23 ` Krzysztof Kozlowski
2023-10-16 5:24 ` Krzysztof Kozlowski
0 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-16 5:23 UTC (permalink / raw)
To: Om Prakash Singh
Cc: neil.armstrong, konrad.dybcio, agross, andersson, conor+dt,
davem, devicetree, herbert, krzysztof.kozlowski+dt,
linux-arm-msm, linux-crypto, linux-kernel, marijn.suijten,
robh+dt, vkoul
On 15/10/2023 21:38, Om Prakash Singh wrote:
> Document SC7280 compatible for the True Random Number Generator.
>
> Signed-off-by: Om Prakash Singh <quic_omprsing@quicinc.com>
> ---
> Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> index 85e6b1c199f5..d52355fbd1d6 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> @@ -20,6 +20,7 @@ properties:
> - qcom,sm8450-trng
> - qcom,sm8550-trng
> - qcom,sa8775p-trng
> + - qcom,sc7280-trng
sc comes before sm
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V1 2/4] dt-bindings: crypto: qcom,prng: document SC7280
2023-10-16 5:23 ` Krzysztof Kozlowski
@ 2023-10-16 5:24 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-16 5:24 UTC (permalink / raw)
To: Om Prakash Singh
Cc: neil.armstrong, konrad.dybcio, agross, andersson, conor+dt,
davem, devicetree, herbert, krzysztof.kozlowski+dt,
linux-arm-msm, linux-crypto, linux-kernel, marijn.suijten,
robh+dt, vkoul
On 16/10/2023 07:23, Krzysztof Kozlowski wrote:
> On 15/10/2023 21:38, Om Prakash Singh wrote:
>> Document SC7280 compatible for the True Random Number Generator.
>>
>> Signed-off-by: Om Prakash Singh <quic_omprsing@quicinc.com>
>> ---
>> Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>> index 85e6b1c199f5..d52355fbd1d6 100644
>> --- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>> +++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>> @@ -20,6 +20,7 @@ properties:
>> - qcom,sm8450-trng
>> - qcom,sm8550-trng
>> - qcom,sa8775p-trng
>> + - qcom,sc7280-trng
>
> sc comes before sm
also, this should be squashed with previous patch.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V1 0/4] Enable TRNG for SA8775P and SC7280
2023-10-15 19:38 [PATCH V1 0/4] Enable TRNG for SA8775P and SC7280 Om Prakash Singh
` (4 preceding siblings ...)
2023-10-16 3:32 ` (subset) [PATCH V1 0/4] Enable TRNG for SA8775P and SC7280 Bjorn Andersson
@ 2023-10-17 16:29 ` Konrad Dybcio
5 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2023-10-17 16:29 UTC (permalink / raw)
To: Om Prakash Singh
Cc: neil.armstrong, agross, andersson, conor+dt, davem, devicetree,
herbert, krzysztof.kozlowski+dt, linux-arm-msm, linux-crypto,
linux-kernel, marijn.suijten, robh+dt, vkoul
On 10/15/23 21:38, Om Prakash Singh wrote:
> Add device-tree nodes to enable TRNG for SA8775P and SC7280
>
> *** BLURB HERE ***
Generally you want to delete this :)
Konrad
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-10-17 16:29 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-15 19:38 [PATCH V1 0/4] Enable TRNG for SA8775P and SC7280 Om Prakash Singh
2023-10-15 19:38 ` [PATCH V1 1/4] dt-bindings: crypto: qcom,prng: document SA8775P Om Prakash Singh
2023-10-16 2:41 ` Bjorn Andersson
2023-10-15 19:38 ` [PATCH V1 2/4] dt-bindings: crypto: qcom,prng: document SC7280 Om Prakash Singh
2023-10-16 5:23 ` Krzysztof Kozlowski
2023-10-16 5:24 ` Krzysztof Kozlowski
2023-10-15 19:39 ` [PATCH V1 3/4] arm64: dts: qcom: sa8775p: add TRNG node Om Prakash Singh
2023-10-15 19:39 ` [PATCH V1 4/4] arm64: dts: qcom: sc7280: " Om Prakash Singh
2023-10-16 3:32 ` (subset) [PATCH V1 0/4] Enable TRNG for SA8775P and SC7280 Bjorn Andersson
2023-10-17 16:29 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).