From: Soumya Negi <soumya.negi97@gmail.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Martyn Welch <martyn@welchs.me.uk>,
Manohar Vanga <manohar.vanga@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
outreachy@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH 0/2] staging: vme_user: Replace printk's & cleanup log messages
Date: Tue, 17 Oct 2023 23:06:46 -0700 [thread overview]
Message-ID: <20231018060646.GA1868@Negi> (raw)
In-Reply-To: <85af8b2d-6246-46c5-c6dc-582807010fa@inria.fr>
On Wed, Oct 18, 2023 at 07:49:22AM +0200, Julia Lawall wrote:
>
>
> On Tue, 17 Oct 2023, Soumya Negi wrote:
>
> > Staging driver vme_user has a bunch of printk() calls in vme.c which
> > triggers checkpatch warnings. Remove all printk's and change them to
> > the appropriate logging mechanism i.e pr_err()/pr_warn(), or
> > dev_err()/dev_warn().
> >
> > Also, cleanup the messages further by using __func__ in the string
> > instead of function names.
>
> "cleanup" is not actually a verb. It's a noun. The verb would be clean
> up.
>
> julia
>
Hi Julia,
Will update the commit log.
Tanks,
Soumya
> >
> > This patchset fixes all checkpatch warnings like:
> >
> > WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then
> > dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
> > &
> > WARNING: Prefer using '"%s...", __func__' to using 'vme_lm_get',
> > this function's name, in a string
> >
> > Patches must be applied in order.
> >
> > Soumya Negi (2):
> > staging: vme_user: Replace printk() with pr_*(),dev_*()
> > staging: vme_user: Use __func__ instead of function name
> >
> > drivers/staging/vme_user/vme.c | 175 ++++++++++++++++++---------------
> > 1 file changed, 94 insertions(+), 81 deletions(-)
> >
> > --
> > 2.42.0
> >
> >
> >
prev parent reply other threads:[~2023-10-18 6:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 4:36 [PATCH 0/2] staging: vme_user: Replace printk's & cleanup log messages Soumya Negi
2023-10-18 4:36 ` [PATCH 1/2] staging: vme_user: Replace printk() with pr_*(),dev_*() Soumya Negi
2023-10-18 5:47 ` Julia Lawall
2023-10-18 6:30 ` Soumya Negi
2023-10-18 7:00 ` Julia Lawall
2023-10-18 13:26 ` Greg Kroah-Hartman
2023-10-18 19:38 ` Soumya Negi
2023-10-19 15:34 ` Greg Kroah-Hartman
2023-10-19 19:06 ` Soumya Negi
2023-10-19 19:42 ` Greg Kroah-Hartman
2023-10-19 20:55 ` Soumya Negi
2023-10-18 4:36 ` [PATCH 2/2] staging: vme_user: Use __func__ instead of function name Soumya Negi
2023-10-18 11:00 ` Andi Shyti
2023-10-18 20:30 ` Soumya Negi
2023-10-18 22:13 ` Andi Shyti
2023-10-18 5:49 ` [PATCH 0/2] staging: vme_user: Replace printk's & cleanup log messages Julia Lawall
2023-10-18 6:06 ` Soumya Negi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018060646.GA1868@Negi \
--to=soumya.negi97@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).