From: Julia Lawall <julia.lawall@inria.fr>
To: Soumya Negi <soumya.negi97@gmail.com>
Cc: Martyn Welch <martyn@welchs.me.uk>,
Manohar Vanga <manohar.vanga@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
outreachy@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH 1/2] staging: vme_user: Replace printk() with pr_*(),dev_*()
Date: Wed, 18 Oct 2023 09:00:57 +0200 (CEST) [thread overview]
Message-ID: <82dc1055-521d-e4d-9d91-b4cc7d8d9d3e@inria.fr> (raw)
In-Reply-To: <20231018063038.GB1868@Negi>
On Tue, 17 Oct 2023, Soumya Negi wrote:
> Hi Julia,
>
> On Wed, Oct 18, 2023 at 07:47:29AM +0200, Julia Lawall wrote:
> >
> >
> > On Tue, 17 Oct 2023, Soumya Negi wrote:
> >
> > > vme.c uses printk() to log messages. To improve and standardize message
> > > formatting, use logging mechanisms pr_err()/pr_warn() and
> > > dev_err()/dev_warn() instead. Retain the printk log levels of the
> > > messages during replacement.
> >
> > It's not possible to use the dev_ functions more often? The pr_functions
> > don't give context information, and the message don't seem to give much
> > context information either.
> >
> > julia
> >
>
> Yes, I think there can be more dev_*() functions.
>
> Most of the dev_ that can be added are error/warning messages where the bridge's
> 'struct device' instance is accessible & can be fed to dev_ fns. Although I went
> through the VME subsystem docs, I wasn't sure if the bridge's context made sense
> to be printed with those messages. So I wrote them as pr_ functions.
>
> Should I add them and send a v2 for review?
Maybe wait a bit and see if someone else has a comment on this issue.
julia
>
> Regards,
> Soumya
>
>
next prev parent reply other threads:[~2023-10-18 7:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 4:36 [PATCH 0/2] staging: vme_user: Replace printk's & cleanup log messages Soumya Negi
2023-10-18 4:36 ` [PATCH 1/2] staging: vme_user: Replace printk() with pr_*(),dev_*() Soumya Negi
2023-10-18 5:47 ` Julia Lawall
2023-10-18 6:30 ` Soumya Negi
2023-10-18 7:00 ` Julia Lawall [this message]
2023-10-18 13:26 ` Greg Kroah-Hartman
2023-10-18 19:38 ` Soumya Negi
2023-10-19 15:34 ` Greg Kroah-Hartman
2023-10-19 19:06 ` Soumya Negi
2023-10-19 19:42 ` Greg Kroah-Hartman
2023-10-19 20:55 ` Soumya Negi
2023-10-18 4:36 ` [PATCH 2/2] staging: vme_user: Use __func__ instead of function name Soumya Negi
2023-10-18 11:00 ` Andi Shyti
2023-10-18 20:30 ` Soumya Negi
2023-10-18 22:13 ` Andi Shyti
2023-10-18 5:49 ` [PATCH 0/2] staging: vme_user: Replace printk's & cleanup log messages Julia Lawall
2023-10-18 6:06 ` Soumya Negi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82dc1055-521d-e4d-9d91-b4cc7d8d9d3e@inria.fr \
--to=julia.lawall@inria.fr \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
--cc=outreachy@lists.linux.dev \
--cc=soumya.negi97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).