From: Rob Herring <robh@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Christian Marangi <ansuelsmth@gmail.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4 6/7] dt-bindings: marvell: Rewrite MV88E6xxx in schema
Date: Thu, 19 Oct 2023 08:51:03 -0500 [thread overview]
Message-ID: <20231019135103.GA203636-robh@kernel.org> (raw)
In-Reply-To: <20231018-marvell-88e6152-wan-led-v4-6-3ee0c67383be@linaro.org>
On Wed, Oct 18, 2023 at 11:03:45AM +0200, Linus Walleij wrote:
> This is an attempt to rewrite the Marvell MV88E6xxx switch bindings
> in YAML schema.
>
> The current text binding says:
> WARNING: This binding is currently unstable. Do not program it into a
> FLASH never to be changed again. Once this binding is stable, this
> warning will be removed.
>
> Well that never happened before we switched to YAML markup,
> we can't have it like this, what about fixing the mess?
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> .../bindings/net/dsa/marvell,mv88e6xxx.yaml | 225 +++++++++++++++++++++
> .../devicetree/bindings/net/dsa/marvell.txt | 109 ----------
> MAINTAINERS | 2 +-
> 3 files changed, 226 insertions(+), 110 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/marvell,mv88e6xxx.yaml b/Documentation/devicetree/bindings/net/dsa/marvell,mv88e6xxx.yaml
> new file mode 100644
> index 000000000000..8013ac411b15
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/dsa/marvell,mv88e6xxx.yaml
> @@ -0,0 +1,225 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/dsa/marvell,mv88e6xxx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell MV88E6xxx DSA switch family
> +
> +maintainers:
> + - Andrew Lunn <andrew@lunn.ch>
> +
> +description:
> + The Marvell MV88E6xxx switch series has been produced and sold
> + by Marvell since at least 2010. The switch has a few compatibles which
> + just indicate the base address of the switch, then operating systems
> + can investigate switch ID registers to find out which actual version
> + of the switch it is dealing with.
> +
> +properties:
> + compatible:
> + enum:
> + - marvell,mv88e6085
> + - marvell,mv88e6190
> + - marvell,mv88e6250
> + description: |
> + marvell,mv88e6085: This switch uses base address 0x10.
> + This switch and its siblings will be autodetected from
> + ID registers found in the switch, so only "marvell,mv88e6085" should be
> + specified. This includes the following list of MV88Exxxx switches:
> + 6085, 6095, 6097, 6123, 6131, 6141, 6161, 6165, 6171, 6172, 6175, 6176,
> + 6185, 6240, 6320, 6321, 6341, 6350, 6351, 6352
> + marvell,mv88e6190: This switch uses base address 0x00.
> + This switch and its siblings will be autodetected from
> + ID registers found in the switch, so only "marvell,mv88e6190" should be
> + specified. This includes the following list of MV88Exxxx switches:
> + 6190, 6190X, 6191, 6290, 6361, 6390, 6390X
> + marvell,mv88e6250: This switch uses base address 0x08 or 0x18.
> + This switch and its siblings will be autodetected from
> + ID registers found in the switch, so only "marvell,mv88e6250" should be
> + specified. This includes the following list of MV88Exxxx switches:
> + 6220, 6250
> +
> + reg:
> + maxItems: 1
> +
> + eeprom-length:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Set to the length of an EEPROM connected to the switch. Must be
> + set if the switch can not detect the presence and/or size of a connected
> + EEPROM, otherwise optional.
> +
> + reset-gpios:
> + description:
> + GPIO to be used to reset the whole device
> + maxItems: 1
> +
> + interrupts:
> + description: The switch provides an external interrupt line, but it is
> + not always used by target systems.
> + maxItems: 1
> +
> + interrupt-controller:
> + description: The switch has an internal interrupt controller used by
> + the different sub-blocks.
> +
> + '#interrupt-cells':
> + description: The internal interrupt controller only supports triggering
> + on active high level interrupts so the second cell must alway be set to
> + IRQ_TYPE_LEVEL_HIGH.
> + const: 2
> +
> + mdio:
> + $ref: /schemas/net/mdio.yaml#
> + unevaluatedProperties: false
> + description: Marvell MV88E6xxx switches have an varying combination of
> + internal and external MDIO buses, in some cases a combined bus that
> + can be used both internally and externally. This node is for the
> + primary bus, used internally and sometimes also externally.
> +
> + mdio-external:
> + $ref: /schemas/net/mdio.yaml#
> + unevaluatedProperties: false
> + description: Marvell MV88E6xxx switches that have a separate external
> + MDIO bus use this port to access external components on the MDIO bus.
> +
> + properties:
> + compatible:
> + const: marvell,mv88e6xxx-mdio-external
> +
> + required:
> + - compatible
> +
> +$ref: dsa.yaml#
Drop this. Covered by the line below.
> +
> +allOf:
> + - $ref: dsa.yaml#/$defs/ethernet-ports
next prev parent reply other threads:[~2023-10-19 13:51 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 9:03 [PATCH net-next v4 0/7] Create a binding for the Marvell MV88E6xxx DSA switches Linus Walleij
2023-10-18 9:03 ` [PATCH net-next v4 1/7] dt-bindings: net: dsa: Require ports or ethernet-ports Linus Walleij
2023-10-18 10:32 ` Rob Herring
2023-10-18 11:11 ` Linus Walleij
2023-10-19 10:58 ` Russell King (Oracle)
2023-10-19 11:58 ` Conor Dooley
2023-10-19 12:27 ` Russell King (Oracle)
2023-10-19 12:46 ` Conor Dooley
2023-10-19 13:41 ` Rob Herring
2023-10-20 11:10 ` Krzysztof Kozlowski
2023-10-20 11:41 ` Linus Walleij
2023-10-20 12:16 ` Krzysztof Kozlowski
2023-10-20 12:27 ` Vladimir Oltean
2023-10-20 12:56 ` Linus Walleij
2023-10-19 12:03 ` Conor Dooley
2023-10-19 12:28 ` Russell King (Oracle)
2023-10-19 12:33 ` Conor Dooley
2023-10-18 9:03 ` [PATCH net-next v4 2/7] dt-bindings: net: mvusb: Fix up DSA example Linus Walleij
2023-10-18 10:32 ` Rob Herring
2023-10-18 11:37 ` Linus Walleij
2023-10-19 13:45 ` Rob Herring
2023-10-19 14:26 ` Vladimir Oltean
2023-10-19 20:23 ` Rob Herring
2023-10-18 13:39 ` Andrew Lunn
2023-10-19 14:28 ` Vladimir Oltean
2023-10-18 9:03 ` [PATCH net-next v4 3/7] ARM: dts: marvell: Fix some common switch mistakes Linus Walleij
2023-10-18 13:41 ` Andrew Lunn
2023-10-19 11:04 ` Russell King (Oracle)
2023-10-19 14:29 ` Vladimir Oltean
2023-10-18 9:03 ` [PATCH net-next v4 4/7] ARM: dts: nxp: " Linus Walleij
2023-10-18 13:42 ` Andrew Lunn
2023-10-19 14:33 ` Vladimir Oltean
2023-10-18 9:03 ` [PATCH net-next v4 5/7] ARM64: dts: marvell: " Linus Walleij
2023-10-18 13:43 ` Andrew Lunn
2023-10-19 14:40 ` Vladimir Oltean
2023-10-19 14:49 ` Vladimir Oltean
2023-10-19 15:26 ` Marek Behún
2023-10-19 16:22 ` Vladimir Oltean
2023-10-20 12:59 ` Linus Walleij
2023-10-25 1:11 ` Vladimir Oltean
2023-10-18 9:03 ` [PATCH net-next v4 6/7] dt-bindings: marvell: Rewrite MV88E6xxx in schema Linus Walleij
2023-10-18 10:32 ` Rob Herring
2023-10-18 11:39 ` Linus Walleij
2023-10-19 13:49 ` Rob Herring
2023-10-19 20:02 ` Rob Herring
2023-10-18 13:48 ` Andrew Lunn
2023-10-19 13:51 ` Rob Herring [this message]
2023-10-19 15:35 ` Vladimir Oltean
2023-10-20 9:13 ` Arınç ÜNAL
2023-10-20 12:47 ` Linus Walleij
2023-10-20 15:12 ` Vladimir Oltean
2023-10-20 16:07 ` Andrew Lunn
2023-10-18 9:03 ` [PATCH net-next v4 7/7] dt-bindings: marvell: Add Marvell MV88E6060 DSA schema Linus Walleij
2023-10-18 13:49 ` Andrew Lunn
2023-10-19 16:11 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231019135103.GA203636-robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).