From: "Marek Behún" <kabel@kernel.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Christian Marangi <ansuelsmth@gmail.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4 5/7] ARM64: dts: marvell: Fix some common switch mistakes
Date: Thu, 19 Oct 2023 17:26:49 +0200 [thread overview]
Message-ID: <20231019172649.784a60d4@dellmb> (raw)
In-Reply-To: <20231019144935.3wrnqyipiq3vkxb7@skbuf>
On Thu, 19 Oct 2023 17:49:35 +0300
Vladimir Oltean <olteanv@gmail.com> wrote:
> On Thu, Oct 19, 2023 at 05:40:22PM +0300, Vladimir Oltean wrote:
> > +Marek
> >
> > On Wed, Oct 18, 2023 at 11:03:44AM +0200, Linus Walleij wrote:
> > > Fix some errors in the Marvell MV88E6xxx switch descriptions:
> > > - The top node had no address size or cells.
> > > - switch0@0 is not OK, should be switch@0.
> > >
> > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > > ---
> > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> > > index 9eab2bb22134..c69cb4e191e5 100644
> > > --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> > > +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> > > @@ -305,7 +305,7 @@ phy1: ethernet-phy@1 {
> > > };
> > >
> > > /* switch nodes are enabled by U-Boot if modules are present */
> > > - switch0@10 {
> > > + switch@10 {
> >
> > As the comment says: U-Boot
> > (https://elixir.bootlin.com/u-boot/latest/source/board/CZ.NIC/turris_mox/turris_mox.c#L728)
> > sets up status = "okay" for these nodes depending on the MOXTET
> > configuration. It doesn't look as if it's doing that by alias, just by
> > path ("%s/switch%i@%x").
> >
> > I have a Turris MOX, please allow me some time to test if the node name
> > change is going to be significant and cause regressions. I expect the
> > answer to be yes (sadly).
>
> Yeah, it's bad.
>
> U-Boot 2018.11 (Dec 16 2018 - 12:50:19 +0000), Build: jenkins-turris-os-packages-kittens-mox-90
>
> DRAM: 1 GiB
> Enabling Armada 3720 wComphy-0: SGMII1 3.125 Gbps
> Comphy-1: PEX0 5 Gbps
> Comphy-2: USB3_HOST0 5 Gbps
> MMC: sdhci@d8000: 0
> Loading Environment from SPI Flash... SF: Detected w25q64dw with page size 256 Bytes, erase size 4 KiB, total 8 MiB
> OK
> Model: CZ.NIC Turris Mox Board
> Net: eth0: neta@30000
> Turris Mox:
> Board version: 22
> RAM size: 1024 MiB
> SD/eMMC version: SD
> Module Topology:
> 1: Peridot Switch Module (8-port)
> 2: Peridot Switch Module (8-port)
> 3: Peridot Switch Module (8-port)
> 4: SFP Module
>
> Hit any key to stop autoboot: 0
> => run sd_tftp_boot
> neta@30000 Waiting for PHY auto negotiation to complete....... done
> BOOTP broadcast 1
> BOOTP broadcast 2
> DHCP client bound to address 10.0.0.117 (254 ms)
> Using neta@30000 device
> TFTP from server 10.0.0.1; our IP address is 10.0.0.117
> Filename 'mox/armada-3720-turris-mox.dtb'.
> Load address: 0x4f00000
> Loading: ####
> 1.5 MiB/s
> done
> Bytes transferred = 19479 (4c17 hex)
> Using neta@30000 device
> TFTP from server 10.0.0.1; our IP address is 10.0.0.117
> Filename 'mox/Image'.
> Load address: 0x5000000
> Loading: #################################################################
> ##########################################
> 6 MiB/s
> done
> Bytes transferred = 54069760 (3390a00 hex)
> ## Flattened Device Tree blob at 04f00000
> Booting using the fdt blob at 0x4f00000
> Loading Device Tree to 000000003bf16000, end 000000003bf1dc16 ... OK
> ERROR: board-specific fdt fixup failed: FDT_ERR_NOTFOUND
> - must RESET the board to recover.
>
> FDT creation failed! hanging...### ERROR ### Please RESET the board ###
Yes, unfortunately changing that node name will break booting.
Maybe we could add a comment into the DTS to describe this unfortunate
state of things? :)
Marek
next prev parent reply other threads:[~2023-10-19 15:27 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 9:03 [PATCH net-next v4 0/7] Create a binding for the Marvell MV88E6xxx DSA switches Linus Walleij
2023-10-18 9:03 ` [PATCH net-next v4 1/7] dt-bindings: net: dsa: Require ports or ethernet-ports Linus Walleij
2023-10-18 10:32 ` Rob Herring
2023-10-18 11:11 ` Linus Walleij
2023-10-19 10:58 ` Russell King (Oracle)
2023-10-19 11:58 ` Conor Dooley
2023-10-19 12:27 ` Russell King (Oracle)
2023-10-19 12:46 ` Conor Dooley
2023-10-19 13:41 ` Rob Herring
2023-10-20 11:10 ` Krzysztof Kozlowski
2023-10-20 11:41 ` Linus Walleij
2023-10-20 12:16 ` Krzysztof Kozlowski
2023-10-20 12:27 ` Vladimir Oltean
2023-10-20 12:56 ` Linus Walleij
2023-10-19 12:03 ` Conor Dooley
2023-10-19 12:28 ` Russell King (Oracle)
2023-10-19 12:33 ` Conor Dooley
2023-10-18 9:03 ` [PATCH net-next v4 2/7] dt-bindings: net: mvusb: Fix up DSA example Linus Walleij
2023-10-18 10:32 ` Rob Herring
2023-10-18 11:37 ` Linus Walleij
2023-10-19 13:45 ` Rob Herring
2023-10-19 14:26 ` Vladimir Oltean
2023-10-19 20:23 ` Rob Herring
2023-10-18 13:39 ` Andrew Lunn
2023-10-19 14:28 ` Vladimir Oltean
2023-10-18 9:03 ` [PATCH net-next v4 3/7] ARM: dts: marvell: Fix some common switch mistakes Linus Walleij
2023-10-18 13:41 ` Andrew Lunn
2023-10-19 11:04 ` Russell King (Oracle)
2023-10-19 14:29 ` Vladimir Oltean
2023-10-18 9:03 ` [PATCH net-next v4 4/7] ARM: dts: nxp: " Linus Walleij
2023-10-18 13:42 ` Andrew Lunn
2023-10-19 14:33 ` Vladimir Oltean
2023-10-18 9:03 ` [PATCH net-next v4 5/7] ARM64: dts: marvell: " Linus Walleij
2023-10-18 13:43 ` Andrew Lunn
2023-10-19 14:40 ` Vladimir Oltean
2023-10-19 14:49 ` Vladimir Oltean
2023-10-19 15:26 ` Marek Behún [this message]
2023-10-19 16:22 ` Vladimir Oltean
2023-10-20 12:59 ` Linus Walleij
2023-10-25 1:11 ` Vladimir Oltean
2023-10-18 9:03 ` [PATCH net-next v4 6/7] dt-bindings: marvell: Rewrite MV88E6xxx in schema Linus Walleij
2023-10-18 10:32 ` Rob Herring
2023-10-18 11:39 ` Linus Walleij
2023-10-19 13:49 ` Rob Herring
2023-10-19 20:02 ` Rob Herring
2023-10-18 13:48 ` Andrew Lunn
2023-10-19 13:51 ` Rob Herring
2023-10-19 15:35 ` Vladimir Oltean
2023-10-20 9:13 ` Arınç ÜNAL
2023-10-20 12:47 ` Linus Walleij
2023-10-20 15:12 ` Vladimir Oltean
2023-10-20 16:07 ` Andrew Lunn
2023-10-18 9:03 ` [PATCH net-next v4 7/7] dt-bindings: marvell: Add Marvell MV88E6060 DSA schema Linus Walleij
2023-10-18 13:49 ` Andrew Lunn
2023-10-19 16:11 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231019172649.784a60d4@dellmb \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).