From: Soumya Negi <soumya.negi97@gmail.com>
To: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Martyn Welch <martyn@welchs.me.uk>,
Manohar Vanga <manohar.vanga@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Julia Lawall <julia.lawall@inria.fr>,
outreachy@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 2/2] staging: vme_user: Use __func__ instead of function name
Date: Thu, 19 Oct 2023 12:14:28 -0700 [thread overview]
Message-ID: <20231019191428.GA32717@Negi> (raw)
In-Reply-To: <ZTFOGIu5U+ZUodXW@ashyti-mobl2.lan>
On Thu, Oct 19, 2023 at 05:41:12PM +0200, Andi Shyti wrote:
> Hi Soumya,
>
> On Thu, Oct 19, 2023 at 12:20:10AM -0700, Soumya Negi wrote:
> > Replace function names in message strings with __func__ to fix
> > all checkpatch warnings like:
> >
> > WARNING: Prefer using '"%s...", __func__' to using 'vme_lm_get',
> > this function's name, in a string
> >
> > Signed-off-by: Soumya Negi <soumya.negi97@gmail.com>
>
> you forgot my ack here:
>
> Acked-by: Andi Shyti <andi.shyti@linux.intel.com>
>
> Andi
Sorry I forgot the tag Andi. I'll add the tags in v3(Greg has suggested
more changes). There will be some new patches, so I'll leave the tags out in
those as you may want to review them first.
Regards,
Soumya
>
> > ---
> > Changes in v2:
> > * None
> >
> > drivers/staging/vme_user/vme.c | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c
> > index 640b2dda3ac6..e533cce8e54e 100644
> > --- a/drivers/staging/vme_user/vme.c
> > +++ b/drivers/staging/vme_user/vme.c
> > @@ -424,7 +424,7 @@ int vme_slave_get(struct vme_resource *resource, int *enabled,
> > image = list_entry(resource->entry, struct vme_slave_resource, list);
> >
> > if (!bridge->slave_get) {
> > - dev_err(bridge->parent, "vme_slave_get not supported\n");
> > + dev_err(bridge->parent, "%s not supported\n", __func__);
> > return -EINVAL;
> > }
> >
> > @@ -576,7 +576,7 @@ int vme_master_set(struct vme_resource *resource, int enabled,
> > image = list_entry(resource->entry, struct vme_master_resource, list);
> >
> > if (!bridge->master_set) {
> > - dev_warn(bridge->parent, "vme_master_set not supported\n");
> > + dev_warn(bridge->parent, "%s not supported\n", __func__);
> > return -EINVAL;
> > }
> >
> > @@ -1576,7 +1576,7 @@ int vme_lm_set(struct vme_resource *resource, unsigned long long lm_base,
> > lm = list_entry(resource->entry, struct vme_lm_resource, list);
> >
> > if (!bridge->lm_set) {
> > - dev_err(bridge->parent, "vme_lm_set not supported\n");
> > + dev_err(bridge->parent, "%s not supported\n", __func__);
> > return -EINVAL;
> > }
> >
> > @@ -1612,7 +1612,7 @@ int vme_lm_get(struct vme_resource *resource, unsigned long long *lm_base,
> > lm = list_entry(resource->entry, struct vme_lm_resource, list);
> >
> > if (!bridge->lm_get) {
> > - dev_err(bridge->parent, "vme_lm_get not supported\n");
> > + dev_err(bridge->parent, "%s not supported\n", __func__);
> > return -EINVAL;
> > }
> >
> > @@ -1649,7 +1649,7 @@ int vme_lm_attach(struct vme_resource *resource, int monitor,
> > lm = list_entry(resource->entry, struct vme_lm_resource, list);
> >
> > if (!bridge->lm_attach) {
> > - dev_err(bridge->parent, "vme_lm_attach not supported\n");
> > + dev_err(bridge->parent, "%s not supported\n", __func__);
> > return -EINVAL;
> > }
> >
> > @@ -1682,7 +1682,7 @@ int vme_lm_detach(struct vme_resource *resource, int monitor)
> > lm = list_entry(resource->entry, struct vme_lm_resource, list);
> >
> > if (!bridge->lm_detach) {
> > - dev_err(bridge->parent, "vme_lm_detach not supported\n");
> > + dev_err(bridge->parent, "%s not supported\n", __func__);
> > return -EINVAL;
> > }
> >
> > @@ -1750,7 +1750,7 @@ int vme_slot_num(struct vme_dev *vdev)
> > }
> >
> > if (!bridge->slot_get) {
> > - dev_warn(bridge->parent, "vme_slot_num not supported\n");
> > + dev_warn(bridge->parent, "%s not supported\n", __func__);
> > return -EINVAL;
> > }
> >
> > --
> > 2.42.0
next prev parent reply other threads:[~2023-10-19 19:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 7:20 [PATCH v2 0/2] staging: vme_user: Replace printk's & clean up log messages Soumya Negi
2023-10-19 7:20 ` [PATCH v2 1/2] staging: vme_user: Replace printk() with pr_*(),dev_*() Soumya Negi
2023-10-19 10:45 ` Karolina Stolarek
2023-10-19 15:31 ` Greg Kroah-Hartman
2023-10-20 2:06 ` Soumya Negi
2023-10-19 15:42 ` Andi Shyti
2023-10-19 7:20 ` [PATCH v2 2/2] staging: vme_user: Use __func__ instead of function name Soumya Negi
2023-10-19 15:41 ` Andi Shyti
2023-10-19 19:14 ` Soumya Negi [this message]
2023-10-19 21:32 ` Andi Shyti
2023-10-19 22:13 ` Soumya Negi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231019191428.GA32717@Negi \
--to=soumya.negi97@gmail.com \
--cc=andi.shyti@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).