linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Soumya Negi <soumya.negi97@gmail.com>
Cc: Andi Shyti <andi.shyti@linux.intel.com>,
	Martyn Welch <martyn@welchs.me.uk>,
	Manohar Vanga <manohar.vanga@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Julia Lawall <julia.lawall@inria.fr>,
	outreachy@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 2/2] staging: vme_user: Use __func__ instead of function name
Date: Thu, 19 Oct 2023 23:32:04 +0200	[thread overview]
Message-ID: <ZTGgVNBoxOtWOuE8@ashyti-mobl2.lan> (raw)
In-Reply-To: <20231019191428.GA32717@Negi>

Hi Soumya,

> > On Thu, Oct 19, 2023 at 12:20:10AM -0700, Soumya Negi wrote:
> > > Replace function names in message strings with __func__ to fix
> > > all checkpatch warnings like:
> > > 
> > >     WARNING: Prefer using '"%s...", __func__' to using 'vme_lm_get',
> > >              this function's name, in a string
> > > 
> > > Signed-off-by: Soumya Negi <soumya.negi97@gmail.com>
> > 
> > you forgot my ack here:
> > 
> > Acked-by: Andi Shyti <andi.shyti@linux.intel.com> 
> > 
> > Andi
> 
> Sorry I forgot the tag Andi. I'll add the tags in v3(Greg has suggested
> more changes). There will be some new patches, so I'll leave the tags out in 
> those as you may want to review them first.

no problem.

I don't see reviews from Greg in this v2 series. If you are
referring to the changelog, then you don't need to resend.

Andi

  reply	other threads:[~2023-10-19 21:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-19  7:20 [PATCH v2 0/2] staging: vme_user: Replace printk's & clean up log messages Soumya Negi
2023-10-19  7:20 ` [PATCH v2 1/2] staging: vme_user: Replace printk() with pr_*(),dev_*() Soumya Negi
2023-10-19 10:45   ` Karolina Stolarek
2023-10-19 15:31     ` Greg Kroah-Hartman
2023-10-20  2:06     ` Soumya Negi
2023-10-19 15:42   ` Andi Shyti
2023-10-19  7:20 ` [PATCH v2 2/2] staging: vme_user: Use __func__ instead of function name Soumya Negi
2023-10-19 15:41   ` Andi Shyti
2023-10-19 19:14     ` Soumya Negi
2023-10-19 21:32       ` Andi Shyti [this message]
2023-10-19 22:13         ` Soumya Negi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZTGgVNBoxOtWOuE8@ashyti-mobl2.lan \
    --to=andi.shyti@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=julia.lawall@inria.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=manohar.vanga@gmail.com \
    --cc=martyn@welchs.me.uk \
    --cc=outreachy@lists.linux.dev \
    --cc=soumya.negi97@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).