From: Lee Jones <lee@kernel.org>
To: "André Apitzsch" <git@apitzsch.eu>
Cc: Samuel Holland <samuel@sholland.org>, Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Conor Dooley <conor@kernel.org>, Guo Ren <guoren@kernel.org>,
Heiko Stuebner <heiko.stuebner@vrull.eu>,
Heiko Stuebner <heiko@sntech.de>,
Jisheng Zhang <jszhang@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: Re: [RESEND PATCH v7 2/5] leds: sun50i-a100: New driver for the A100 LED controller
Date: Mon, 23 Oct 2023 10:58:55 +0100 [thread overview]
Message-ID: <20231023095855.GH8909@google.com> (raw)
In-Reply-To: <c3ae7d79ab81621c66e939d804ca41e97eab79fb.camel@apitzsch.eu>
> Hi Samuel,
>
> there are two more things to change, which came up recently. See below.
>
> Regards,
> André
>
> Am Samstag, dem 31.12.2022 um 17:55 -0600 schrieb Samuel Holland:
> > Some Allwinner sunxi SoCs, starting with the A100, contain an LED
> > controller designed to drive RGB LED pixels. Add a driver for it
> > using
> > the multicolor LED framework, and with LEDs defined in the device
> > tree.
> >
> > Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> > Signed-off-by: Samuel Holland <samuel@sholland.org>
> > ---
> > [...]
> > diff --git a/drivers/leds/leds-sun50i-a100.c b/drivers/leds/leds-
> > sun50i-a100.c
[...]
> > +struct sun50i_a100_ledc {
> > + struct device *dev;
> > + void __iomem *base;
> > + struct clk *bus_clk;
> > + struct clk *mod_clk;
> > + struct reset_control *reset;
> > +
> > + u32 *buffer;
> > + struct dma_chan *dma_chan;
> > + dma_addr_t dma_handle;
> > + int pio_length;
> > + int pio_offset;
> > +
> > + spinlock_t lock;
> > + int next_length;
> > + bool xfer_active;
> > +
> > + u32 format;
> > + struct sun50i_a100_ledc_timing timing;
> > +
> > + int num_leds;
> > + struct sun50i_a100_ledc_led leds[];
>
> Annotate struct with __counted_by(num_leds).
André, please remember to snip your replies.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-10-23 9:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-31 23:55 [RESEND PATCH v7 0/5] leds: Allwinner A100 LED controller support Samuel Holland
2022-12-31 23:55 ` [RESEND PATCH v7 1/5] dt-bindings: leds: Add Allwinner A100 LED controller Samuel Holland
2022-12-31 23:55 ` [RESEND PATCH v7 2/5] leds: sun50i-a100: New driver for the " Samuel Holland
2023-01-09 17:16 ` Lee Jones
2023-03-01 14:27 ` Lee Jones
2023-03-16 13:34 ` Lee Jones
2023-10-18 0:38 ` Samuel Holland
2023-10-29 18:37 ` Samuel Holland
2023-10-31 7:48 ` Lee Jones
2023-10-19 20:26 ` André Apitzsch
2023-10-23 9:58 ` Lee Jones [this message]
2023-11-17 12:54 ` Lee Jones
2022-12-31 23:55 ` [RESEND PATCH v7 3/5] arm64: dts: allwinner: a100: Add LED controller node Samuel Holland
2022-12-31 23:55 ` [RESEND PATCH v7 4/5] riscv: dts: allwinner: d1: " Samuel Holland
2022-12-31 23:55 ` [RESEND PATCH v7 5/5] riscv: dts: allwinner: d1: Add RGB LEDs to boards Samuel Holland
2023-01-26 4:59 ` [RESEND PATCH v7 0/5] leds: Allwinner A100 LED controller support Trevor Woerner
2023-03-07 20:56 ` Palmer Dabbelt
2023-03-08 4:13 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231023095855.GH8909@google.com \
--to=lee@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@apitzsch.eu \
--cc=guoren@kernel.org \
--cc=heiko.stuebner@vrull.eu \
--cc=heiko@sntech.de \
--cc=jernej.skrabec@gmail.com \
--cc=jszhang@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).