From: Palmer Dabbelt <palmer@dabbelt.com>
To: samuel@sholland.org
Cc: lee@kernel.org, pavel@ucw.cz, linux-leds@vger.kernel.org,
wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org,
aou@eecs.berkeley.edu, Conor Dooley <conor@kernel.org>,
guoren@kernel.org, heiko.stuebner@vrull.eu, heiko@sntech.de,
jszhang@kernel.org, krzysztof.kozlowski+dt@linaro.org,
Paul Walmsley <paul.walmsley@sifive.com>,
p.zabel@pengutronix.de, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: Re: [RESEND PATCH v7 0/5] leds: Allwinner A100 LED controller support
Date: Tue, 07 Mar 2023 12:56:39 -0800 (PST) [thread overview]
Message-ID: <mhng-93c6925c-9c65-40dc-ac0a-221dbdbbc492@palmer-ri-x1c9a> (raw)
In-Reply-To: <20221231235541.13568-1-samuel@sholland.org>
On Sat, 31 Dec 2022 15:55:35 PST (-0800), samuel@sholland.org wrote:
> [Resending because it has been a couple of months since v7 with no LED
> maintainer feedback, and LEDs now have an additional maintainer.]
>
> This series adds bindings and a driver for the RGB LED controller found
> in some Allwinner SoCs, starting with A100. The hardware in the R329 and
> D1 SoCs appears to be identical.
>
> Patches 4-5 depend on the D1 devicetree series[1], but the rest of this
> series can/should be merged without them.
>
> This driver was tested on the D1 Nezha board.
>
> [1]: https://lore.kernel.org/lkml/20221231233851.24923-1-samuel@sholland.org/
>
> Changes in v7:
> - Use DEFINE_SIMPLE_DEV_PM_OPS
>
> Changes in v6:
> - Drop the A100 DMA controller DT node patch, which was merged via a
> different series
>
> Changes in v5:
> - A100 contains the original implementation, so use that as the base
> compatible string, and rename the binding to match
> - Add "unevaluatedProperties: false" to the child multi-led binding
> - Rename the driver R329 -> A100, since that is the actual original
> implementation
>
> Changes in v4:
> - Use "default" instead of "maxItems" for timing properties
> - Depend on LEDS_CLASS_MULTICOLOR
>
> Changes in v3:
> - Removed quotes from enumeration values
> - Added vendor prefix to timing/format properties
> - Renamed "format" property to "pixel-format" for clarity
> - Dropped "vled-supply" as it is unrelated to the controller hardware
> - Added vendor prefix to timing/format properties
> - Renamed "format" property to "pixel-format" for clarity
> - Dropped "vled-supply" as it is unrelated to the controller hardware
> - Changed "writesl" to "iowrite32_rep" so the driver builds on hppa
>
> Changes in v2:
> - Fixed typo leading to duplicate t1h-ns property
> - Removed "items" layer in definition of dmas/dma-names
> - Replaced uint32 type reference with maxItems in timing properties
> - Renamed from sunxi-ledc to sun50i-r329-ledc
> - Added missing "static" to functions/globals as reported by 0day bot
>
> Samuel Holland (5):
> dt-bindings: leds: Add Allwinner A100 LED controller
> leds: sun50i-a100: New driver for the A100 LED controller
> arm64: dts: allwinner: a100: Add LED controller node
> riscv: dts: allwinner: d1: Add LED controller node
> riscv: dts: allwinner: d1: Add RGB LEDs to boards
>
> .../leds/allwinner,sun50i-a100-ledc.yaml | 139 +++++
> .../arm64/boot/dts/allwinner/sun50i-a100.dtsi | 14 +
> .../allwinner/sun20i-d1-lichee-rv-dock.dts | 12 +
> .../boot/dts/allwinner/sun20i-d1-nezha.dts | 13 +
> arch/riscv/boot/dts/allwinner/sun20i-d1.dtsi | 6 +
> .../boot/dts/allwinner/sunxi-d1s-t113.dtsi | 15 +
> drivers/leds/Kconfig | 9 +
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-sun50i-a100.c | 555 ++++++++++++++++++
> 9 files changed, 764 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/allwinner,sun50i-a100-ledc.yaml
> create mode 100644 drivers/leds/leds-sun50i-a100.c
Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
next prev parent reply other threads:[~2023-03-07 20:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-31 23:55 [RESEND PATCH v7 0/5] leds: Allwinner A100 LED controller support Samuel Holland
2022-12-31 23:55 ` [RESEND PATCH v7 1/5] dt-bindings: leds: Add Allwinner A100 LED controller Samuel Holland
2022-12-31 23:55 ` [RESEND PATCH v7 2/5] leds: sun50i-a100: New driver for the " Samuel Holland
2023-01-09 17:16 ` Lee Jones
2023-03-01 14:27 ` Lee Jones
2023-03-16 13:34 ` Lee Jones
2023-10-18 0:38 ` Samuel Holland
2023-10-29 18:37 ` Samuel Holland
2023-10-31 7:48 ` Lee Jones
2023-10-19 20:26 ` André Apitzsch
2023-10-23 9:58 ` Lee Jones
2023-11-17 12:54 ` Lee Jones
2022-12-31 23:55 ` [RESEND PATCH v7 3/5] arm64: dts: allwinner: a100: Add LED controller node Samuel Holland
2022-12-31 23:55 ` [RESEND PATCH v7 4/5] riscv: dts: allwinner: d1: " Samuel Holland
2022-12-31 23:55 ` [RESEND PATCH v7 5/5] riscv: dts: allwinner: d1: Add RGB LEDs to boards Samuel Holland
2023-01-26 4:59 ` [RESEND PATCH v7 0/5] leds: Allwinner A100 LED controller support Trevor Woerner
2023-03-07 20:56 ` Palmer Dabbelt [this message]
2023-03-08 4:13 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-93c6925c-9c65-40dc-ac0a-221dbdbbc492@palmer-ri-x1c9a \
--to=palmer@dabbelt.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guoren@kernel.org \
--cc=heiko.stuebner@vrull.eu \
--cc=heiko@sntech.de \
--cc=jernej.skrabec@gmail.com \
--cc=jszhang@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=p.zabel@pengutronix.de \
--cc=paul.walmsley@sifive.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).