* [PATCH v2 00/10] Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
@ 2023-11-24 10:16 Heiner Kallweit
2023-11-24 10:16 ` [PATCH v2 01/10] i2c: " Heiner Kallweit
` (10 more replies)
0 siblings, 11 replies; 23+ messages in thread
From: Heiner Kallweit @ 2023-11-24 10:16 UTC (permalink / raw)
To: Wolfram Sang, linuxppc-dev
Cc: linux-i2c, Heiner Kallweit, Christophe Leroy, Nicholas Piggin,
linux-kernel, greybus-dev, linux-staging, linux-media
After removal of the legacy eeprom driver the only remaining I2C
client device driver supporting I2C_CLASS_SPD is jc42. Because this
driver also supports I2C_CLASS_HWMON, adapters don't have to
declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
It's one step towards getting rid of I2C_CLASS_SPD mid-term.
Series was created supported by Coccinelle and its splitpatch.
v2:
- fix style issue in patch 4
- add ack in patch 2
- set proper subject prefix for all patches
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/i2c/busses/i2c-ali1535.c | 2 +-
drivers/i2c/busses/i2c-ali1563.c | 2 +-
drivers/i2c/busses/i2c-ali15x3.c | 2 +-
drivers/i2c/busses/i2c-amd756.c | 2 +-
drivers/i2c/busses/i2c-amd8111.c | 2 +-
drivers/i2c/busses/i2c-elektor.c | 2 +-
drivers/i2c/busses/i2c-gpio.c | 2 +-
drivers/i2c/busses/i2c-ibm_iic.c | 2 +-
drivers/i2c/busses/i2c-iop3xx.c | 2 +-
drivers/i2c/busses/i2c-isch.c | 2 +-
drivers/i2c/busses/i2c-kempld.c | 3 +--
drivers/i2c/busses/i2c-mlxcpld.c | 2 +-
drivers/i2c/busses/i2c-nforce2.c | 2 +-
drivers/i2c/busses/i2c-pasemi-pci.c | 2 +-
drivers/i2c/busses/i2c-piix4.c | 2 +-
drivers/i2c/busses/i2c-scmi.c | 2 +-
drivers/i2c/busses/i2c-sh7760.c | 2 +-
drivers/i2c/busses/i2c-sibyte.c | 4 ++--
drivers/i2c/busses/i2c-sis5595.c | 2 +-
drivers/i2c/busses/i2c-sis630.c | 2 +-
drivers/i2c/busses/i2c-sis96x.c | 2 +-
drivers/i2c/busses/i2c-via.c | 2 +-
drivers/i2c/busses/i2c-viapro.c | 2 +-
drivers/i2c/busses/scx200_acb.c | 2 +-
drivers/i2c/i2c-stub.c | 2 +-
drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c | 2 +-
drivers/staging/greybus/i2c.c | 2 +-
27 files changed, 28 insertions(+), 29 deletions(-)
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH v2 01/10] i2c: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
2023-11-24 10:16 [PATCH v2 00/10] Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON Heiner Kallweit
@ 2023-11-24 10:16 ` Heiner Kallweit
2023-11-26 14:21 ` Andi Shyti
2023-11-24 10:16 ` [PATCH v2 02/10] staging: greybus: " Heiner Kallweit
` (9 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Heiner Kallweit @ 2023-11-24 10:16 UTC (permalink / raw)
To: Wolfram Sang, Jean Delvare
Cc: linux-i2c, Heiner Kallweit, Andi Shyti, linux-kernel
After removal of the legacy eeprom driver the only remaining I2C
client device driver supporting I2C_CLASS_SPD is jc42. Because this
driver also supports I2C_CLASS_HWMON, adapters don't have to
declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
It's one step towards getting rid of I2C_CLASS_SPD mid-term.
Series was created supported by Coccinelle and its splitpatch.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/i2c/busses/i2c-ali1535.c | 2 +-
drivers/i2c/busses/i2c-ali15x3.c | 2 +-
drivers/i2c/busses/i2c-amd756.c | 2 +-
drivers/i2c/busses/i2c-amd8111.c | 2 +-
drivers/i2c/busses/i2c-isch.c | 2 +-
drivers/i2c/busses/i2c-nforce2.c | 2 +-
drivers/i2c/busses/i2c-piix4.c | 2 +-
drivers/i2c/busses/i2c-sis5595.c | 2 +-
drivers/i2c/busses/i2c-sis630.c | 2 +-
drivers/i2c/busses/i2c-sis96x.c | 2 +-
drivers/i2c/busses/i2c-via.c | 2 +-
drivers/i2c/busses/i2c-viapro.c | 2 +-
12 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/i2c/busses/i2c-ali1535.c b/drivers/i2c/busses/i2c-ali1535.c
index ee83c4581..461eb23f9 100644
--- a/drivers/i2c/busses/i2c-ali1535.c
+++ b/drivers/i2c/busses/i2c-ali1535.c
@@ -477,7 +477,7 @@ static const struct i2c_algorithm smbus_algorithm = {
static struct i2c_adapter ali1535_adapter = {
.owner = THIS_MODULE,
- .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
+ .class = I2C_CLASS_HWMON,
.algo = &smbus_algorithm,
};
diff --git a/drivers/i2c/busses/i2c-ali15x3.c b/drivers/i2c/busses/i2c-ali15x3.c
index 0231c5be6..d2fa30deb 100644
--- a/drivers/i2c/busses/i2c-ali15x3.c
+++ b/drivers/i2c/busses/i2c-ali15x3.c
@@ -461,7 +461,7 @@ static const struct i2c_algorithm smbus_algorithm = {
static struct i2c_adapter ali15x3_adapter = {
.owner = THIS_MODULE,
- .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
+ .class = I2C_CLASS_HWMON,
.algo = &smbus_algorithm,
};
diff --git a/drivers/i2c/busses/i2c-amd756.c b/drivers/i2c/busses/i2c-amd756.c
index ef1307a25..208310db9 100644
--- a/drivers/i2c/busses/i2c-amd756.c
+++ b/drivers/i2c/busses/i2c-amd756.c
@@ -285,7 +285,7 @@ static const struct i2c_algorithm smbus_algorithm = {
struct i2c_adapter amd756_smbus = {
.owner = THIS_MODULE,
- .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
+ .class = I2C_CLASS_HWMON,
.algo = &smbus_algorithm,
};
diff --git a/drivers/i2c/busses/i2c-amd8111.c b/drivers/i2c/busses/i2c-amd8111.c
index 1ed7e945b..42a9b1221 100644
--- a/drivers/i2c/busses/i2c-amd8111.c
+++ b/drivers/i2c/busses/i2c-amd8111.c
@@ -449,7 +449,7 @@ static int amd8111_probe(struct pci_dev *dev, const struct pci_device_id *id)
smbus->adapter.owner = THIS_MODULE;
snprintf(smbus->adapter.name, sizeof(smbus->adapter.name),
"SMBus2 AMD8111 adapter at %04x", smbus->base);
- smbus->adapter.class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
+ smbus->adapter.class = I2C_CLASS_HWMON;
smbus->adapter.algo = &smbus_algorithm;
smbus->adapter.algo_data = smbus;
diff --git a/drivers/i2c/busses/i2c-isch.c b/drivers/i2c/busses/i2c-isch.c
index 1dc1ceaa4..416a9968e 100644
--- a/drivers/i2c/busses/i2c-isch.c
+++ b/drivers/i2c/busses/i2c-isch.c
@@ -249,7 +249,7 @@ static const struct i2c_algorithm smbus_algorithm = {
static struct i2c_adapter sch_adapter = {
.owner = THIS_MODULE,
- .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
+ .class = I2C_CLASS_HWMON,
.algo = &smbus_algorithm,
};
diff --git a/drivers/i2c/busses/i2c-nforce2.c b/drivers/i2c/busses/i2c-nforce2.c
index 38d203d93..fab662e6b 100644
--- a/drivers/i2c/busses/i2c-nforce2.c
+++ b/drivers/i2c/busses/i2c-nforce2.c
@@ -349,7 +349,7 @@ static int nforce2_probe_smb(struct pci_dev *dev, int bar, int alt_reg,
return -EBUSY;
}
smbus->adapter.owner = THIS_MODULE;
- smbus->adapter.class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
+ smbus->adapter.class = I2C_CLASS_HWMON;
smbus->adapter.algo = &smbus_algorithm;
smbus->adapter.algo_data = smbus;
smbus->adapter.dev.parent = &dev->dev;
diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
index 809fbd014..6a0392172 100644
--- a/drivers/i2c/busses/i2c-piix4.c
+++ b/drivers/i2c/busses/i2c-piix4.c
@@ -943,7 +943,7 @@ static int piix4_add_adapter(struct pci_dev *dev, unsigned short smba,
}
adap->owner = THIS_MODULE;
- adap->class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
+ adap->class = I2C_CLASS_HWMON;
adap->algo = sb800_main ? &piix4_smbus_algorithm_sb800
: &smbus_algorithm;
diff --git a/drivers/i2c/busses/i2c-sis5595.c b/drivers/i2c/busses/i2c-sis5595.c
index 486f1e9df..32476dc10 100644
--- a/drivers/i2c/busses/i2c-sis5595.c
+++ b/drivers/i2c/busses/i2c-sis5595.c
@@ -353,7 +353,7 @@ static const struct i2c_algorithm smbus_algorithm = {
static struct i2c_adapter sis5595_adapter = {
.owner = THIS_MODULE,
- .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
+ .class = I2C_CLASS_HWMON,
.algo = &smbus_algorithm,
};
diff --git a/drivers/i2c/busses/i2c-sis630.c b/drivers/i2c/busses/i2c-sis630.c
index 87d56250d..3505cf29c 100644
--- a/drivers/i2c/busses/i2c-sis630.c
+++ b/drivers/i2c/busses/i2c-sis630.c
@@ -493,7 +493,7 @@ static const struct i2c_algorithm smbus_algorithm = {
static struct i2c_adapter sis630_adapter = {
.owner = THIS_MODULE,
- .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
+ .class = I2C_CLASS_HWMON,
.algo = &smbus_algorithm,
.retries = 3
};
diff --git a/drivers/i2c/busses/i2c-sis96x.c b/drivers/i2c/busses/i2c-sis96x.c
index cde800398..77529dda6 100644
--- a/drivers/i2c/busses/i2c-sis96x.c
+++ b/drivers/i2c/busses/i2c-sis96x.c
@@ -228,7 +228,7 @@ static const struct i2c_algorithm smbus_algorithm = {
static struct i2c_adapter sis96x_adapter = {
.owner = THIS_MODULE,
- .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
+ .class = I2C_CLASS_HWMON,
.algo = &smbus_algorithm,
};
diff --git a/drivers/i2c/busses/i2c-via.c b/drivers/i2c/busses/i2c-via.c
index ad4f09c7f..7ed29992a 100644
--- a/drivers/i2c/busses/i2c-via.c
+++ b/drivers/i2c/busses/i2c-via.c
@@ -70,7 +70,7 @@ static struct i2c_algo_bit_data bit_data = {
static struct i2c_adapter vt586b_adapter = {
.owner = THIS_MODULE,
- .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
+ .class = I2C_CLASS_HWMON,
.name = "VIA i2c",
.algo_data = &bit_data,
};
diff --git a/drivers/i2c/busses/i2c-viapro.c b/drivers/i2c/busses/i2c-viapro.c
index 970ccdcbb..2cc7bba3b 100644
--- a/drivers/i2c/busses/i2c-viapro.c
+++ b/drivers/i2c/busses/i2c-viapro.c
@@ -304,7 +304,7 @@ static const struct i2c_algorithm smbus_algorithm = {
static struct i2c_adapter vt596_adapter = {
.owner = THIS_MODULE,
- .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
+ .class = I2C_CLASS_HWMON,
.algo = &smbus_algorithm,
};
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 02/10] staging: greybus: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
2023-11-24 10:16 [PATCH v2 00/10] Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON Heiner Kallweit
2023-11-24 10:16 ` [PATCH v2 01/10] i2c: " Heiner Kallweit
@ 2023-11-24 10:16 ` Heiner Kallweit
2023-11-24 10:16 ` [PATCH v2 03/10] i2c: pasemi: " Heiner Kallweit
` (8 subsequent siblings)
10 siblings, 0 replies; 23+ messages in thread
From: Heiner Kallweit @ 2023-11-24 10:16 UTC (permalink / raw)
To: Wolfram Sang, Viresh Kumar
Cc: linux-i2c, Heiner Kallweit, Johan Hovold, Alex Elder,
Greg Kroah-Hartman, greybus-dev, linux-staging, linux-kernel
After removal of the legacy eeprom driver the only remaining I2C
client device driver supporting I2C_CLASS_SPD is jc42. Because this
driver also supports I2C_CLASS_HWMON, adapters don't have to
declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
It's one step towards getting rid of I2C_CLASS_SPD mid-term.
Series was created supported by Coccinelle and its splitpatch.
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/staging/greybus/i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/i2c.c b/drivers/staging/greybus/i2c.c
index de2f6516d..22325ab9d 100644
--- a/drivers/staging/greybus/i2c.c
+++ b/drivers/staging/greybus/i2c.c
@@ -264,7 +264,7 @@ static int gb_i2c_probe(struct gbphy_device *gbphy_dev,
/* Looks good; up our i2c adapter */
adapter = &gb_i2c_dev->adapter;
adapter->owner = THIS_MODULE;
- adapter->class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
+ adapter->class = I2C_CLASS_HWMON;
adapter->algo = &gb_i2c_algorithm;
adapter->dev.parent = &gbphy_dev->dev;
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 03/10] i2c: pasemi: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
2023-11-24 10:16 [PATCH v2 00/10] Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON Heiner Kallweit
2023-11-24 10:16 ` [PATCH v2 01/10] i2c: " Heiner Kallweit
2023-11-24 10:16 ` [PATCH v2 02/10] staging: greybus: " Heiner Kallweit
@ 2023-11-24 10:16 ` Heiner Kallweit
2023-11-26 14:22 ` Andi Shyti
2023-11-24 10:16 ` [PATCH v2 04/10] i2c: " Heiner Kallweit
` (7 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Heiner Kallweit @ 2023-11-24 10:16 UTC (permalink / raw)
To: Wolfram Sang, Michael Ellerman
Cc: linux-i2c, Heiner Kallweit, Nicholas Piggin, Christophe Leroy,
Andi Shyti, linuxppc-dev, linux-kernel
After removal of the legacy eeprom driver the only remaining I2C
client device driver supporting I2C_CLASS_SPD is jc42. Because this
driver also supports I2C_CLASS_HWMON, adapters don't have to
declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
It's one step towards getting rid of I2C_CLASS_SPD mid-term.
Series was created supported by Coccinelle and its splitpatch.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/i2c/busses/i2c-pasemi-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-pasemi-pci.c b/drivers/i2c/busses/i2c-pasemi-pci.c
index cfc89e04e..77f90c743 100644
--- a/drivers/i2c/busses/i2c-pasemi-pci.c
+++ b/drivers/i2c/busses/i2c-pasemi-pci.c
@@ -56,7 +56,7 @@ static int pasemi_smb_pci_probe(struct pci_dev *dev,
if (!smbus->ioaddr)
return -EBUSY;
- smbus->adapter.class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
+ smbus->adapter.class = I2C_CLASS_HWMON;
error = pasemi_i2c_common_probe(smbus);
if (error)
return error;
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 04/10] i2c: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
2023-11-24 10:16 [PATCH v2 00/10] Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON Heiner Kallweit
` (2 preceding siblings ...)
2023-11-24 10:16 ` [PATCH v2 03/10] i2c: pasemi: " Heiner Kallweit
@ 2023-11-24 10:16 ` Heiner Kallweit
2023-11-26 14:23 ` Andi Shyti
2023-11-24 10:16 ` [PATCH v2 05/10] i2c: stub: " Heiner Kallweit
` (6 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Heiner Kallweit @ 2023-11-24 10:16 UTC (permalink / raw)
To: Wolfram Sang, Andi Shyti; +Cc: linux-i2c, Heiner Kallweit, linux-kernel
After removal of the legacy eeprom driver the only remaining I2C
client device driver supporting I2C_CLASS_SPD is jc42. Because this
driver also supports I2C_CLASS_HWMON, adapters don't have to
declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
It's one step towards getting rid of I2C_CLASS_SPD mid-term.
Series was created supported by Coccinelle and its splitpatch.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
v2:
- fix style issue in i2c-kempld.c
---
drivers/i2c/busses/i2c-elektor.c | 2 +-
drivers/i2c/busses/i2c-ibm_iic.c | 2 +-
drivers/i2c/busses/i2c-iop3xx.c | 2 +-
drivers/i2c/busses/i2c-kempld.c | 3 +--
drivers/i2c/busses/i2c-scmi.c | 2 +-
drivers/i2c/busses/i2c-sh7760.c | 2 +-
drivers/i2c/busses/i2c-sibyte.c | 4 ++--
7 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/i2c/busses/i2c-elektor.c b/drivers/i2c/busses/i2c-elektor.c
index b0f50dce9..cfe8665ca 100644
--- a/drivers/i2c/busses/i2c-elektor.c
+++ b/drivers/i2c/busses/i2c-elektor.c
@@ -188,7 +188,7 @@ static struct i2c_algo_pcf_data pcf_isa_data = {
static struct i2c_adapter pcf_isa_ops = {
.owner = THIS_MODULE,
- .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
+ .class = I2C_CLASS_HWMON,
.algo_data = &pcf_isa_data,
.name = "i2c-elektor",
};
diff --git a/drivers/i2c/busses/i2c-ibm_iic.c b/drivers/i2c/busses/i2c-ibm_iic.c
index 408820319..7fb87b789 100644
--- a/drivers/i2c/busses/i2c-ibm_iic.c
+++ b/drivers/i2c/busses/i2c-ibm_iic.c
@@ -739,7 +739,7 @@ static int iic_probe(struct platform_device *ofdev)
adap->dev.of_node = of_node_get(np);
strscpy(adap->name, "IBM IIC", sizeof(adap->name));
i2c_set_adapdata(adap, dev);
- adap->class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
+ adap->class = I2C_CLASS_HWMON;
adap->algo = &iic_algo;
adap->timeout = HZ;
diff --git a/drivers/i2c/busses/i2c-iop3xx.c b/drivers/i2c/busses/i2c-iop3xx.c
index f2f7ebeea..2e5f0165c 100644
--- a/drivers/i2c/busses/i2c-iop3xx.c
+++ b/drivers/i2c/busses/i2c-iop3xx.c
@@ -478,7 +478,7 @@ iop3xx_i2c_probe(struct platform_device *pdev)
memcpy(new_adapter->name, pdev->name, strlen(pdev->name));
new_adapter->owner = THIS_MODULE;
- new_adapter->class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
+ new_adapter->class = I2C_CLASS_HWMON;
new_adapter->dev.parent = &pdev->dev;
new_adapter->dev.of_node = pdev->dev.of_node;
new_adapter->nr = pdev->id;
diff --git a/drivers/i2c/busses/i2c-kempld.c b/drivers/i2c/busses/i2c-kempld.c
index e01d75308..c3a529a73 100644
--- a/drivers/i2c/busses/i2c-kempld.c
+++ b/drivers/i2c/busses/i2c-kempld.c
@@ -283,8 +283,7 @@ static const struct i2c_algorithm kempld_i2c_algorithm = {
static const struct i2c_adapter kempld_i2c_adapter = {
.owner = THIS_MODULE,
.name = "i2c-kempld",
- .class = I2C_CLASS_HWMON | I2C_CLASS_SPD |
- I2C_CLASS_DEPRECATED,
+ .class = I2C_CLASS_HWMON | I2C_CLASS_DEPRECATED,
.algo = &kempld_i2c_algorithm,
};
diff --git a/drivers/i2c/busses/i2c-scmi.c b/drivers/i2c/busses/i2c-scmi.c
index 421735acf..d7af8e0d7 100644
--- a/drivers/i2c/busses/i2c-scmi.c
+++ b/drivers/i2c/busses/i2c-scmi.c
@@ -385,7 +385,7 @@ static int smbus_cmi_probe(struct platform_device *device)
smbus_cmi->adapter.owner = THIS_MODULE;
smbus_cmi->adapter.algo = &acpi_smbus_cmi_algorithm;
smbus_cmi->adapter.algo_data = smbus_cmi;
- smbus_cmi->adapter.class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
+ smbus_cmi->adapter.class = I2C_CLASS_HWMON;
smbus_cmi->adapter.dev.parent = &device->dev;
ret = i2c_add_adapter(&smbus_cmi->adapter);
diff --git a/drivers/i2c/busses/i2c-sh7760.c b/drivers/i2c/busses/i2c-sh7760.c
index 1ad2a2615..8a043f5fc 100644
--- a/drivers/i2c/busses/i2c-sh7760.c
+++ b/drivers/i2c/busses/i2c-sh7760.c
@@ -477,7 +477,7 @@ static int sh7760_i2c_probe(struct platform_device *pdev)
id->adap.nr = pdev->id;
id->adap.algo = &sh7760_i2c_algo;
- id->adap.class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
+ id->adap.class = I2C_CLASS_HWMON;
id->adap.retries = 3;
id->adap.algo_data = id;
id->adap.dev.parent = &pdev->dev;
diff --git a/drivers/i2c/busses/i2c-sibyte.c b/drivers/i2c/busses/i2c-sibyte.c
index 8f71f01cb..49f8f4f1b 100644
--- a/drivers/i2c/busses/i2c-sibyte.c
+++ b/drivers/i2c/busses/i2c-sibyte.c
@@ -142,7 +142,7 @@ static struct i2c_algo_sibyte_data sibyte_board_data[2] = {
static struct i2c_adapter sibyte_board_adapter[2] = {
{
.owner = THIS_MODULE,
- .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
+ .class = I2C_CLASS_HWMON,
.algo = NULL,
.algo_data = &sibyte_board_data[0],
.nr = 0,
@@ -150,7 +150,7 @@ static struct i2c_adapter sibyte_board_adapter[2] = {
},
{
.owner = THIS_MODULE,
- .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
+ .class = I2C_CLASS_HWMON,
.algo = NULL,
.algo_data = &sibyte_board_data[1],
.nr = 1,
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 05/10] i2c: stub: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
2023-11-24 10:16 [PATCH v2 00/10] Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON Heiner Kallweit
` (3 preceding siblings ...)
2023-11-24 10:16 ` [PATCH v2 04/10] i2c: " Heiner Kallweit
@ 2023-11-24 10:16 ` Heiner Kallweit
2023-11-24 10:16 ` [PATCH v2 06/10] i2c: gpio: " Heiner Kallweit
` (5 subsequent siblings)
10 siblings, 0 replies; 23+ messages in thread
From: Heiner Kallweit @ 2023-11-24 10:16 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, Heiner Kallweit, Jean Delvare, linux-kernel
After removal of the legacy eeprom driver the only remaining I2C
client device driver supporting I2C_CLASS_SPD is jc42. Because this
driver also supports I2C_CLASS_HWMON, adapters don't have to
declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
It's one step towards getting rid of I2C_CLASS_SPD mid-term.
Series was created supported by Coccinelle and its splitpatch.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/i2c/i2c-stub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/i2c-stub.c b/drivers/i2c/i2c-stub.c
index d642cad21..09e7b7bf4 100644
--- a/drivers/i2c/i2c-stub.c
+++ b/drivers/i2c/i2c-stub.c
@@ -308,7 +308,7 @@ static const struct i2c_algorithm smbus_algorithm = {
static struct i2c_adapter stub_adapter = {
.owner = THIS_MODULE,
- .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
+ .class = I2C_CLASS_HWMON,
.algo = &smbus_algorithm,
.name = "SMBus stub driver",
};
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 06/10] i2c: gpio: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
2023-11-24 10:16 [PATCH v2 00/10] Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON Heiner Kallweit
` (4 preceding siblings ...)
2023-11-24 10:16 ` [PATCH v2 05/10] i2c: stub: " Heiner Kallweit
@ 2023-11-24 10:16 ` Heiner Kallweit
2023-11-26 14:24 ` Andi Shyti
2023-11-24 10:16 ` [PATCH v2 07/10] i2c: mlxcpld: " Heiner Kallweit
` (4 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Heiner Kallweit @ 2023-11-24 10:16 UTC (permalink / raw)
To: Wolfram Sang, Wolfram Sang
Cc: linux-i2c, Heiner Kallweit, Andi Shyti, linux-kernel
After removal of the legacy eeprom driver the only remaining I2C
client device driver supporting I2C_CLASS_SPD is jc42. Because this
driver also supports I2C_CLASS_HWMON, adapters don't have to
declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
It's one step towards getting rid of I2C_CLASS_SPD mid-term.
Series was created supported by Coccinelle and its splitpatch.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/i2c/busses/i2c-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c
index fb35a75fe..df2b183ca 100644
--- a/drivers/i2c/busses/i2c-gpio.c
+++ b/drivers/i2c/busses/i2c-gpio.c
@@ -444,7 +444,7 @@ static int i2c_gpio_probe(struct platform_device *pdev)
snprintf(adap->name, sizeof(adap->name), "i2c-gpio%d", pdev->id);
adap->algo_data = bit_data;
- adap->class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
+ adap->class = I2C_CLASS_HWMON;
adap->dev.parent = dev;
device_set_node(&adap->dev, fwnode);
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 07/10] i2c: mlxcpld: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
2023-11-24 10:16 [PATCH v2 00/10] Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON Heiner Kallweit
` (5 preceding siblings ...)
2023-11-24 10:16 ` [PATCH v2 06/10] i2c: gpio: " Heiner Kallweit
@ 2023-11-24 10:16 ` Heiner Kallweit
2023-11-26 14:24 ` Andi Shyti
2023-11-24 10:16 ` [PATCH v2 08/10] media: netup_unidvb: " Heiner Kallweit
` (3 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Heiner Kallweit @ 2023-11-24 10:16 UTC (permalink / raw)
To: Wolfram Sang, Vadim Pasternak
Cc: linux-i2c, Heiner Kallweit, Michael Shych, Andi Shyti, linux-kernel
After removal of the legacy eeprom driver the only remaining I2C
client device driver supporting I2C_CLASS_SPD is jc42. Because this
driver also supports I2C_CLASS_HWMON, adapters don't have to
declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
It's one step towards getting rid of I2C_CLASS_SPD mid-term.
Series was created supported by Coccinelle and its splitpatch.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/i2c/busses/i2c-mlxcpld.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-mlxcpld.c b/drivers/i2c/busses/i2c-mlxcpld.c
index 6fec64ea6..099291a04 100644
--- a/drivers/i2c/busses/i2c-mlxcpld.c
+++ b/drivers/i2c/busses/i2c-mlxcpld.c
@@ -477,7 +477,7 @@ static const struct i2c_adapter_quirks mlxcpld_i2c_quirks_ext2 = {
static struct i2c_adapter mlxcpld_i2c_adapter = {
.owner = THIS_MODULE,
.name = "i2c-mlxcpld",
- .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
+ .class = I2C_CLASS_HWMON,
.algo = &mlxcpld_i2c_algo,
.quirks = &mlxcpld_i2c_quirks,
.retries = MLXCPLD_I2C_RETR_NUM,
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 08/10] media: netup_unidvb: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
2023-11-24 10:16 [PATCH v2 00/10] Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON Heiner Kallweit
` (6 preceding siblings ...)
2023-11-24 10:16 ` [PATCH v2 07/10] i2c: mlxcpld: " Heiner Kallweit
@ 2023-11-24 10:16 ` Heiner Kallweit
2023-12-05 8:13 ` Hans Verkuil
2023-11-24 10:16 ` [PATCH v2 09/10] i2c: ali1563: " Heiner Kallweit
` (2 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Heiner Kallweit @ 2023-11-24 10:16 UTC (permalink / raw)
To: Wolfram Sang, Sergey Kozlov, Mauro Carvalho Chehab
Cc: linux-i2c, Heiner Kallweit, Abylay Ospan, linux-media, linux-kernel
After removal of the legacy eeprom driver the only remaining I2C
client device driver supporting I2C_CLASS_SPD is jc42. Because this
driver also supports I2C_CLASS_HWMON, adapters don't have to
declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
It's one step towards getting rid of I2C_CLASS_SPD mid-term.
Series was created supported by Coccinelle and its splitpatch.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c
index bd38ce444..46676f2c8 100644
--- a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c
+++ b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c
@@ -289,7 +289,7 @@ static const struct i2c_algorithm netup_i2c_algorithm = {
static const struct i2c_adapter netup_i2c_adapter = {
.owner = THIS_MODULE,
.name = NETUP_UNIDVB_NAME,
- .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
+ .class = I2C_CLASS_HWMON,
.algo = &netup_i2c_algorithm,
};
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 09/10] i2c: ali1563: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
2023-11-24 10:16 [PATCH v2 00/10] Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON Heiner Kallweit
` (7 preceding siblings ...)
2023-11-24 10:16 ` [PATCH v2 08/10] media: netup_unidvb: " Heiner Kallweit
@ 2023-11-24 10:16 ` Heiner Kallweit
2023-11-26 14:24 ` Andi Shyti
2023-11-24 10:16 ` [PATCH v2 10/10] i2c: scx200_acb: " Heiner Kallweit
2023-12-16 20:23 ` [PATCH v2 00/10] " Heiner Kallweit
10 siblings, 1 reply; 23+ messages in thread
From: Heiner Kallweit @ 2023-11-24 10:16 UTC (permalink / raw)
To: Wolfram Sang, Jean Delvare
Cc: linux-i2c, Heiner Kallweit, Rudolf Marek, Andi Shyti, linux-kernel
After removal of the legacy eeprom driver the only remaining I2C
client device driver supporting I2C_CLASS_SPD is jc42. Because this
driver also supports I2C_CLASS_HWMON, adapters don't have to
declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
It's one step towards getting rid of I2C_CLASS_SPD mid-term.
Series was created supported by Coccinelle and its splitpatch.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/i2c/busses/i2c-ali1563.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-ali1563.c b/drivers/i2c/busses/i2c-ali1563.c
index 55a9e93fb..307fb0666 100644
--- a/drivers/i2c/busses/i2c-ali1563.c
+++ b/drivers/i2c/busses/i2c-ali1563.c
@@ -390,7 +390,7 @@ static const struct i2c_algorithm ali1563_algorithm = {
static struct i2c_adapter ali1563_adapter = {
.owner = THIS_MODULE,
- .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
+ .class = I2C_CLASS_HWMON,
.algo = &ali1563_algorithm,
};
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH v2 10/10] i2c: scx200_acb: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
2023-11-24 10:16 [PATCH v2 00/10] Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON Heiner Kallweit
` (8 preceding siblings ...)
2023-11-24 10:16 ` [PATCH v2 09/10] i2c: ali1563: " Heiner Kallweit
@ 2023-11-24 10:16 ` Heiner Kallweit
2023-11-26 6:03 ` jim.cromie
2023-11-26 14:30 ` Andi Shyti
2023-12-16 20:23 ` [PATCH v2 00/10] " Heiner Kallweit
10 siblings, 2 replies; 23+ messages in thread
From: Heiner Kallweit @ 2023-11-24 10:16 UTC (permalink / raw)
To: Wolfram Sang, Jim Cromie
Cc: linux-i2c, Heiner Kallweit, Andi Shyti, linux-kernel
After removal of the legacy eeprom driver the only remaining I2C
client device driver supporting I2C_CLASS_SPD is jc42. Because this
driver also supports I2C_CLASS_HWMON, adapters don't have to
declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
It's one step towards getting rid of I2C_CLASS_SPD mid-term.
Series was created supported by Coccinelle and its splitpatch.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/i2c/busses/scx200_acb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/scx200_acb.c b/drivers/i2c/busses/scx200_acb.c
index 83c1db610..3648382b8 100644
--- a/drivers/i2c/busses/scx200_acb.c
+++ b/drivers/i2c/busses/scx200_acb.c
@@ -427,7 +427,7 @@ static struct scx200_acb_iface *scx200_create_iface(const char *text,
snprintf(adapter->name, sizeof(adapter->name), "%s ACB%d", text, index);
adapter->owner = THIS_MODULE;
adapter->algo = &scx200_acb_algorithm;
- adapter->class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
+ adapter->class = I2C_CLASS_HWMON;
adapter->dev.parent = dev;
mutex_init(&iface->mutex);
^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH v2 10/10] i2c: scx200_acb: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
2023-11-24 10:16 ` [PATCH v2 10/10] i2c: scx200_acb: " Heiner Kallweit
@ 2023-11-26 6:03 ` jim.cromie
2023-11-26 12:18 ` Heiner Kallweit
2023-11-26 14:30 ` Andi Shyti
1 sibling, 1 reply; 23+ messages in thread
From: jim.cromie @ 2023-11-26 6:03 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: Wolfram Sang, linux-i2c, Andi Shyti, linux-kernel
On Fri, Nov 24, 2023 at 3:16 AM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> After removal of the legacy eeprom driver the only remaining I2C
> client device driver supporting I2C_CLASS_SPD is jc42. Because this
> driver also supports I2C_CLASS_HWMON, adapters don't have to
> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
> It's one step towards getting rid of I2C_CLASS_SPD mid-term.
>
> Series was created supported by Coccinelle and its splitpatch.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
Acked:
> ---
> drivers/i2c/busses/scx200_acb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/scx200_acb.c b/drivers/i2c/busses/scx200_acb.c
> index 83c1db610..3648382b8 100644
> --- a/drivers/i2c/busses/scx200_acb.c
> +++ b/drivers/i2c/busses/scx200_acb.c
> @@ -427,7 +427,7 @@ static struct scx200_acb_iface *scx200_create_iface(const char *text,
> snprintf(adapter->name, sizeof(adapter->name), "%s ACB%d", text, index);
> adapter->owner = THIS_MODULE;
> adapter->algo = &scx200_acb_algorithm;
> - adapter->class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
> + adapter->class = I2C_CLASS_HWMON;
> adapter->dev.parent = dev;
>
> mutex_init(&iface->mutex);
>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 10/10] i2c: scx200_acb: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
2023-11-26 6:03 ` jim.cromie
@ 2023-11-26 12:18 ` Heiner Kallweit
0 siblings, 0 replies; 23+ messages in thread
From: Heiner Kallweit @ 2023-11-26 12:18 UTC (permalink / raw)
To: jim.cromie; +Cc: Wolfram Sang, linux-i2c, Andi Shyti, linux-kernel
On 26.11.2023 07:03, jim.cromie@gmail.com wrote:
> On Fri, Nov 24, 2023 at 3:16 AM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>>
>> After removal of the legacy eeprom driver the only remaining I2C
>> client device driver supporting I2C_CLASS_SPD is jc42. Because this
>> driver also supports I2C_CLASS_HWMON, adapters don't have to
>> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
>> It's one step towards getting rid of I2C_CLASS_SPD mid-term.
>>
>> Series was created supported by Coccinelle and its splitpatch.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>
>
> Acked:
>
Thanks. Could you please respond with a proper Acked-by tag so that patchwork
can pick it up?
>
>> ---
>> drivers/i2c/busses/scx200_acb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/i2c/busses/scx200_acb.c b/drivers/i2c/busses/scx200_acb.c
>> index 83c1db610..3648382b8 100644
>> --- a/drivers/i2c/busses/scx200_acb.c
>> +++ b/drivers/i2c/busses/scx200_acb.c
>> @@ -427,7 +427,7 @@ static struct scx200_acb_iface *scx200_create_iface(const char *text,
>> snprintf(adapter->name, sizeof(adapter->name), "%s ACB%d", text, index);
>> adapter->owner = THIS_MODULE;
>> adapter->algo = &scx200_acb_algorithm;
>> - adapter->class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
>> + adapter->class = I2C_CLASS_HWMON;
>> adapter->dev.parent = dev;
>>
>> mutex_init(&iface->mutex);
>>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 01/10] i2c: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
2023-11-24 10:16 ` [PATCH v2 01/10] i2c: " Heiner Kallweit
@ 2023-11-26 14:21 ` Andi Shyti
0 siblings, 0 replies; 23+ messages in thread
From: Andi Shyti @ 2023-11-26 14:21 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: Wolfram Sang, Jean Delvare, linux-i2c, linux-kernel
Hi Heiner,
On Fri, Nov 24, 2023 at 11:16:10AM +0100, Heiner Kallweit wrote:
> After removal of the legacy eeprom driver the only remaining I2C
> client device driver supporting I2C_CLASS_SPD is jc42. Because this
> driver also supports I2C_CLASS_HWMON, adapters don't have to
> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
> It's one step towards getting rid of I2C_CLASS_SPD mid-term.
>
> Series was created supported by Coccinelle and its splitpatch.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Andi Shyti <andi.shyti@kernel.org>
Andi
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 03/10] i2c: pasemi: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
2023-11-24 10:16 ` [PATCH v2 03/10] i2c: pasemi: " Heiner Kallweit
@ 2023-11-26 14:22 ` Andi Shyti
0 siblings, 0 replies; 23+ messages in thread
From: Andi Shyti @ 2023-11-26 14:22 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Wolfram Sang, Michael Ellerman, linux-i2c, Nicholas Piggin,
Christophe Leroy, linuxppc-dev, linux-kernel
Hi Heiner,
On Fri, Nov 24, 2023 at 11:16:12AM +0100, Heiner Kallweit wrote:
> After removal of the legacy eeprom driver the only remaining I2C
> client device driver supporting I2C_CLASS_SPD is jc42. Because this
> driver also supports I2C_CLASS_HWMON, adapters don't have to
> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
> It's one step towards getting rid of I2C_CLASS_SPD mid-term.
>
> Series was created supported by Coccinelle and its splitpatch.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Andi Shyti <andi.shyti@kernel.org>
Thanks,
Andi
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 04/10] i2c: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
2023-11-24 10:16 ` [PATCH v2 04/10] i2c: " Heiner Kallweit
@ 2023-11-26 14:23 ` Andi Shyti
0 siblings, 0 replies; 23+ messages in thread
From: Andi Shyti @ 2023-11-26 14:23 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: Wolfram Sang, linux-i2c, linux-kernel
Hi Heiner,
On Fri, Nov 24, 2023 at 11:16:13AM +0100, Heiner Kallweit wrote:
> After removal of the legacy eeprom driver the only remaining I2C
> client device driver supporting I2C_CLASS_SPD is jc42. Because this
> driver also supports I2C_CLASS_HWMON, adapters don't have to
> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
> It's one step towards getting rid of I2C_CLASS_SPD mid-term.
>
> Series was created supported by Coccinelle and its splitpatch.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Andi Shyti <andi.shyti@kernel.org>
Thanks,
Andi
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 06/10] i2c: gpio: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
2023-11-24 10:16 ` [PATCH v2 06/10] i2c: gpio: " Heiner Kallweit
@ 2023-11-26 14:24 ` Andi Shyti
0 siblings, 0 replies; 23+ messages in thread
From: Andi Shyti @ 2023-11-26 14:24 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: Wolfram Sang, Wolfram Sang, linux-i2c, linux-kernel
Hi Heiner,
On Fri, Nov 24, 2023 at 11:16:15AM +0100, Heiner Kallweit wrote:
> After removal of the legacy eeprom driver the only remaining I2C
> client device driver supporting I2C_CLASS_SPD is jc42. Because this
> driver also supports I2C_CLASS_HWMON, adapters don't have to
> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
> It's one step towards getting rid of I2C_CLASS_SPD mid-term.
>
> Series was created supported by Coccinelle and its splitpatch.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Andi Shyti <andi.shyti@kernel.org>
Thanks,
Andi
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 07/10] i2c: mlxcpld: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
2023-11-24 10:16 ` [PATCH v2 07/10] i2c: mlxcpld: " Heiner Kallweit
@ 2023-11-26 14:24 ` Andi Shyti
0 siblings, 0 replies; 23+ messages in thread
From: Andi Shyti @ 2023-11-26 14:24 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Wolfram Sang, Vadim Pasternak, linux-i2c, Michael Shych, linux-kernel
Hi Heiner,
On Fri, Nov 24, 2023 at 11:16:16AM +0100, Heiner Kallweit wrote:
> After removal of the legacy eeprom driver the only remaining I2C
> client device driver supporting I2C_CLASS_SPD is jc42. Because this
> driver also supports I2C_CLASS_HWMON, adapters don't have to
> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
> It's one step towards getting rid of I2C_CLASS_SPD mid-term.
>
> Series was created supported by Coccinelle and its splitpatch.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Andi Shyti <andi.shyti@kernel.org>
Thanks,
Andi
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 09/10] i2c: ali1563: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
2023-11-24 10:16 ` [PATCH v2 09/10] i2c: ali1563: " Heiner Kallweit
@ 2023-11-26 14:24 ` Andi Shyti
0 siblings, 0 replies; 23+ messages in thread
From: Andi Shyti @ 2023-11-26 14:24 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Wolfram Sang, Jean Delvare, linux-i2c, Rudolf Marek, linux-kernel
Hi Heiner,
On Fri, Nov 24, 2023 at 11:16:18AM +0100, Heiner Kallweit wrote:
> After removal of the legacy eeprom driver the only remaining I2C
> client device driver supporting I2C_CLASS_SPD is jc42. Because this
> driver also supports I2C_CLASS_HWMON, adapters don't have to
> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
> It's one step towards getting rid of I2C_CLASS_SPD mid-term.
>
> Series was created supported by Coccinelle and its splitpatch.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Andi Shyti <andi.shyti@kernel.org>
Thanks,
Andi
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 10/10] i2c: scx200_acb: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
2023-11-24 10:16 ` [PATCH v2 10/10] i2c: scx200_acb: " Heiner Kallweit
2023-11-26 6:03 ` jim.cromie
@ 2023-11-26 14:30 ` Andi Shyti
1 sibling, 0 replies; 23+ messages in thread
From: Andi Shyti @ 2023-11-26 14:30 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: Wolfram Sang, Jim Cromie, linux-i2c, linux-kernel
Hi Heiner,
in this last patch I will add a couple of minor comments valid
for the previous, as well.
On Fri, Nov 24, 2023 at 11:16:19AM +0100, Heiner Kallweit wrote:
> After removal of the legacy eeprom driver the only remaining I2C
> client device driver supporting I2C_CLASS_SPD is jc42. Because this
> driver also supports I2C_CLASS_HWMON, adapters don't have to
> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
> It's one step towards getting rid of I2C_CLASS_SPD mid-term.
>
> Series was created supported by Coccinelle and its splitpatch.
this sentence is grammatically incorrect, I guess you meant:
"The series was created with support from Coccinelle and its
splitpatch feature."
Please fix it if you are going to resend it.
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
Just for you to know, all your patches have a blank line after
your SoB, it doesn't really matter as I guess git removes it.
In any case, as before:
Acked-by: Andi Shyti <andi.shyti@kernel.org>
and I believe:
Acked-by: Jim Cromie <jim.cromie@gmail.com>
so that patchwork takes it.
Thanks,
Andi
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 08/10] media: netup_unidvb: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
2023-11-24 10:16 ` [PATCH v2 08/10] media: netup_unidvb: " Heiner Kallweit
@ 2023-12-05 8:13 ` Hans Verkuil
0 siblings, 0 replies; 23+ messages in thread
From: Hans Verkuil @ 2023-12-05 8:13 UTC (permalink / raw)
To: Heiner Kallweit, Wolfram Sang, Sergey Kozlov, Mauro Carvalho Chehab
Cc: linux-i2c, Abylay Ospan, linux-media, linux-kernel
On 24/11/2023 11:16, Heiner Kallweit wrote:
> After removal of the legacy eeprom driver the only remaining I2C
> client device driver supporting I2C_CLASS_SPD is jc42. Because this
> driver also supports I2C_CLASS_HWMON, adapters don't have to
> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
> It's one step towards getting rid of I2C_CLASS_SPD mid-term.
>
> Series was created supported by Coccinelle and its splitpatch.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Do you want me to take this, or will this go through the i2c subsystem?
Regards,
Hans
>
> ---
> drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c
> index bd38ce444..46676f2c8 100644
> --- a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c
> +++ b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c
> @@ -289,7 +289,7 @@ static const struct i2c_algorithm netup_i2c_algorithm = {
> static const struct i2c_adapter netup_i2c_adapter = {
> .owner = THIS_MODULE,
> .name = NETUP_UNIDVB_NAME,
> - .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
> + .class = I2C_CLASS_HWMON,
> .algo = &netup_i2c_algorithm,
> };
>
>
>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 00/10] Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
2023-11-24 10:16 [PATCH v2 00/10] Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON Heiner Kallweit
` (9 preceding siblings ...)
2023-11-24 10:16 ` [PATCH v2 10/10] i2c: scx200_acb: " Heiner Kallweit
@ 2023-12-16 20:23 ` Heiner Kallweit
2023-12-19 12:36 ` Wolfram Sang
10 siblings, 1 reply; 23+ messages in thread
From: Heiner Kallweit @ 2023-12-16 20:23 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c, Christophe Leroy, Nicholas Piggin, linux-kernel,
greybus-dev, linux-staging, linux-media, linuxppc-dev
On 24.11.2023 11:16, Heiner Kallweit wrote:
> After removal of the legacy eeprom driver the only remaining I2C
> client device driver supporting I2C_CLASS_SPD is jc42. Because this
> driver also supports I2C_CLASS_HWMON, adapters don't have to
> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
> It's one step towards getting rid of I2C_CLASS_SPD mid-term.
>
> Series was created supported by Coccinelle and its splitpatch.
>
> v2:
> - fix style issue in patch 4
> - add ack in patch 2
> - set proper subject prefix for all patches
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> ---
>
> drivers/i2c/busses/i2c-ali1535.c | 2 +-
> drivers/i2c/busses/i2c-ali1563.c | 2 +-
> drivers/i2c/busses/i2c-ali15x3.c | 2 +-
> drivers/i2c/busses/i2c-amd756.c | 2 +-
> drivers/i2c/busses/i2c-amd8111.c | 2 +-
> drivers/i2c/busses/i2c-elektor.c | 2 +-
> drivers/i2c/busses/i2c-gpio.c | 2 +-
> drivers/i2c/busses/i2c-ibm_iic.c | 2 +-
> drivers/i2c/busses/i2c-iop3xx.c | 2 +-
> drivers/i2c/busses/i2c-isch.c | 2 +-
> drivers/i2c/busses/i2c-kempld.c | 3 +--
> drivers/i2c/busses/i2c-mlxcpld.c | 2 +-
> drivers/i2c/busses/i2c-nforce2.c | 2 +-
> drivers/i2c/busses/i2c-pasemi-pci.c | 2 +-
> drivers/i2c/busses/i2c-piix4.c | 2 +-
> drivers/i2c/busses/i2c-scmi.c | 2 +-
> drivers/i2c/busses/i2c-sh7760.c | 2 +-
> drivers/i2c/busses/i2c-sibyte.c | 4 ++--
> drivers/i2c/busses/i2c-sis5595.c | 2 +-
> drivers/i2c/busses/i2c-sis630.c | 2 +-
> drivers/i2c/busses/i2c-sis96x.c | 2 +-
> drivers/i2c/busses/i2c-via.c | 2 +-
> drivers/i2c/busses/i2c-viapro.c | 2 +-
> drivers/i2c/busses/scx200_acb.c | 2 +-
> drivers/i2c/i2c-stub.c | 2 +-
> drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c | 2 +-
> drivers/staging/greybus/i2c.c | 2 +-
> 27 files changed, 28 insertions(+), 29 deletions(-)
This series and my other series are sitting idle in patchwork
for 3 weeks now. AFAICS they have the needed ack's.
Anything missing before they can be applied?
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v2 00/10] Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
2023-12-16 20:23 ` [PATCH v2 00/10] " Heiner Kallweit
@ 2023-12-19 12:36 ` Wolfram Sang
0 siblings, 0 replies; 23+ messages in thread
From: Wolfram Sang @ 2023-12-19 12:36 UTC (permalink / raw)
To: Heiner Kallweit
Cc: linux-i2c, Christophe Leroy, Nicholas Piggin, linux-kernel,
greybus-dev, linux-staging, linux-media, linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 197 bytes --]
> This series and my other series are sitting idle in patchwork
> for 3 weeks now. AFAICS they have the needed ack's.
> Anything missing before they can be applied?
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread
end of thread, other threads:[~2023-12-19 12:36 UTC | newest]
Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-24 10:16 [PATCH v2 00/10] Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON Heiner Kallweit
2023-11-24 10:16 ` [PATCH v2 01/10] i2c: " Heiner Kallweit
2023-11-26 14:21 ` Andi Shyti
2023-11-24 10:16 ` [PATCH v2 02/10] staging: greybus: " Heiner Kallweit
2023-11-24 10:16 ` [PATCH v2 03/10] i2c: pasemi: " Heiner Kallweit
2023-11-26 14:22 ` Andi Shyti
2023-11-24 10:16 ` [PATCH v2 04/10] i2c: " Heiner Kallweit
2023-11-26 14:23 ` Andi Shyti
2023-11-24 10:16 ` [PATCH v2 05/10] i2c: stub: " Heiner Kallweit
2023-11-24 10:16 ` [PATCH v2 06/10] i2c: gpio: " Heiner Kallweit
2023-11-26 14:24 ` Andi Shyti
2023-11-24 10:16 ` [PATCH v2 07/10] i2c: mlxcpld: " Heiner Kallweit
2023-11-26 14:24 ` Andi Shyti
2023-11-24 10:16 ` [PATCH v2 08/10] media: netup_unidvb: " Heiner Kallweit
2023-12-05 8:13 ` Hans Verkuil
2023-11-24 10:16 ` [PATCH v2 09/10] i2c: ali1563: " Heiner Kallweit
2023-11-26 14:24 ` Andi Shyti
2023-11-24 10:16 ` [PATCH v2 10/10] i2c: scx200_acb: " Heiner Kallweit
2023-11-26 6:03 ` jim.cromie
2023-11-26 12:18 ` Heiner Kallweit
2023-11-26 14:30 ` Andi Shyti
2023-12-16 20:23 ` [PATCH v2 00/10] " Heiner Kallweit
2023-12-19 12:36 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).