* [PATCH v2] ASoC: dt-bindings: Add tas2563 into yaml
@ 2023-12-10 23:47 Shenghao Ding
2023-12-11 11:06 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Shenghao Ding @ 2023-12-10 23:47 UTC (permalink / raw)
To: broonie, conor+dt, krzysztof.kozlowski
Cc: robh+dt, andriy.shevchenko, devicetree, lgirdwood, perex,
pierre-louis.bossart, 13916275206, linux-sound, linux-kernel,
liam.r.girdwood, soyer, tiwai, peeyush, navada, Shenghao Ding
Support tas2563.
Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
---
Change in v2:
- Add devicetree list and other list of necessary people and lists to CC
- Express Compatibility in the bindings
- Drop driver changes
---
.../devicetree/bindings/sound/ti,tas2781.yaml | 26 +++++++++++++------
1 file changed, 18 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
index a69e6c223308..c049fe6b2dad 100644
--- a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
+++ b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
@@ -5,17 +5,17 @@
$id: http://devicetree.org/schemas/sound/ti,tas2781.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
-title: Texas Instruments TAS2781 SmartAMP
+title: Texas Instruments TAS2781/TAS2563 SmartAMP
maintainers:
- Shenghao Ding <shenghao-ding@ti.com>
description:
- The TAS2781 is a mono, digital input Class-D audio amplifier
- optimized for efficiently driving high peak power into small
- loudspeakers. An integrated on-chip DSP supports Texas Instruments
- Smart Amp speaker protection algorithm. The integrated speaker
- voltage and current sense provides for real time
+ The TAS2781/TAS2563 is a mono, digital input Class-D audio
+ amplifier optimized for efficiently driving high peak power into
+ small loudspeakers. An integrated on-chip DSP supports Texas
+ Instruments Smart Amp speaker protection algorithm. The
+ integrated speaker voltage and current sense provides for real time
monitoring of loudspeaker behavior.
allOf:
@@ -23,18 +23,28 @@ allOf:
properties:
compatible:
+ description: |
+ ti,tas2781: 24-V Class-D Amplifier with Real Time Integrated Speaker
+ Protection and Audio Processing, 16/20/24/32bit stereo I2S or
+ multichannel TDM.
+
+ ti,tas2563: 6.1-W Boosted Class-D Audio Amplifier With Integrated
+ DSP and IV Sense, 16/20/24/32bit stereo I2S or multichannel TDM.
enum:
- ti,tas2781
+ - ti,tas2563
reg:
description:
- I2C address, in multiple tas2781s case, all the i2c address
+ I2C address, in multiple AMP case, all the i2c address
aggregate as one Audio Device to support multiple audio slots.
+ - For tas2781, i2c address is from 0x38 to 0x3f.
+ - For tas2563, i2c address is from 0x4e to 0x4f.
maxItems: 8
minItems: 1
items:
minimum: 0x38
- maximum: 0x3f
+ maximum: 0x4f
reset-gpios:
maxItems: 1
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ASoC: dt-bindings: Add tas2563 into yaml
2023-12-10 23:47 [PATCH v2] ASoC: dt-bindings: Add tas2563 into yaml Shenghao Ding
@ 2023-12-11 11:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-11 11:06 UTC (permalink / raw)
To: Shenghao Ding, broonie, conor+dt
Cc: robh+dt, andriy.shevchenko, devicetree, lgirdwood, perex,
pierre-louis.bossart, 13916275206, linux-sound, linux-kernel,
liam.r.girdwood, soyer, tiwai, peeyush, navada
On 11/12/2023 00:47, Shenghao Ding wrote:
> Support tas2563.
>
> Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
>
> ---
> Change in v2:
> - Add devicetree list and other list of necessary people and lists to CC
> - Express Compatibility in the bindings
> - Drop driver changes
> ---
> .../devicetree/bindings/sound/ti,tas2781.yaml | 26 +++++++++++++------
> 1 file changed, 18 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> index a69e6c223308..c049fe6b2dad 100644
> --- a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> +++ b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> @@ -5,17 +5,17 @@
> $id: http://devicetree.org/schemas/sound/ti,tas2781.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: Texas Instruments TAS2781 SmartAMP
> +title: Texas Instruments TAS2781/TAS2563 SmartAMP
>
> maintainers:
> - Shenghao Ding <shenghao-ding@ti.com>
>
> description:
> - The TAS2781 is a mono, digital input Class-D audio amplifier
> - optimized for efficiently driving high peak power into small
> - loudspeakers. An integrated on-chip DSP supports Texas Instruments
> - Smart Amp speaker protection algorithm. The integrated speaker
> - voltage and current sense provides for real time
> + The TAS2781/TAS2563 is a mono, digital input Class-D audio
> + amplifier optimized for efficiently driving high peak power into
> + small loudspeakers. An integrated on-chip DSP supports Texas
> + Instruments Smart Amp speaker protection algorithm. The
> + integrated speaker voltage and current sense provides for real time
> monitoring of loudspeaker behavior.
>
> allOf:
> @@ -23,18 +23,28 @@ allOf:
>
> properties:
> compatible:
> + description: |
> + ti,tas2781: 24-V Class-D Amplifier with Real Time Integrated Speaker
> + Protection and Audio Processing, 16/20/24/32bit stereo I2S or
> + multichannel TDM.
> +
> + ti,tas2563: 6.1-W Boosted Class-D Audio Amplifier With Integrated
> + DSP and IV Sense, 16/20/24/32bit stereo I2S or multichannel TDM.
> enum:
> - ti,tas2781
> + - ti,tas2563
I don't think you tested your DTS. Where is the compatibility / fallback?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-11 11:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-10 23:47 [PATCH v2] ASoC: dt-bindings: Add tas2563 into yaml Shenghao Ding
2023-12-11 11:06 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).