From: Al Viro <viro@zeniv.linux.org.uk>
To: NeilBrown <neilb@suse.de>
Cc: Chuck Lever <chuck.lever@oracle.com>,
Christian Brauner <brauner@kernel.org>,
Jens Axboe <axboe@kernel.dk>, Oleg Nesterov <oleg@redhat.com>,
Jeff Layton <jlayton@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/3] nfsd: use __fput_sync() to avoid delayed closing of files.
Date: Mon, 11 Dec 2023 19:11:17 +0000 [thread overview]
Message-ID: <20231211191117.GD1674809@ZenIV> (raw)
In-Reply-To: <170224845504.12910.16483736613606611138@noble.neil.brown.name>
On Mon, Dec 11, 2023 at 09:47:35AM +1100, NeilBrown wrote:
> Similarly would could wrap __fput_sync() is a more friendly name, but
> that would be better if we actually renamed the function.
>
> void fput_now(struct file *f)
> {
> __fput_sync(f);
> }
It is unfriendly *precisely* because it should not be used without
a very good reason.
It may be the last opened file keeping a lazy-umounted mount alive.
It may be taking pretty much any locks, or eating a lot of stack
space.
It really isn't a general-purpose API; any "more friendly name"
is going to be NAKed for that reason alone.
Al, very much tempted to send a patch renaming that sucker to
__fput_dont_use_that_unless_you_really_know_what_you_are_doing().
next prev parent reply other threads:[~2023-12-11 19:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 3:27 [PATCH 0/3] nfsd: fully close all files in the nfsd threads NeilBrown
2023-12-08 3:27 ` [PATCH 1/3] nfsd: use __fput_sync() to avoid delayed closing of files NeilBrown
2023-12-08 15:01 ` Chuck Lever
2023-12-10 22:47 ` NeilBrown
2023-12-11 19:01 ` Chuck Lever
2023-12-11 22:04 ` NeilBrown
2023-12-12 16:17 ` Chuck Lever
2023-12-11 19:11 ` Al Viro [this message]
2023-12-11 22:23 ` NeilBrown
2023-12-11 23:13 ` Al Viro
2023-12-11 23:21 ` Al Viro
2023-12-13 0:28 ` NeilBrown
2023-12-15 18:27 ` David Laight
2023-12-15 19:35 ` Chuck Lever III
2023-12-15 22:36 ` NeilBrown
2023-12-15 18:28 ` David Laight
2023-12-16 1:50 ` Dave Chinner
2023-12-08 3:27 ` [PATCH 2/3] nfsd: Don't leave work of closing files to a work queue NeilBrown
2023-12-08 3:27 ` [PATCH 3/3] VFS: don't export flush_delayed_fput() NeilBrown
2023-12-08 11:40 ` [PATCH 0/3] nfsd: fully close all files in the nfsd threads Jeff Layton
2023-12-08 14:33 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231211191117.GD1674809@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).