[PATCH v2 0/2] hwrng: starfive: Add support for JH8100

[PATCH v2 0/2] hwrng: starfive: Add support for JH8100

[Jia Jie Ho]

This series adds driver support for StarFive JH8100 trng. It also
updates pm ops of the original driver.

v1->v2:
Dropped driver .compatible change, express new compatible string in
devicetree bindings instead. (Krzysztof)

Thanks,
Jia Jie

Jia Jie Ho (2):
  dt-bindings: rng: starfive: Add jh8100 compatible string
  hwrng: starfive - Add runtime pm ops

 .../devicetree/bindings/rng/starfive,jh7110-trng.yaml     | 6 +++++-
 drivers/char/hw_random/jh7110-trng.c                      | 8 ++++++--
 2 files changed, 11 insertions(+), 3 deletions(-)

-- 
2.34.1

[PATCH v2 1/2] dt-bindings: rng: starfive: Add jh8100 compatible string

[Jia Jie Ho]

Add compatible string for StarFive JH8100 trng.

Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
---
 .../devicetree/bindings/rng/starfive,jh7110-trng.yaml       | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
index 2b76ce25acc4..4639247e9e51 100644
--- a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
+++ b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
@@ -11,7 +11,11 @@ maintainers:
 
 properties:
   compatible:
-    const: starfive,jh7110-trng
+    oneOf:
+      - items:
+          - const: starfive,jh8100-trng
+          - const: starfive,jh7110-trng
+      - const: starfive,jh7110-trng
 
   reg:
     maxItems: 1
-- 
2.34.1

[PATCH v2 2/2] hwrng: starfive - Add runtime pm ops

[Jia Jie Ho]

Define SET_RUNTIME_PM_OPS for StarFive TRNG driver.

Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
---
 drivers/char/hw_random/jh7110-trng.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/char/hw_random/jh7110-trng.c b/drivers/char/hw_random/jh7110-trng.c
index 38474d48a25e..5053e6add877 100644
--- a/drivers/char/hw_random/jh7110-trng.c
+++ b/drivers/char/hw_random/jh7110-trng.c
@@ -369,8 +369,12 @@ static int __maybe_unused starfive_trng_resume(struct device *dev)
 	return 0;
 }
 
-static DEFINE_SIMPLE_DEV_PM_OPS(starfive_trng_pm_ops, starfive_trng_suspend,
-				starfive_trng_resume);
+static const struct dev_pm_ops starfive_trng_pm_ops = {
+	SET_SYSTEM_SLEEP_PM_OPS(starfive_trng_suspend,
+				starfive_trng_resume)
+	SET_RUNTIME_PM_OPS(starfive_trng_suspend,
+			   starfive_trng_resume, NULL)
+};
 
 static const struct of_device_id trng_dt_ids[] __maybe_unused = {
 	{ .compatible = "starfive,jh7110-trng" },
-- 
2.34.1

Re: [PATCH v2 1/2] dt-bindings: rng: starfive: Add jh8100 compatible string

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]

On Tue, Dec 12, 2023 at 11:25:26AM +0800, Jia Jie Ho wrote:
> Add compatible string for StarFive JH8100 trng.
> 
> Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> ---
>  .../devicetree/bindings/rng/starfive,jh7110-trng.yaml       | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> index 2b76ce25acc4..4639247e9e51 100644
> --- a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> +++ b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> @@ -11,7 +11,11 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: starfive,jh7110-trng
> +    oneOf:
> +      - items:
> +          - const: starfive,jh8100-trng
> +          - const: starfive,jh7110-trng
> +      - const: starfive,jh7110-trng
>  
>    reg:
>      maxItems: 1
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 0/2] hwrng: starfive: Add support for JH8100

[Herbert Xu]

On Tue, Dec 12, 2023 at 11:25:25AM +0800, Jia Jie Ho wrote:
> This series adds driver support for StarFive JH8100 trng. It also
> updates pm ops of the original driver.
> 
> v1->v2:
> Dropped driver .compatible change, express new compatible string in
> devicetree bindings instead. (Krzysztof)
> 
> Thanks,
> Jia Jie
> 
> Jia Jie Ho (2):
>   dt-bindings: rng: starfive: Add jh8100 compatible string
>   hwrng: starfive - Add runtime pm ops
> 
>  .../devicetree/bindings/rng/starfive,jh7110-trng.yaml     | 6 +++++-
>  drivers/char/hw_random/jh7110-trng.c                      | 8 ++++++--
>  2 files changed, 11 insertions(+), 3 deletions(-)
> 
> -- 
> 2.34.1

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt