linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* include/trace/events/nilfs2.h:191:1: sparse: sparse: cast to restricted blk_opf_t
@ 2024-01-09 14:16 kernel test robot
  0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2024-01-09 14:16 UTC (permalink / raw)
  To: Bart Van Assche; +Cc: oe-kbuild-all, linux-kernel, Jens Axboe, Ryusuke Konishi

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   9f8413c4a66f2fb776d3dc3c9ed20bf435eb305e
commit: ed4512590bd5839f8ea9eef1626b0f4db626b1d1 fs/nilfs2: Use the enum req_op and blk_opf_t types
date:   1 year, 6 months ago
config: x86_64-randconfig-121-20240107 (https://download.01.org/0day-ci/archive/20240109/202401092241.I4mm9OWl-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240109/202401092241.I4mm9OWl-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401092241.I4mm9OWl-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
   fs/nilfs2/segment.c: note: in included file (through include/trace/trace_events.h, include/trace/define_trace.h, include/trace/events/nilfs2.h):
>> include/trace/events/nilfs2.h:191:1: sparse: sparse: cast to restricted blk_opf_t
>> include/trace/events/nilfs2.h:191:1: sparse: sparse: cast to restricted blk_opf_t
>> include/trace/events/nilfs2.h:191:1: sparse: sparse: restricted blk_opf_t degrades to integer
>> include/trace/events/nilfs2.h:191:1: sparse: sparse: restricted blk_opf_t degrades to integer

vim +191 include/trace/events/nilfs2.h

a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  190  
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06 @191  TRACE_EVENT(nilfs2_mdt_submit_block,
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  192  	    TP_PROTO(struct inode *inode,
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  193  		     unsigned long ino,
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  194  		     unsigned long blkoff,
ed4512590bd5839 Bart Van Assche 2022-07-14  195  		     enum req_op mode),
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  196  
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  197  	    TP_ARGS(inode, ino, blkoff, mode),
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  198  
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  199  	    TP_STRUCT__entry(
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  200  		    __field(struct inode *, inode)
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  201  		    __field(unsigned long, ino)
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  202  		    __field(unsigned long, blkoff)
ed4512590bd5839 Bart Van Assche 2022-07-14  203  		    __field(enum req_op, mode)
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  204  	    ),
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  205  
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  206  	    TP_fast_assign(
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  207  		    __entry->inode = inode;
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  208  		    __entry->ino = ino;
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  209  		    __entry->blkoff = blkoff;
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  210  		    __entry->mode = mode;
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  211  		    ),
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  212  
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  213  	    TP_printk("inode = %p ino = %lu blkoff = %lu mode = %x",
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  214  		      __entry->inode,
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  215  		      __entry->ino,
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  216  		      __entry->blkoff,
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  217  		      __entry->mode)
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  218  );
a9cd207c23ca4fa Hitoshi Mitake  2015-11-06  219  

:::::: The code at line 191 was first introduced by commit
:::::: a9cd207c23ca4fa5bd5f1092e867e87542e349a3 nilfs2: add tracepoints for analyzing reading and writing metadata files

:::::: TO: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: include/trace/events/nilfs2.h:191:1: sparse: sparse: cast to restricted blk_opf_t
  2022-08-05  2:03 kernel test robot
@ 2022-08-05  3:07 ` Bart Van Assche
  0 siblings, 0 replies; 3+ messages in thread
From: Bart Van Assche @ 2022-08-05  3:07 UTC (permalink / raw)
  To: Luc Van Oostenryck, Linus Torvalds
  Cc: kernel test robot, kbuild-all, linux-kernel, Jens Axboe, Ryusuke Konishi

On 8/4/22 19:03, kernel test robot wrote:
> sparse warnings: (new ones prefixed by >>)
>     fs/nilfs2/segment.c: note: in included file (through include/trace/trace_events.h, include/trace/define_trace.h, include/trace/events/nilfs2.h):
>>> include/trace/events/nilfs2.h:191:1: sparse: sparse: cast to restricted blk_opf_t
>>> include/trace/events/nilfs2.h:191:1: sparse: sparse: cast to restricted blk_opf_t
>>> include/trace/events/nilfs2.h:191:1: sparse: sparse: restricted blk_opf_t degrades to integer
>>> include/trace/events/nilfs2.h:191:1: sparse: sparse: restricted blk_opf_t degrades to integer
> 
> vim +191 include/trace/events/nilfs2.h

Hi Luc and Linus,

I think the above sparse warnings refer to the following macro:

#define is_signed_type(type)	(((type)(-1)) < (type)1)

Is the current plan still to modify sparse such that it stops 
complaining about the above macro?

See also 
https://lore.kernel.org/linux-sparse/20220626095814.7wtma47w4sph7dha@mail/

Thanks,

Bart.

^ permalink raw reply	[flat|nested] 3+ messages in thread
* include/trace/events/nilfs2.h:191:1: sparse: sparse: cast to restricted blk_opf_t
@ 2022-08-05  2:03 kernel test robot
  2022-08-05  3:07 ` Bart Van Assche
  0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2022-08-05  2:03 UTC (permalink / raw)
  To: Bart Van Assche; +Cc: kbuild-all, linux-kernel, Jens Axboe, Ryusuke Konishi

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   c040862bfbd9c5f3cb64e1df1c623e20e38fe656
commit: ed4512590bd5839f8ea9eef1626b0f4db626b1d1 fs/nilfs2: Use the enum req_op and blk_opf_t types
date:   3 weeks ago
config: x86_64-randconfig-s023 (https://download.01.org/0day-ci/archive/20220805/202208051050.mUx9O9G8-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ed4512590bd5839f8ea9eef1626b0f4db626b1d1
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout ed4512590bd5839f8ea9eef1626b0f4db626b1d1
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/nilfs2/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
   fs/nilfs2/segment.c: note: in included file (through include/trace/trace_events.h, include/trace/define_trace.h, include/trace/events/nilfs2.h):
>> include/trace/events/nilfs2.h:191:1: sparse: sparse: cast to restricted blk_opf_t
>> include/trace/events/nilfs2.h:191:1: sparse: sparse: cast to restricted blk_opf_t
>> include/trace/events/nilfs2.h:191:1: sparse: sparse: restricted blk_opf_t degrades to integer
>> include/trace/events/nilfs2.h:191:1: sparse: sparse: restricted blk_opf_t degrades to integer

vim +191 include/trace/events/nilfs2.h

a9cd207c23ca4f Hitoshi Mitake  2015-11-06  190  
a9cd207c23ca4f Hitoshi Mitake  2015-11-06 @191  TRACE_EVENT(nilfs2_mdt_submit_block,
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  192  	    TP_PROTO(struct inode *inode,
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  193  		     unsigned long ino,
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  194  		     unsigned long blkoff,
ed4512590bd583 Bart Van Assche 2022-07-14  195  		     enum req_op mode),
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  196  
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  197  	    TP_ARGS(inode, ino, blkoff, mode),
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  198  
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  199  	    TP_STRUCT__entry(
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  200  		    __field(struct inode *, inode)
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  201  		    __field(unsigned long, ino)
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  202  		    __field(unsigned long, blkoff)
ed4512590bd583 Bart Van Assche 2022-07-14  203  		    __field(enum req_op, mode)
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  204  	    ),
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  205  
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  206  	    TP_fast_assign(
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  207  		    __entry->inode = inode;
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  208  		    __entry->ino = ino;
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  209  		    __entry->blkoff = blkoff;
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  210  		    __entry->mode = mode;
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  211  		    ),
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  212  
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  213  	    TP_printk("inode = %p ino = %lu blkoff = %lu mode = %x",
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  214  		      __entry->inode,
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  215  		      __entry->ino,
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  216  		      __entry->blkoff,
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  217  		      __entry->mode)
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  218  );
a9cd207c23ca4f Hitoshi Mitake  2015-11-06  219  

:::::: The code at line 191 was first introduced by commit
:::::: a9cd207c23ca4fa5bd5f1092e867e87542e349a3 nilfs2: add tracepoints for analyzing reading and writing metadata files

:::::: TO: Hitoshi Mitake <mitake.hitoshi@lab.ntt.co.jp>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-09 14:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-09 14:16 include/trace/events/nilfs2.h:191:1: sparse: sparse: cast to restricted blk_opf_t kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2022-08-05  2:03 kernel test robot
2022-08-05  3:07 ` Bart Van Assche

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).