* [PATCH] scsi: fnic: clean up some inconsistent indenting
@ 2024-01-18 2:01 Jiapeng Chong
2024-01-18 23:21 ` Karan Tilak Kumar (kartilak)
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jiapeng Chong @ 2024-01-18 2:01 UTC (permalink / raw)
To: satishkh
Cc: sebaddel, kartilak, jejb, martin.petersen, linux-scsi,
linux-kernel, Jiapeng Chong, Abaci Robot
No functional modification involved.
drivers/scsi/fnic/fnic_scsi.c:1964 fnic_abort_cmd() warn: inconsistent indenting.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7930
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/scsi/fnic/fnic_scsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
index 8d7fc5284293..5b4768e669f0 100644
--- a/drivers/scsi/fnic/fnic_scsi.c
+++ b/drivers/scsi/fnic/fnic_scsi.c
@@ -1961,8 +1961,8 @@ int fnic_abort_cmd(struct scsi_cmnd *sc)
if (!(fnic_priv(sc)->flags & (FNIC_IO_ABORTED | FNIC_IO_DONE))) {
spin_unlock_irqrestore(&fnic->wq_copy_lock[hwq], flags);
- FNIC_SCSI_DBG(KERN_ERR, fnic->lport->host, fnic->fnic_num,
- "Issuing host reset due to out of order IO\n");
+ FNIC_SCSI_DBG(KERN_ERR, fnic->lport->host, fnic->fnic_num,
+ "Issuing host reset due to out of order IO\n");
ret = FAILED;
goto fnic_abort_cmd_end;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] scsi: fnic: clean up some inconsistent indenting
2024-01-18 2:01 [PATCH] scsi: fnic: clean up some inconsistent indenting Jiapeng Chong
@ 2024-01-18 23:21 ` Karan Tilak Kumar (kartilak)
2024-01-24 2:47 ` Martin K. Petersen
2024-01-30 2:27 ` Martin K. Petersen
2 siblings, 0 replies; 6+ messages in thread
From: Karan Tilak Kumar (kartilak) @ 2024-01-18 23:21 UTC (permalink / raw)
To: Jiapeng Chong, Satish Kharat (satishkh)
Cc: Sesidhar Baddela (sebaddel),
jejb, martin.petersen, linux-scsi, linux-kernel, Abaci Robot
On Wednesday, January 17, 2024 6:01 PM, Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:
>
> No functional modification involved.
>
> drivers/scsi/fnic/fnic_scsi.c:1964 fnic_abort_cmd() warn: inconsistent indenting.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7930
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/scsi/fnic/fnic_scsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c index 8d7fc5284293..5b4768e669f0 100644
> --- a/drivers/scsi/fnic/fnic_scsi.c
> +++ b/drivers/scsi/fnic/fnic_scsi.c
> @@ -1961,8 +1961,8 @@ int fnic_abort_cmd(struct scsi_cmnd *sc)
>
> if (!(fnic_priv(sc)->flags & (FNIC_IO_ABORTED | FNIC_IO_DONE))) {
> spin_unlock_irqrestore(&fnic->wq_copy_lock[hwq], flags);
> - FNIC_SCSI_DBG(KERN_ERR, fnic->lport->host, fnic->fnic_num,
> - "Issuing host reset due to out of order IO\n");
> + FNIC_SCSI_DBG(KERN_ERR, fnic->lport->host, fnic->fnic_num,
> + "Issuing host reset due to out of order IO\n");
>
> ret = FAILED;
> goto fnic_abort_cmd_end;
> --
> 2.20.1.7.g153144c
>
Looks good to me.
Reviewed-by: Karan Tilak Kumar <kartilak@cisco.com>
Regards,
Karan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: fnic: clean up some inconsistent indenting
2024-01-18 2:01 [PATCH] scsi: fnic: clean up some inconsistent indenting Jiapeng Chong
2024-01-18 23:21 ` Karan Tilak Kumar (kartilak)
@ 2024-01-24 2:47 ` Martin K. Petersen
2024-01-30 2:27 ` Martin K. Petersen
2 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2024-01-24 2:47 UTC (permalink / raw)
To: Jiapeng Chong
Cc: satishkh, sebaddel, kartilak, jejb, martin.petersen, linux-scsi,
linux-kernel, Abaci Robot
Jiapeng,
> No functional modification involved.
>
> drivers/scsi/fnic/fnic_scsi.c:1964 fnic_abort_cmd() warn: inconsistent indenting.
Applied to 6.9/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: fnic: clean up some inconsistent indenting
2024-01-18 2:01 [PATCH] scsi: fnic: clean up some inconsistent indenting Jiapeng Chong
2024-01-18 23:21 ` Karan Tilak Kumar (kartilak)
2024-01-24 2:47 ` Martin K. Petersen
@ 2024-01-30 2:27 ` Martin K. Petersen
2 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2024-01-30 2:27 UTC (permalink / raw)
To: satishkh, Jiapeng Chong
Cc: Martin K . Petersen, sebaddel, kartilak, jejb, linux-scsi,
linux-kernel, Abaci Robot
On Thu, 18 Jan 2024 10:01:28 +0800, Jiapeng Chong wrote:
> No functional modification involved.
>
> drivers/scsi/fnic/fnic_scsi.c:1964 fnic_abort_cmd() warn: inconsistent indenting.
>
>
Applied to 6.9/scsi-queue, thanks!
[1/1] scsi: fnic: clean up some inconsistent indenting
https://git.kernel.org/mkp/scsi/c/f1aa6437733a
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: fnic: clean up some inconsistent indenting
2023-09-22 10:06 Jiapeng Chong
@ 2023-10-10 2:09 ` Martin K. Petersen
0 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2023-10-10 2:09 UTC (permalink / raw)
To: satishkh, Jiapeng Chong
Cc: Martin K . Petersen, sebaddel, kartilak, jejb, linux-scsi,
linux-kernel, Abaci Robot
On Fri, 22 Sep 2023 18:06:57 +0800, Jiapeng Chong wrote:
> No functional modification involved.
>
> drivers/scsi/fnic/fnic_fcs.c:152 fnic_handle_link() warn: inconsistent indenting.
>
>
Applied to 6.7/scsi-queue, thanks!
[1/1] scsi: fnic: clean up some inconsistent indenting
https://git.kernel.org/mkp/scsi/c/5ef104b749e8
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] scsi: fnic: clean up some inconsistent indenting
@ 2023-09-22 10:06 Jiapeng Chong
2023-10-10 2:09 ` Martin K. Petersen
0 siblings, 1 reply; 6+ messages in thread
From: Jiapeng Chong @ 2023-09-22 10:06 UTC (permalink / raw)
To: satishkh
Cc: sebaddel, kartilak, jejb, martin.petersen, linux-scsi,
linux-kernel, Jiapeng Chong, Abaci Robot
No functional modification involved.
drivers/scsi/fnic/fnic_fcs.c:152 fnic_handle_link() warn: inconsistent indenting.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6678
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/scsi/fnic/fnic_fcs.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/fnic/fnic_fcs.c b/drivers/scsi/fnic/fnic_fcs.c
index 79ddfaaf71a4..55632c67a8f2 100644
--- a/drivers/scsi/fnic/fnic_fcs.c
+++ b/drivers/scsi/fnic/fnic_fcs.c
@@ -145,16 +145,17 @@ void fnic_handle_link(struct work_struct *work)
spin_unlock_irqrestore(&fnic->fnic_lock, flags);
if (fnic->config.flags & VFCF_FIP_CAPABLE) {
/* start FCoE VLAN discovery */
- fnic_fc_trace_set_data(
- fnic->lport->host->host_no,
- FNIC_FC_LE, "Link Status: DOWN_UP_VLAN",
- strlen("Link Status: DOWN_UP_VLAN"));
+ fnic_fc_trace_set_data(fnic->lport->host->host_no,
+ FNIC_FC_LE, "Link Status: DOWN_UP_VLAN",
+ strlen("Link Status: DOWN_UP_VLAN"));
fnic_fcoe_send_vlan_req(fnic);
+
return;
}
+
FNIC_FCS_DBG(KERN_DEBUG, fnic->lport->host, "link up\n");
fnic_fc_trace_set_data(fnic->lport->host->host_no, FNIC_FC_LE,
- "Link Status: DOWN_UP", strlen("Link Status: DOWN_UP"));
+ "Link Status: DOWN_UP", strlen("Link Status: DOWN_UP"));
fcoe_ctlr_link_up(&fnic->ctlr);
} else {
/* UP -> DOWN */
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-01-30 2:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-18 2:01 [PATCH] scsi: fnic: clean up some inconsistent indenting Jiapeng Chong
2024-01-18 23:21 ` Karan Tilak Kumar (kartilak)
2024-01-24 2:47 ` Martin K. Petersen
2024-01-30 2:27 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2023-09-22 10:06 Jiapeng Chong
2023-10-10 2:09 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).