* [PATCH 1/3] dt-bindings: clock: gcc-msm8953: add reset for MDSS subsystem
2024-01-23 21:03 [PATCH 0/3] Add MDSS_BCR reset for MSM8953 Luca Weiss
@ 2024-01-23 21:03 ` Luca Weiss
2024-01-24 6:41 ` Krzysztof Kozlowski
2024-01-23 21:03 ` [PATCH 2/3] clk: qcom: gcc-msm8953: add MDSS_BCR reset Luca Weiss
2024-01-23 21:03 ` [PATCH 3/3] arm64: dts: qcom: msm8953: add reset for display subsystem Luca Weiss
2 siblings, 1 reply; 8+ messages in thread
From: Luca Weiss @ 2024-01-23 21:03 UTC (permalink / raw)
To: ~postmarketos/upstreaming, phone-devel, Bjorn Andersson,
Konrad Dybcio, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, linux-clk, devicetree, linux-kernel, Luca Weiss,
Vladimir Lypak
From: Vladimir Lypak <vladimir.lypak@gmail.com>
Add a new define for the GCC_MDSS_BCR found on MSM8953.
Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
[luca: expand commit message]
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
include/dt-bindings/clock/qcom,gcc-msm8953.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/dt-bindings/clock/qcom,gcc-msm8953.h b/include/dt-bindings/clock/qcom,gcc-msm8953.h
index 783162da6148..28090f9d7f24 100644
--- a/include/dt-bindings/clock/qcom,gcc-msm8953.h
+++ b/include/dt-bindings/clock/qcom,gcc-msm8953.h
@@ -218,6 +218,7 @@
#define GCC_USB3PHY_PHY_BCR 3
#define GCC_USB3_PHY_BCR 4
#define GCC_USB_30_BCR 5
+#define GCC_MDSS_BCR 6
/* GDSCs */
#define CPP_GDSC 0
--
2.43.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] dt-bindings: clock: gcc-msm8953: add reset for MDSS subsystem
2024-01-23 21:03 ` [PATCH 1/3] dt-bindings: clock: gcc-msm8953: add reset for MDSS subsystem Luca Weiss
@ 2024-01-24 6:41 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-24 6:41 UTC (permalink / raw)
To: Luca Weiss, ~postmarketos/upstreaming, phone-devel,
Bjorn Andersson, Konrad Dybcio, Michael Turquette, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, linux-clk, devicetree, linux-kernel, Vladimir Lypak
On 23/01/2024 22:03, Luca Weiss wrote:
> From: Vladimir Lypak <vladimir.lypak@gmail.com>
>
> Add a new define for the GCC_MDSS_BCR found on MSM8953.
>
> Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
> [luca: expand commit message]
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/3] clk: qcom: gcc-msm8953: add MDSS_BCR reset
2024-01-23 21:03 [PATCH 0/3] Add MDSS_BCR reset for MSM8953 Luca Weiss
2024-01-23 21:03 ` [PATCH 1/3] dt-bindings: clock: gcc-msm8953: add reset for MDSS subsystem Luca Weiss
@ 2024-01-23 21:03 ` Luca Weiss
2024-01-24 12:10 ` Konrad Dybcio
2024-01-23 21:03 ` [PATCH 3/3] arm64: dts: qcom: msm8953: add reset for display subsystem Luca Weiss
2 siblings, 1 reply; 8+ messages in thread
From: Luca Weiss @ 2024-01-23 21:03 UTC (permalink / raw)
To: ~postmarketos/upstreaming, phone-devel, Bjorn Andersson,
Konrad Dybcio, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, linux-clk, devicetree, linux-kernel, Luca Weiss,
Vladimir Lypak
From: Vladimir Lypak <vladimir.lypak@gmail.com>
Add an entry in the gcc driver for the MDSS_BCR reset found on MSM8953.
Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
[luca: expand commit message, move entry]
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
drivers/clk/qcom/gcc-msm8953.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/qcom/gcc-msm8953.c b/drivers/clk/qcom/gcc-msm8953.c
index 3e5a8cb14d4d..5725857faae6 100644
--- a/drivers/clk/qcom/gcc-msm8953.c
+++ b/drivers/clk/qcom/gcc-msm8953.c
@@ -4171,6 +4171,7 @@ static const struct qcom_reset_map gcc_msm8953_resets[] = {
[GCC_USB3PHY_PHY_BCR] = { 0x3f03c },
[GCC_USB3_PHY_BCR] = { 0x3f034 },
[GCC_USB_30_BCR] = { 0x3f070 },
+ [GCC_MDSS_BCR] = { 0x4d074 },
};
static const struct regmap_config gcc_msm8953_regmap_config = {
--
2.43.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 2/3] clk: qcom: gcc-msm8953: add MDSS_BCR reset
2024-01-23 21:03 ` [PATCH 2/3] clk: qcom: gcc-msm8953: add MDSS_BCR reset Luca Weiss
@ 2024-01-24 12:10 ` Konrad Dybcio
2024-01-25 21:25 ` Luca Weiss
0 siblings, 1 reply; 8+ messages in thread
From: Konrad Dybcio @ 2024-01-24 12:10 UTC (permalink / raw)
To: Luca Weiss, ~postmarketos/upstreaming, phone-devel,
Bjorn Andersson, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, linux-clk, devicetree, linux-kernel, Vladimir Lypak
On 1/23/24 22:03, Luca Weiss wrote:
> From: Vladimir Lypak <vladimir.lypak@gmail.com>
>
> Add an entry in the gcc driver for the MDSS_BCR reset found on MSM8953.
>
> Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
> [luca: expand commit message, move entry]
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
I found some more definitions in lk2nd
88:#define GCC_CRYPTO_BCR (CLK_CTL_BASE + 0x16000)
106:#define SDCC1_BCR (CLK_CTL_BASE + 0x42000) /* block reset*/
125:#define SDCC2_BCR (CLK_CTL_BASE + 0x43000) /* block reset */
150:#define USB_HS_BCR (CLK_CTL_BASE + 0x41000)
155:#define GCC_QUSB2_PHY_BCR (CLK_CTL_BASE + 0x4103C)
168:#define USB_30_BCR (CLK_CTL_BASE + 0x3F070)
189:#define USB3_PHY_BCR (CLK_CTL_BASE + 0x3F034)
190:#define USB3PHY_PHY_BCR (CLK_CTL_BASE + 0x3F03C)
Couldn't find this one though, did you confirm that MDSS goes off
when you assert it?
Konrad
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] clk: qcom: gcc-msm8953: add MDSS_BCR reset
2024-01-24 12:10 ` Konrad Dybcio
@ 2024-01-25 21:25 ` Luca Weiss
0 siblings, 0 replies; 8+ messages in thread
From: Luca Weiss @ 2024-01-25 21:25 UTC (permalink / raw)
To: ~postmarketos/upstreaming, phone-devel, Bjorn Andersson,
Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Konrad Dybcio
Cc: linux-arm-msm, linux-clk, devicetree, linux-kernel, Vladimir Lypak
On Mittwoch, 24. Jänner 2024 13:10:53 CET Konrad Dybcio wrote:
> On 1/23/24 22:03, Luca Weiss wrote:
> > From: Vladimir Lypak <vladimir.lypak@gmail.com>
> >
> > Add an entry in the gcc driver for the MDSS_BCR reset found on MSM8953.
> >
> > Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
> > [luca: expand commit message, move entry]
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > ---
>
> I found some more definitions in lk2nd
>
> 88:#define GCC_CRYPTO_BCR (CLK_CTL_BASE + 0x16000)
> 106:#define SDCC1_BCR (CLK_CTL_BASE + 0x42000) /*
> block reset*/ 125:#define SDCC2_BCR (CLK_CTL_BASE
> + 0x43000) /* block reset */ 150:#define USB_HS_BCR
> (CLK_CTL_BASE + 0x41000) 155:#define GCC_QUSB2_PHY_BCR
> (CLK_CTL_BASE + 0x4103C) 168:#define USB_30_BCR
> (CLK_CTL_BASE + 0x3F070)
> 189:#define USB3_PHY_BCR (CLK_CTL_BASE + 0x3F034)
> 190:#define USB3PHY_PHY_BCR (CLK_CTL_BASE + 0x3F03C)
>
> Couldn't find this one though, did you confirm that MDSS goes off
> when you assert it?
That one's defined here:
https://gerrit-public.fairphone.software/plugins/gitiles/kernel/msm-4.9/+/refs/heads/int/13/fp3/arch/arm64/boot/dts/qcom/msm8953-mdss-pll.dtsi#21
I'll add some of the others in v2.
>
> Konrad
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 3/3] arm64: dts: qcom: msm8953: add reset for display subsystem
2024-01-23 21:03 [PATCH 0/3] Add MDSS_BCR reset for MSM8953 Luca Weiss
2024-01-23 21:03 ` [PATCH 1/3] dt-bindings: clock: gcc-msm8953: add reset for MDSS subsystem Luca Weiss
2024-01-23 21:03 ` [PATCH 2/3] clk: qcom: gcc-msm8953: add MDSS_BCR reset Luca Weiss
@ 2024-01-23 21:03 ` Luca Weiss
2024-01-24 12:32 ` Konrad Dybcio
2 siblings, 1 reply; 8+ messages in thread
From: Luca Weiss @ 2024-01-23 21:03 UTC (permalink / raw)
To: ~postmarketos/upstreaming, phone-devel, Bjorn Andersson,
Konrad Dybcio, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, linux-clk, devicetree, linux-kernel, Luca Weiss,
Vladimir Lypak
From: Vladimir Lypak <vladimir.lypak@gmail.com>
With this reset we can avoid situations like IRQ storms from DSI host
before it even started probing (because boot-loader left DSI IRQs on).
Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
arch/arm64/boot/dts/qcom/msm8953.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi b/arch/arm64/boot/dts/qcom/msm8953.dtsi
index ad2f8cf9c966..dcb5c98b793c 100644
--- a/arch/arm64/boot/dts/qcom/msm8953.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi
@@ -859,6 +859,8 @@ mdss: display-subsystem@1a00000 {
"vsync",
"core";
+ resets = <&gcc GCC_MDSS_BCR>;
+
#address-cells = <1>;
#size-cells = <1>;
ranges;
--
2.43.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 3/3] arm64: dts: qcom: msm8953: add reset for display subsystem
2024-01-23 21:03 ` [PATCH 3/3] arm64: dts: qcom: msm8953: add reset for display subsystem Luca Weiss
@ 2024-01-24 12:32 ` Konrad Dybcio
0 siblings, 0 replies; 8+ messages in thread
From: Konrad Dybcio @ 2024-01-24 12:32 UTC (permalink / raw)
To: Luca Weiss, ~postmarketos/upstreaming, phone-devel,
Bjorn Andersson, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, linux-clk, devicetree, linux-kernel, Vladimir Lypak
On 1/23/24 22:03, Luca Weiss wrote:
> From: Vladimir Lypak <vladimir.lypak@gmail.com>
>
> With this reset we can avoid situations like IRQ storms from DSI host
> before it even started probing (because boot-loader left DSI IRQs on).
>
> Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 8+ messages in thread