* [PATCH v3] dt-bindings: PCI: ti,j721e-pci-host: Add support for J722S SoC
@ 2024-01-24 12:29 Siddharth Vadapalli
2024-01-24 16:10 ` Conor Dooley
0 siblings, 1 reply; 3+ messages in thread
From: Siddharth Vadapalli @ 2024-01-24 12:29 UTC (permalink / raw)
To: bhelgaas, lpieralisi, kw, robh, krzysztof.kozlowski+dt, conor+dt
Cc: linux-pci, devicetree, linux-kernel, linux-arm-kernel, vigneshr,
afd, srk, s-vadapalli
TI's J722S SoC has one instance of a Gen3 Single-Lane PCIe controller.
The controller on J722S SoC is similar to the one present on TI's AM64
SoC, with the difference being that the controller on AM64 SoC supports
up to Gen2 link speed while the one on J722S SoC supports Gen3 link speed.
Update the bindings with a new compatible for J722S SoC.
Technical Reference Manual of J722S SoC: https://www.ti.com/lit/zip/sprujb3
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
---
Hello,
This patch is based on linux-next tagged next-20240124.
v2:
https://lore.kernel.org/r/20240122064457.664542-1-s-vadapalli@ti.com/
Changes since v2:
- Added fallback compatible for "ti,j722s-pcie-host" as
"ti,j721e-pcie-host" based on Conor's suggestion at:
https://lore.kernel.org/r/20240122-getting-drippy-bb22a0634092@spud/#t
v1:
https://lore.kernel.org/r/20240117102526.557006-1-s-vadapalli@ti.com/
Changes since v1:
- Dropped patches 1/3 and 2/3 of the v1 series as discussed in the v1
thread.
- Updated patch 3/3 which is the v1 for this patch by dropping the checks
for the "num-lanes" property and "max-link-speed" property since the PCI
driver already validates the "num-lanes" property.
Regards,
Siddharth.
Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
index b7a534cef24d..ac69deeaf1ee 100644
--- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
@@ -23,6 +23,10 @@ properties:
items:
- const: ti,j7200-pcie-host
- const: ti,j721e-pcie-host
+ - description: PCIe controller in J722S
+ items:
+ - const: ti,j722s-pcie-host
+ - const: ti,j721e-pcie-host
reg:
maxItems: 4
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] dt-bindings: PCI: ti,j721e-pci-host: Add support for J722S SoC
2024-01-24 12:29 [PATCH v3] dt-bindings: PCI: ti,j721e-pci-host: Add support for J722S SoC Siddharth Vadapalli
@ 2024-01-24 16:10 ` Conor Dooley
2024-02-13 6:13 ` Siddharth Vadapalli
0 siblings, 1 reply; 3+ messages in thread
From: Conor Dooley @ 2024-01-24 16:10 UTC (permalink / raw)
To: Siddharth Vadapalli
Cc: bhelgaas, lpieralisi, kw, robh, krzysztof.kozlowski+dt, conor+dt,
linux-pci, devicetree, linux-kernel, linux-arm-kernel, vigneshr,
afd, srk
[-- Attachment #1: Type: text/plain, Size: 2259 bytes --]
On Wed, Jan 24, 2024 at 05:59:36PM +0530, Siddharth Vadapalli wrote:
> TI's J722S SoC has one instance of a Gen3 Single-Lane PCIe controller.
> The controller on J722S SoC is similar to the one present on TI's AM64
> SoC, with the difference being that the controller on AM64 SoC supports
> up to Gen2 link speed while the one on J722S SoC supports Gen3 link speed.
>
> Update the bindings with a new compatible for J722S SoC.
>
> Technical Reference Manual of J722S SoC: https://www.ti.com/lit/zip/sprujb3
>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
> ---
>
> Hello,
>
> This patch is based on linux-next tagged next-20240124.
>
> v2:
> https://lore.kernel.org/r/20240122064457.664542-1-s-vadapalli@ti.com/
> Changes since v2:
> - Added fallback compatible for "ti,j722s-pcie-host" as
> "ti,j721e-pcie-host" based on Conor's suggestion at:
> https://lore.kernel.org/r/20240122-getting-drippy-bb22a0634092@spud/#t
>
> v1:
> https://lore.kernel.org/r/20240117102526.557006-1-s-vadapalli@ti.com/
> Changes since v1:
> - Dropped patches 1/3 and 2/3 of the v1 series as discussed in the v1
> thread.
> - Updated patch 3/3 which is the v1 for this patch by dropping the checks
> for the "num-lanes" property and "max-link-speed" property since the PCI
> driver already validates the "num-lanes" property.
>
> Regards,
> Siddharth.
>
> Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> index b7a534cef24d..ac69deeaf1ee 100644
> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> @@ -23,6 +23,10 @@ properties:
> items:
> - const: ti,j7200-pcie-host
> - const: ti,j721e-pcie-host
> + - description: PCIe controller in J722S
> + items:
> + - const: ti,j722s-pcie-host
> + - const: ti,j721e-pcie-host
>
> reg:
> maxItems: 4
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] dt-bindings: PCI: ti,j721e-pci-host: Add support for J722S SoC
2024-01-24 16:10 ` Conor Dooley
@ 2024-02-13 6:13 ` Siddharth Vadapalli
0 siblings, 0 replies; 3+ messages in thread
From: Siddharth Vadapalli @ 2024-02-13 6:13 UTC (permalink / raw)
To: bhelgaas, lpieralisi, kw, robh, Conor Dooley
Cc: krzysztof.kozlowski+dt, conor+dt, linux-pci, devicetree,
linux-kernel, linux-arm-kernel, vigneshr, afd, srk, s-vadapalli
On 24/01/24 21:40, Conor Dooley wrote:
> On Wed, Jan 24, 2024 at 05:59:36PM +0530, Siddharth Vadapalli wrote:
>> TI's J722S SoC has one instance of a Gen3 Single-Lane PCIe controller.
>> The controller on J722S SoC is similar to the one present on TI's AM64
>> SoC, with the difference being that the controller on AM64 SoC supports
>> up to Gen2 link speed while the one on J722S SoC supports Gen3 link speed.
>>
>> Update the bindings with a new compatible for J722S SoC.
>>
>> Technical Reference Manual of J722S SoC: https://www.ti.com/lit/zip/sprujb3
>>
>> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
Bjorn, Rob,
Could you please merge this patch? This patch applies cleanly on the latest
linux-next tagged next-20240213.
>
> Cheers,
> Conor.
>
>> ---
>>
>> Hello,
>>
>> This patch is based on linux-next tagged next-20240124.
>>
>> v2:
>> https://lore.kernel.org/r/20240122064457.664542-1-s-vadapalli@ti.com/
>> Changes since v2:
>> - Added fallback compatible for "ti,j722s-pcie-host" as
>> "ti,j721e-pcie-host" based on Conor's suggestion at:
>> https://lore.kernel.org/r/20240122-getting-drippy-bb22a0634092@spud/#t
>>
>> v1:
>> https://lore.kernel.org/r/20240117102526.557006-1-s-vadapalli@ti.com/
>> Changes since v1:
>> - Dropped patches 1/3 and 2/3 of the v1 series as discussed in the v1
>> thread.
>> - Updated patch 3/3 which is the v1 for this patch by dropping the checks
>> for the "num-lanes" property and "max-link-speed" property since the PCI
>> driver already validates the "num-lanes" property.
>>
>> Regards,
>> Siddharth.
>>
>> Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
>> index b7a534cef24d..ac69deeaf1ee 100644
>> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
>> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
>> @@ -23,6 +23,10 @@ properties:
>> items:
>> - const: ti,j7200-pcie-host
>> - const: ti,j721e-pcie-host
>> + - description: PCIe controller in J722S
>> + items:
>> + - const: ti,j722s-pcie-host
>> + - const: ti,j721e-pcie-host
>>
>> reg:
>> maxItems: 4
>> --
>> 2.34.1
>>
--
Regards,
Siddharth.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-13 6:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-24 12:29 [PATCH v3] dt-bindings: PCI: ti,j721e-pci-host: Add support for J722S SoC Siddharth Vadapalli
2024-01-24 16:10 ` Conor Dooley
2024-02-13 6:13 ` Siddharth Vadapalli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).