* [PATCH net 00/10] Fix MODULE_DESCRIPTION() for net (p3)
@ 2024-01-25 19:34 Breno Leitao
2024-01-25 19:34 ` [PATCH net 01/10] net: fill in MODULE_DESCRIPTION()s for encx24j600 Breno Leitao
` (10 more replies)
0 siblings, 11 replies; 23+ messages in thread
From: Breno Leitao @ 2024-01-25 19:34 UTC (permalink / raw)
To: kuba, davem, pabeni, edumazet; +Cc: dsahern, weiwan, netdev, linux-kernel
There are hundreds of network modules that misses MODULE_DESCRIPTION(),
causing a warning when compiling with W=1. Example:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/com90io.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/arc-rimi.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/com20020.o
This part3 of the patchset focus on the missing ethernet drivers, which
is now warning free. This also fixes net/pcs and ieee802154.
Breno Leitao (10):
net: fill in MODULE_DESCRIPTION()s for encx24j600
net: fill in MODULE_DESCRIPTION()s for ocelot
net: fill in MODULE_DESCRIPTION()s for SMSC drivers
net: fill in MODULE_DESCRIPTION()s for Qualcom drivers
net: fill in MODULE_DESCRIPTION()s for dwmac-socfpga
net: fill in MODULE_DESCRIPTION()s for cpsw-common
net: fill in MODULE_DESCRIPTION()s for ec_bhf
net: fill in MODULE_DESCRIPTION()s for PCS drivers
net: fill in MODULE_DESCRIPTION()s for ieee802154
net: fill in MODULE_DESCRIPTION()s for arcnet
drivers/net/arcnet/arcnet.c | 1 +
drivers/net/ethernet/ec_bhf.c | 1 +
drivers/net/ethernet/microchip/encx24j600-regmap.c | 1 +
drivers/net/ethernet/mscc/ocelot.c | 1 +
drivers/net/ethernet/qualcomm/emac/emac.c | 1 +
drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 1 +
drivers/net/ethernet/smsc/smc91x.c | 1 +
drivers/net/ethernet/smsc/smsc911x.c | 1 +
drivers/net/ethernet/smsc/smsc9420.c | 1 +
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 1 +
drivers/net/ethernet/ti/cpsw-common.c | 1 +
drivers/net/pcs/pcs-lynx.c | 1 +
drivers/net/pcs/pcs-mtk-lynxi.c | 1 +
drivers/net/pcs/pcs-xpcs.c | 1 +
net/ieee802154/6lowpan/core.c | 1 +
net/ieee802154/socket.c | 1 +
16 files changed, 16 insertions(+)
--
2.39.3
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH net 01/10] net: fill in MODULE_DESCRIPTION()s for encx24j600
2024-01-25 19:34 [PATCH net 00/10] Fix MODULE_DESCRIPTION() for net (p3) Breno Leitao
@ 2024-01-25 19:34 ` Breno Leitao
2024-01-30 12:54 ` Simon Horman
2024-01-25 19:34 ` [PATCH net 02/10] net: fill in MODULE_DESCRIPTION()s for ocelot Breno Leitao
` (9 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Breno Leitao @ 2024-01-25 19:34 UTC (permalink / raw)
To: kuba, davem, pabeni, edumazet; +Cc: dsahern, weiwan, netdev, linux-kernel
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the Microchip ENCX24J600 helpers driver.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
drivers/net/ethernet/microchip/encx24j600-regmap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/microchip/encx24j600-regmap.c b/drivers/net/ethernet/microchip/encx24j600-regmap.c
index 5693784eec5b..2e0fe16a4082 100644
--- a/drivers/net/ethernet/microchip/encx24j600-regmap.c
+++ b/drivers/net/ethernet/microchip/encx24j600-regmap.c
@@ -513,4 +513,5 @@ int devm_regmap_init_encx24j600(struct device *dev,
}
EXPORT_SYMBOL_GPL(devm_regmap_init_encx24j600);
+MODULE_DESCRIPTION("Microchip ENCX24J600 helpers");
MODULE_LICENSE("GPL");
--
2.39.3
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH net 02/10] net: fill in MODULE_DESCRIPTION()s for ocelot
2024-01-25 19:34 [PATCH net 00/10] Fix MODULE_DESCRIPTION() for net (p3) Breno Leitao
2024-01-25 19:34 ` [PATCH net 01/10] net: fill in MODULE_DESCRIPTION()s for encx24j600 Breno Leitao
@ 2024-01-25 19:34 ` Breno Leitao
2024-01-30 10:11 ` Simon Horman
2024-01-25 19:34 ` [PATCH net 03/10] net: fill in MODULE_DESCRIPTION()s for SMSC drivers Breno Leitao
` (8 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Breno Leitao @ 2024-01-25 19:34 UTC (permalink / raw)
To: kuba, davem, pabeni, edumazet, Vladimir Oltean, Claudiu Manoil,
Alexandre Belloni, UNGLinuxDriver
Cc: dsahern, weiwan, netdev, linux-kernel, Horatiu Vultur
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the Ocelot SoCs (VSC7514) helpers driver.
Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
---
drivers/net/ethernet/mscc/ocelot.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
index 56ccbd4c37fe..2194f2a7ab27 100644
--- a/drivers/net/ethernet/mscc/ocelot.c
+++ b/drivers/net/ethernet/mscc/ocelot.c
@@ -3078,4 +3078,5 @@ void ocelot_deinit_port(struct ocelot *ocelot, int port)
}
EXPORT_SYMBOL(ocelot_deinit_port);
+MODULE_DESCRIPTION("Microsemi Ocelot (VSC7514) Switch driver");
MODULE_LICENSE("Dual MIT/GPL");
--
2.39.3
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH net 03/10] net: fill in MODULE_DESCRIPTION()s for SMSC drivers
2024-01-25 19:34 [PATCH net 00/10] Fix MODULE_DESCRIPTION() for net (p3) Breno Leitao
2024-01-25 19:34 ` [PATCH net 01/10] net: fill in MODULE_DESCRIPTION()s for encx24j600 Breno Leitao
2024-01-25 19:34 ` [PATCH net 02/10] net: fill in MODULE_DESCRIPTION()s for ocelot Breno Leitao
@ 2024-01-25 19:34 ` Breno Leitao
2024-01-30 12:55 ` Simon Horman
2024-01-25 19:34 ` [PATCH net 04/10] net: fill in MODULE_DESCRIPTION()s for Qualcom drivers Breno Leitao
` (7 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Breno Leitao @ 2024-01-25 19:34 UTC (permalink / raw)
To: kuba, davem, pabeni, edumazet, Nicolas Pitre, Steve Glendinning
Cc: dsahern, weiwan, netdev, linux-kernel, Andy Shevchenko,
Uwe Kleine-König
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the SMSC 91x/911x/9420 Ethernet drivers.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
drivers/net/ethernet/smsc/smc91x.c | 1 +
drivers/net/ethernet/smsc/smsc911x.c | 1 +
drivers/net/ethernet/smsc/smsc9420.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
index 758347616535..78ff3af7911a 100644
--- a/drivers/net/ethernet/smsc/smc91x.c
+++ b/drivers/net/ethernet/smsc/smc91x.c
@@ -98,6 +98,7 @@ static int watchdog = 1000;
module_param(watchdog, int, 0400);
MODULE_PARM_DESC(watchdog, "transmit timeout in milliseconds");
+MODULE_DESCRIPTION("SMC 91C9x/91C1xxx Ethernet driver");
MODULE_LICENSE("GPL");
MODULE_ALIAS("platform:smc91x");
diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index 31cb7d0166f0..74f1ccc96459 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -56,6 +56,7 @@
#define SMSC_MDIONAME "smsc911x-mdio"
#define SMSC_DRV_VERSION "2008-10-21"
+MODULE_DESCRIPTION("SMSC LAN911x/LAN921x Ethernet driver");
MODULE_LICENSE("GPL");
MODULE_VERSION(SMSC_DRV_VERSION);
MODULE_ALIAS("platform:smsc911x");
diff --git a/drivers/net/ethernet/smsc/smsc9420.c b/drivers/net/ethernet/smsc/smsc9420.c
index e1c4a11c1f18..15cb96c2506d 100644
--- a/drivers/net/ethernet/smsc/smsc9420.c
+++ b/drivers/net/ethernet/smsc/smsc9420.c
@@ -26,6 +26,7 @@
#define DRV_DESCRIPTION "SMSC LAN9420 driver"
#define DRV_VERSION "1.01"
+MODULE_DESCRIPTION("SMSC LAN9420 Ethernet driver");
MODULE_LICENSE("GPL");
MODULE_VERSION(DRV_VERSION);
--
2.39.3
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH net 04/10] net: fill in MODULE_DESCRIPTION()s for Qualcom drivers
2024-01-25 19:34 [PATCH net 00/10] Fix MODULE_DESCRIPTION() for net (p3) Breno Leitao
` (2 preceding siblings ...)
2024-01-25 19:34 ` [PATCH net 03/10] net: fill in MODULE_DESCRIPTION()s for SMSC drivers Breno Leitao
@ 2024-01-25 19:34 ` Breno Leitao
2024-01-30 12:56 ` Simon Horman
2024-01-25 19:34 ` [PATCH net 05/10] net: fill in MODULE_DESCRIPTION()s for dwmac-socfpga Breno Leitao
` (6 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Breno Leitao @ 2024-01-25 19:34 UTC (permalink / raw)
To: kuba, davem, pabeni, edumazet, Timur Tabi,
Subash Abhinov Kasiviswanathan, Sean Tranchetti
Cc: dsahern, weiwan, netdev, linux-kernel
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the Qualcom rmnet and emac drivers.
Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Subash Abhinov Kasiviswanathan <quic_subashab@quicinc.com>
---
drivers/net/ethernet/qualcomm/emac/emac.c | 1 +
drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/qualcomm/emac/emac.c b/drivers/net/ethernet/qualcomm/emac/emac.c
index 3270df72541b..4c06f55878de 100644
--- a/drivers/net/ethernet/qualcomm/emac/emac.c
+++ b/drivers/net/ethernet/qualcomm/emac/emac.c
@@ -771,5 +771,6 @@ static struct platform_driver emac_platform_driver = {
module_platform_driver(emac_platform_driver);
+MODULE_DESCRIPTION("Qualcomm EMAC Gigabit Ethernet driver");
MODULE_LICENSE("GPL v2");
MODULE_ALIAS("platform:qcom-emac");
diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
index 5b69b9268c75..f3bea196a8f9 100644
--- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
+++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
@@ -520,4 +520,5 @@ static void __exit rmnet_exit(void)
module_init(rmnet_init)
module_exit(rmnet_exit)
MODULE_ALIAS_RTNL_LINK("rmnet");
+MODULE_DESCRIPTION("Qualcomm RmNet MAP driver");
MODULE_LICENSE("GPL v2");
--
2.39.3
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH net 05/10] net: fill in MODULE_DESCRIPTION()s for dwmac-socfpga
2024-01-25 19:34 [PATCH net 00/10] Fix MODULE_DESCRIPTION() for net (p3) Breno Leitao
` (3 preceding siblings ...)
2024-01-25 19:34 ` [PATCH net 04/10] net: fill in MODULE_DESCRIPTION()s for Qualcom drivers Breno Leitao
@ 2024-01-25 19:34 ` Breno Leitao
2024-01-30 12:56 ` Simon Horman
2024-01-25 19:34 ` [PATCH net 06/10] net: fill in MODULE_DESCRIPTION()s for cpsw-common Breno Leitao
` (5 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Breno Leitao @ 2024-01-25 19:34 UTC (permalink / raw)
To: kuba, davem, pabeni, edumazet, Alexandre Torgue, Jose Abreu,
Maxime Coquelin
Cc: dsahern, weiwan, netdev, linux-kernel,
moderated list:ARM/STM32 ARCHITECTURE,
moderated list:ARM/STM32 ARCHITECTURE
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the STMicro DWMAC for Altera SOCs.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
index ba2ce776bd4d..68f85e4605cb 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
@@ -585,4 +585,5 @@ static struct platform_driver socfpga_dwmac_driver = {
};
module_platform_driver(socfpga_dwmac_driver);
+MODULE_DESCRIPTION("Altera SOC DWMAC Specific Glue layer");
MODULE_LICENSE("GPL v2");
--
2.39.3
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH net 06/10] net: fill in MODULE_DESCRIPTION()s for cpsw-common
2024-01-25 19:34 [PATCH net 00/10] Fix MODULE_DESCRIPTION() for net (p3) Breno Leitao
` (4 preceding siblings ...)
2024-01-25 19:34 ` [PATCH net 05/10] net: fill in MODULE_DESCRIPTION()s for dwmac-socfpga Breno Leitao
@ 2024-01-25 19:34 ` Breno Leitao
2024-01-30 12:57 ` Simon Horman
2024-01-25 19:34 ` [PATCH net 07/10] net: fill in MODULE_DESCRIPTION()s for ec_bhf Breno Leitao
` (4 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Breno Leitao @ 2024-01-25 19:34 UTC (permalink / raw)
To: kuba, davem, pabeni, edumazet, Siddharth Vadapalli,
Ravi Gunasekaran, Roger Quadros
Cc: dsahern, weiwan, netdev, linux-kernel, Bhupesh Sharma,
Alex Elder, Rob Herring,
open list:TI ETHERNET SWITCH DRIVER (CPSW)
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the TI CPSW switch module.
Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
---
drivers/net/ethernet/ti/cpsw-common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/ti/cpsw-common.c b/drivers/net/ethernet/ti/cpsw-common.c
index 26dc906eae90..57fe936bb177 100644
--- a/drivers/net/ethernet/ti/cpsw-common.c
+++ b/drivers/net/ethernet/ti/cpsw-common.c
@@ -90,4 +90,5 @@ int ti_cm_get_macid(struct device *dev, int slave, u8 *mac_addr)
}
EXPORT_SYMBOL_GPL(ti_cm_get_macid);
+MODULE_DESCRIPTION("TI CPSW Switch common module");
MODULE_LICENSE("GPL");
--
2.39.3
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH net 07/10] net: fill in MODULE_DESCRIPTION()s for ec_bhf
2024-01-25 19:34 [PATCH net 00/10] Fix MODULE_DESCRIPTION() for net (p3) Breno Leitao
` (5 preceding siblings ...)
2024-01-25 19:34 ` [PATCH net 06/10] net: fill in MODULE_DESCRIPTION()s for cpsw-common Breno Leitao
@ 2024-01-25 19:34 ` Breno Leitao
2024-01-30 12:57 ` Simon Horman
2024-01-25 19:34 ` [PATCH net 08/10] net: fill in MODULE_DESCRIPTION()s for PCS drivers Breno Leitao
` (3 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Breno Leitao @ 2024-01-25 19:34 UTC (permalink / raw)
To: kuba, davem, pabeni, edumazet, Dariusz Marcinkiewicz
Cc: dsahern, weiwan, netdev, linux-kernel
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the Beckhoff CX5020 EtherCAT Ethernet driver.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
drivers/net/ethernet/ec_bhf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/ec_bhf.c b/drivers/net/ethernet/ec_bhf.c
index c2c5c589a5e3..44af1d13d931 100644
--- a/drivers/net/ethernet/ec_bhf.c
+++ b/drivers/net/ethernet/ec_bhf.c
@@ -590,5 +590,6 @@ module_pci_driver(pci_driver);
module_param(polling_frequency, long, 0444);
MODULE_PARM_DESC(polling_frequency, "Polling timer frequency in ns");
+MODULE_DESCRIPTION("Beckhoff CX5020 EtherCAT Ethernet driver");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Dariusz Marcinkiewicz <reksio@newterm.pl>");
--
2.39.3
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH net 08/10] net: fill in MODULE_DESCRIPTION()s for PCS drivers
2024-01-25 19:34 [PATCH net 00/10] Fix MODULE_DESCRIPTION() for net (p3) Breno Leitao
` (6 preceding siblings ...)
2024-01-25 19:34 ` [PATCH net 07/10] net: fill in MODULE_DESCRIPTION()s for ec_bhf Breno Leitao
@ 2024-01-25 19:34 ` Breno Leitao
2024-01-25 21:26 ` Andrew Lunn
2024-01-25 19:34 ` [PATCH net 09/10] net: fill in MODULE_DESCRIPTION()s for ieee802154 Breno Leitao
` (2 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Breno Leitao @ 2024-01-25 19:34 UTC (permalink / raw)
To: kuba, davem, pabeni, edumazet, Ioana Ciornei, Andrew Lunn,
Heiner Kallweit, Russell King, Alexander Couzens, Daniel Golle,
Matthias Brugger, AngeloGioacchino Del Regno, Jose Abreu
Cc: dsahern, weiwan, netdev, linux-kernel,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the Lynx, XPCS and LynxI PCS drivers.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
drivers/net/pcs/pcs-lynx.c | 1 +
drivers/net/pcs/pcs-mtk-lynxi.c | 1 +
drivers/net/pcs/pcs-xpcs.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/drivers/net/pcs/pcs-lynx.c b/drivers/net/pcs/pcs-lynx.c
index dc3962b2aa6b..853b8c138718 100644
--- a/drivers/net/pcs/pcs-lynx.c
+++ b/drivers/net/pcs/pcs-lynx.c
@@ -398,4 +398,5 @@ void lynx_pcs_destroy(struct phylink_pcs *pcs)
}
EXPORT_SYMBOL(lynx_pcs_destroy);
+MODULE_DESCRIPTION("NXP Lynx PCS phylink library");
MODULE_LICENSE("Dual BSD/GPL");
diff --git a/drivers/net/pcs/pcs-mtk-lynxi.c b/drivers/net/pcs/pcs-mtk-lynxi.c
index 8501dd365279..4f63abe638c4 100644
--- a/drivers/net/pcs/pcs-mtk-lynxi.c
+++ b/drivers/net/pcs/pcs-mtk-lynxi.c
@@ -303,4 +303,5 @@ void mtk_pcs_lynxi_destroy(struct phylink_pcs *pcs)
}
EXPORT_SYMBOL(mtk_pcs_lynxi_destroy);
+MODULE_DESCRIPTION("MediaTek SGMII library for LynxI");
MODULE_LICENSE("GPL");
diff --git a/drivers/net/pcs/pcs-xpcs.c b/drivers/net/pcs/pcs-xpcs.c
index 31f0beba638a..52a7757ee419 100644
--- a/drivers/net/pcs/pcs-xpcs.c
+++ b/drivers/net/pcs/pcs-xpcs.c
@@ -1456,4 +1456,5 @@ struct dw_xpcs *xpcs_create_mdiodev(struct mii_bus *bus, int addr,
}
EXPORT_SYMBOL_GPL(xpcs_create_mdiodev);
+MODULE_DESCRIPTION("Synopsys DesignWare XPCS library");
MODULE_LICENSE("GPL v2");
--
2.39.3
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH net 09/10] net: fill in MODULE_DESCRIPTION()s for ieee802154
2024-01-25 19:34 [PATCH net 00/10] Fix MODULE_DESCRIPTION() for net (p3) Breno Leitao
` (7 preceding siblings ...)
2024-01-25 19:34 ` [PATCH net 08/10] net: fill in MODULE_DESCRIPTION()s for PCS drivers Breno Leitao
@ 2024-01-25 19:34 ` Breno Leitao
2024-01-25 19:34 ` [PATCH net 10/10] net: fill in MODULE_DESCRIPTION()s for arcnet Breno Leitao
2024-01-29 12:20 ` [PATCH net 00/10] Fix MODULE_DESCRIPTION() for net (p3) patchwork-bot+netdevbpf
10 siblings, 0 replies; 23+ messages in thread
From: Breno Leitao @ 2024-01-25 19:34 UTC (permalink / raw)
To: kuba, davem, pabeni, edumazet, Alexander Aring, Stefan Schmidt,
Miquel Raynal
Cc: dsahern, weiwan, netdev, linux-kernel, open list:IEEE 802.15.4 SUBSYSTEM
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to ieee802154 modules.
Signed-off-by: Breno Leitao <leitao@debian.org>
Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>
---
net/ieee802154/6lowpan/core.c | 1 +
net/ieee802154/socket.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c
index 2c087b7f17c5..e643f52663f9 100644
--- a/net/ieee802154/6lowpan/core.c
+++ b/net/ieee802154/6lowpan/core.c
@@ -280,5 +280,6 @@ static void __exit lowpan_cleanup_module(void)
module_init(lowpan_init_module);
module_exit(lowpan_cleanup_module);
+MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network IEEE 802.15.4 core");
MODULE_LICENSE("GPL");
MODULE_ALIAS_RTNL_LINK("lowpan");
diff --git a/net/ieee802154/socket.c b/net/ieee802154/socket.c
index 00302e8b9615..990a83455dcf 100644
--- a/net/ieee802154/socket.c
+++ b/net/ieee802154/socket.c
@@ -1137,4 +1137,5 @@ module_init(af_ieee802154_init);
module_exit(af_ieee802154_remove);
MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("IEEE 802.15.4 socket interface");
MODULE_ALIAS_NETPROTO(PF_IEEE802154);
--
2.39.3
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH net 10/10] net: fill in MODULE_DESCRIPTION()s for arcnet
2024-01-25 19:34 [PATCH net 00/10] Fix MODULE_DESCRIPTION() for net (p3) Breno Leitao
` (8 preceding siblings ...)
2024-01-25 19:34 ` [PATCH net 09/10] net: fill in MODULE_DESCRIPTION()s for ieee802154 Breno Leitao
@ 2024-01-25 19:34 ` Breno Leitao
2024-01-30 12:57 ` Simon Horman
2024-01-29 12:20 ` [PATCH net 00/10] Fix MODULE_DESCRIPTION() for net (p3) patchwork-bot+netdevbpf
10 siblings, 1 reply; 23+ messages in thread
From: Breno Leitao @ 2024-01-25 19:34 UTC (permalink / raw)
To: kuba, davem, pabeni, edumazet, Michael Grzeschik
Cc: dsahern, weiwan, netdev, linux-kernel
W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to arcnet module.
Signed-off-by: Breno Leitao <leitao@debian.org>
---
drivers/net/arcnet/arcnet.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/arcnet/arcnet.c b/drivers/net/arcnet/arcnet.c
index d9e052c49ba1..166bfc3c8e6c 100644
--- a/drivers/net/arcnet/arcnet.c
+++ b/drivers/net/arcnet/arcnet.c
@@ -108,6 +108,7 @@ static int go_tx(struct net_device *dev);
static int debug = ARCNET_DEBUG;
module_param(debug, int, 0);
+MODULE_DESCRIPTION("ARCnet core driver");
MODULE_LICENSE("GPL");
static int __init arcnet_init(void)
--
2.39.3
^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH net 08/10] net: fill in MODULE_DESCRIPTION()s for PCS drivers
2024-01-25 19:34 ` [PATCH net 08/10] net: fill in MODULE_DESCRIPTION()s for PCS drivers Breno Leitao
@ 2024-01-25 21:26 ` Andrew Lunn
0 siblings, 0 replies; 23+ messages in thread
From: Andrew Lunn @ 2024-01-25 21:26 UTC (permalink / raw)
To: Breno Leitao
Cc: kuba, davem, pabeni, edumazet, Ioana Ciornei, Heiner Kallweit,
Russell King, Alexander Couzens, Daniel Golle, Matthias Brugger,
AngeloGioacchino Del Regno, Jose Abreu, dsahern, weiwan, netdev,
linux-kernel, moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
On Thu, Jan 25, 2024 at 11:34:18AM -0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the Lynx, XPCS and LynxI PCS drivers.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH net 00/10] Fix MODULE_DESCRIPTION() for net (p3)
2024-01-25 19:34 [PATCH net 00/10] Fix MODULE_DESCRIPTION() for net (p3) Breno Leitao
` (9 preceding siblings ...)
2024-01-25 19:34 ` [PATCH net 10/10] net: fill in MODULE_DESCRIPTION()s for arcnet Breno Leitao
@ 2024-01-29 12:20 ` patchwork-bot+netdevbpf
2024-01-29 20:00 ` Jakub Kicinski
10 siblings, 1 reply; 23+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-01-29 12:20 UTC (permalink / raw)
To: Breno Leitao
Cc: kuba, davem, pabeni, edumazet, dsahern, weiwan, netdev, linux-kernel
Hello:
This series was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 25 Jan 2024 11:34:10 -0800 you wrote:
> There are hundreds of network modules that misses MODULE_DESCRIPTION(),
> causing a warning when compiling with W=1. Example:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/com90io.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/arc-rimi.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/arcnet/com20020.o
>
> [...]
Here is the summary with links:
- [net,01/10] net: fill in MODULE_DESCRIPTION()s for encx24j600
https://git.kernel.org/netdev/net-next/c/dec836ed69d1
- [net,02/10] net: fill in MODULE_DESCRIPTION()s for ocelot
https://git.kernel.org/netdev/net-next/c/1c870c63d7d2
- [net,03/10] net: fill in MODULE_DESCRIPTION()s for SMSC drivers
https://git.kernel.org/netdev/net-next/c/9ba4295b2eab
- [net,04/10] net: fill in MODULE_DESCRIPTION()s for Qualcom drivers
https://git.kernel.org/netdev/net-next/c/66c164633bb0
- [net,05/10] net: fill in MODULE_DESCRIPTION()s for dwmac-socfpga
https://git.kernel.org/netdev/net-next/c/23f487f70c73
- [net,06/10] net: fill in MODULE_DESCRIPTION()s for cpsw-common
https://git.kernel.org/netdev/net-next/c/3e4620c89148
- [net,07/10] net: fill in MODULE_DESCRIPTION()s for ec_bhf
https://git.kernel.org/netdev/net-next/c/ad979679d64b
- [net,08/10] net: fill in MODULE_DESCRIPTION()s for PCS drivers
https://git.kernel.org/netdev/net-next/c/be884c15de37
- [net,09/10] net: fill in MODULE_DESCRIPTION()s for ieee802154
https://git.kernel.org/netdev/net-next/c/6aa89bf8ac9a
- [net,10/10] net: fill in MODULE_DESCRIPTION()s for arcnet
https://git.kernel.org/netdev/net-next/c/d06aa0eb0a70
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH net 00/10] Fix MODULE_DESCRIPTION() for net (p3)
2024-01-29 12:20 ` [PATCH net 00/10] Fix MODULE_DESCRIPTION() for net (p3) patchwork-bot+netdevbpf
@ 2024-01-29 20:00 ` Jakub Kicinski
0 siblings, 0 replies; 23+ messages in thread
From: Jakub Kicinski @ 2024-01-29 20:00 UTC (permalink / raw)
To: patchwork-bot+netdevbpf
Cc: Breno Leitao, davem, pabeni, edumazet, dsahern, weiwan, netdev,
linux-kernel
On Mon, 29 Jan 2024 12:20:28 +0000 patchwork-bot+netdevbpf@kernel.org
wrote:
> This series was applied to netdev/net-next.git (main)
> by David S. Miller <davem@davemloft.net>:
🧘
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH net 02/10] net: fill in MODULE_DESCRIPTION()s for ocelot
2024-01-25 19:34 ` [PATCH net 02/10] net: fill in MODULE_DESCRIPTION()s for ocelot Breno Leitao
@ 2024-01-30 10:11 ` Simon Horman
2024-01-30 12:03 ` Vladimir Oltean
0 siblings, 1 reply; 23+ messages in thread
From: Simon Horman @ 2024-01-30 10:11 UTC (permalink / raw)
To: Breno Leitao
Cc: kuba, davem, pabeni, edumazet, Vladimir Oltean, Claudiu Manoil,
Alexandre Belloni, UNGLinuxDriver, dsahern, weiwan, netdev,
linux-kernel, Horatiu Vultur
On Thu, Jan 25, 2024 at 11:34:12AM -0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the Ocelot SoCs (VSC7514) helpers driver.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
> drivers/net/ethernet/mscc/ocelot.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
> index 56ccbd4c37fe..2194f2a7ab27 100644
> --- a/drivers/net/ethernet/mscc/ocelot.c
> +++ b/drivers/net/ethernet/mscc/ocelot.c
> @@ -3078,4 +3078,5 @@ void ocelot_deinit_port(struct ocelot *ocelot, int port)
> }
> EXPORT_SYMBOL(ocelot_deinit_port);
>
> +MODULE_DESCRIPTION("Microsemi Ocelot (VSC7514) Switch driver");
Hi Breno,
I really appreciate your work in this area.
WRT this patch, I could well be wrong, but I think this code is also used
by Felix (VSC9959). If so the description might want tweaking.
Vladimir, can you shed some light on this?
> MODULE_LICENSE("Dual MIT/GPL");
> --
> 2.39.3
>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH net 02/10] net: fill in MODULE_DESCRIPTION()s for ocelot
2024-01-30 10:11 ` Simon Horman
@ 2024-01-30 12:03 ` Vladimir Oltean
0 siblings, 0 replies; 23+ messages in thread
From: Vladimir Oltean @ 2024-01-30 12:03 UTC (permalink / raw)
To: Simon Horman
Cc: Breno Leitao, kuba, davem, pabeni, edumazet, Claudiu Manoil,
Alexandre Belloni, UNGLinuxDriver, dsahern, weiwan, netdev,
linux-kernel, Horatiu Vultur
On Tue, Jan 30, 2024 at 10:11:34AM +0000, Simon Horman wrote:
> On Thu, Jan 25, 2024 at 11:34:12AM -0800, Breno Leitao wrote:
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to the Ocelot SoCs (VSC7514) helpers driver.
> >
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > ---
> > drivers/net/ethernet/mscc/ocelot.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
> > index 56ccbd4c37fe..2194f2a7ab27 100644
> > --- a/drivers/net/ethernet/mscc/ocelot.c
> > +++ b/drivers/net/ethernet/mscc/ocelot.c
> > @@ -3078,4 +3078,5 @@ void ocelot_deinit_port(struct ocelot *ocelot, int port)
> > }
> > EXPORT_SYMBOL(ocelot_deinit_port);
> >
> > +MODULE_DESCRIPTION("Microsemi Ocelot (VSC7514) Switch driver");
>
> Hi Breno,
>
> I really appreciate your work in this area.
>
> WRT this patch, I could well be wrong, but I think this code is also used
> by Felix (VSC9959). If so the description might want tweaking.
>
> Vladimir, can you shed some light on this?
Thanks for pointing this out, Simon, you are correct. This would be better:
MODULE_DESCRIPTION("Microsemi Ocelot switch family library");
Also, the commit prefix for this driver should be "net: mscc: ocelot:
fill in MODULE_DESCRIPTION()".
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH net 01/10] net: fill in MODULE_DESCRIPTION()s for encx24j600
2024-01-25 19:34 ` [PATCH net 01/10] net: fill in MODULE_DESCRIPTION()s for encx24j600 Breno Leitao
@ 2024-01-30 12:54 ` Simon Horman
0 siblings, 0 replies; 23+ messages in thread
From: Simon Horman @ 2024-01-30 12:54 UTC (permalink / raw)
To: Breno Leitao
Cc: kuba, davem, pabeni, edumazet, dsahern, weiwan, netdev, linux-kernel
On Thu, Jan 25, 2024 at 11:34:11AM -0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the Microchip ENCX24J600 helpers driver.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH net 03/10] net: fill in MODULE_DESCRIPTION()s for SMSC drivers
2024-01-25 19:34 ` [PATCH net 03/10] net: fill in MODULE_DESCRIPTION()s for SMSC drivers Breno Leitao
@ 2024-01-30 12:55 ` Simon Horman
0 siblings, 0 replies; 23+ messages in thread
From: Simon Horman @ 2024-01-30 12:55 UTC (permalink / raw)
To: Breno Leitao
Cc: kuba, davem, pabeni, edumazet, Nicolas Pitre, Steve Glendinning,
dsahern, weiwan, netdev, linux-kernel, Andy Shevchenko,
Uwe Kleine-König
On Thu, Jan 25, 2024 at 11:34:13AM -0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the SMSC 91x/911x/9420 Ethernet drivers.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH net 04/10] net: fill in MODULE_DESCRIPTION()s for Qualcom drivers
2024-01-25 19:34 ` [PATCH net 04/10] net: fill in MODULE_DESCRIPTION()s for Qualcom drivers Breno Leitao
@ 2024-01-30 12:56 ` Simon Horman
0 siblings, 0 replies; 23+ messages in thread
From: Simon Horman @ 2024-01-30 12:56 UTC (permalink / raw)
To: Breno Leitao
Cc: kuba, davem, pabeni, edumazet, Timur Tabi,
Subash Abhinov Kasiviswanathan, Sean Tranchetti, dsahern, weiwan,
netdev, linux-kernel
On Thu, Jan 25, 2024 at 11:34:14AM -0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the Qualcom rmnet and emac drivers.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> Reviewed-by: Subash Abhinov Kasiviswanathan <quic_subashab@quicinc.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH net 05/10] net: fill in MODULE_DESCRIPTION()s for dwmac-socfpga
2024-01-25 19:34 ` [PATCH net 05/10] net: fill in MODULE_DESCRIPTION()s for dwmac-socfpga Breno Leitao
@ 2024-01-30 12:56 ` Simon Horman
0 siblings, 0 replies; 23+ messages in thread
From: Simon Horman @ 2024-01-30 12:56 UTC (permalink / raw)
To: Breno Leitao
Cc: kuba, davem, pabeni, edumazet, Alexandre Torgue, Jose Abreu,
Maxime Coquelin, dsahern, weiwan, netdev, linux-kernel,
moderated list:ARM/STM32 ARCHITECTURE,
moderated list:ARM/STM32 ARCHITECTURE
On Thu, Jan 25, 2024 at 11:34:15AM -0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the STMicro DWMAC for Altera SOCs.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH net 06/10] net: fill in MODULE_DESCRIPTION()s for cpsw-common
2024-01-25 19:34 ` [PATCH net 06/10] net: fill in MODULE_DESCRIPTION()s for cpsw-common Breno Leitao
@ 2024-01-30 12:57 ` Simon Horman
0 siblings, 0 replies; 23+ messages in thread
From: Simon Horman @ 2024-01-30 12:57 UTC (permalink / raw)
To: Breno Leitao
Cc: kuba, davem, pabeni, edumazet, Siddharth Vadapalli,
Ravi Gunasekaran, Roger Quadros, dsahern, weiwan, netdev,
linux-kernel, Bhupesh Sharma, Alex Elder, Rob Herring,
open list:TI ETHERNET SWITCH DRIVER (CPSW)
On Thu, Jan 25, 2024 at 11:34:16AM -0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the TI CPSW switch module.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> Reviewed-by: Roger Quadros <rogerq@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH net 07/10] net: fill in MODULE_DESCRIPTION()s for ec_bhf
2024-01-25 19:34 ` [PATCH net 07/10] net: fill in MODULE_DESCRIPTION()s for ec_bhf Breno Leitao
@ 2024-01-30 12:57 ` Simon Horman
0 siblings, 0 replies; 23+ messages in thread
From: Simon Horman @ 2024-01-30 12:57 UTC (permalink / raw)
To: Breno Leitao
Cc: kuba, davem, pabeni, edumazet, Dariusz Marcinkiewicz, dsahern,
weiwan, netdev, linux-kernel
On Thu, Jan 25, 2024 at 11:34:17AM -0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the Beckhoff CX5020 EtherCAT Ethernet driver.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH net 10/10] net: fill in MODULE_DESCRIPTION()s for arcnet
2024-01-25 19:34 ` [PATCH net 10/10] net: fill in MODULE_DESCRIPTION()s for arcnet Breno Leitao
@ 2024-01-30 12:57 ` Simon Horman
0 siblings, 0 replies; 23+ messages in thread
From: Simon Horman @ 2024-01-30 12:57 UTC (permalink / raw)
To: Breno Leitao
Cc: kuba, davem, pabeni, edumazet, Michael Grzeschik, dsahern,
weiwan, netdev, linux-kernel
On Thu, Jan 25, 2024 at 11:34:20AM -0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to arcnet module.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 23+ messages in thread
end of thread, other threads:[~2024-01-30 12:58 UTC | newest]
Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-25 19:34 [PATCH net 00/10] Fix MODULE_DESCRIPTION() for net (p3) Breno Leitao
2024-01-25 19:34 ` [PATCH net 01/10] net: fill in MODULE_DESCRIPTION()s for encx24j600 Breno Leitao
2024-01-30 12:54 ` Simon Horman
2024-01-25 19:34 ` [PATCH net 02/10] net: fill in MODULE_DESCRIPTION()s for ocelot Breno Leitao
2024-01-30 10:11 ` Simon Horman
2024-01-30 12:03 ` Vladimir Oltean
2024-01-25 19:34 ` [PATCH net 03/10] net: fill in MODULE_DESCRIPTION()s for SMSC drivers Breno Leitao
2024-01-30 12:55 ` Simon Horman
2024-01-25 19:34 ` [PATCH net 04/10] net: fill in MODULE_DESCRIPTION()s for Qualcom drivers Breno Leitao
2024-01-30 12:56 ` Simon Horman
2024-01-25 19:34 ` [PATCH net 05/10] net: fill in MODULE_DESCRIPTION()s for dwmac-socfpga Breno Leitao
2024-01-30 12:56 ` Simon Horman
2024-01-25 19:34 ` [PATCH net 06/10] net: fill in MODULE_DESCRIPTION()s for cpsw-common Breno Leitao
2024-01-30 12:57 ` Simon Horman
2024-01-25 19:34 ` [PATCH net 07/10] net: fill in MODULE_DESCRIPTION()s for ec_bhf Breno Leitao
2024-01-30 12:57 ` Simon Horman
2024-01-25 19:34 ` [PATCH net 08/10] net: fill in MODULE_DESCRIPTION()s for PCS drivers Breno Leitao
2024-01-25 21:26 ` Andrew Lunn
2024-01-25 19:34 ` [PATCH net 09/10] net: fill in MODULE_DESCRIPTION()s for ieee802154 Breno Leitao
2024-01-25 19:34 ` [PATCH net 10/10] net: fill in MODULE_DESCRIPTION()s for arcnet Breno Leitao
2024-01-30 12:57 ` Simon Horman
2024-01-29 12:20 ` [PATCH net 00/10] Fix MODULE_DESCRIPTION() for net (p3) patchwork-bot+netdevbpf
2024-01-29 20:00 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).