* [PATCH] ptp: lan743x: Use spin_lock instead of spin_lock_bh
@ 2024-01-28 10:18 Lucas Tanure
2024-01-31 23:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Lucas Tanure @ 2024-01-28 10:18 UTC (permalink / raw)
To: Bryan Whitehead, UNGLinuxDriver, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Richard Cochran
Cc: netdev, linux-kernel, Lucas Tanure
lan743x_ptp_request_tx_timestamp uses spin_lock_bh, but it is
only called from lan743x_tx_xmit_frame where all IRQs are
already disabled.
This fixes the "IRQs not enabled as expected" warning.
Signed-off-by: Lucas Tanure <tanure@linux.com>
---
drivers/net/ethernet/microchip/lan743x_ptp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/microchip/lan743x_ptp.c b/drivers/net/ethernet/microchip/lan743x_ptp.c
index 2f04bc77a118..2801f08bf1c9 100644
--- a/drivers/net/ethernet/microchip/lan743x_ptp.c
+++ b/drivers/net/ethernet/microchip/lan743x_ptp.c
@@ -1712,13 +1712,13 @@ bool lan743x_ptp_request_tx_timestamp(struct lan743x_adapter *adapter)
struct lan743x_ptp *ptp = &adapter->ptp;
bool result = false;
- spin_lock_bh(&ptp->tx_ts_lock);
+ spin_lock(&ptp->tx_ts_lock);
if (ptp->pending_tx_timestamps < LAN743X_PTP_NUMBER_OF_TX_TIMESTAMPS) {
/* request granted */
ptp->pending_tx_timestamps++;
result = true;
}
- spin_unlock_bh(&ptp->tx_ts_lock);
+ spin_unlock(&ptp->tx_ts_lock);
return result;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ptp: lan743x: Use spin_lock instead of spin_lock_bh
2024-01-28 10:18 [PATCH] ptp: lan743x: Use spin_lock instead of spin_lock_bh Lucas Tanure
@ 2024-01-31 23:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-01-31 23:20 UTC (permalink / raw)
To: Lucas Tanure
Cc: bryan.whitehead, UNGLinuxDriver, davem, edumazet, kuba, pabeni,
richardcochran, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sun, 28 Jan 2024 10:18:49 +0000 you wrote:
> lan743x_ptp_request_tx_timestamp uses spin_lock_bh, but it is
> only called from lan743x_tx_xmit_frame where all IRQs are
> already disabled.
>
> This fixes the "IRQs not enabled as expected" warning.
>
> Signed-off-by: Lucas Tanure <tanure@linux.com>
>
> [...]
Here is the summary with links:
- ptp: lan743x: Use spin_lock instead of spin_lock_bh
https://git.kernel.org/netdev/net-next/c/96b93f08357c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-31 23:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-28 10:18 [PATCH] ptp: lan743x: Use spin_lock instead of spin_lock_bh Lucas Tanure
2024-01-31 23:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).