linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] net: lan966x: debugfs: Fix showing the port keyset
@ 2024-01-28 19:51 Horatiu Vultur
  2024-01-31 13:40 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Horatiu Vultur @ 2024-01-28 19:51 UTC (permalink / raw)
  To: davem, edumazet, kuba, pabeni, UNGLinuxDriver
  Cc: netdev, linux-kernel, Horatiu Vultur

On lan966x, it is possible to use debugfs to print different information
about the VCAPs. Information like, if it is enabled, how the ports are
configured, print the actual rules. The issue is that when printing how
the ports are configured for IS1 lookups, it was parsing the wrong
register to get this information. The fix consists in reading the
correct register that contains this information.

Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
---
 drivers/net/ethernet/microchip/lan966x/lan966x_vcap_debugfs.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_vcap_debugfs.c b/drivers/net/ethernet/microchip/lan966x/lan966x_vcap_debugfs.c
index ac525ff1503e6..3a01e13bd10b7 100644
--- a/drivers/net/ethernet/microchip/lan966x/lan966x_vcap_debugfs.c
+++ b/drivers/net/ethernet/microchip/lan966x/lan966x_vcap_debugfs.c
@@ -25,6 +25,8 @@ static void lan966x_vcap_is1_port_keys(struct lan966x_port *port,
 	for (int l = 0; l < admin->lookups; ++l) {
 		out->prf(out->dst, "\n    Lookup %d: ", l);
 
+		val = lan_rd(lan966x, ANA_VCAP_S1_CFG(port->chip_port, l));
+
 		out->prf(out->dst, "\n      other: ");
 		switch (ANA_VCAP_S1_CFG_KEY_OTHER_CFG_GET(val)) {
 		case VCAP_IS1_PS_OTHER_NORMAL:
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] net: lan966x: debugfs: Fix showing the port keyset
  2024-01-28 19:51 [PATCH net-next] net: lan966x: debugfs: Fix showing the port keyset Horatiu Vultur
@ 2024-01-31 13:40 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-01-31 13:40 UTC (permalink / raw)
  To: Horatiu Vultur
  Cc: davem, edumazet, kuba, pabeni, UNGLinuxDriver, netdev, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Sun, 28 Jan 2024 20:51:34 +0100 you wrote:
> On lan966x, it is possible to use debugfs to print different information
> about the VCAPs. Information like, if it is enabled, how the ports are
> configured, print the actual rules. The issue is that when printing how
> the ports are configured for IS1 lookups, it was parsing the wrong
> register to get this information. The fix consists in reading the
> correct register that contains this information.
> 
> [...]

Here is the summary with links:
  - [net-next] net: lan966x: debugfs: Fix showing the port keyset
    https://git.kernel.org/netdev/net-next/c/e746094b1bb0

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-01-31 13:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-28 19:51 [PATCH net-next] net: lan966x: debugfs: Fix showing the port keyset Horatiu Vultur
2024-01-31 13:40 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).