* [PATCH] cxl: remove CONFIG_CXL_PMU entry in drivers/cxl/Kconfig
@ 2024-02-04 9:46 Masahiro Yamada
2024-02-05 11:13 ` Jonathan Cameron
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Masahiro Yamada @ 2024-02-04 9:46 UTC (permalink / raw)
To: Davidlohr Bueso, Jonathan Cameron, Dave Jiang, Alison Schofield,
Vishal Verma, Ira Weiny, Dan Williams, linux-cxl
Cc: Masahiro Yamada, linux-kernel
Commit 5d7107c72796 ("perf: CXL Performance Monitoring Unit driver")
added the config entries for CXL_PMU in drivers/cxl/Kconfig and
drivers/perf/Kconfig, so it can be toggled from multiple locations:
[1] Device Drivers
-> PCI support
-> CXL (Compute Expres Link) Devices
-> CXL Performance Monitoring Unit
[2] Device Drivers
-> Performance monitor support
-> CXL Performance Monitoring Unit
This complicates things, and nobody else does this.
I kept the one in drivers/perf/Kconfig because CONFIG_CXL_PMU controls
the compilation of drivers/perf/cxl_pmu.c.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
drivers/cxl/Kconfig | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig
index 67998dbd1d46..5f3c9c5529b9 100644
--- a/drivers/cxl/Kconfig
+++ b/drivers/cxl/Kconfig
@@ -144,17 +144,4 @@ config CXL_REGION_INVALIDATION_TEST
If unsure, or if this kernel is meant for production environments,
say N.
-config CXL_PMU
- tristate "CXL Performance Monitoring Unit"
- default CXL_BUS
- depends on PERF_EVENTS
- help
- Support performance monitoring as defined in CXL rev 3.0
- section 13.2: Performance Monitoring. CXL components may have
- one or more CXL Performance Monitoring Units (CPMUs).
-
- Say 'y/m' to enable a driver that will attach to performance
- monitoring units and provide standard perf based interfaces.
-
- If unsure say 'm'.
endif
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] cxl: remove CONFIG_CXL_PMU entry in drivers/cxl/Kconfig
2024-02-04 9:46 [PATCH] cxl: remove CONFIG_CXL_PMU entry in drivers/cxl/Kconfig Masahiro Yamada
@ 2024-02-05 11:13 ` Jonathan Cameron
2024-02-05 20:54 ` Davidlohr Bueso
2024-02-05 22:07 ` Dave Jiang
2 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2024-02-05 11:13 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Davidlohr Bueso, Dave Jiang, Alison Schofield, Vishal Verma,
Ira Weiny, Dan Williams, linux-cxl, linux-kernel
On Sun, 4 Feb 2024 18:46:13 +0900
Masahiro Yamada <masahiroy@kernel.org> wrote:
> Commit 5d7107c72796 ("perf: CXL Performance Monitoring Unit driver")
> added the config entries for CXL_PMU in drivers/cxl/Kconfig and
> drivers/perf/Kconfig, so it can be toggled from multiple locations:
>
> [1] Device Drivers
> -> PCI support
> -> CXL (Compute Expres Link) Devices
> -> CXL Performance Monitoring Unit
>
> [2] Device Drivers
> -> Performance monitor support
> -> CXL Performance Monitoring Unit
>
> This complicates things, and nobody else does this.
>
> I kept the one in drivers/perf/Kconfig because CONFIG_CXL_PMU controls
> the compilation of drivers/perf/cxl_pmu.c.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
oops.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Thanks
Jonathan
> ---
>
> drivers/cxl/Kconfig | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig
> index 67998dbd1d46..5f3c9c5529b9 100644
> --- a/drivers/cxl/Kconfig
> +++ b/drivers/cxl/Kconfig
> @@ -144,17 +144,4 @@ config CXL_REGION_INVALIDATION_TEST
> If unsure, or if this kernel is meant for production environments,
> say N.
>
> -config CXL_PMU
> - tristate "CXL Performance Monitoring Unit"
> - default CXL_BUS
> - depends on PERF_EVENTS
> - help
> - Support performance monitoring as defined in CXL rev 3.0
> - section 13.2: Performance Monitoring. CXL components may have
> - one or more CXL Performance Monitoring Units (CPMUs).
> -
> - Say 'y/m' to enable a driver that will attach to performance
> - monitoring units and provide standard perf based interfaces.
> -
> - If unsure say 'm'.
> endif
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cxl: remove CONFIG_CXL_PMU entry in drivers/cxl/Kconfig
2024-02-04 9:46 [PATCH] cxl: remove CONFIG_CXL_PMU entry in drivers/cxl/Kconfig Masahiro Yamada
2024-02-05 11:13 ` Jonathan Cameron
@ 2024-02-05 20:54 ` Davidlohr Bueso
2024-02-05 22:07 ` Dave Jiang
2 siblings, 0 replies; 4+ messages in thread
From: Davidlohr Bueso @ 2024-02-05 20:54 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Jonathan Cameron, Dave Jiang, Alison Schofield, Vishal Verma,
Ira Weiny, Dan Williams, linux-cxl, linux-kernel
On Sun, 04 Feb 2024, Masahiro Yamada wrote:
>Commit 5d7107c72796 ("perf: CXL Performance Monitoring Unit driver")
>added the config entries for CXL_PMU in drivers/cxl/Kconfig and
>drivers/perf/Kconfig, so it can be toggled from multiple locations:
>
>[1] Device Drivers
> -> PCI support
> -> CXL (Compute Expres Link) Devices
> -> CXL Performance Monitoring Unit
>
>[2] Device Drivers
> -> Performance monitor support
> -> CXL Performance Monitoring Unit
>
>This complicates things, and nobody else does this.
>
>I kept the one in drivers/perf/Kconfig because CONFIG_CXL_PMU controls
>the compilation of drivers/perf/cxl_pmu.c.
Completely agree. In general we should try to keep config
options minimal where possible.
Acked-by: Davidlohr Bueso <dave@stgolabs.net>
>
>Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
>---
>
> drivers/cxl/Kconfig | 13 -------------
> 1 file changed, 13 deletions(-)
>
>diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig
>index 67998dbd1d46..5f3c9c5529b9 100644
>--- a/drivers/cxl/Kconfig
>+++ b/drivers/cxl/Kconfig
>@@ -144,17 +144,4 @@ config CXL_REGION_INVALIDATION_TEST
> If unsure, or if this kernel is meant for production environments,
> say N.
>
>-config CXL_PMU
>- tristate "CXL Performance Monitoring Unit"
>- default CXL_BUS
>- depends on PERF_EVENTS
>- help
>- Support performance monitoring as defined in CXL rev 3.0
>- section 13.2: Performance Monitoring. CXL components may have
>- one or more CXL Performance Monitoring Units (CPMUs).
>-
>- Say 'y/m' to enable a driver that will attach to performance
>- monitoring units and provide standard perf based interfaces.
>-
>- If unsure say 'm'.
> endif
>--
>2.40.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cxl: remove CONFIG_CXL_PMU entry in drivers/cxl/Kconfig
2024-02-04 9:46 [PATCH] cxl: remove CONFIG_CXL_PMU entry in drivers/cxl/Kconfig Masahiro Yamada
2024-02-05 11:13 ` Jonathan Cameron
2024-02-05 20:54 ` Davidlohr Bueso
@ 2024-02-05 22:07 ` Dave Jiang
2 siblings, 0 replies; 4+ messages in thread
From: Dave Jiang @ 2024-02-05 22:07 UTC (permalink / raw)
To: Masahiro Yamada, Davidlohr Bueso, Jonathan Cameron,
Alison Schofield, Vishal Verma, Ira Weiny, Dan Williams,
linux-cxl
Cc: linux-kernel
On 2/4/24 2:46 AM, Masahiro Yamada wrote:
> Commit 5d7107c72796 ("perf: CXL Performance Monitoring Unit driver")
> added the config entries for CXL_PMU in drivers/cxl/Kconfig and
> drivers/perf/Kconfig, so it can be toggled from multiple locations:
>
> [1] Device Drivers
> -> PCI support
> -> CXL (Compute Expres Link) Devices
> -> CXL Performance Monitoring Unit
>
> [2] Device Drivers
> -> Performance monitor support
> -> CXL Performance Monitoring Unit
>
> This complicates things, and nobody else does this.
>
> I kept the one in drivers/perf/Kconfig because CONFIG_CXL_PMU controls
> the compilation of drivers/perf/cxl_pmu.c.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>
> drivers/cxl/Kconfig | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig
> index 67998dbd1d46..5f3c9c5529b9 100644
> --- a/drivers/cxl/Kconfig
> +++ b/drivers/cxl/Kconfig
> @@ -144,17 +144,4 @@ config CXL_REGION_INVALIDATION_TEST
> If unsure, or if this kernel is meant for production environments,
> say N.
>
> -config CXL_PMU
> - tristate "CXL Performance Monitoring Unit"
> - default CXL_BUS
> - depends on PERF_EVENTS
> - help
> - Support performance monitoring as defined in CXL rev 3.0
> - section 13.2: Performance Monitoring. CXL components may have
> - one or more CXL Performance Monitoring Units (CPMUs).
> -
> - Say 'y/m' to enable a driver that will attach to performance
> - monitoring units and provide standard perf based interfaces.
> -
> - If unsure say 'm'.
> endif
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-06 2:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-04 9:46 [PATCH] cxl: remove CONFIG_CXL_PMU entry in drivers/cxl/Kconfig Masahiro Yamada
2024-02-05 11:13 ` Jonathan Cameron
2024-02-05 20:54 ` Davidlohr Bueso
2024-02-05 22:07 ` Dave Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).