* [PATCH v1] perf kvm powerpc: Fix build
@ 2024-02-06 23:59 Ian Rogers
2024-02-07 0:01 ` Namhyung Kim
2024-02-07 21:47 ` Namhyung Kim
0 siblings, 2 replies; 3+ messages in thread
From: Ian Rogers @ 2024-02-06 23:59 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Ian Rogers, Adrian Hunter, Kan Liang, Leo Yan, James Clark,
linux-perf-users, linux-kernel, sfr
Updates to struct parse_events_error needed to be carried through to
PowerPC specific event parsing.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: fd7b8e8fb20f ("perf parse-events: Print all errors")
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/arch/powerpc/util/kvm-stat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/arch/powerpc/util/kvm-stat.c b/tools/perf/arch/powerpc/util/kvm-stat.c
index d9a0ac1cdf30..c8357b571ccf 100644
--- a/tools/perf/arch/powerpc/util/kvm-stat.c
+++ b/tools/perf/arch/powerpc/util/kvm-stat.c
@@ -114,7 +114,7 @@ static int is_tracepoint_available(const char *str, struct evlist *evlist)
parse_events_error__init(&err);
ret = parse_events(evlist, str, &err);
- if (err.str)
+ if (ret)
parse_events_error__print(&err, "tracepoint");
parse_events_error__exit(&err);
return ret;
--
2.43.0.594.gd9cf4e227d-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] perf kvm powerpc: Fix build
2024-02-06 23:59 [PATCH v1] perf kvm powerpc: Fix build Ian Rogers
@ 2024-02-07 0:01 ` Namhyung Kim
2024-02-07 21:47 ` Namhyung Kim
1 sibling, 0 replies; 3+ messages in thread
From: Namhyung Kim @ 2024-02-07 0:01 UTC (permalink / raw)
To: Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Adrian Hunter,
Kan Liang, Leo Yan, James Clark, linux-perf-users, linux-kernel,
sfr
On Tue, Feb 6, 2024 at 3:59 PM Ian Rogers <irogers@google.com> wrote:
>
> Updates to struct parse_events_error needed to be carried through to
> PowerPC specific event parsing.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: fd7b8e8fb20f ("perf parse-events: Print all errors")
> Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Namhyung <namhyung@kernel.org>
Thanks for the quick fix!
Namhyung
> ---
> tools/perf/arch/powerpc/util/kvm-stat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/arch/powerpc/util/kvm-stat.c b/tools/perf/arch/powerpc/util/kvm-stat.c
> index d9a0ac1cdf30..c8357b571ccf 100644
> --- a/tools/perf/arch/powerpc/util/kvm-stat.c
> +++ b/tools/perf/arch/powerpc/util/kvm-stat.c
> @@ -114,7 +114,7 @@ static int is_tracepoint_available(const char *str, struct evlist *evlist)
>
> parse_events_error__init(&err);
> ret = parse_events(evlist, str, &err);
> - if (err.str)
> + if (ret)
> parse_events_error__print(&err, "tracepoint");
> parse_events_error__exit(&err);
> return ret;
> --
> 2.43.0.594.gd9cf4e227d-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] perf kvm powerpc: Fix build
2024-02-06 23:59 [PATCH v1] perf kvm powerpc: Fix build Ian Rogers
2024-02-07 0:01 ` Namhyung Kim
@ 2024-02-07 21:47 ` Namhyung Kim
1 sibling, 0 replies; 3+ messages in thread
From: Namhyung Kim @ 2024-02-07 21:47 UTC (permalink / raw)
To: Kan Liang, Peter Zijlstra, Leo Yan, linux-kernel, Jiri Olsa,
linux-perf-users, James Clark, Adrian Hunter, Alexander Shishkin,
Ian Rogers, Mark Rutland, sfr, Ingo Molnar,
Arnaldo Carvalho de Melo
On Tue, 6 Feb 2024 15:59:02 -0800, Ian Rogers wrote:
> Updates to struct parse_events_error needed to be carried through to
> PowerPC specific event parsing.
>
>
Applied to perf-tools-next, thanks!
Best regards,
--
Namhyung Kim <namhyung@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-07 21:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-06 23:59 [PATCH v1] perf kvm powerpc: Fix build Ian Rogers
2024-02-07 0:01 ` Namhyung Kim
2024-02-07 21:47 ` Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).