* [PATCH] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree
@ 2024-02-26 5:55 Raihan Ahamed
2024-02-26 7:05 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 15+ messages in thread
From: Raihan Ahamed @ 2024-02-26 5:55 UTC (permalink / raw)
Cc: raihan1999ahamed, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Kees Cook, Tony Luck,
Guilherme G. Piccoli, linux-arm-msm, devicetree, linux-kernel,
linux-hardening
Lenovo P2 is a handset using the MSM8953 SoC released in 2016
Add a device tree for with initial support for:
- GPIO keys
- SDHCI (internal and external storage)
- USB Device Mode
- WCNSS (WiFi/BT)
- Regulators
Signed-off-by: Raihan Ahamed <raihan1999ahamed@gmail.com>
---
arch/arm64/boot/dts/qcom/Makefile | 1 +
.../boot/dts/qcom/msm8953-lenovo-kuntao.dts | 240 ++++++++++++++++++
2 files changed, 241 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 39889d5f8e12..aebfb1ae728c 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -49,6 +49,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8939-huawei-kiwi.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8939-longcheer-l9100.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8939-samsung-a7.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8939-sony-xperia-kanuti-tulip.dtb
+dtb-$(CONFIG_ARCH_QCOM) += msm8953-lenovo-kuntao.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8953-motorola-potter.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8953-xiaomi-daisy.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8953-xiaomi-mido.dtb
diff --git a/arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts b/arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts
new file mode 100644
index 000000000000..2fd6345bbe15
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts
@@ -0,0 +1,240 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2024, Raihan Ahamed <raihan1999ahamed@gmail.com>
+ */
+/dts-v1/;
+
+#include "msm8953.dtsi"
+#include "pm8953.dtsi"
+#include "pmi8950.dtsi"
+
+/delete-node/ &qseecom_mem;
+
+/ {
+ model = "Lenovo P2";
+ compatible = "lenovo,kuntao", "qcom,msm8953";
+ chassis-type = "handset";
+ qcom,msm-id = <0x125 0x00>;
+ qcom,board-id = <0x41 0x82b1 0x41 0x83b0>;
+
+ gpio-keys {
+ compatible = "gpio-keys";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&gpio_key_default>;
+
+ key-volume-up {
+ label = "Volume Up";
+ gpios = <&tlmm 85 GPIO_ACTIVE_LOW>;
+ linux,code = <KEY_VOLUMEUP>;
+ debounce-interval = <15>;
+ };
+ };
+
+ reserved-memory {
+ qseecom_mem: qseecom@84a00000 {
+ reg = <0x0 0x84a00000 0x0 0x1900000>;
+ no-map;
+ };
+
+ ramoops@8ee00000 {
+ compatible = "ramoops";
+ reg = <0x0 0x8ee00000 0x0 0x80000>;
+ console-size = <0x40000>;
+ ftrace-size = <0x15000>;
+ record-size = <0x5000>;
+ pmsg-size = <0x2000>;
+ };
+ };
+
+ vph_pwr: vph-pwr-regulator {
+ compatible = "regulator-fixed";
+ regulator-name = "vph_pwr";
+ regulator-always-on;
+ regulator-boot-on;
+ };
+};
+
+&hsusb_phy {
+ vdd-supply = <&pm8953_l3>;
+ vdda-pll-supply = <&pm8953_l7>;
+ vdda-phy-dpdm-supply = <&pm8953_l13>;
+
+ status = "okay";
+};
+
+&pm8953_resin {
+ linux,code = <KEY_VOLUMEDOWN>;
+ status = "okay";
+};
+
+&rpm_requests {
+ regulators {
+ compatible = "qcom,rpm-pm8953-regulators";
+ vdd_s1-supply = <&vph_pwr>;
+ vdd_s2-supply = <&vph_pwr>;
+ vdd_s3-supply = <&vph_pwr>;
+ vdd_s4-supply = <&vph_pwr>;
+ vdd_s5-supply = <&vph_pwr>;
+ vdd_s6-supply = <&vph_pwr>;
+ vdd_s7-supply = <&vph_pwr>;
+ vdd_l1-supply = <&pm8953_s3>;
+ vdd_l2_l3-supply = <&pm8953_s3>;
+ vdd_l4_l5_l6_l7_l16_l19-supply = <&pm8953_s4>;
+ vdd_l8_l11_l12_l13_l14_l15-supply = <&vph_pwr>;
+ vdd_l9_l10_l17_l18_l22-supply = <&vph_pwr>;
+
+ pm8953_s1: s1 {
+ regulator-min-microvolt = <863000>;
+ regulator-max-microvolt = <1152000>;
+ };
+
+ pm8953_s3: s3 {
+ regulator-min-microvolt = <1224000>;
+ regulator-max-microvolt = <1224000>;
+ };
+
+ pm8953_s4: s4 {
+ regulator-min-microvolt = <1896000>;
+ regulator-max-microvolt = <2048000>;
+ };
+
+ pm8953_l1: l1 {
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1100000>;
+ };
+
+ pm8953_l2: l2 {
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1000000>;
+ };
+
+ pm8953_l3: l3 {
+ regulator-min-microvolt = <925000>;
+ regulator-max-microvolt = <925000>;
+ regulator-allow-set-load;
+ };
+
+ pm8953_l5: l5 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ pm8953_l6: l6 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ pm8953_l7: l7 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1900000>;
+ };
+
+ pm8953_l8: l8 {
+ regulator-min-microvolt = <2900000>;
+ regulator-max-microvolt = <2900000>;
+ };
+
+ pm8953_l9: l9 {
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ pm8953_l10: l10 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ pm8953_l11: l11 {
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <3000000>;
+ };
+
+ pm8953_l12: l12 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3000000>;
+ };
+
+ pm8953_l13: l13 {
+ regulator-min-microvolt = <3075000>;
+ regulator-max-microvolt = <3125000>;
+ };
+
+ pm8953_l15: l15 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ pm8953_l16: l16 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ pm8953_l17: l17 {
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <3000000>;
+ };
+
+ pm8953_l19: l19 {
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1350000>;
+ };
+
+ pm8953_l22: l22 {
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2850000>;
+ };
+
+ pm8953_l23: l23 {
+ regulator-min-microvolt = <975000>;
+ regulator-max-microvolt = <1225000>;
+ };
+ };
+};
+
+&sdhc_1 {
+ vmmc-supply = <&pm8953_l8>;
+ vqmmc-supply = <&pm8953_l5>;
+
+ status = "okay";
+};
+
+&sdhc_2 {
+ vmmc-supply = <&pm8953_l11>;
+ vqmmc-supply = <&pm8953_l12>;
+
+ cd-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>;
+
+ pinctrl-names = "default", "sleep";
+ pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_off>;
+ pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off &sdc2_cd_off>;
+
+ status = "okay";
+};
+
+&tlmm {
+ gpio-reserved-ranges = <0 4>, <135 4>;
+};
+
+&usb3 {
+ status = "okay";
+};
+
+&usb3_dwc3 {
+ dr_mode = "peripheral";
+};
+
+&wcnss {
+ vddpx-supply = <&pm8953_l5>;
+
+ status = "okay";
+};
+
+&wcnss_iris {
+ compatible = "qcom,wcn3660b";
+
+ vddxo-supply = <&pm8953_l7>;
+ vddrfa-supply = <&pm8953_l19>;
+ vddpa-supply = <&pm8953_l9>;
+ vdddig-supply = <&pm8953_l5>;
+};
--
2.43.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree
2024-02-26 5:55 [PATCH] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree Raihan Ahamed
@ 2024-02-26 7:05 ` Krzysztof Kozlowski
2024-02-26 9:41 ` [PATCH v2 1/2] dt-bindings: arm: qcom: Add Lenovo P2 Raihan Ahamed
2024-02-26 16:54 ` [PATCH] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree Rob Herring
2024-02-26 19:54 ` [PATCH v3 1/2] dt-bindings: arm: qcom: Add Lenovo P2 Raihan Ahamed
2 siblings, 1 reply; 15+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-26 7:05 UTC (permalink / raw)
To: Raihan Ahamed
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Kees Cook, Tony Luck, Guilherme G. Piccoli,
linux-arm-msm, devicetree, linux-kernel, linux-hardening
On 26/02/2024 06:55, Raihan Ahamed wrote:
> Lenovo P2 is a handset using the MSM8953 SoC released in 2016
>
> Add a device tree for with initial support for:
>
> - GPIO keys
> - SDHCI (internal and external storage)
> - USB Device Mode
> - WCNSS (WiFi/BT)
> - Regulators
>
> Signed-off-by: Raihan Ahamed <raihan1999ahamed@gmail.com>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> .../boot/dts/qcom/msm8953-lenovo-kuntao.dts | 240 ++++++++++++++++++
> 2 files changed, 241 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 39889d5f8e12..aebfb1ae728c 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -49,6 +49,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8939-huawei-kiwi.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8939-longcheer-l9100.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8939-samsung-a7.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8939-sony-xperia-kanuti-tulip.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += msm8953-lenovo-kuntao.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8953-motorola-potter.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8953-xiaomi-daisy.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8953-xiaomi-mido.dtb
> diff --git a/arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts b/arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts
> new file mode 100644
> index 000000000000..2fd6345bbe15
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts
> @@ -0,0 +1,240 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (C) 2024, Raihan Ahamed <raihan1999ahamed@gmail.com>
> + */
> +/dts-v1/;
> +
> +#include "msm8953.dtsi"
> +#include "pm8953.dtsi"
> +#include "pmi8950.dtsi"
> +
> +/delete-node/ &qseecom_mem;
> +
> +/ {
> + model = "Lenovo P2";
> + compatible = "lenovo,kuntao", "qcom,msm8953";
Missing bindings.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v2 1/2] dt-bindings: arm: qcom: Add Lenovo P2
2024-02-26 7:05 ` Krzysztof Kozlowski
@ 2024-02-26 9:41 ` Raihan Ahamed
2024-02-26 9:41 ` [PATCH v2 2/2] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree Raihan Ahamed
` (2 more replies)
0 siblings, 3 replies; 15+ messages in thread
From: Raihan Ahamed @ 2024-02-26 9:41 UTC (permalink / raw)
To: krzysztof.kozlowski+dt
Cc: raihan1999ahamed, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Conor Dooley, Kees Cook, Tony Luck, Guilherme G. Piccoli,
linux-arm-msm, devicetree, linux-kernel, linux-hardening
Document the compatible for the MSM8953-based Lenovo P2
smartphone released in 2016
Signed-off-by: Raihan Ahamed <raihan1999ahamed@gmail.com>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 1a5fb889a444..6cc19c8d116d 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -263,6 +263,7 @@ properties:
- items:
- enum:
+ - lenovo,kuntao
- motorola,potter
- xiaomi,daisy
- xiaomi,mido
--
2.43.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 2/2] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree
2024-02-26 9:41 ` [PATCH v2 1/2] dt-bindings: arm: qcom: Add Lenovo P2 Raihan Ahamed
@ 2024-02-26 9:41 ` Raihan Ahamed
2024-02-26 16:54 ` [PATCH v2 1/2] dt-bindings: arm: qcom: Add Lenovo P2 Rob Herring
2024-02-26 17:32 ` Krzysztof Kozlowski
2 siblings, 0 replies; 15+ messages in thread
From: Raihan Ahamed @ 2024-02-26 9:41 UTC (permalink / raw)
To: krzysztof.kozlowski+dt
Cc: raihan1999ahamed, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Conor Dooley, Kees Cook, Tony Luck, Guilherme G. Piccoli,
linux-arm-msm, devicetree, linux-kernel, linux-hardening
Lenovo P2 is a handset using the MSM8953 SoC released in 2016
Add a device tree with initial support for:
- GPIO keys
- SDHCI (internal and external storage)
- USB Device Mode
- WCNSS (WiFi/BT)
- Regulators
Signed-off-by: Raihan Ahamed <raihan1999ahamed@gmail.com>
---
arch/arm64/boot/dts/qcom/Makefile | 1 +
.../boot/dts/qcom/msm8953-lenovo-kuntao.dts | 240 ++++++++++++++++++
2 files changed, 241 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 39889d5f8e12..aebfb1ae728c 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -49,6 +49,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8939-huawei-kiwi.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8939-longcheer-l9100.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8939-samsung-a7.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8939-sony-xperia-kanuti-tulip.dtb
+dtb-$(CONFIG_ARCH_QCOM) += msm8953-lenovo-kuntao.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8953-motorola-potter.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8953-xiaomi-daisy.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8953-xiaomi-mido.dtb
diff --git a/arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts b/arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts
new file mode 100644
index 000000000000..2fd6345bbe15
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts
@@ -0,0 +1,240 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2024, Raihan Ahamed <raihan1999ahamed@gmail.com>
+ */
+/dts-v1/;
+
+#include "msm8953.dtsi"
+#include "pm8953.dtsi"
+#include "pmi8950.dtsi"
+
+/delete-node/ &qseecom_mem;
+
+/ {
+ model = "Lenovo P2";
+ compatible = "lenovo,kuntao", "qcom,msm8953";
+ chassis-type = "handset";
+ qcom,msm-id = <0x125 0x00>;
+ qcom,board-id = <0x41 0x82b1 0x41 0x83b0>;
+
+ gpio-keys {
+ compatible = "gpio-keys";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&gpio_key_default>;
+
+ key-volume-up {
+ label = "Volume Up";
+ gpios = <&tlmm 85 GPIO_ACTIVE_LOW>;
+ linux,code = <KEY_VOLUMEUP>;
+ debounce-interval = <15>;
+ };
+ };
+
+ reserved-memory {
+ qseecom_mem: qseecom@84a00000 {
+ reg = <0x0 0x84a00000 0x0 0x1900000>;
+ no-map;
+ };
+
+ ramoops@8ee00000 {
+ compatible = "ramoops";
+ reg = <0x0 0x8ee00000 0x0 0x80000>;
+ console-size = <0x40000>;
+ ftrace-size = <0x15000>;
+ record-size = <0x5000>;
+ pmsg-size = <0x2000>;
+ };
+ };
+
+ vph_pwr: vph-pwr-regulator {
+ compatible = "regulator-fixed";
+ regulator-name = "vph_pwr";
+ regulator-always-on;
+ regulator-boot-on;
+ };
+};
+
+&hsusb_phy {
+ vdd-supply = <&pm8953_l3>;
+ vdda-pll-supply = <&pm8953_l7>;
+ vdda-phy-dpdm-supply = <&pm8953_l13>;
+
+ status = "okay";
+};
+
+&pm8953_resin {
+ linux,code = <KEY_VOLUMEDOWN>;
+ status = "okay";
+};
+
+&rpm_requests {
+ regulators {
+ compatible = "qcom,rpm-pm8953-regulators";
+ vdd_s1-supply = <&vph_pwr>;
+ vdd_s2-supply = <&vph_pwr>;
+ vdd_s3-supply = <&vph_pwr>;
+ vdd_s4-supply = <&vph_pwr>;
+ vdd_s5-supply = <&vph_pwr>;
+ vdd_s6-supply = <&vph_pwr>;
+ vdd_s7-supply = <&vph_pwr>;
+ vdd_l1-supply = <&pm8953_s3>;
+ vdd_l2_l3-supply = <&pm8953_s3>;
+ vdd_l4_l5_l6_l7_l16_l19-supply = <&pm8953_s4>;
+ vdd_l8_l11_l12_l13_l14_l15-supply = <&vph_pwr>;
+ vdd_l9_l10_l17_l18_l22-supply = <&vph_pwr>;
+
+ pm8953_s1: s1 {
+ regulator-min-microvolt = <863000>;
+ regulator-max-microvolt = <1152000>;
+ };
+
+ pm8953_s3: s3 {
+ regulator-min-microvolt = <1224000>;
+ regulator-max-microvolt = <1224000>;
+ };
+
+ pm8953_s4: s4 {
+ regulator-min-microvolt = <1896000>;
+ regulator-max-microvolt = <2048000>;
+ };
+
+ pm8953_l1: l1 {
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1100000>;
+ };
+
+ pm8953_l2: l2 {
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1000000>;
+ };
+
+ pm8953_l3: l3 {
+ regulator-min-microvolt = <925000>;
+ regulator-max-microvolt = <925000>;
+ regulator-allow-set-load;
+ };
+
+ pm8953_l5: l5 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ pm8953_l6: l6 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ pm8953_l7: l7 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1900000>;
+ };
+
+ pm8953_l8: l8 {
+ regulator-min-microvolt = <2900000>;
+ regulator-max-microvolt = <2900000>;
+ };
+
+ pm8953_l9: l9 {
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ pm8953_l10: l10 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ pm8953_l11: l11 {
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <3000000>;
+ };
+
+ pm8953_l12: l12 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3000000>;
+ };
+
+ pm8953_l13: l13 {
+ regulator-min-microvolt = <3075000>;
+ regulator-max-microvolt = <3125000>;
+ };
+
+ pm8953_l15: l15 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ pm8953_l16: l16 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ pm8953_l17: l17 {
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <3000000>;
+ };
+
+ pm8953_l19: l19 {
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1350000>;
+ };
+
+ pm8953_l22: l22 {
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2850000>;
+ };
+
+ pm8953_l23: l23 {
+ regulator-min-microvolt = <975000>;
+ regulator-max-microvolt = <1225000>;
+ };
+ };
+};
+
+&sdhc_1 {
+ vmmc-supply = <&pm8953_l8>;
+ vqmmc-supply = <&pm8953_l5>;
+
+ status = "okay";
+};
+
+&sdhc_2 {
+ vmmc-supply = <&pm8953_l11>;
+ vqmmc-supply = <&pm8953_l12>;
+
+ cd-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>;
+
+ pinctrl-names = "default", "sleep";
+ pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_off>;
+ pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off &sdc2_cd_off>;
+
+ status = "okay";
+};
+
+&tlmm {
+ gpio-reserved-ranges = <0 4>, <135 4>;
+};
+
+&usb3 {
+ status = "okay";
+};
+
+&usb3_dwc3 {
+ dr_mode = "peripheral";
+};
+
+&wcnss {
+ vddpx-supply = <&pm8953_l5>;
+
+ status = "okay";
+};
+
+&wcnss_iris {
+ compatible = "qcom,wcn3660b";
+
+ vddxo-supply = <&pm8953_l7>;
+ vddrfa-supply = <&pm8953_l19>;
+ vddpa-supply = <&pm8953_l9>;
+ vdddig-supply = <&pm8953_l5>;
+};
--
2.43.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree
2024-02-26 5:55 [PATCH] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree Raihan Ahamed
2024-02-26 7:05 ` Krzysztof Kozlowski
@ 2024-02-26 16:54 ` Rob Herring
2024-02-27 5:40 ` Raihan Ahamed
[not found] ` <CANt1HJsbYJS5p5i+WWmfMWkD5aBU67gNx9_Fi838w9x3CUPZZQ@mail.gmail.com>
2024-02-26 19:54 ` [PATCH v3 1/2] dt-bindings: arm: qcom: Add Lenovo P2 Raihan Ahamed
2 siblings, 2 replies; 15+ messages in thread
From: Rob Herring @ 2024-02-26 16:54 UTC (permalink / raw)
To: Raihan Ahamed
Cc: Krzysztof Kozlowski, linux-arm-msm, Kees Cook, Rob Herring,
Konrad Dybcio, Guilherme G. Piccoli, Bjorn Andersson,
linux-hardening, linux-kernel, Conor Dooley, Tony Luck,
devicetree
On Mon, 26 Feb 2024 11:25:56 +0530, Raihan Ahamed wrote:
> Lenovo P2 is a handset using the MSM8953 SoC released in 2016
>
> Add a device tree for with initial support for:
>
> - GPIO keys
> - SDHCI (internal and external storage)
> - USB Device Mode
> - WCNSS (WiFi/BT)
> - Regulators
>
> Signed-off-by: Raihan Ahamed <raihan1999ahamed@gmail.com>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> .../boot/dts/qcom/msm8953-lenovo-kuntao.dts | 240 ++++++++++++++++++
> 2 files changed, 241 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts
>
My bot found new DT warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y qcom/msm8953-lenovo-kuntao.dtb' for 20240226055615.79195-1-raihan1999ahamed@gmail.com:
arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dtb: gpu@1c00000: clock-names:5: 'anyOf' conditional failed, one must be fixed:
'core' was expected
'iface' was expected
'mem' was expected
'mem_iface' was expected
'alt_mem_iface' was expected
'gfx3d' was expected
'rbbmtimer' was expected
'rbcpr' was expected
from schema $id: http://devicetree.org/schemas/display/msm/gpu.yaml#
arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dtb: iommu@1c48000: compatible: 'oneOf' conditional failed, one must be fixed:
'qcom,msm8953-iommu' is not one of ['qcom,msm8976-iommu']
'qcom,msm-iommu-v1' was expected
from schema $id: http://devicetree.org/schemas/iommu/qcom,iommu.yaml#
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: arm: qcom: Add Lenovo P2
2024-02-26 9:41 ` [PATCH v2 1/2] dt-bindings: arm: qcom: Add Lenovo P2 Raihan Ahamed
2024-02-26 9:41 ` [PATCH v2 2/2] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree Raihan Ahamed
@ 2024-02-26 16:54 ` Rob Herring
2024-02-26 17:32 ` Krzysztof Kozlowski
2 siblings, 0 replies; 15+ messages in thread
From: Rob Herring @ 2024-02-26 16:54 UTC (permalink / raw)
To: Raihan Ahamed
Cc: Kees Cook, Rob Herring, linux-kernel, Conor Dooley,
Guilherme G. Piccoli, Tony Luck, devicetree, linux-hardening,
krzysztof.kozlowski+dt, Konrad Dybcio, Bjorn Andersson,
linux-arm-msm
On Mon, 26 Feb 2024 15:11:03 +0530, Raihan Ahamed wrote:
> Document the compatible for the MSM8953-based Lenovo P2
>
> smartphone released in 2016
>
> Signed-off-by: Raihan Ahamed <raihan1999ahamed@gmail.com>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
My bot found new DT warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y qcom/msm8953-lenovo-kuntao.dtb' for 20240226094256.5736-1-raihan1999ahamed@gmail.com:
arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dtb: gpu@1c00000: clock-names:5: 'anyOf' conditional failed, one must be fixed:
'core' was expected
'iface' was expected
'mem' was expected
'mem_iface' was expected
'alt_mem_iface' was expected
'gfx3d' was expected
'rbbmtimer' was expected
'rbcpr' was expected
from schema $id: http://devicetree.org/schemas/display/msm/gpu.yaml#
arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dtb: iommu@1c48000: compatible: 'oneOf' conditional failed, one must be fixed:
'qcom,msm8953-iommu' is not one of ['qcom,msm8976-iommu']
'qcom,msm-iommu-v1' was expected
from schema $id: http://devicetree.org/schemas/iommu/qcom,iommu.yaml#
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: arm: qcom: Add Lenovo P2
2024-02-26 9:41 ` [PATCH v2 1/2] dt-bindings: arm: qcom: Add Lenovo P2 Raihan Ahamed
2024-02-26 9:41 ` [PATCH v2 2/2] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree Raihan Ahamed
2024-02-26 16:54 ` [PATCH v2 1/2] dt-bindings: arm: qcom: Add Lenovo P2 Rob Herring
@ 2024-02-26 17:32 ` Krzysztof Kozlowski
2 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-26 17:32 UTC (permalink / raw)
To: Raihan Ahamed, krzysztof.kozlowski+dt
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Conor Dooley,
Kees Cook, Tony Luck, Guilherme G. Piccoli, linux-arm-msm,
devicetree, linux-kernel, linux-hardening
On 26/02/2024 10:41, Raihan Ahamed wrote:
> Document the compatible for the MSM8953-based Lenovo P2
>
> smartphone released in 2016
It seems you split one sentence over multiple lines. Please join them
and finish with full stop.
Also, this appeared in some odd place. Do not attach (thread) your
patchsets to some other threads (unrelated or older versions). This
buries them deep in the mailbox and might interfere with applying entire
sets.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.
https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v3 1/2] dt-bindings: arm: qcom: Add Lenovo P2
2024-02-26 5:55 [PATCH] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree Raihan Ahamed
2024-02-26 7:05 ` Krzysztof Kozlowski
2024-02-26 16:54 ` [PATCH] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree Rob Herring
@ 2024-02-26 19:54 ` Raihan Ahamed
2024-02-26 19:54 ` [PATCH v3 2/2] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree Raihan Ahamed
2024-02-27 13:44 ` [PATCH v3 1/2] dt-bindings: arm: qcom: Add Lenovo P2 Rob Herring
2 siblings, 2 replies; 15+ messages in thread
From: Raihan Ahamed @ 2024-02-26 19:54 UTC (permalink / raw)
To: krzysztof.kozlowski+dt, robh+dt
Cc: raihan1999ahamed, Krzysztof Kozlowski, Bjorn Andersson,
Konrad Dybcio, Conor Dooley, Kees Cook, Tony Luck,
Guilherme G. Piccoli, linux-arm-msm, devicetree, linux-kernel,
linux-hardening
Document the compatible for the MSM8953-based Lenovo P2 smartphone released in 2016.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Raihan Ahamed <raihan1999ahamed@gmail.com>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 1a5fb889a444..6cc19c8d116d 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -263,6 +263,7 @@ properties:
- items:
- enum:
+ - lenovo,kuntao
- motorola,potter
- xiaomi,daisy
- xiaomi,mido
--
2.44.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3 2/2] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree
2024-02-26 19:54 ` [PATCH v3 1/2] dt-bindings: arm: qcom: Add Lenovo P2 Raihan Ahamed
@ 2024-02-26 19:54 ` Raihan Ahamed
2024-02-27 3:54 ` Rob Herring
2024-02-27 6:47 ` Krzysztof Kozlowski
2024-02-27 13:44 ` [PATCH v3 1/2] dt-bindings: arm: qcom: Add Lenovo P2 Rob Herring
1 sibling, 2 replies; 15+ messages in thread
From: Raihan Ahamed @ 2024-02-26 19:54 UTC (permalink / raw)
To: krzysztof.kozlowski+dt, robh+dt
Cc: raihan1999ahamed, Krzysztof Kozlowski, Bjorn Andersson,
Konrad Dybcio, Conor Dooley, Kees Cook, Tony Luck,
Guilherme G. Piccoli, linux-arm-msm, devicetree, linux-kernel,
linux-hardening
Lenovo P2 is a handset using the MSM8953 SoC released in 2016
Add a device tree with initial support for:
- GPIO keys
- SDHCI (internal and external storage)
- USB Device Mode
- WCNSS (WiFi/BT)
- Regulators
Acked-by: Rob Herring <robh+dt@kernel.org>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Raihan Ahamed <raihan1999ahamed@gmail.com>
---
arch/arm64/boot/dts/qcom/Makefile | 1 +
.../boot/dts/qcom/msm8953-lenovo-kuntao.dts | 240 ++++++++++++++++++
2 files changed, 241 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 39889d5f8e12..aebfb1ae728c 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -49,6 +49,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8939-huawei-kiwi.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8939-longcheer-l9100.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8939-samsung-a7.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8939-sony-xperia-kanuti-tulip.dtb
+dtb-$(CONFIG_ARCH_QCOM) += msm8953-lenovo-kuntao.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8953-motorola-potter.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8953-xiaomi-daisy.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8953-xiaomi-mido.dtb
diff --git a/arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts b/arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts
new file mode 100644
index 000000000000..2fd6345bbe15
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts
@@ -0,0 +1,240 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2024, Raihan Ahamed <raihan1999ahamed@gmail.com>
+ */
+/dts-v1/;
+
+#include "msm8953.dtsi"
+#include "pm8953.dtsi"
+#include "pmi8950.dtsi"
+
+/delete-node/ &qseecom_mem;
+
+/ {
+ model = "Lenovo P2";
+ compatible = "lenovo,kuntao", "qcom,msm8953";
+ chassis-type = "handset";
+ qcom,msm-id = <0x125 0x00>;
+ qcom,board-id = <0x41 0x82b1 0x41 0x83b0>;
+
+ gpio-keys {
+ compatible = "gpio-keys";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&gpio_key_default>;
+
+ key-volume-up {
+ label = "Volume Up";
+ gpios = <&tlmm 85 GPIO_ACTIVE_LOW>;
+ linux,code = <KEY_VOLUMEUP>;
+ debounce-interval = <15>;
+ };
+ };
+
+ reserved-memory {
+ qseecom_mem: qseecom@84a00000 {
+ reg = <0x0 0x84a00000 0x0 0x1900000>;
+ no-map;
+ };
+
+ ramoops@8ee00000 {
+ compatible = "ramoops";
+ reg = <0x0 0x8ee00000 0x0 0x80000>;
+ console-size = <0x40000>;
+ ftrace-size = <0x15000>;
+ record-size = <0x5000>;
+ pmsg-size = <0x2000>;
+ };
+ };
+
+ vph_pwr: vph-pwr-regulator {
+ compatible = "regulator-fixed";
+ regulator-name = "vph_pwr";
+ regulator-always-on;
+ regulator-boot-on;
+ };
+};
+
+&hsusb_phy {
+ vdd-supply = <&pm8953_l3>;
+ vdda-pll-supply = <&pm8953_l7>;
+ vdda-phy-dpdm-supply = <&pm8953_l13>;
+
+ status = "okay";
+};
+
+&pm8953_resin {
+ linux,code = <KEY_VOLUMEDOWN>;
+ status = "okay";
+};
+
+&rpm_requests {
+ regulators {
+ compatible = "qcom,rpm-pm8953-regulators";
+ vdd_s1-supply = <&vph_pwr>;
+ vdd_s2-supply = <&vph_pwr>;
+ vdd_s3-supply = <&vph_pwr>;
+ vdd_s4-supply = <&vph_pwr>;
+ vdd_s5-supply = <&vph_pwr>;
+ vdd_s6-supply = <&vph_pwr>;
+ vdd_s7-supply = <&vph_pwr>;
+ vdd_l1-supply = <&pm8953_s3>;
+ vdd_l2_l3-supply = <&pm8953_s3>;
+ vdd_l4_l5_l6_l7_l16_l19-supply = <&pm8953_s4>;
+ vdd_l8_l11_l12_l13_l14_l15-supply = <&vph_pwr>;
+ vdd_l9_l10_l17_l18_l22-supply = <&vph_pwr>;
+
+ pm8953_s1: s1 {
+ regulator-min-microvolt = <863000>;
+ regulator-max-microvolt = <1152000>;
+ };
+
+ pm8953_s3: s3 {
+ regulator-min-microvolt = <1224000>;
+ regulator-max-microvolt = <1224000>;
+ };
+
+ pm8953_s4: s4 {
+ regulator-min-microvolt = <1896000>;
+ regulator-max-microvolt = <2048000>;
+ };
+
+ pm8953_l1: l1 {
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1100000>;
+ };
+
+ pm8953_l2: l2 {
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1000000>;
+ };
+
+ pm8953_l3: l3 {
+ regulator-min-microvolt = <925000>;
+ regulator-max-microvolt = <925000>;
+ regulator-allow-set-load;
+ };
+
+ pm8953_l5: l5 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ pm8953_l6: l6 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ pm8953_l7: l7 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1900000>;
+ };
+
+ pm8953_l8: l8 {
+ regulator-min-microvolt = <2900000>;
+ regulator-max-microvolt = <2900000>;
+ };
+
+ pm8953_l9: l9 {
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ pm8953_l10: l10 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ pm8953_l11: l11 {
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <3000000>;
+ };
+
+ pm8953_l12: l12 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3000000>;
+ };
+
+ pm8953_l13: l13 {
+ regulator-min-microvolt = <3075000>;
+ regulator-max-microvolt = <3125000>;
+ };
+
+ pm8953_l15: l15 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ pm8953_l16: l16 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ pm8953_l17: l17 {
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <3000000>;
+ };
+
+ pm8953_l19: l19 {
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1350000>;
+ };
+
+ pm8953_l22: l22 {
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2850000>;
+ };
+
+ pm8953_l23: l23 {
+ regulator-min-microvolt = <975000>;
+ regulator-max-microvolt = <1225000>;
+ };
+ };
+};
+
+&sdhc_1 {
+ vmmc-supply = <&pm8953_l8>;
+ vqmmc-supply = <&pm8953_l5>;
+
+ status = "okay";
+};
+
+&sdhc_2 {
+ vmmc-supply = <&pm8953_l11>;
+ vqmmc-supply = <&pm8953_l12>;
+
+ cd-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>;
+
+ pinctrl-names = "default", "sleep";
+ pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_off>;
+ pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off &sdc2_cd_off>;
+
+ status = "okay";
+};
+
+&tlmm {
+ gpio-reserved-ranges = <0 4>, <135 4>;
+};
+
+&usb3 {
+ status = "okay";
+};
+
+&usb3_dwc3 {
+ dr_mode = "peripheral";
+};
+
+&wcnss {
+ vddpx-supply = <&pm8953_l5>;
+
+ status = "okay";
+};
+
+&wcnss_iris {
+ compatible = "qcom,wcn3660b";
+
+ vddxo-supply = <&pm8953_l7>;
+ vddrfa-supply = <&pm8953_l19>;
+ vddpa-supply = <&pm8953_l9>;
+ vdddig-supply = <&pm8953_l5>;
+};
--
2.44.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH v3 2/2] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree
2024-02-26 19:54 ` [PATCH v3 2/2] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree Raihan Ahamed
@ 2024-02-27 3:54 ` Rob Herring
2024-02-27 5:39 ` Raihan Ahamed
2024-02-27 6:47 ` Krzysztof Kozlowski
1 sibling, 1 reply; 15+ messages in thread
From: Rob Herring @ 2024-02-27 3:54 UTC (permalink / raw)
To: Raihan Ahamed
Cc: krzysztof.kozlowski+dt, Krzysztof Kozlowski, Bjorn Andersson,
Konrad Dybcio, Conor Dooley, Kees Cook, Tony Luck,
Guilherme G. Piccoli, linux-arm-msm, devicetree, linux-kernel,
linux-hardening
On Mon, Feb 26, 2024 at 1:56 PM Raihan Ahamed
<raihan1999ahamed@gmail.com> wrote:
>
> Lenovo P2 is a handset using the MSM8953 SoC released in 2016
>
> Add a device tree with initial support for:
>
> - GPIO keys
> - SDHCI (internal and external storage)
> - USB Device Mode
> - WCNSS (WiFi/BT)
> - Regulators
>
> Acked-by: Rob Herring <robh+dt@kernel.org>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
We gave no such tag. I'd suggest you go read what these mean.
Rob
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 2/2] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree
2024-02-27 3:54 ` Rob Herring
@ 2024-02-27 5:39 ` Raihan Ahamed
0 siblings, 0 replies; 15+ messages in thread
From: Raihan Ahamed @ 2024-02-27 5:39 UTC (permalink / raw)
To: Rob Herring
Cc: krzysztof.kozlowski+dt, Krzysztof Kozlowski, Bjorn Andersson,
Konrad Dybcio, Conor Dooley, Kees Cook, Tony Luck,
Guilherme G. Piccoli, linux-arm-msm, devicetree, linux-kernel,
linux-hardening
Sorry, I misunderstood the fact. Is it necessary to change the tags
only by sending another version?
On Tue, Feb 27, 2024 at 9:25 AM Rob Herring <robh+dt@kernel.org> wrote:
>
> On Mon, Feb 26, 2024 at 1:56 PM Raihan Ahamed
> <raihan1999ahamed@gmail.com> wrote:
> >
> > Lenovo P2 is a handset using the MSM8953 SoC released in 2016
> >
> > Add a device tree with initial support for:
> >
> > - GPIO keys
> > - SDHCI (internal and external storage)
> > - USB Device Mode
> > - WCNSS (WiFi/BT)
> > - Regulators
> >
> > Acked-by: Rob Herring <robh+dt@kernel.org>
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> We gave no such tag. I'd suggest you go read what these mean.
>
> Rob
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree
2024-02-26 16:54 ` [PATCH] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree Rob Herring
@ 2024-02-27 5:40 ` Raihan Ahamed
[not found] ` <CANt1HJsbYJS5p5i+WWmfMWkD5aBU67gNx9_Fi838w9x3CUPZZQ@mail.gmail.com>
1 sibling, 0 replies; 15+ messages in thread
From: Raihan Ahamed @ 2024-02-27 5:40 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, linux-arm-msm, Kees Cook, Rob Herring,
Konrad Dybcio, Guilherme G. Piccoli, Bjorn Andersson,
linux-hardening, linux-kernel, Conor Dooley, Tony Luck,
devicetree
I have checked with latest dtschema before sending version 3, it does
not give anything related to gpu and iommu.
On Mon, Feb 26, 2024 at 10:24 PM Rob Herring <robh@kernel.org> wrote:
>
>
> On Mon, 26 Feb 2024 11:25:56 +0530, Raihan Ahamed wrote:
> > Lenovo P2 is a handset using the MSM8953 SoC released in 2016
> >
> > Add a device tree for with initial support for:
> >
> > - GPIO keys
> > - SDHCI (internal and external storage)
> > - USB Device Mode
> > - WCNSS (WiFi/BT)
> > - Regulators
> >
> > Signed-off-by: Raihan Ahamed <raihan1999ahamed@gmail.com>
> > ---
> > arch/arm64/boot/dts/qcom/Makefile | 1 +
> > .../boot/dts/qcom/msm8953-lenovo-kuntao.dts | 240 ++++++++++++++++++
> > 2 files changed, 241 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dts
> >
>
>
> My bot found new DT warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
> pip3 install dtschema --upgrade
>
>
> New warnings running 'make CHECK_DTBS=y qcom/msm8953-lenovo-kuntao.dtb' for 20240226055615.79195-1-raihan1999ahamed@gmail.com:
>
> arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dtb: gpu@1c00000: clock-names:5: 'anyOf' conditional failed, one must be fixed:
> 'core' was expected
> 'iface' was expected
> 'mem' was expected
> 'mem_iface' was expected
> 'alt_mem_iface' was expected
> 'gfx3d' was expected
> 'rbbmtimer' was expected
> 'rbcpr' was expected
> from schema $id: http://devicetree.org/schemas/display/msm/gpu.yaml#
> arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dtb: iommu@1c48000: compatible: 'oneOf' conditional failed, one must be fixed:
> 'qcom,msm8953-iommu' is not one of ['qcom,msm8976-iommu']
> 'qcom,msm-iommu-v1' was expected
> from schema $id: http://devicetree.org/schemas/iommu/qcom,iommu.yaml#
>
>
>
>
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 2/2] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree
2024-02-26 19:54 ` [PATCH v3 2/2] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree Raihan Ahamed
2024-02-27 3:54 ` Rob Herring
@ 2024-02-27 6:47 ` Krzysztof Kozlowski
1 sibling, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-27 6:47 UTC (permalink / raw)
To: Raihan Ahamed, krzysztof.kozlowski+dt, robh+dt
Cc: Bjorn Andersson, Konrad Dybcio, Conor Dooley, Kees Cook,
Tony Luck, Guilherme G. Piccoli, linux-arm-msm, devicetree,
linux-kernel, linux-hardening
On 26/02/2024 20:54, Raihan Ahamed wrote:
> Lenovo P2 is a handset using the MSM8953 SoC released in 2016
>
> Add a device tree with initial support for:
>
> - GPIO keys
> - SDHCI (internal and external storage)
> - USB Device Mode
> - WCNSS (WiFi/BT)
> - Regulators
>
> Acked-by: Rob Herring <robh+dt@kernel.org>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
No, these did not happen!
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree
[not found] ` <CANt1HJsbYJS5p5i+WWmfMWkD5aBU67gNx9_Fi838w9x3CUPZZQ@mail.gmail.com>
@ 2024-02-27 7:08 ` Krzysztof Kozlowski
0 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-27 7:08 UTC (permalink / raw)
To: Raihan Ahamed, Rob Herring
Cc: Krzysztof Kozlowski, linux-arm-msm, Kees Cook, Rob Herring,
Konrad Dybcio, Guilherme G. Piccoli, Bjorn Andersson,
linux-hardening, linux-kernel, Conor Dooley, Tony Luck,
devicetree
On 27/02/2024 05:33, Raihan Ahamed wrote:
> I have checked again with latest dtschema before sending version 3 it
> doesn't give anything related to gpu and iommu
At least the second warning looks real, but the error was already there
- in the DTSI.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: arm: qcom: Add Lenovo P2
2024-02-26 19:54 ` [PATCH v3 1/2] dt-bindings: arm: qcom: Add Lenovo P2 Raihan Ahamed
2024-02-26 19:54 ` [PATCH v3 2/2] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree Raihan Ahamed
@ 2024-02-27 13:44 ` Rob Herring
1 sibling, 0 replies; 15+ messages in thread
From: Rob Herring @ 2024-02-27 13:44 UTC (permalink / raw)
To: Raihan Ahamed
Cc: Kees Cook, devicetree, Bjorn Andersson, robh+dt,
Guilherme G. Piccoli, linux-kernel, Krzysztof Kozlowski,
krzysztof.kozlowski+dt, linux-arm-msm, Conor Dooley,
Konrad Dybcio, Tony Luck, linux-hardening
On Tue, 27 Feb 2024 01:24:41 +0530, Raihan Ahamed wrote:
> Document the compatible for the MSM8953-based Lenovo P2 smartphone released in 2016.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Raihan Ahamed <raihan1999ahamed@gmail.com>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
My bot found new DT warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y qcom/msm8953-lenovo-kuntao.dtb' for 20240226195516.174737-1-raihan1999ahamed@gmail.com:
arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dtb: gpu@1c00000: clock-names:5: 'anyOf' conditional failed, one must be fixed:
'core' was expected
'iface' was expected
'mem' was expected
'mem_iface' was expected
'alt_mem_iface' was expected
'gfx3d' was expected
'rbbmtimer' was expected
'rbcpr' was expected
from schema $id: http://devicetree.org/schemas/display/msm/gpu.yaml#
arch/arm64/boot/dts/qcom/msm8953-lenovo-kuntao.dtb: iommu@1c48000: compatible: 'oneOf' conditional failed, one must be fixed:
'qcom,msm8953-iommu' is not one of ['qcom,msm8976-iommu']
'qcom,msm-iommu-v1' was expected
from schema $id: http://devicetree.org/schemas/iommu/qcom,iommu.yaml#
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2024-02-27 13:44 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-26 5:55 [PATCH] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree Raihan Ahamed
2024-02-26 7:05 ` Krzysztof Kozlowski
2024-02-26 9:41 ` [PATCH v2 1/2] dt-bindings: arm: qcom: Add Lenovo P2 Raihan Ahamed
2024-02-26 9:41 ` [PATCH v2 2/2] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree Raihan Ahamed
2024-02-26 16:54 ` [PATCH v2 1/2] dt-bindings: arm: qcom: Add Lenovo P2 Rob Herring
2024-02-26 17:32 ` Krzysztof Kozlowski
2024-02-26 16:54 ` [PATCH] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree Rob Herring
2024-02-27 5:40 ` Raihan Ahamed
[not found] ` <CANt1HJsbYJS5p5i+WWmfMWkD5aBU67gNx9_Fi838w9x3CUPZZQ@mail.gmail.com>
2024-02-27 7:08 ` Krzysztof Kozlowski
2024-02-26 19:54 ` [PATCH v3 1/2] dt-bindings: arm: qcom: Add Lenovo P2 Raihan Ahamed
2024-02-26 19:54 ` [PATCH v3 2/2] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree Raihan Ahamed
2024-02-27 3:54 ` Rob Herring
2024-02-27 5:39 ` Raihan Ahamed
2024-02-27 6:47 ` Krzysztof Kozlowski
2024-02-27 13:44 ` [PATCH v3 1/2] dt-bindings: arm: qcom: Add Lenovo P2 Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).