* [PATCH v1] mtd: rawnand: meson: fix scrambling mode value in command macro
@ 2024-02-10 21:45 Arseniy Krasnov
2024-02-26 10:45 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Arseniy Krasnov @ 2024-02-10 21:45 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
Yixun Lan, Jianxin Pan
Cc: oxffffaa, linux-mtd, linux-arm-kernel, linux-amlogic,
linux-kernel, kernel, Arseniy Krasnov, Stable
Scrambling mode is enabled by value (1 << 19). NFC_CMD_SCRAMBLER_ENABLE
is already (1 << 19), so there is no need to shift it again in CMDRWGEN
macro.
Signed-off-by: Arseniy Krasnov <avkrasnov@salutedevices.com>
Cc: <Stable@vger.kernel.org>
Fixes: 8fae856c5350 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
---
drivers/mtd/nand/raw/meson_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
index cdb58aca59c0..2a96a87cf79c 100644
--- a/drivers/mtd/nand/raw/meson_nand.c
+++ b/drivers/mtd/nand/raw/meson_nand.c
@@ -63,7 +63,7 @@
#define CMDRWGEN(cmd_dir, ran, bch, short_mode, page_size, pages) \
( \
(cmd_dir) | \
- ((ran) << 19) | \
+ (ran) | \
((bch) << 14) | \
((short_mode) << 13) | \
(((page_size) & 0x7f) << 6) | \
--
2.35.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] mtd: rawnand: meson: fix scrambling mode value in command macro
2024-02-10 21:45 [PATCH v1] mtd: rawnand: meson: fix scrambling mode value in command macro Arseniy Krasnov
@ 2024-02-26 10:45 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2024-02-26 10:45 UTC (permalink / raw)
To: Arseniy Krasnov, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, Yixun Lan, Jianxin Pan
Cc: oxffffaa, linux-mtd, linux-arm-kernel, linux-amlogic,
linux-kernel, kernel, Stable
On Sat, 2024-02-10 at 21:45:51 UTC, Arseniy Krasnov wrote:
> Scrambling mode is enabled by value (1 << 19). NFC_CMD_SCRAMBLER_ENABLE
> is already (1 << 19), so there is no need to shift it again in CMDRWGEN
> macro.
>
> Signed-off-by: Arseniy Krasnov <avkrasnov@salutedevices.com>
> Cc: <Stable@vger.kernel.org>
> Fixes: 8fae856c5350 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-26 10:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-10 21:45 [PATCH v1] mtd: rawnand: meson: fix scrambling mode value in command macro Arseniy Krasnov
2024-02-26 10:45 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).