* [PATCH] bus: mhi: host: pci_generic: constify modem_telit_fn980_hw_v1_config
@ 2024-02-23 2:00 Jeff Johnson
2024-02-26 11:44 ` Manivannan Sadhasivam
2024-02-26 11:47 ` Manivannan Sadhasivam
0 siblings, 2 replies; 3+ messages in thread
From: Jeff Johnson @ 2024-02-23 2:00 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: mhi, linux-arm-msm, linux-kernel, kernel, Jeff Johnson
MHI expects the controller configs to be const, and all of the other ones
in this file already are, so constify modem_telit_fn980_hw_v1_config.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
drivers/bus/mhi/host/pci_generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index cd6cd14b3d29..51639bfcfec7 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -538,7 +538,7 @@ static struct mhi_event_config mhi_telit_fn980_hw_v1_events[] = {
MHI_EVENT_CONFIG_HW_DATA(2, 2048, 101)
};
-static struct mhi_controller_config modem_telit_fn980_hw_v1_config = {
+static const struct mhi_controller_config modem_telit_fn980_hw_v1_config = {
.max_channels = 128,
.timeout_ms = 20000,
.num_channels = ARRAY_SIZE(mhi_telit_fn980_hw_v1_channels),
---
base-commit: 3ab6aff5793c3c7bdf6535d9b0024544a4abbdd5
change-id: 20240222-mhi-const-bus-mhi-host-pci_generic-5ddf8f13d35c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: mhi: host: pci_generic: constify modem_telit_fn980_hw_v1_config
2024-02-23 2:00 [PATCH] bus: mhi: host: pci_generic: constify modem_telit_fn980_hw_v1_config Jeff Johnson
@ 2024-02-26 11:44 ` Manivannan Sadhasivam
2024-02-26 11:47 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2024-02-26 11:44 UTC (permalink / raw)
To: Jeff Johnson; +Cc: mhi, linux-arm-msm, linux-kernel, kernel
On Thu, Feb 22, 2024 at 06:00:23PM -0800, Jeff Johnson wrote:
> MHI expects the controller configs to be const, and all of the other ones
> in this file already are, so constify modem_telit_fn980_hw_v1_config.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> drivers/bus/mhi/host/pci_generic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index cd6cd14b3d29..51639bfcfec7 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -538,7 +538,7 @@ static struct mhi_event_config mhi_telit_fn980_hw_v1_events[] = {
> MHI_EVENT_CONFIG_HW_DATA(2, 2048, 101)
> };
>
> -static struct mhi_controller_config modem_telit_fn980_hw_v1_config = {
> +static const struct mhi_controller_config modem_telit_fn980_hw_v1_config = {
> .max_channels = 128,
> .timeout_ms = 20000,
> .num_channels = ARRAY_SIZE(mhi_telit_fn980_hw_v1_channels),
>
> ---
> base-commit: 3ab6aff5793c3c7bdf6535d9b0024544a4abbdd5
> change-id: 20240222-mhi-const-bus-mhi-host-pci_generic-5ddf8f13d35c
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: mhi: host: pci_generic: constify modem_telit_fn980_hw_v1_config
2024-02-23 2:00 [PATCH] bus: mhi: host: pci_generic: constify modem_telit_fn980_hw_v1_config Jeff Johnson
2024-02-26 11:44 ` Manivannan Sadhasivam
@ 2024-02-26 11:47 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2024-02-26 11:47 UTC (permalink / raw)
To: Jeff Johnson; +Cc: mhi, linux-arm-msm, linux-kernel, kernel
On Thu, Feb 22, 2024 at 06:00:23PM -0800, Jeff Johnson wrote:
> MHI expects the controller configs to be const, and all of the other ones
> in this file already are, so constify modem_telit_fn980_hw_v1_config.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Applied to mhi-next!
- Mani
> ---
> drivers/bus/mhi/host/pci_generic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index cd6cd14b3d29..51639bfcfec7 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -538,7 +538,7 @@ static struct mhi_event_config mhi_telit_fn980_hw_v1_events[] = {
> MHI_EVENT_CONFIG_HW_DATA(2, 2048, 101)
> };
>
> -static struct mhi_controller_config modem_telit_fn980_hw_v1_config = {
> +static const struct mhi_controller_config modem_telit_fn980_hw_v1_config = {
> .max_channels = 128,
> .timeout_ms = 20000,
> .num_channels = ARRAY_SIZE(mhi_telit_fn980_hw_v1_channels),
>
> ---
> base-commit: 3ab6aff5793c3c7bdf6535d9b0024544a4abbdd5
> change-id: 20240222-mhi-const-bus-mhi-host-pci_generic-5ddf8f13d35c
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-26 11:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-23 2:00 [PATCH] bus: mhi: host: pci_generic: constify modem_telit_fn980_hw_v1_config Jeff Johnson
2024-02-26 11:44 ` Manivannan Sadhasivam
2024-02-26 11:47 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).