linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers: wave5: Remove unnecessary semicolons
@ 2024-02-13 14:04 Thorsten Blum
  2024-02-16 18:51 ` Nicolas Dufresne
  2024-02-26 13:33 ` Sebastian Fricke
  0 siblings, 2 replies; 3+ messages in thread
From: Thorsten Blum @ 2024-02-13 14:04 UTC (permalink / raw)
  To: Nas Chung, Jackson Lee
  Cc: Mauro Carvalho Chehab, linux-media, linux-kernel, Thorsten Blum

Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
semantic patch at scripts/coccinelle/misc/semicolon.cocci.

Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
---
 drivers/media/platform/chips-media/wave5/wave5-hw.c      | 2 +-
 drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/chips-media/wave5/wave5-hw.c b/drivers/media/platform/chips-media/wave5/wave5-hw.c
index f1e022fb148e..2d82791f575e 100644
--- a/drivers/media/platform/chips-media/wave5/wave5-hw.c
+++ b/drivers/media/platform/chips-media/wave5/wave5-hw.c
@@ -2315,7 +2315,7 @@ static bool wave5_vpu_enc_check_common_param_valid(struct vpu_instance *inst,
 				param->intra_refresh_mode);
 			return false;
 		}
-	};
+	}
 	return true;
 
 invalid_refresh_argument:
diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c b/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
index f29cfa3af94a..8bbf9d10b467 100644
--- a/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
+++ b/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
@@ -92,7 +92,7 @@ static int switch_state(struct vpu_instance *inst, enum vpu_instance_state state
 		break;
 	case VPU_INST_STATE_STOP:
 		break;
-	};
+	}
 
 	dev_dbg(inst->dev->dev, "Switch state from %s to %s.\n",
 		state_to_str(inst->state), state_to_str(state));
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: wave5: Remove unnecessary semicolons
  2024-02-13 14:04 [PATCH] drivers: wave5: Remove unnecessary semicolons Thorsten Blum
@ 2024-02-16 18:51 ` Nicolas Dufresne
  2024-02-26 13:33 ` Sebastian Fricke
  1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Dufresne @ 2024-02-16 18:51 UTC (permalink / raw)
  To: Thorsten Blum, Nas Chung, Jackson Lee
  Cc: Mauro Carvalho Chehab, linux-media, linux-kernel

Hi,

Le mardi 13 février 2024 à 15:04 +0100, Thorsten Blum a écrit :
> Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
> semantic patch at scripts/coccinelle/misc/semicolon.cocci.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>

Thanks for the fix.

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

> ---
>  drivers/media/platform/chips-media/wave5/wave5-hw.c      | 2 +-
>  drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/chips-media/wave5/wave5-hw.c b/drivers/media/platform/chips-media/wave5/wave5-hw.c
> index f1e022fb148e..2d82791f575e 100644
> --- a/drivers/media/platform/chips-media/wave5/wave5-hw.c
> +++ b/drivers/media/platform/chips-media/wave5/wave5-hw.c
> @@ -2315,7 +2315,7 @@ static bool wave5_vpu_enc_check_common_param_valid(struct vpu_instance *inst,
>  				param->intra_refresh_mode);
>  			return false;
>  		}
> -	};
> +	}
>  	return true;
>  
>  invalid_refresh_argument:
> diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c b/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
> index f29cfa3af94a..8bbf9d10b467 100644
> --- a/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
> +++ b/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
> @@ -92,7 +92,7 @@ static int switch_state(struct vpu_instance *inst, enum vpu_instance_state state
>  		break;
>  	case VPU_INST_STATE_STOP:
>  		break;
> -	};
> +	}
>  
>  	dev_dbg(inst->dev->dev, "Switch state from %s to %s.\n",
>  		state_to_str(inst->state), state_to_str(state));


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: wave5: Remove unnecessary semicolons
  2024-02-13 14:04 [PATCH] drivers: wave5: Remove unnecessary semicolons Thorsten Blum
  2024-02-16 18:51 ` Nicolas Dufresne
@ 2024-02-26 13:33 ` Sebastian Fricke
  1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Fricke @ 2024-02-26 13:33 UTC (permalink / raw)
  To: Thorsten Blum
  Cc: Nas Chung, Jackson Lee, Mauro Carvalho Chehab, linux-media, linux-kernel

Hey Thorsten,

Thanks for the patch, change looks obviously good, one small thing to
note for the future, the commit title should start with:

media: chips-media: wave5:

instead of:

drivers: wave5: 

I will change that myself this time, but please do a quick git log next
time to check how the path should be formatted for the driver.

Greetings,
Sebastian

On 13.02.2024 15:04, Thorsten Blum wrote:
>Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
>semantic patch at scripts/coccinelle/misc/semicolon.cocci.
>
>Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
>---
> drivers/media/platform/chips-media/wave5/wave5-hw.c      | 2 +-
> drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/media/platform/chips-media/wave5/wave5-hw.c b/drivers/media/platform/chips-media/wave5/wave5-hw.c
>index f1e022fb148e..2d82791f575e 100644
>--- a/drivers/media/platform/chips-media/wave5/wave5-hw.c
>+++ b/drivers/media/platform/chips-media/wave5/wave5-hw.c
>@@ -2315,7 +2315,7 @@ static bool wave5_vpu_enc_check_common_param_valid(struct vpu_instance *inst,
> 				param->intra_refresh_mode);
> 			return false;
> 		}
>-	};
>+	}
> 	return true;
>
> invalid_refresh_argument:
>diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c b/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
>index f29cfa3af94a..8bbf9d10b467 100644
>--- a/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
>+++ b/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
>@@ -92,7 +92,7 @@ static int switch_state(struct vpu_instance *inst, enum vpu_instance_state state
> 		break;
> 	case VPU_INST_STATE_STOP:
> 		break;
>-	};
>+	}
>
> 	dev_dbg(inst->dev->dev, "Switch state from %s to %s.\n",
> 		state_to_str(inst->state), state_to_str(state));
>-- 
>2.43.0
>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-26 13:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-13 14:04 [PATCH] drivers: wave5: Remove unnecessary semicolons Thorsten Blum
2024-02-16 18:51 ` Nicolas Dufresne
2024-02-26 13:33 ` Sebastian Fricke

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).