* [PATCH 0/3] Support intra-function call validation
@ 2024-02-26 9:49 Rui Qi
2024-02-26 9:49 ` [PATCH 1/3] objtool: is_fentry_call() crashes if call has no destination Rui Qi
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Rui Qi @ 2024-02-26 9:49 UTC (permalink / raw)
To: bp, mingo, tglx, hpa, jpoimboe, peterz, mbenes, gregkh, stable,
alexandre.chartre
Cc: x86, linux-kernel, Rui Qi
Since kernel version 5.4.250 LTS, there has been an issue with the kernel live patching feature becoming unavailable. When compiling the sample code for kernel live patching, the following message is displayed when enabled:
livepatch: klp_check_stack: kworker/u256:6:23490 has an unreliable stack
After investigation, it was found that this is due to objtool not supporting intra-function calls, resulting in incorrect orc entry generation.
This patchset adds support for intra-function calls, allowing the kernel live patching feature to work correctly.
Alexandre Chartre (2):
objtool: is_fentry_call() crashes if call has no destination
objtool: Add support for intra-function calls
Rui Qi (1):
x86/speculation: Support intra-function call validation
arch/x86/include/asm/nospec-branch.h | 7 ++
include/linux/frame.h | 11 ++++
.../Documentation/stack-validation.txt | 8 +++
tools/objtool/arch/x86/decode.c | 6 ++
tools/objtool/check.c | 64 +++++++++++++++++--
5 files changed, 91 insertions(+), 5 deletions(-)
--
2.39.2 (Apple Git-143)
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 1/3] objtool: is_fentry_call() crashes if call has no destination
2024-02-26 9:49 [PATCH 0/3] Support intra-function call validation Rui Qi
@ 2024-02-26 9:49 ` Rui Qi
2024-02-26 13:29 ` Greg KH
2024-02-26 9:49 ` [PATCH 2/3] objtool: Add support for intra-function calls Rui Qi
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Rui Qi @ 2024-02-26 9:49 UTC (permalink / raw)
To: bp, mingo, tglx, hpa, jpoimboe, peterz, mbenes, gregkh, stable,
alexandre.chartre
Cc: x86, linux-kernel
From: Alexandre Chartre <alexandre.chartre@oracle.com>
commit 87cf61fe848ca8ddf091548671e168f52e8a718e upstream.
Fix is_fentry_call() so that it works if a call has no destination
set (call_dest). This needs to be done in order to support intra-
function calls.
Signed-off-by: Alexandre Chartre <alexandre.chartre@oracle.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Link: https://lkml.kernel.org/r/20200414103618.12657-2-alexandre.chartre@oracle.com
---
tools/objtool/check.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index dfd67243faac..71a24fd46dbd 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -1367,7 +1367,7 @@ static int decode_sections(struct objtool_file *file)
static bool is_fentry_call(struct instruction *insn)
{
- if (insn->type == INSN_CALL &&
+ if (insn->type == INSN_CALL && insn->call_dest &&
insn->call_dest->type == STT_NOTYPE &&
!strcmp(insn->call_dest->name, "__fentry__"))
return true;
--
2.39.2 (Apple Git-143)
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 1/3] objtool: is_fentry_call() crashes if call has no destination
2024-02-26 9:49 ` [PATCH 1/3] objtool: is_fentry_call() crashes if call has no destination Rui Qi
@ 2024-02-26 13:29 ` Greg KH
0 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2024-02-26 13:29 UTC (permalink / raw)
To: Rui Qi
Cc: bp, mingo, tglx, hpa, jpoimboe, peterz, mbenes, stable,
alexandre.chartre, x86, linux-kernel
On Mon, Feb 26, 2024 at 05:49:23PM +0800, Rui Qi wrote:
> From: Alexandre Chartre <alexandre.chartre@oracle.com>
>
> commit 87cf61fe848ca8ddf091548671e168f52e8a718e upstream.
>
> Fix is_fentry_call() so that it works if a call has no destination
> set (call_dest). This needs to be done in order to support intra-
> function calls.
>
> Signed-off-by: Alexandre Chartre <alexandre.chartre@oracle.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Reviewed-by: Miroslav Benes <mbenes@suse.cz>
> Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
> Link: https://lkml.kernel.org/r/20200414103618.12657-2-alexandre.chartre@oracle.com
When you forward a patch on for inclusion, you too have to sign off on
it.
Please do so for all of these commits.
And we recieved a few different copies of this series, please resend a
v2 series so we know which one is the correct one to review.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/3] objtool: Add support for intra-function calls
2024-02-26 9:49 [PATCH 0/3] Support intra-function call validation Rui Qi
2024-02-26 9:49 ` [PATCH 1/3] objtool: is_fentry_call() crashes if call has no destination Rui Qi
@ 2024-02-26 9:49 ` Rui Qi
2024-02-26 9:49 ` [PATCH 3/3] x86/speculation: Support intra-function call validation Rui Qi
2024-02-26 11:33 ` [PATCH 0/3] " qirui
3 siblings, 0 replies; 10+ messages in thread
From: Rui Qi @ 2024-02-26 9:49 UTC (permalink / raw)
To: bp, mingo, tglx, hpa, jpoimboe, peterz, mbenes, gregkh, stable,
alexandre.chartre
Cc: x86, linux-kernel, Rui Qi
From: Alexandre Chartre <alexandre.chartre@oracle.com>
commit 8aa8eb2a8f5b3305a95f39957dd2b715fa668e21 upstream.
Change objtool to support intra-function calls. On x86, an intra-function
call is represented in objtool as a push onto the stack (of the return
address), and a jump to the destination address. That way the stack
information is correctly updated and the call flow is still accurate.
Signed-off-by: Alexandre Chartre <alexandre.chartre@oracle.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Link: https://lkml.kernel.org/r/20200414103618.12657-4-alexandre.chartre@oracle.com
Signed-off-by: Rui Qi <qirui.001@bytedance.com>
---
include/linux/frame.h | 11 ++++
.../Documentation/stack-validation.txt | 8 +++
tools/objtool/arch/x86/decode.c | 6 ++
tools/objtool/check.c | 62 +++++++++++++++++--
4 files changed, 83 insertions(+), 4 deletions(-)
diff --git a/include/linux/frame.h b/include/linux/frame.h
index 02d3ca2d9598..303cda600e56 100644
--- a/include/linux/frame.h
+++ b/include/linux/frame.h
@@ -15,9 +15,20 @@
static void __used __section(.discard.func_stack_frame_non_standard) \
*__func_stack_frame_non_standard_##func = func
+/*
+ * This macro indicates that the following intra-function call is valid.
+ * Any non-annotated intra-function call will cause objtool to issue a warning.
+ */
+#define ANNOTATE_INTRA_FUNCTION_CALL \
+ 999: \
+ .pushsection .discard.intra_function_calls; \
+ .long 999b; \
+ .popsection;
+
#else /* !CONFIG_STACK_VALIDATION */
#define STACK_FRAME_NON_STANDARD(func)
+#define ANNOTATE_INTRA_FUNCTION_CALL
#endif /* CONFIG_STACK_VALIDATION */
diff --git a/tools/objtool/Documentation/stack-validation.txt b/tools/objtool/Documentation/stack-validation.txt
index de094670050b..ee26bb382b70 100644
--- a/tools/objtool/Documentation/stack-validation.txt
+++ b/tools/objtool/Documentation/stack-validation.txt
@@ -290,6 +290,14 @@ they mean, and suggestions for how to fix them.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70646
+11. file.o: warning: unannotated intra-function call
+
+ This warning means that a direct call is done to a destination which
+ is not at the beginning of a function. If this is a legit call, you
+ can remove this warning by putting the ANNOTATE_INTRA_FUNCTION_CALL
+ directive right before the call.
+
+
If the error doesn't seem to make sense, it could be a bug in objtool.
Feel free to ask the objtool maintainer for help.
diff --git a/tools/objtool/arch/x86/decode.c b/tools/objtool/arch/x86/decode.c
index a62e032863a8..c3ff62c085c8 100644
--- a/tools/objtool/arch/x86/decode.c
+++ b/tools/objtool/arch/x86/decode.c
@@ -437,6 +437,12 @@ int arch_decode_instruction(struct elf *elf, struct section *sec,
case 0xe8:
*type = INSN_CALL;
+ /*
+ * For the impact on the stack, a CALL behaves like
+ * a PUSH of an immediate value (the return address).
+ */
+ op->src.type = OP_SRC_CONST;
+ op->dest.type = OP_DEST_PUSH;
break;
case 0xfc:
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 71a24fd46dbd..0fa414869f45 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -645,6 +645,7 @@ static int add_jump_destinations(struct objtool_file *file)
return 0;
}
+
/*
* Find the destination instructions for all calls.
*/
@@ -666,10 +667,7 @@ static int add_call_destinations(struct objtool_file *file)
dest_off);
if (!insn->call_dest && !insn->ignore) {
- WARN_FUNC("unsupported intra-function call",
- insn->sec, insn->offset);
- if (retpoline)
- WARN("If this is a retpoline, please patch it in with alternatives and annotate it with ANNOTATE_NOSPEC_ALTERNATIVE.");
+ WARN_FUNC("unannotated intra-function call", insn->sec, insn->offset);
return -1;
}
@@ -1291,6 +1289,58 @@ static int read_retpoline_hints(struct objtool_file *file)
return 0;
}
+
+static int read_intra_function_calls(struct objtool_file *file)
+{
+ struct instruction *insn;
+ struct section *sec;
+ struct rela *rela;
+
+ sec = find_section_by_name(file->elf, ".rela.discard.intra_function_calls");
+ if (!sec)
+ return 0;
+
+ list_for_each_entry(rela, &sec->rela_list, list) {
+ unsigned long dest_off;
+
+ if (rela->sym->type != STT_SECTION) {
+ WARN("unexpected relocation symbol type in %s",
+ sec->name);
+ return -1;
+ }
+
+ insn = find_insn(file, rela->sym->sec, rela->addend);
+ if (!insn) {
+ WARN("bad .discard.intra_function_call entry");
+ return -1;
+ }
+
+ if (insn->type != INSN_CALL) {
+ WARN_FUNC("intra_function_call not a direct call",
+ insn->sec, insn->offset);
+ return -1;
+ }
+
+ /*
+ * Treat intra-function CALLs as JMPs, but with a stack_op.
+ * See add_call_destinations(), which strips stack_ops from
+ * normal CALLs.
+ */
+ insn->type = INSN_JUMP_UNCONDITIONAL;
+
+ dest_off = insn->offset + insn->len + insn->immediate;
+ insn->jump_dest = find_insn(file, insn->sec, dest_off);
+ if (!insn->jump_dest) {
+ WARN_FUNC("can't find call dest at %s+0x%lx",
+ insn->sec, insn->offset,
+ insn->sec->name, dest_off);
+ return -1;
+ }
+ }
+
+ return 0;
+}
+
static void mark_rodata(struct objtool_file *file)
{
struct section *sec;
@@ -1346,6 +1396,10 @@ static int decode_sections(struct objtool_file *file)
if (ret)
return ret;
+ ret = read_intra_function_calls(file);
+ if (ret)
+ return ret;
+
ret = add_call_destinations(file);
if (ret)
return ret;
--
2.39.2 (Apple Git-143)
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 3/3] x86/speculation: Support intra-function call validation
2024-02-26 9:49 [PATCH 0/3] Support intra-function call validation Rui Qi
2024-02-26 9:49 ` [PATCH 1/3] objtool: is_fentry_call() crashes if call has no destination Rui Qi
2024-02-26 9:49 ` [PATCH 2/3] objtool: Add support for intra-function calls Rui Qi
@ 2024-02-26 9:49 ` Rui Qi
2024-02-26 11:33 ` [PATCH 0/3] " qirui
3 siblings, 0 replies; 10+ messages in thread
From: Rui Qi @ 2024-02-26 9:49 UTC (permalink / raw)
To: bp, mingo, tglx, hpa, jpoimboe, peterz, mbenes, gregkh, stable,
alexandre.chartre
Cc: x86, linux-kernel, Rui Qi
commit 8afd1c7da2b0 ("x86/speculation: Change FILL_RETURN_BUFFER
to work with objtool") does not support intra-function call
stack validation, which causes kernel live patching to fail.
This commit adds support for this, and after testing, the kernel
live patching feature is restored to normal.
Fixes: 8afd1c7da2b0 ("x86/speculation: Change FILL_RETURN_BUFFER to work with objtool")
Signed-off-by: Rui Qi <qirui.001@bytedance.com>
---
arch/x86/include/asm/nospec-branch.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/x86/include/asm/nospec-branch.h b/arch/x86/include/asm/nospec-branch.h
index c8819358a332..a88135c358c0 100644
--- a/arch/x86/include/asm/nospec-branch.h
+++ b/arch/x86/include/asm/nospec-branch.h
@@ -13,6 +13,8 @@
#include <asm/unwind_hints.h>
#include <asm/percpu.h>
+#include <linux/frame.h>
+#include <asm/unwind_hints.h>
/*
* This should be used immediately before a retpoline alternative. It tells
* objtool where the retpolines are so that it can make sense of the control
@@ -51,14 +53,18 @@
#define __FILL_RETURN_BUFFER(reg, nr, sp) \
mov $(nr/2), reg; \
771: \
+ ANNOTATE_INTRA_FUNCTION_CALL; \
call 772f; \
773: /* speculation trap */ \
+ UNWIND_HINT_EMPTY; \
pause; \
lfence; \
jmp 773b; \
772: \
+ ANNOTATE_INTRA_FUNCTION_CALL; \
call 774f; \
775: /* speculation trap */ \
+ UNWIND_HINT_EMPTY; \
pause; \
lfence; \
jmp 775b; \
@@ -152,6 +158,7 @@
.endm
.macro ISSUE_UNBALANCED_RET_GUARD
+ ANNOTATE_INTRA_FUNCTION_CALL;
call .Lunbalanced_ret_guard_\@
int3
.Lunbalanced_ret_guard_\@:
--
2.39.2 (Apple Git-143)
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 0/3] Support intra-function call validation
2024-02-26 9:49 [PATCH 0/3] Support intra-function call validation Rui Qi
` (2 preceding siblings ...)
2024-02-26 9:49 ` [PATCH 3/3] x86/speculation: Support intra-function call validation Rui Qi
@ 2024-02-26 11:33 ` qirui
2024-02-26 17:28 ` Josh Poimboeuf
3 siblings, 1 reply; 10+ messages in thread
From: qirui @ 2024-02-26 11:33 UTC (permalink / raw)
To: bp, mingo, tglx, hpa, jpoimboe, peterz, mbenes, gregkh, stable,
alexandre.chartre
Cc: x86, linux-kernel
This issue only occurs in 5.4 LTS versions after LTS 5.4.250 (inclusive), and this patchset is based on commit 6e1f54a4985b63bc1b55a09e5e75a974c5d6719b (Linux 5.4.269)
On 2/26/24 5:49 PM, Rui Qi wrote:
> Since kernel version 5.4.250 LTS, there has been an issue with the kernel live patching feature becoming unavailable. When compiling the sample code for kernel live patching, the following message is displayed when enabled:
>
> livepatch: klp_check_stack: kworker/u256:6:23490 has an unreliable stack
>
> After investigation, it was found that this is due to objtool not supporting intra-function calls, resulting in incorrect orc entry generation.
>
> This patchset adds support for intra-function calls, allowing the kernel live patching feature to work correctly.
>
> Alexandre Chartre (2):
> objtool: is_fentry_call() crashes if call has no destination
> objtool: Add support for intra-function calls
>
> Rui Qi (1):
> x86/speculation: Support intra-function call validation
>
> arch/x86/include/asm/nospec-branch.h | 7 ++
> include/linux/frame.h | 11 ++++
> .../Documentation/stack-validation.txt | 8 +++
> tools/objtool/arch/x86/decode.c | 6 ++
> tools/objtool/check.c | 64 +++++++++++++++++--
> 5 files changed, 91 insertions(+), 5 deletions(-)
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 0/3] Support intra-function call validation
2024-02-26 11:33 ` [PATCH 0/3] " qirui
@ 2024-02-26 17:28 ` Josh Poimboeuf
2024-02-28 2:50 ` [External] " Rui Qi
0 siblings, 1 reply; 10+ messages in thread
From: Josh Poimboeuf @ 2024-02-26 17:28 UTC (permalink / raw)
To: qirui
Cc: bp, mingo, tglx, hpa, jpoimboe, peterz, mbenes, gregkh, stable,
alexandre.chartre, x86, linux-kernel
On Mon, Feb 26, 2024 at 07:33:53PM +0800, qirui wrote:
> This issue only occurs in 5.4 LTS versions after LTS 5.4.250
> (inclusive), and this patchset is based on commit
> 6e1f54a4985b63bc1b55a09e5e75a974c5d6719b (Linux 5.4.269)
Does the bug also exist in mainline? If not, why?
--
Josh
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [External] Re: [PATCH 0/3] Support intra-function call validation
2024-02-26 17:28 ` Josh Poimboeuf
@ 2024-02-28 2:50 ` Rui Qi
0 siblings, 0 replies; 10+ messages in thread
From: Rui Qi @ 2024-02-28 2:50 UTC (permalink / raw)
To: Josh Poimboeuf
Cc: bp, mingo, tglx, hpa, jpoimboe, peterz, mbenes, gregkh, stable,
alexandre.chartre, x86, linux-kernel
I tested the mainline kernel v6.8-rc5 without this problem, as I said before, this problem only occurs in 5.4 LTS, to be precise, it can occur from v5.4.217, with CONFIG_RETPOLINE and CONFIG_LIVEPATCH enabled
BTW: The patch for V2 version has been sent out. We can discuss based on that. Thank you!
https://lore.kernel.org/stable/20240228024535.79980-1-qirui.001@bytedance.com/T/#t
On 2/27/24 1:28 AM, Josh Poimboeuf wrote:
> On Mon, Feb 26, 2024 at 07:33:53PM +0800, qirui wrote:
>> This issue only occurs in 5.4 LTS versions after LTS 5.4.250
>> (inclusive), and this patchset is based on commit
>> 6e1f54a4985b63bc1b55a09e5e75a974c5d6719b (Linux 5.4.269)
>
> Does the bug also exist in mainline? If not, why?
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 0/3] Support intra-function call validation
@ 2024-02-26 9:40 $(name)
0 siblings, 0 replies; 10+ messages in thread
From: $(name) @ 2024-02-26 9:40 UTC (permalink / raw)
To: bp, mingo, tglx, hpa, jpoimboe, peterz, mbenes, gregkh, stable,
alexandre.chartre
Cc: x86, linux-kernel, qirui.001
From: Rui Qi <qirui.001@bytedance.com>
Since kernel version 5.4.250 LTS, there has been an issue with the kernel live patching feature becoming unavailable. When compiling the sample code for kernel live patching, the following message is displayed when enabled:
livepatch: klp_check_stack: kworker/u256:6:23490 has an unreliable stack
After investigation, it was found that this is due to objtool not supporting intra-function calls, resulting in incorrect orc entry generation.
This patchset adds support for intra-function calls, allowing the kernel live patching feature to work correctly.
Alexandre Chartre (2):
objtool: is_fentry_call() crashes if call has no destination
objtool: Add support for intra-function calls
Rui Qi (1):
x86/speculation: Support intra-function call validation
arch/x86/include/asm/nospec-branch.h | 7 ++
include/linux/frame.h | 11 ++++
.../Documentation/stack-validation.txt | 8 +++
tools/objtool/arch/x86/decode.c | 6 ++
tools/objtool/check.c | 64 +++++++++++++++++--
5 files changed, 91 insertions(+), 5 deletions(-)
--
2.39.2 (Apple Git-143)
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 0/3] Support intra-function call validation
@ 2024-02-26 9:31 $(uname)
0 siblings, 0 replies; 10+ messages in thread
From: $(uname) @ 2024-02-26 9:31 UTC (permalink / raw)
To: bp, mingo, tglx, hpa, jpoimboe, peterz, mbenes, gregkh, stable,
alexandre.chartre
Cc: x86, linux-kernel, qirui.001
From: Rui Qi <qirui.001@bytedance.com>
Since kernel version 5.4.250 LTS, there has been an issue with the kernel live patching feature becoming unavailable. When compiling the sample code for kernel live patching, the following message is displayed when enabled:
livepatch: klp_check_stack: kworker/u256:6:23490 has an unreliable stack
After investigation, it was found that this is due to objtool not supporting intra-function calls, resulting in incorrect orc entry generation.
This patchset adds support for intra-function calls, allowing the kernel live patching feature to work correctly.
Alexandre Chartre (2):
objtool: is_fentry_call() crashes if call has no destination
objtool: Add support for intra-function calls
Rui Qi (1):
x86/speculation: Support intra-function call validation
arch/x86/include/asm/nospec-branch.h | 7 ++
include/linux/frame.h | 11 ++++
.../Documentation/stack-validation.txt | 8 +++
tools/objtool/arch/x86/decode.c | 6 ++
tools/objtool/check.c | 64 +++++++++++++++++--
5 files changed, 91 insertions(+), 5 deletions(-)
--
2.39.2 (Apple Git-143)
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2024-02-28 2:51 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-26 9:49 [PATCH 0/3] Support intra-function call validation Rui Qi
2024-02-26 9:49 ` [PATCH 1/3] objtool: is_fentry_call() crashes if call has no destination Rui Qi
2024-02-26 13:29 ` Greg KH
2024-02-26 9:49 ` [PATCH 2/3] objtool: Add support for intra-function calls Rui Qi
2024-02-26 9:49 ` [PATCH 3/3] x86/speculation: Support intra-function call validation Rui Qi
2024-02-26 11:33 ` [PATCH 0/3] " qirui
2024-02-26 17:28 ` Josh Poimboeuf
2024-02-28 2:50 ` [External] " Rui Qi
-- strict thread matches above, loose matches on Subject: below --
2024-02-26 9:40 $(name)
2024-02-26 9:31 $(uname)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).