* [PATCH] ASoC: Intel: bytcr_rt5640: Add an extra entry for the Chuwi Vi8 tablet The bios version can differ depending if it is a dual-boot variant of the tablet. Therefore another DMI match is required
@ 2024-02-27 22:25 Alban Boyé
2024-02-28 8:56 ` Cezary Rojewski
0 siblings, 1 reply; 2+ messages in thread
From: Alban Boyé @ 2024-02-27 22:25 UTC (permalink / raw)
To: cezary.rojewski, pierre-louis.bossart, broonie, linux-sound,
linux-kernel
Cc: Alban Boyé
Signed-off-by: Alban Boyé <alban.boye@protonmail.com>
---
sound/soc/intel/boards/bytcr_rt5640.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
index 03be5e26ec4a..05f38d1f7d82 100644
--- a/sound/soc/intel/boards/bytcr_rt5640.c
+++ b/sound/soc/intel/boards/bytcr_rt5640.c
@@ -685,6 +685,18 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
BYT_RT5640_SSP0_AIF1 |
BYT_RT5640_MCLK_EN),
},
+ { /* Chuwi Vi8 dual-boot (CWI506) */
+ .matches = {
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Insyde"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "i86"),
+ /* The above are too generic, also match BIOS info */
+ DMI_MATCH(DMI_BIOS_VERSION, "CHUWI2.D86JHBNR02"),
+ },
+ .driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
+ BYT_RT5640_MONO_SPEAKER |
+ BYT_RT5640_SSP0_AIF1 |
+ BYT_RT5640_MCLK_EN),
+ },
{
/* Chuwi Vi10 (CWI505) */
.matches = {
--
2.43.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: Intel: bytcr_rt5640: Add an extra entry for the Chuwi Vi8 tablet The bios version can differ depending if it is a dual-boot variant of the tablet. Therefore another DMI match is required
2024-02-27 22:25 [PATCH] ASoC: Intel: bytcr_rt5640: Add an extra entry for the Chuwi Vi8 tablet The bios version can differ depending if it is a dual-boot variant of the tablet. Therefore another DMI match is required Alban Boyé
@ 2024-02-28 8:56 ` Cezary Rojewski
0 siblings, 0 replies; 2+ messages in thread
From: Cezary Rojewski @ 2024-02-28 8:56 UTC (permalink / raw)
To: Alban Boyé,
pierre-louis.bossart, broonie, linux-sound, linux-kernel
On 2024-02-27 11:25 PM, Alban Boyé wrote:
> Signed-off-by: Alban Boyé <alban.boye@protonmail.com>
I believe commit title and message became one. Please split them up and
resend your patch.
Whenever sending updates, increment the patch revision. What I'm reading
right now is in fact "PATCH v2" given you've added Signed-off tag after
Mark's review. The follow up should read: PATCH v3.
> ---
> sound/soc/intel/boards/bytcr_rt5640.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
> index 03be5e26ec4a..05f38d1f7d82 100644
> --- a/sound/soc/intel/boards/bytcr_rt5640.c
> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
> @@ -685,6 +685,18 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
> BYT_RT5640_SSP0_AIF1 |
> BYT_RT5640_MCLK_EN),
> },
> + { /* Chuwi Vi8 dual-boot (CWI506) */
> + .matches = {
> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Insyde"),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "i86"),
> + /* The above are too generic, also match BIOS info */
> + DMI_MATCH(DMI_BIOS_VERSION, "CHUWI2.D86JHBNR02"),
> + },
> + .driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
> + BYT_RT5640_MONO_SPEAKER |
> + BYT_RT5640_SSP0_AIF1 |
> + BYT_RT5640_MCLK_EN),
> + },
> {
> /* Chuwi Vi10 (CWI505) */
> .matches = {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-28 8:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-27 22:25 [PATCH] ASoC: Intel: bytcr_rt5640: Add an extra entry for the Chuwi Vi8 tablet The bios version can differ depending if it is a dual-boot variant of the tablet. Therefore another DMI match is required Alban Boyé
2024-02-28 8:56 ` Cezary Rojewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).