From: Stefan Berger <stefanb@linux.ibm.com>
To: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
herbert@gondor.apana.org.au, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org, saulo.alessandre@tse.jus.br,
lukas@wunner.de, Stefan Berger <stefanb@linux.ibm.com>
Subject: [PATCH v5 02/12] crypto: ecdsa - Adjust tests on length of key parameters
Date: Wed, 6 Mar 2024 17:22:47 -0500 [thread overview]
Message-ID: <20240306222257.979304-3-stefanb@linux.ibm.com> (raw)
In-Reply-To: <20240306222257.979304-1-stefanb@linux.ibm.com>
In preparation for support of NIST P521, adjust the basic tests on the
length of the provided key parameters to only ensure that the length of the
x plus y coordinates parameter array is not an odd number and that each
coordinate fits into an array of 'ndigits' digits. Mathematical tests on
the key's parameters are then done in ecc_is_pubkey_valid_full rejecting
invalid keys.
The change is necessary since NIST P521 keys do not have keys with
coordinates that each fully require 'full' digits (= u64), unlike
NIST P192/256/384 that all require multiple 'full' digits.
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Tested-by: Lukas Wunner <lukas@wunner.de>
---
crypto/ecdsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/ecdsa.c b/crypto/ecdsa.c
index 6653dec17327..64e1e69d53ba 100644
--- a/crypto/ecdsa.c
+++ b/crypto/ecdsa.c
@@ -230,7 +230,7 @@ static int ecdsa_set_pub_key(struct crypto_akcipher *tfm, const void *key, unsig
if (ret < 0)
return ret;
- if (keylen < 1 || (((keylen - 1) >> 1) % sizeof(u64)) != 0)
+ if (keylen < 1 || ((keylen - 1) & 1) != 0)
return -EINVAL;
/* we only accept uncompressed format indicated by '4' */
if (d[0] != 4)
--
2.43.0
next prev parent reply other threads:[~2024-03-06 22:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 22:22 [PATCH v4 00/12] Add support for NIST P521 to ecdsa Stefan Berger
2024-03-06 22:22 ` [PATCH v5 01/12] crypto: ecdsa - Convert byte arrays with key coordinates to digits Stefan Berger
2024-03-08 8:41 ` Lukas Wunner
2024-03-08 12:11 ` Stefan Berger
2024-03-06 22:22 ` Stefan Berger [this message]
2024-03-06 22:22 ` [PATCH v5 03/12] crypto: ecdsa - Extend res.x mod n calculation for NIST P521 Stefan Berger
2024-03-06 22:22 ` [PATCH v5 04/12] crypto: ecc - Add nbits field to ecc_curve structure Stefan Berger
2024-03-06 22:22 ` [PATCH v5 05/12] crypto: ecc - Implement vli_mmod_fast_521 for NIST p521 Stefan Berger
2024-03-07 19:11 ` Jarkko Sakkinen
2024-03-07 20:37 ` Stefan Berger
2024-03-11 5:07 ` [EXTERNAL] " Bharat Bhushan
2024-03-11 14:03 ` Stefan Berger
2024-03-11 16:11 ` [EXTERNAL] " Bharat Bhushan
2024-03-06 22:22 ` [PATCH v5 06/12] crypto: ecc - Add special case for NIST P521 in ecc_point_mult Stefan Berger
2024-03-06 22:22 ` [PATCH v5 07/12] crypto: ecc - Add NIST P521 curve parameters Stefan Berger
2024-03-06 22:22 ` [PATCH v5 08/12] crypto: ecdsa - Replace ndigits with nbits where precision is needed Stefan Berger
2024-03-06 22:22 ` [PATCH v5 09/12] crypto: ecdsa - Rename keylen to bufsize where necessary Stefan Berger
2024-03-07 19:13 ` Jarkko Sakkinen
2024-03-07 19:20 ` Stefan Berger
2024-03-08 7:48 ` Vitaly Chikunov
2024-03-06 22:22 ` [PATCH v5 10/12] crypto: ecdsa - Register NIST P521 and extend test suite Stefan Berger
2024-03-06 22:22 ` [PATCH v5 11/12] crypto: asymmetric_keys - Adjust signature size calculation for NIST P521 Stefan Berger
2024-03-06 22:22 ` [PATCH v5 12/12] crypto: x509 - Add OID for NIST P521 and extend parser for it Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240306222257.979304-3-stefanb@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=saulo.alessandre@tse.jus.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).