From: Stefan Berger <stefanb@linux.ibm.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
herbert@gondor.apana.org.au, davem@davemloft.net,
linux-kernel@vger.kernel.org, saulo.alessandre@tse.jus.br
Subject: Re: [PATCH v5 01/12] crypto: ecdsa - Convert byte arrays with key coordinates to digits
Date: Fri, 8 Mar 2024 07:11:22 -0500 [thread overview]
Message-ID: <eedf397f-24c6-4ee6-96b4-67f52c0ef8f4@linux.ibm.com> (raw)
In-Reply-To: <ZerPU6pJiosjOvDq@wunner.de>
On 3/8/24 03:41, Lukas Wunner wrote:
> On Wed, Mar 06, 2024 at 05:22:46PM -0500, Stefan Berger wrote:
>> +static inline void ecc_digits_from_bytes(const u8 *in, unsigned int nbytes,
>> + u64 *out, unsigned int ndigits)
>> +{
>> + unsigned int o = nbytes & 7;
>> + u64 msd = 0;
>
> My sincere apologies, I made a mistake when I proposed this:
> It needs to be __be64 instead of u64...
>
>> +
>> + if (o) {
>> + memcpy((u8 *)&msd + sizeof(msd) - o, in, o);
>> + out[--ndigits] = be64_to_cpu(msd);
>> + in += o;
>> + }
>
> ...otherwise sparse complains:
>
> crypto/ecdsa.c: note: in included file:
> >> include/crypto/internal/ecc.h:74:34: sparse: sparse: cast to restricted __be64
> >> include/crypto/internal/ecc.h:74:34: sparse: sparse: cast to restricted __be64
> [...]
> 66 static inline void ecc_digits_from_bytes(const u8 *in, unsigned int nbytes,
> 67 u64 *out, unsigned int ndigits)
> 68 {
> 69 unsigned int o = nbytes & 7;
> 70 u64 msd = 0;
> 71
> 72 if (o) {
> 73 memcpy((u8 *)&msd + sizeof(msd) - o, in, o);
> > 74 out[--ndigits] = be64_to_cpu(msd);
> 75 in += o;
> 76 }
> 77 ecc_swap_digits(in, out, ndigits);
> 78 }
> 79
>
> 0-day alerted me about this, it's monitoring my GitHub repo and
> I've got your patches on one of my development branches.
Thanks. Fixed.
>
> Thanks,
>
> Lukas
>
next prev parent reply other threads:[~2024-03-08 12:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 22:22 [PATCH v4 00/12] Add support for NIST P521 to ecdsa Stefan Berger
2024-03-06 22:22 ` [PATCH v5 01/12] crypto: ecdsa - Convert byte arrays with key coordinates to digits Stefan Berger
2024-03-08 8:41 ` Lukas Wunner
2024-03-08 12:11 ` Stefan Berger [this message]
2024-03-06 22:22 ` [PATCH v5 02/12] crypto: ecdsa - Adjust tests on length of key parameters Stefan Berger
2024-03-06 22:22 ` [PATCH v5 03/12] crypto: ecdsa - Extend res.x mod n calculation for NIST P521 Stefan Berger
2024-03-06 22:22 ` [PATCH v5 04/12] crypto: ecc - Add nbits field to ecc_curve structure Stefan Berger
2024-03-06 22:22 ` [PATCH v5 05/12] crypto: ecc - Implement vli_mmod_fast_521 for NIST p521 Stefan Berger
2024-03-07 19:11 ` Jarkko Sakkinen
2024-03-07 20:37 ` Stefan Berger
2024-03-11 5:07 ` [EXTERNAL] " Bharat Bhushan
2024-03-11 14:03 ` Stefan Berger
2024-03-11 16:11 ` [EXTERNAL] " Bharat Bhushan
2024-03-06 22:22 ` [PATCH v5 06/12] crypto: ecc - Add special case for NIST P521 in ecc_point_mult Stefan Berger
2024-03-06 22:22 ` [PATCH v5 07/12] crypto: ecc - Add NIST P521 curve parameters Stefan Berger
2024-03-06 22:22 ` [PATCH v5 08/12] crypto: ecdsa - Replace ndigits with nbits where precision is needed Stefan Berger
2024-03-06 22:22 ` [PATCH v5 09/12] crypto: ecdsa - Rename keylen to bufsize where necessary Stefan Berger
2024-03-07 19:13 ` Jarkko Sakkinen
2024-03-07 19:20 ` Stefan Berger
2024-03-08 7:48 ` Vitaly Chikunov
2024-03-06 22:22 ` [PATCH v5 10/12] crypto: ecdsa - Register NIST P521 and extend test suite Stefan Berger
2024-03-06 22:22 ` [PATCH v5 11/12] crypto: asymmetric_keys - Adjust signature size calculation for NIST P521 Stefan Berger
2024-03-06 22:22 ` [PATCH v5 12/12] crypto: x509 - Add OID for NIST P521 and extend parser for it Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eedf397f-24c6-4ee6-96b4-67f52c0ef8f4@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=saulo.alessandre@tse.jus.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).