From: Umang Jain <umang.jain@ideasonboard.com>
To: linux-media@vger.kernel.org
Cc: Alexander Shiyan <eagle.alexander923@gmail.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
open list <linux-kernel@vger.kernel.org>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Umang Jain <umang.jain@ideasonboard.com>
Subject: [PATCH v2 4/6] media: imx335: Use integer values for size registers
Date: Fri, 8 Mar 2024 14:03:10 +0530 [thread overview]
Message-ID: <20240308083312.90279-5-umang.jain@ideasonboard.com> (raw)
In-Reply-To: <20240308083312.90279-1-umang.jain@ideasonboard.com>
Consider integer values for registers that are related to various
sizes in the register map. This helps in improving the overall
readability.
No functional changes intended in this patch.
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
---
drivers/media/i2c/imx335.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c
index ec27035586f3..3c593538f727 100644
--- a/drivers/media/i2c/imx335.c
+++ b/drivers/media/i2c/imx335.c
@@ -250,12 +250,12 @@ static const struct cci_reg_sequence mode_2592x1940_regs[] = {
{IMX335_REG_MODE_SELECT, 0x01},
{IMX335_REG_MASTER_MODE, 0x00},
{IMX335_REG_WINMODE, 0x04},
- {IMX335_REG_HTRIMMING_START, 0x0180},
- {IMX335_REG_HNUM, 0x0a20},
- {IMX335_REG_Y_OUT_SIZE, 0x0794},
- {IMX335_REG_AREA3_ST_ADR_1, 0x00b0},
- {IMX335_REG_AREA3_WIDTH_1, 0x0f58},
- {IMX335_REG_OPB_SIZE_V, 0x00},
+ {IMX335_REG_HTRIMMING_START, 384},
+ {IMX335_REG_HNUM, 2592},
+ {IMX335_REG_Y_OUT_SIZE, 1940},
+ {IMX335_REG_AREA3_ST_ADR_1, 176},
+ {IMX335_REG_AREA3_WIDTH_1, 3928},
+ {IMX335_REG_OPB_SIZE_V, 0},
{IMX335_REG_XVS_XHS_DRV, 0x00},
{CCI_REG8(0x3288), 0x21}, /* undocumented */
{CCI_REG8(0x328a), 0x02}, /* undocumented */
--
2.43.0
next prev parent reply other threads:[~2024-03-08 8:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 8:33 [PATCH v2 0/6] media: imx335: 2/4 lane ops and improvements Umang Jain
2024-03-08 8:33 ` [PATCH v2 1/6] media: imx335: Support 2 or 4 lane operation modes Umang Jain
2024-03-08 10:42 ` Tommaso Merciai
2024-03-08 8:33 ` [PATCH v2 2/6] media: imx335: Parse fwnode properties Umang Jain
2024-03-08 10:56 ` Tommaso Merciai
2024-03-19 5:33 ` Umang Jain
2024-03-08 8:33 ` [PATCH v2 3/6] media: imx335: Use V4L2 CCI for accessing sensor registers Umang Jain
2024-03-08 8:33 ` Umang Jain [this message]
2024-03-08 11:08 ` [PATCH v2 4/6] media: imx335: Use integer values for size registers Tommaso Merciai
2024-03-08 8:33 ` [PATCH v2 5/6] media: imx335: Fix active area height discrepency Umang Jain
2024-03-08 8:33 ` [PATCH v2 6/6] media: imx335: Limit analogue gain value Umang Jain
2024-03-08 11:25 ` Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240308083312.90279-5-umang.jain@ideasonboard.com \
--to=umang.jain@ideasonboard.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=eagle.alexander923@gmail.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).