From: Tommaso Merciai <tomm.merciai@gmail.com>
To: Umang Jain <umang.jain@ideasonboard.com>
Cc: linux-media@vger.kernel.org,
Alexander Shiyan <eagle.alexander923@gmail.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
open list <linux-kernel@vger.kernel.org>,
Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH v2 6/6] media: imx335: Limit analogue gain value
Date: Fri, 8 Mar 2024 12:25:05 +0100 [thread overview]
Message-ID: <Zer1kQvdA+Nf9KG1@tom-HP-ZBook-Fury-15-G7-Mobile-Workstation> (raw)
In-Reply-To: <20240308083312.90279-7-umang.jain@ideasonboard.com>
Hi Umang,
On Fri, Mar 08, 2024 at 02:03:12PM +0530, Umang Jain wrote:
> The sensor gain (both analog and digital) are controlled by a
> single gain value where:
> - 0dB to 30dB correspond to analog gain
> - 30.3dB to 72dB correspond to digital gain
> (with 0.3dB step)
>
> Hence, limit the analogue gain value to 100.
> For digital gain, support can be added later if needed.
>
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
> drivers/media/i2c/imx335.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c
> index 85cb53e3d5d4..cc59f446cd09 100644
> --- a/drivers/media/i2c/imx335.c
> +++ b/drivers/media/i2c/imx335.c
> @@ -53,7 +53,7 @@
> /* Analog gain control */
> #define IMX335_REG_AGAIN CCI_REG8(0x30e8)
> #define IMX335_AGAIN_MIN 0
> -#define IMX335_AGAIN_MAX 240
> +#define IMX335_AGAIN_MAX 100
> #define IMX335_AGAIN_STEP 1
> #define IMX335_AGAIN_DEFAULT 0
>
> @@ -1174,6 +1174,14 @@ static int imx335_init_controls(struct imx335 *imx335)
> IMX335_EXPOSURE_STEP,
> IMX335_EXPOSURE_DEFAULT);
>
> + /*
> + * The sensor has an analog gain and a digital gain, both controlled
> + * through a single gain value, expressed in 0.3dB increments. Values
> + * from 0.0dB (0) to 30.0dB (100) apply analog gain only, higher values
> + * up to 72.0dB (240) add further digital gain. Limit the range to
> + * analog gain only, support for digital gain can be added separately
> + * if needed.
> + */
> imx335->again_ctrl = v4l2_ctrl_new_std(ctrl_hdlr,
> &imx335_ctrl_ops,
> V4L2_CID_ANALOGUE_GAIN,
> --
> 2.43.0
>
>
Unfortunately I don't have the datasheet of this sensor but the logic
behind this patch looks good to me. :)
Btw I check the datasheet of IMX323LQN-C and the gain controll logic
it's pretty similar except for the values in dB (different sensor).
Hope this help.
Reviewed-by: Tommaso Merciai <tomm.merciai@gmail.com>
Thanks & Regards,
Tommaso
prev parent reply other threads:[~2024-03-08 11:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 8:33 [PATCH v2 0/6] media: imx335: 2/4 lane ops and improvements Umang Jain
2024-03-08 8:33 ` [PATCH v2 1/6] media: imx335: Support 2 or 4 lane operation modes Umang Jain
2024-03-08 10:42 ` Tommaso Merciai
2024-03-08 8:33 ` [PATCH v2 2/6] media: imx335: Parse fwnode properties Umang Jain
2024-03-08 10:56 ` Tommaso Merciai
2024-03-19 5:33 ` Umang Jain
2024-03-08 8:33 ` [PATCH v2 3/6] media: imx335: Use V4L2 CCI for accessing sensor registers Umang Jain
2024-03-08 8:33 ` [PATCH v2 4/6] media: imx335: Use integer values for size registers Umang Jain
2024-03-08 11:08 ` Tommaso Merciai
2024-03-08 8:33 ` [PATCH v2 5/6] media: imx335: Fix active area height discrepency Umang Jain
2024-03-08 8:33 ` [PATCH v2 6/6] media: imx335: Limit analogue gain value Umang Jain
2024-03-08 11:25 ` Tommaso Merciai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zer1kQvdA+Nf9KG1@tom-HP-ZBook-Fury-15-G7-Mobile-Workstation \
--to=tomm.merciai@gmail.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=eagle.alexander923@gmail.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).