linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH][next] dmaengine: pch_dma: remove unused function chan2parent
@ 2024-03-08 13:47 Colin Ian King
  2024-04-07 16:39 ` Vinod Koul
  0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2024-03-08 13:47 UTC (permalink / raw)
  To: Vinod Koul, dmaengine; +Cc: kernel-janitors, linux-kernel

The helper function chan2parent is not used and has never been
used since the first commit to the code back in 2010. The function
is redundant and can be removed.

Cleans up clang scan build warning:
drivers/dma/pch_dma.c:158:30: warning: unused function 'chan2parent' [-Wunused-function]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/dma/pch_dma.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
index c359decc07a3..6b2793b07694 100644
--- a/drivers/dma/pch_dma.c
+++ b/drivers/dma/pch_dma.c
@@ -155,11 +155,6 @@ static inline struct device *chan2dev(struct dma_chan *chan)
 	return &chan->dev->device;
 }
 
-static inline struct device *chan2parent(struct dma_chan *chan)
-{
-	return chan->dev->device.parent;
-}
-
 static inline
 struct pch_dma_desc *pdc_first_active(struct pch_dma_chan *pd_chan)
 {
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH][next] dmaengine: pch_dma: remove unused function chan2parent
  2024-03-08 13:47 [PATCH][next] dmaengine: pch_dma: remove unused function chan2parent Colin Ian King
@ 2024-04-07 16:39 ` Vinod Koul
  0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2024-04-07 16:39 UTC (permalink / raw)
  To: dmaengine, Colin Ian King; +Cc: kernel-janitors, linux-kernel


On Fri, 08 Mar 2024 13:47:50 +0000, Colin Ian King wrote:
> The helper function chan2parent is not used and has never been
> used since the first commit to the code back in 2010. The function
> is redundant and can be removed.
> 
> Cleans up clang scan build warning:
> drivers/dma/pch_dma.c:158:30: warning: unused function 'chan2parent' [-Wunused-function]
> 
> [...]

Applied, thanks!

[1/1] dmaengine: pch_dma: remove unused function chan2parent
      commit: 4665be0e952f68306cc6fba2cce68b940a7ec78c

Best regards,
-- 
~Vinod



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-04-07 16:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-08 13:47 [PATCH][next] dmaengine: pch_dma: remove unused function chan2parent Colin Ian King
2024-04-07 16:39 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).