* [PATCH RESEND] irqchip: Drop the custom fixes for the same irq_chip name
@ 2024-03-11 11:53 Keguang Zhang
2024-03-25 16:46 ` [tip: irq/core] irqchip: Remove redundant irq_chip::name initialization tip-bot2 for Keguang Zhang
0 siblings, 1 reply; 2+ messages in thread
From: Keguang Zhang @ 2024-03-11 11:53 UTC (permalink / raw)
To: Thomas Gleixner, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland
Cc: linux-kernel, linux-arm-kernel, linux-sunxi, Keguang Zhang
Since commit 021a8ca2ba23 ("genirq/generic-chip: Fix the irq_chip name
for /proc/interrupts"), the chip name of all chip types are set to the
same name by irq_init_generic_chip() now. Those custom fixes for
the same irq_chip name are no longer needed.
So drop them.
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
---
drivers/irqchip/irq-sunxi-nmi.c | 1 -
drivers/irqchip/irq-tb10x.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/irqchip/irq-sunxi-nmi.c b/drivers/irqchip/irq-sunxi-nmi.c
index e760b1278143..bb92fd85e975 100644
--- a/drivers/irqchip/irq-sunxi-nmi.c
+++ b/drivers/irqchip/irq-sunxi-nmi.c
@@ -192,7 +192,6 @@ static int __init sunxi_sc_nmi_irq_init(struct device_node *node,
gc->chip_types[0].regs.type = reg_offs->ctrl;
gc->chip_types[1].type = IRQ_TYPE_EDGE_BOTH;
- gc->chip_types[1].chip.name = gc->chip_types[0].chip.name;
gc->chip_types[1].chip.irq_ack = irq_gc_ack_set_bit;
gc->chip_types[1].chip.irq_mask = irq_gc_mask_clr_bit;
gc->chip_types[1].chip.irq_unmask = irq_gc_mask_set_bit;
diff --git a/drivers/irqchip/irq-tb10x.c b/drivers/irqchip/irq-tb10x.c
index 680586354d12..d59bfbe8c6d0 100644
--- a/drivers/irqchip/irq-tb10x.c
+++ b/drivers/irqchip/irq-tb10x.c
@@ -150,7 +150,6 @@ static int __init of_tb10x_init_irq(struct device_node *ictl,
gc->chip_types[0].regs.mask = AB_IRQCTL_INT_ENABLE;
gc->chip_types[1].type = IRQ_TYPE_EDGE_BOTH;
- gc->chip_types[1].chip.name = gc->chip_types[0].chip.name;
gc->chip_types[1].chip.irq_ack = irq_gc_ack_set_bit;
gc->chip_types[1].chip.irq_mask = irq_gc_mask_clr_bit;
gc->chip_types[1].chip.irq_unmask = irq_gc_mask_set_bit;
base-commit: 8ffc8b1bbd505e27e2c8439d326b6059c906c9dd
--
2.40.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip: irq/core] irqchip: Remove redundant irq_chip::name initialization
2024-03-11 11:53 [PATCH RESEND] irqchip: Drop the custom fixes for the same irq_chip name Keguang Zhang
@ 2024-03-25 16:46 ` tip-bot2 for Keguang Zhang
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Keguang Zhang @ 2024-03-25 16:46 UTC (permalink / raw)
To: linux-tip-commits
Cc: Keguang Zhang, Thomas Gleixner, Jernej Skrabec, x86, linux-kernel, maz
The following commit has been merged into the irq/core branch of tip:
Commit-ID: 7b6f0f278d02de5a8f49202465c6427b56c97545
Gitweb: https://git.kernel.org/tip/7b6f0f278d02de5a8f49202465c6427b56c97545
Author: Keguang Zhang <keguang.zhang@gmail.com>
AuthorDate: Mon, 11 Mar 2024 19:53:44 +08:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Mon, 25 Mar 2024 17:38:29 +01:00
irqchip: Remove redundant irq_chip::name initialization
Since commit 021a8ca2ba23 ("genirq/generic-chip: Fix the irq_chip name for
/proc/interrupts"), the chip name of all chip types are set to the same
name by irq_init_generic_chip() now. So the initialization to the same
irq_chip name are no longer needed. Drop them.
Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Link: https://lore.kernel.org/r/20240311115344.72567-1-keguang.zhang@gmail.com
---
drivers/irqchip/irq-sunxi-nmi.c | 1 -
drivers/irqchip/irq-tb10x.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/irqchip/irq-sunxi-nmi.c b/drivers/irqchip/irq-sunxi-nmi.c
index e760b12..bb92fd8 100644
--- a/drivers/irqchip/irq-sunxi-nmi.c
+++ b/drivers/irqchip/irq-sunxi-nmi.c
@@ -192,7 +192,6 @@ static int __init sunxi_sc_nmi_irq_init(struct device_node *node,
gc->chip_types[0].regs.type = reg_offs->ctrl;
gc->chip_types[1].type = IRQ_TYPE_EDGE_BOTH;
- gc->chip_types[1].chip.name = gc->chip_types[0].chip.name;
gc->chip_types[1].chip.irq_ack = irq_gc_ack_set_bit;
gc->chip_types[1].chip.irq_mask = irq_gc_mask_clr_bit;
gc->chip_types[1].chip.irq_unmask = irq_gc_mask_set_bit;
diff --git a/drivers/irqchip/irq-tb10x.c b/drivers/irqchip/irq-tb10x.c
index 6805863..d59bfbe 100644
--- a/drivers/irqchip/irq-tb10x.c
+++ b/drivers/irqchip/irq-tb10x.c
@@ -150,7 +150,6 @@ static int __init of_tb10x_init_irq(struct device_node *ictl,
gc->chip_types[0].regs.mask = AB_IRQCTL_INT_ENABLE;
gc->chip_types[1].type = IRQ_TYPE_EDGE_BOTH;
- gc->chip_types[1].chip.name = gc->chip_types[0].chip.name;
gc->chip_types[1].chip.irq_ack = irq_gc_ack_set_bit;
gc->chip_types[1].chip.irq_mask = irq_gc_mask_clr_bit;
gc->chip_types[1].chip.irq_unmask = irq_gc_mask_set_bit;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-25 16:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-11 11:53 [PATCH RESEND] irqchip: Drop the custom fixes for the same irq_chip name Keguang Zhang
2024-03-25 16:46 ` [tip: irq/core] irqchip: Remove redundant irq_chip::name initialization tip-bot2 for Keguang Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).