* [PATCH] drm: ci: fix the xfails for apq8016
@ 2024-04-01 20:48 Abhinav Kumar
2024-04-05 16:46 ` Dmitry Baryshkov
2024-04-08 17:04 ` Abhinav Kumar
0 siblings, 2 replies; 5+ messages in thread
From: Abhinav Kumar @ 2024-04-01 20:48 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, Helen Koike, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel
After IGT migrating to dynamic sub-tests, the pipe prefixes
in the expected fails list are incorrect. Lets drop those
to accurately match the expected fails.
In addition, update the xfails list to match the current passing
list. This should have ideally failed in the CI run because some
tests were marked as fail even though they passed but due to the
mismatch in test names, the matching didn't correctly work and was
resulting in those failures not being seen.
Here is the passing pipeline for apq8016 with this change:
https://gitlab.freedesktop.org/drm/msm/-/jobs/57050562
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
---
drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
index 44a5c62dedad..b14d4e884971 100644
--- a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
+++ b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
@@ -1,17 +1,6 @@
kms_3d,Fail
kms_addfb_basic@addfb25-bad-modifier,Fail
-kms_cursor_legacy@all-pipes-forked-bo,Fail
-kms_cursor_legacy@all-pipes-forked-move,Fail
-kms_cursor_legacy@all-pipes-single-bo,Fail
-kms_cursor_legacy@all-pipes-single-move,Fail
-kms_cursor_legacy@all-pipes-torture-bo,Fail
-kms_cursor_legacy@all-pipes-torture-move,Fail
-kms_cursor_legacy@pipe-A-forked-bo,Fail
-kms_cursor_legacy@pipe-A-forked-move,Fail
-kms_cursor_legacy@pipe-A-single-bo,Fail
-kms_cursor_legacy@pipe-A-single-move,Fail
-kms_cursor_legacy@pipe-A-torture-bo,Fail
-kms_cursor_legacy@pipe-A-torture-move,Fail
+kms_cursor_legacy@torture-bo,Fail
kms_force_connector_basic@force-edid,Fail
kms_hdmi_inject@inject-4k,Fail
kms_selftest@drm_format,Timeout
--
2.43.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: ci: fix the xfails for apq8016
2024-04-01 20:48 [PATCH] drm: ci: fix the xfails for apq8016 Abhinav Kumar
@ 2024-04-05 16:46 ` Dmitry Baryshkov
2024-04-08 17:04 ` Abhinav Kumar
1 sibling, 0 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2024-04-05 16:46 UTC (permalink / raw)
To: Abhinav Kumar
Cc: Rob Clark, Sean Paul, Marijn Suijten, Helen Koike,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, linux-arm-msm, dri-devel, freedreno,
linux-kernel
On Mon, Apr 01, 2024 at 01:48:58PM -0700, Abhinav Kumar wrote:
> After IGT migrating to dynamic sub-tests, the pipe prefixes
> in the expected fails list are incorrect. Lets drop those
> to accurately match the expected fails.
>
> In addition, update the xfails list to match the current passing
> list. This should have ideally failed in the CI run because some
> tests were marked as fail even though they passed but due to the
> mismatch in test names, the matching didn't correctly work and was
> resulting in those failures not being seen.
>
> Here is the passing pipeline for apq8016 with this change:
>
> https://gitlab.freedesktop.org/drm/msm/-/jobs/57050562
>
> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
> drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: ci: fix the xfails for apq8016
2024-04-01 20:48 [PATCH] drm: ci: fix the xfails for apq8016 Abhinav Kumar
2024-04-05 16:46 ` Dmitry Baryshkov
@ 2024-04-08 17:04 ` Abhinav Kumar
2024-04-25 14:01 ` Helen Koike
1 sibling, 1 reply; 5+ messages in thread
From: Abhinav Kumar @ 2024-04-08 17:04 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Sean Paul, Marijn Suijten,
Helen Koike, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel
Hi Helen
Gentle reminder on this.
If you are okay, we can land it via msm-next tree...
Thanks
Abhinav
On 4/1/2024 1:48 PM, Abhinav Kumar wrote:
> After IGT migrating to dynamic sub-tests, the pipe prefixes
> in the expected fails list are incorrect. Lets drop those
> to accurately match the expected fails.
>
> In addition, update the xfails list to match the current passing
> list. This should have ideally failed in the CI run because some
> tests were marked as fail even though they passed but due to the
> mismatch in test names, the matching didn't correctly work and was
> resulting in those failures not being seen.
>
> Here is the passing pipeline for apq8016 with this change:
>
> https://gitlab.freedesktop.org/drm/msm/-/jobs/57050562
>
> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
> drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
> index 44a5c62dedad..b14d4e884971 100644
> --- a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
> +++ b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
> @@ -1,17 +1,6 @@
> kms_3d,Fail
> kms_addfb_basic@addfb25-bad-modifier,Fail
> -kms_cursor_legacy@all-pipes-forked-bo,Fail
> -kms_cursor_legacy@all-pipes-forked-move,Fail
> -kms_cursor_legacy@all-pipes-single-bo,Fail
> -kms_cursor_legacy@all-pipes-single-move,Fail
> -kms_cursor_legacy@all-pipes-torture-bo,Fail
> -kms_cursor_legacy@all-pipes-torture-move,Fail
> -kms_cursor_legacy@pipe-A-forked-bo,Fail
> -kms_cursor_legacy@pipe-A-forked-move,Fail
> -kms_cursor_legacy@pipe-A-single-bo,Fail
> -kms_cursor_legacy@pipe-A-single-move,Fail
> -kms_cursor_legacy@pipe-A-torture-bo,Fail
> -kms_cursor_legacy@pipe-A-torture-move,Fail
> +kms_cursor_legacy@torture-bo,Fail
> kms_force_connector_basic@force-edid,Fail
> kms_hdmi_inject@inject-4k,Fail
> kms_selftest@drm_format,Timeout
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: ci: fix the xfails for apq8016
2024-04-08 17:04 ` Abhinav Kumar
@ 2024-04-25 14:01 ` Helen Koike
2024-04-29 20:06 ` Helen Koike
0 siblings, 1 reply; 5+ messages in thread
From: Helen Koike @ 2024-04-25 14:01 UTC (permalink / raw)
To: Abhinav Kumar, Rob Clark, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel
On 08/04/2024 14:04, Abhinav Kumar wrote:
> Hi Helen
>
> Gentle reminder on this.
>
> If you are okay, we can land it via msm-next tree...
>
> Thanks
>
> Abhinav
>
> On 4/1/2024 1:48 PM, Abhinav Kumar wrote:
>> After IGT migrating to dynamic sub-tests, the pipe prefixes
>> in the expected fails list are incorrect. Lets drop those
>> to accurately match the expected fails.
>>
>> In addition, update the xfails list to match the current passing
>> list. This should have ideally failed in the CI run because some
>> tests were marked as fail even though they passed but due to the
>> mismatch in test names, the matching didn't correctly work and was
>> resulting in those failures not being seen.
>>
>> Here is the passing pipeline for apq8016 with this change:
>>
>> https://gitlab.freedesktop.org/drm/msm/-/jobs/57050562
>>
>> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
I'm sorry about my delay.
Acked-by: Helen Koike <helen.koike@collabora.com>
I'm also merging it to msm-misc-next.
Regards,
Helen
>> ---
>> drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt | 13 +------------
>> 1 file changed, 1 insertion(+), 12 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>> b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>> index 44a5c62dedad..b14d4e884971 100644
>> --- a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>> +++ b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>> @@ -1,17 +1,6 @@
>> kms_3d,Fail
>> kms_addfb_basic@addfb25-bad-modifier,Fail
>> -kms_cursor_legacy@all-pipes-forked-bo,Fail
>> -kms_cursor_legacy@all-pipes-forked-move,Fail
>> -kms_cursor_legacy@all-pipes-single-bo,Fail
>> -kms_cursor_legacy@all-pipes-single-move,Fail
>> -kms_cursor_legacy@all-pipes-torture-bo,Fail
>> -kms_cursor_legacy@all-pipes-torture-move,Fail
>> -kms_cursor_legacy@pipe-A-forked-bo,Fail
>> -kms_cursor_legacy@pipe-A-forked-move,Fail
>> -kms_cursor_legacy@pipe-A-single-bo,Fail
>> -kms_cursor_legacy@pipe-A-single-move,Fail
>> -kms_cursor_legacy@pipe-A-torture-bo,Fail
>> -kms_cursor_legacy@pipe-A-torture-move,Fail
>> +kms_cursor_legacy@torture-bo,Fail
>> kms_force_connector_basic@force-edid,Fail
>> kms_hdmi_inject@inject-4k,Fail
>> kms_selftest@drm_format,Timeout
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: ci: fix the xfails for apq8016
2024-04-25 14:01 ` Helen Koike
@ 2024-04-29 20:06 ` Helen Koike
0 siblings, 0 replies; 5+ messages in thread
From: Helen Koike @ 2024-04-29 20:06 UTC (permalink / raw)
To: Abhinav Kumar, Rob Clark, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel
On 25/04/2024 11:01, Helen Koike wrote:
>
>
> On 08/04/2024 14:04, Abhinav Kumar wrote:
>> Hi Helen
>>
>> Gentle reminder on this.
>>
>> If you are okay, we can land it via msm-next tree...
>>
>> Thanks
>>
>> Abhinav
>>
>> On 4/1/2024 1:48 PM, Abhinav Kumar wrote:
>>> After IGT migrating to dynamic sub-tests, the pipe prefixes
>>> in the expected fails list are incorrect. Lets drop those
>>> to accurately match the expected fails.
>>>
>>> In addition, update the xfails list to match the current passing
>>> list. This should have ideally failed in the CI run because some
>>> tests were marked as fail even though they passed but due to the
>>> mismatch in test names, the matching didn't correctly work and was
>>> resulting in those failures not being seen.
>>>
>>> Here is the passing pipeline for apq8016 with this change:
>>>
>>> https://gitlab.freedesktop.org/drm/msm/-/jobs/57050562
>>>
>>> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
>
> I'm sorry about my delay.
>
> Acked-by: Helen Koike <helen.koike@collabora.com>
>
> I'm also merging it to msm-misc-next.
Applied, thanks.
Helen
>
> Regards,
> Helen
>
>>> ---
>>> drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt | 13 +------------
>>> 1 file changed, 1 insertion(+), 12 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>>> b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>>> index 44a5c62dedad..b14d4e884971 100644
>>> --- a/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>>> +++ b/drivers/gpu/drm/ci/xfails/msm-apq8016-fails.txt
>>> @@ -1,17 +1,6 @@
>>> kms_3d,Fail
>>> kms_addfb_basic@addfb25-bad-modifier,Fail
>>> -kms_cursor_legacy@all-pipes-forked-bo,Fail
>>> -kms_cursor_legacy@all-pipes-forked-move,Fail
>>> -kms_cursor_legacy@all-pipes-single-bo,Fail
>>> -kms_cursor_legacy@all-pipes-single-move,Fail
>>> -kms_cursor_legacy@all-pipes-torture-bo,Fail
>>> -kms_cursor_legacy@all-pipes-torture-move,Fail
>>> -kms_cursor_legacy@pipe-A-forked-bo,Fail
>>> -kms_cursor_legacy@pipe-A-forked-move,Fail
>>> -kms_cursor_legacy@pipe-A-single-bo,Fail
>>> -kms_cursor_legacy@pipe-A-single-move,Fail
>>> -kms_cursor_legacy@pipe-A-torture-bo,Fail
>>> -kms_cursor_legacy@pipe-A-torture-move,Fail
>>> +kms_cursor_legacy@torture-bo,Fail
>>> kms_force_connector_basic@force-edid,Fail
>>> kms_hdmi_inject@inject-4k,Fail
>>> kms_selftest@drm_format,Timeout
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-04-29 20:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-01 20:48 [PATCH] drm: ci: fix the xfails for apq8016 Abhinav Kumar
2024-04-05 16:46 ` Dmitry Baryshkov
2024-04-08 17:04 ` Abhinav Kumar
2024-04-25 14:01 ` Helen Koike
2024-04-29 20:06 ` Helen Koike
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).