* WARNING in ar5523_cmd/usb_submit_urb
@ 2024-04-05 14:06 Nikita Zhandarovich
2024-04-06 14:19 ` [syzbot] [usb?] [wireless?] " syzbot
0 siblings, 1 reply; 4+ messages in thread
From: Nikita Zhandarovich @ 2024-04-05 14:06 UTC (permalink / raw)
To: syzbot+1bc2c2afd44f820a669f
Cc: Nikita Zhandarovich, syzkaller-bugs, linux-kernel
Enable endpoint checking.
#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
---
drivers/net/wireless/ath/ar5523/ar5523.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/net/wireless/ath/ar5523/ar5523.c b/drivers/net/wireless/ath/ar5523/ar5523.c
index 815f8f599f5d..5cac4a6452db 100644
--- a/drivers/net/wireless/ath/ar5523/ar5523.c
+++ b/drivers/net/wireless/ath/ar5523/ar5523.c
@@ -1594,6 +1594,20 @@ static int ar5523_probe(struct usb_interface *intf,
struct ar5523 *ar;
int error = -ENOMEM;
+ static u8 bulk_ep_addr[] = {
+ AR5523_CMD_TX_PIPE | USB_DIR_OUT,
+ AR5523_DATA_TX_PIPE | USB_DIR_OUT,
+ AR5523_CMD_RX_PIPE | USB_DIR_IN,
+ AR5523_DATA_RX_PIPE | USB_DIR_IN,
+ 0};
+
+ if (!usb_check_bulk_endpoints(intf, bulk_ep_addr)) {
+ dev_err(&dev->dev,
+ "Could not find all expected endpoints\n");
+ error = -ENODEV;
+ goto out;
+ }
+
/*
* Load firmware if the device requires it. This will return
* -ENXIO on success and we'll get called back afer the usb
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [syzbot] [usb?] [wireless?] WARNING in ar5523_cmd/usb_submit_urb
2024-04-05 14:06 WARNING in ar5523_cmd/usb_submit_urb Nikita Zhandarovich
@ 2024-04-06 14:19 ` syzbot
0 siblings, 0 replies; 4+ messages in thread
From: syzbot @ 2024-04-06 14:19 UTC (permalink / raw)
To: linux-kernel, n.zhandarovich, syzkaller-bugs
Hello,
syzbot tried to test the proposed patch but the build/boot failed:
:04: ttyS1 at I/O 0x2f8 (irq = 3, base_baud = 115200) is a 16550A
[ 9.237640][ T1] 00:05: ttyS2 at I/O 0x3e8 (irq = 6, base_baud = 115200) is a 16550A
[ 9.252560][ T1] 00:06: ttyS3 at I/O 0x2e8 (irq = 7, base_baud = 115200) is a 16550A
[ 9.276612][ T1] Non-volatile memory driver v1.3
[ 9.293898][ T1] Linux agpgart interface v0.103
[ 9.298192][ T1] ACPI: bus type drm_connector registered
[ 9.309824][ T1] [drm] Initialized vgem 1.0.0 20120112 for vgem on minor 0
[ 9.320431][ T1] [drm] Initialized vkms 1.0.0 20180514 for vkms on minor 1
[ 9.418419][ T1] Console: switching to colour frame buffer device 128x48
[ 9.434811][ T1] platform vkms: [drm] fb0: vkmsdrmfb frame buffer device
[ 9.436949][ T1] usbcore: registered new interface driver udl
[ 9.497480][ T804] kworker/u8:5 (804) used greatest stack depth: 27136 bytes left
[ 9.536903][ T1] brd: module loaded
[ 9.649711][ T1] loop: module loaded
[ 9.805358][ T1] zram: Added device: zram0
[ 9.818794][ T1] null_blk: disk nullb0 created
[ 9.819703][ T1] null_blk: module loaded
[ 9.820523][ T1] Guest personality initialized and is inactive
[ 9.822130][ T1] VMCI host device registered (name=vmci, major=10, minor=119)
[ 9.823324][ T1] Initialized host personality
[ 9.824207][ T1] usbcore: registered new interface driver rtsx_usb
[ 9.826193][ T1] usbcore: registered new interface driver viperboard
[ 9.827800][ T1] usbcore: registered new interface driver dln2
[ 9.829804][ T1] usbcore: registered new interface driver pn533_usb
[ 9.838027][ T1] nfcsim 0.2 initialized
[ 9.838893][ T1] usbcore: registered new interface driver port100
[ 9.840051][ T1] usbcore: registered new interface driver nfcmrvl
[ 9.848387][ T1] Loading iSCSI transport class v2.0-870.
[ 9.869483][ T1] virtio_scsi virtio0: 1/0/0 default/read/poll queues
[ 9.879674][ T1] ------------[ cut here ]------------
[ 9.880549][ T1] refcount_t: decrement hit 0; leaking memory.
[ 9.881818][ T1] WARNING: CPU: 0 PID: 1 at lib/refcount.c:31 refcount_warn_saturate+0x1d7/0x1f0
[ 9.883132][ T1] Modules linked in:
[ 9.883676][ T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.9.0-rc2-syzkaller-00387-g6c6e47d69d82-dirty #0
[ 9.887735][ T1] Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
[ 9.889174][ T1] RIP: 0010:refcount_warn_saturate+0x1d7/0x1f0
[ 9.890033][ T1] Code: 05 9b 98 fb 0a 01 e8 98 d0 0d fd 0f 0b e9 d7 fe ff ff e8 0c 81 4b fd 48 c7 c7 00 eb 2a 8b c6 05 7a 98 fb 0a 01 e8 79 d0 0d fd <0f> 0b e9 b8 fe ff ff 48 89 ef e8 ea 71 a4 fd e9 5c fe ff ff 0f 1f
[ 9.892646][ T1] RSP: 0000:ffffc900000673b8 EFLAGS: 00010282
[ 9.893490][ T1] RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffffffff814faf0a
[ 9.894555][ T1] RDX: ffff888017e78000 RSI: ffffffff814faf17 RDI: 0000000000000001
[ 9.895754][ T1] RBP: ffff88801f81ef3c R08: 0000000000000001 R09: 0000000000000000
[ 9.896829][ T1] R10: 0000000000000000 R11: 0000000000000001 R12: ffff88801f81ef3c
[ 9.897987][ T1] R13: 0000000000000000 R14: 0000000005e400ba R15: ffff888015a391c8
[ 9.899235][ T1] FS: 0000000000000000(0000) GS:ffff8880b9400000(0000) knlGS:0000000000000000
[ 9.900816][ T1] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 9.901761][ T1] CR2: ffff88823ffff000 CR3: 000000000d17a000 CR4: 00000000003506f0
[ 9.902892][ T1] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 9.903984][ T1] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 9.905099][ T1] Call Trace:
[ 9.905564][ T1] <TASK>
[ 9.905996][ T1] ? show_regs+0x8c/0xa0
[ 9.906613][ T1] ? __warn+0xe5/0x3b0
[ 9.907200][ T1] ? refcount_warn_saturate+0x1d7/0x1f0
[ 9.907962][ T1] ? report_bug+0x3c0/0x580
[ 9.908636][ T1] ? handle_bug+0x3c/0x70
[ 9.909296][ T1] ? exc_invalid_op+0x17/0x40
[ 9.910092][ T1] ? asm_exc_invalid_op+0x1a/0x20
[ 9.910797][ T1] ? __warn_printk+0x17a/0x310
[ 9.911479][ T1] ? __warn_printk+0x187/0x310
[ 9.912178][ T1] ? refcount_warn_saturate+0x1d7/0x1f0
[ 9.913194][ T1] ? refcount_warn_saturate+0x1d7/0x1f0
[ 9.914001][ T1] __reset_page_owner+0x2ea/0x370
[ 9.914767][ T1] __free_pages_ok+0x5aa/0xbb0
[ 9.915537][ T1] ? __split_page_owner+0xdd/0x120
[ 9.916319][ T1] make_alloc_exact+0x165/0x260
[ 9.917056][ T1] vring_alloc_queue+0xc1/0x110
[ 9.917761][ T1] vring_alloc_queue_split.part.0+0x19a/0x4d0
[ 9.918677][ T1] ? __pfx_vring_alloc_queue_split.part.0+0x10/0x10
[ 9.919618][ T1] vring_create_virtqueue_split+0x135/0x300
[ 9.920515][ T1] ? __pfx_vp_notify+0x10/0x10
[ 9.921189][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 9.921966][ T1] ? __pfx_vring_create_virtqueue_split+0x10/0x10
[ 9.923065][ T1] ? driver_register+0x15c/0x4b0
[ 9.923794][ T1] ? virtio_scsi_init+0x75/0x100
[ 9.924611][ T1] ? do_one_initcall+0x113/0x6c0
[ 9.925397][ T1] vring_create_virtqueue+0xd7/0x140
[ 9.926167][ T1] ? __pfx_vp_notify+0x10/0x10
[ 9.927003][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 9.927812][ T1] setup_vq+0x123/0x2f0
[ 9.928521][ T1] ? __pfx_vp_notify+0x10/0x10
[ 9.929221][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 9.930011][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 9.930821][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 9.931621][ T1] vp_setup_vq+0xb1/0x380
[ 9.932241][ T1] ? ioread16+0x50/0xc0
[ 9.932824][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 9.933759][ T1] vp_find_vqs_msix+0x661/0xe30
[ 9.934541][ T1] vp_find_vqs+0x58/0x560
[ 9.935217][ T1] virtscsi_init+0x459/0x9f0
[ 9.935931][ T1] ? __pfx_virtscsi_init+0x10/0x10
[ 9.936649][ T1] ? __init_waitqueue_head+0xca/0x150
[ 9.937520][ T1] ? __pfx_default_calc_sets+0x10/0x10
[ 9.938447][ T1] ? ioread8+0x4f/0xc0
[ 9.939076][ T1] ? vp_get+0xf6/0x140
[ 9.939719][ T1] virtscsi_probe+0x39b/0xda0
[ 9.940444][ T1] ? __pfx_virtscsi_probe+0x10/0x10
[ 9.941192][ T1] virtio_dev_probe+0x5fd/0x9b0
[ 9.941914][ T1] ? __pfx_virtio_dev_probe+0x10/0x10
[ 9.942658][ T1] really_probe+0x23e/0xa90
[ 9.943379][ T1] __driver_probe_device+0x1de/0x440
[ 9.944151][ T1] ? _raw_spin_unlock_irqrestore+0x52/0x80
[ 9.945028][ T1] driver_probe_device+0x4c/0x1b0
[ 9.945917][ T1] __driver_attach+0x283/0x580
[ 9.946607][ T1] ? __pfx___driver_attach+0x10/0x10
[ 9.947355][ T1] bus_for_each_dev+0x12a/0x1c0
[ 9.948044][ T1] ? __pfx_bus_for_each_dev+0x10/0x10
[ 9.948842][ T1] bus_add_driver+0x2ed/0x640
[ 9.949565][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 9.950373][ T1] driver_register+0x15c/0x4b0
[ 9.951097][ T1] virtio_scsi_init+0x75/0x100
[ 9.951761][ T1] do_one_initcall+0x113/0x6c0
[ 9.952473][ T1] ? __pfx_do_one_initcall+0x10/0x10
[ 9.953442][ T1] ? parameq+0xf0/0x180
[ 9.954130][ T1] ? trace_kmalloc+0x2d/0xd0
[ 9.954767][ T1] ? __kmalloc+0x20f/0x430
[ 9.955561][ T1] kernel_init_freeable+0x5c7/0x900
[ 9.956325][ T1] ? __pfx_kernel_init+0x10/0x10
[ 9.957064][ T1] kernel_init+0x1c/0x2b0
[ 9.957848][ T1] ? __pfx_kernel_init+0x10/0x10
[ 9.958677][ T1] ret_from_fork+0x45/0x80
[ 9.959408][ T1] ? __pfx_kernel_init+0x10/0x10
[ 9.960135][ T1] ret_from_fork_asm+0x1a/0x30
[ 9.960816][ T1] </TASK>
[ 9.961290][ T1] Kernel panic - not syncing: kernel: panic_on_warn set ...
[ 9.962348][ T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.9.0-rc2-syzkaller-00387-g6c6e47d69d82-dirty #0
[ 9.963984][ T1] Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
[ 9.965538][ T1] Call Trace:
[ 9.965538][ T1] <TASK>
[ 9.965538][ T1] dump_stack_lvl+0x3d/0x1f0
[ 9.965538][ T1] panic+0x6d2/0x780
[ 9.965538][ T1] ? __pfx_panic+0x10/0x10
[ 9.965538][ T1] ? show_trace_log_lvl+0x35c/0x510
[ 9.965538][ T1] ? check_panic_on_warn+0x1f/0xb0
[ 9.965538][ T1] ? refcount_warn_saturate+0x1d7/0x1f0
[ 9.965538][ T1] check_panic_on_warn+0xab/0xb0
[ 9.965538][ T1] __warn+0xf1/0x3b0
[ 9.965538][ T1] ? refcount_warn_saturate+0x1d7/0x1f0
[ 9.965538][ T1] report_bug+0x3c0/0x580
[ 9.965538][ T1] handle_bug+0x3c/0x70
[ 9.965538][ T1] exc_invalid_op+0x17/0x40
[ 9.965538][ T1] asm_exc_invalid_op+0x1a/0x20
[ 9.965538][ T1] RIP: 0010:refcount_warn_saturate+0x1d7/0x1f0
[ 9.965538][ T1] Code: 05 9b 98 fb 0a 01 e8 98 d0 0d fd 0f 0b e9 d7 fe ff ff e8 0c 81 4b fd 48 c7 c7 00 eb 2a 8b c6 05 7a 98 fb 0a 01 e8 79 d0 0d fd <0f> 0b e9 b8 fe ff ff 48 89 ef e8 ea 71 a4 fd e9 5c fe ff ff 0f 1f
[ 9.965538][ T1] RSP: 0000:ffffc900000673b8 EFLAGS: 00010282
[ 9.965538][ T1] RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffffffff814faf0a
[ 9.965538][ T1] RDX: ffff888017e78000 RSI: ffffffff814faf17 RDI: 0000000000000001
[ 9.965538][ T1] RBP: ffff88801f81ef3c R08: 0000000000000001 R09: 0000000000000000
[ 9.965538][ T1] R10: 0000000000000000 R11: 0000000000000001 R12: ffff88801f81ef3c
[ 9.965538][ T1] R13: 0000000000000000 R14: 0000000005e400ba R15: ffff888015a391c8
[ 9.965538][ T1] ? __warn_printk+0x17a/0x310
[ 9.965538][ T1] ? __warn_printk+0x187/0x310
[ 9.965538][ T1] ? refcount_warn_saturate+0x1d7/0x1f0
[ 9.965538][ T1] __reset_page_owner+0x2ea/0x370
[ 9.965538][ T1] __free_pages_ok+0x5aa/0xbb0
[ 9.965538][ T1] ? __split_page_owner+0xdd/0x120
[ 9.965538][ T1] make_alloc_exact+0x165/0x260
[ 9.965538][ T1] vring_alloc_queue+0xc1/0x110
[ 9.965538][ T1] vring_alloc_queue_split.part.0+0x19a/0x4d0
[ 9.965538][ T1] ? __pfx_vring_alloc_queue_split.part.0+0x10/0x10
[ 9.965538][ T1] vring_create_virtqueue_split+0x135/0x300
[ 9.965538][ T1] ? __pfx_vp_notify+0x10/0x10
[ 9.965538][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 9.965538][ T1] ? __pfx_vring_create_virtqueue_split+0x10/0x10
[ 9.965538][ T1] ? driver_register+0x15c/0x4b0
[ 9.965538][ T1] ? virtio_scsi_init+0x75/0x100
[ 9.965538][ T1] ? do_one_initcall+0x113/0x6c0
[ 9.965538][ T1] vring_create_virtqueue+0xd7/0x140
[ 9.965538][ T1] ? __pfx_vp_notify+0x10/0x10
[ 9.965538][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 9.965538][ T1] setup_vq+0x123/0x2f0
[ 9.965538][ T1] ? __pfx_vp_notify+0x10/0x10
[ 9.965538][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 9.965538][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 9.965538][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 9.965538][ T1] vp_setup_vq+0xb1/0x380
[ 9.965538][ T1] ? ioread16+0x50/0xc0
[ 9.965538][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 9.965538][ T1] vp_find_vqs_msix+0x661/0xe30
[ 9.965538][ T1] vp_find_vqs+0x58/0x560
[ 9.965538][ T1] virtscsi_init+0x459/0x9f0
[ 9.965538][ T1] ? __pfx_virtscsi_init+0x10/0x10
[ 9.965538][ T1] ? __init_waitqueue_head+0xca/0x150
[ 9.965538][ T1] ? __pfx_default_calc_sets+0x10/0x10
[ 9.965538][ T1] ? ioread8+0x4f/0xc0
[ 9.965538][ T1] ? vp_get+0xf6/0x140
[ 9.965538][ T1] virtscsi_probe+0x39b/0xda0
[ 9.965538][ T1] ? __pfx_virtscsi_probe+0x10/0x10
[ 9.965538][ T1] virtio_dev_probe+0x5fd/0x9b0
[ 9.965538][ T1] ? __pfx_virtio_dev_probe+0x10/0x10
[ 9.965538][ T1] really_probe+0x23e/0xa90
[ 9.965538][ T1] __driver_probe_device+0x1de/0x440
[ 9.965538][ T1] ? _raw_spin_unlock_irqrestore+0x52/0x80
[ 9.965538][ T1] driver_probe_device+0x4c/0x1b0
[ 9.965538][ T1] __driver_attach+0x283/0x580
[ 9.965538][ T1] ? __pfx___driver_attach+0x10/0x10
[ 9.965538][ T1] bus_for_each_dev+0x12a/0x1c0
[ 9.965538][ T1] ? __pfx_bus_for_each_dev+0x10/0x10
[ 9.965538][ T1] bus_add_driver+0x2ed/0x640
[ 9.965538][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 9.965538][ T1] driver_register+0x15c/0x4b0
[ 9.965538][ T1] virtio_scsi_init+0x75/0x100
[ 9.965538][ T1] do_one_initcall+0x113/0x6c0
[ 9.965538][ T1] ? __pfx_do_one_initcall+0x10/0x10
[ 9.965538][ T1] ? parameq+0xf0/0x180
[ 9.965538][ T1] ? trace_kmalloc+0x2d/0xd0
[ 9.965538][ T1] ? __kmalloc+0x20f/0x430
[ 9.965538][ T1] kernel_init_freeable+0x5c7/0x900
[ 9.965538][ T1] ? __pfx_kernel_init+0x10/0x10
[ 9.965538][ T1] kernel_init+0x1c/0x2b0
[ 9.965538][ T1] ? __pfx_kernel_init+0x10/0x10
[ 9.965538][ T1] ret_from_fork+0x45/0x80
[ 9.965538][ T1] ? __pfx_kernel_init+0x10/0x10
[ 9.965538][ T1] ret_from_fork_asm+0x1a/0x30
[ 9.965538][ T1] </TASK>
[ 9.965538][ T1] Kernel Offset: disabled
[ 9.965538][ T1] Rebooting in 86400 seconds..
syzkaller build log:
go env (err=<nil>)
GO111MODULE='auto'
GOARCH='amd64'
GOBIN=''
GOCACHE='/syzkaller/.cache/go-build'
GOENV='/syzkaller/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/syzkaller/jobs/linux/gopath/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/syzkaller/jobs/linux/gopath'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.21.4'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/syzkaller/jobs/linux/gopath/src/github.com/google/syzkaller/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build1747655191=/tmp/go-build -gno-record-gcc-switches'
git status (err=<nil>)
HEAD detached at 1c576c232
nothing to commit, working tree clean
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
Makefile:32: run command via tools/syz-env for best compatibility, see:
Makefile:33: https://github.com/google/syzkaller/blob/master/docs/contributing.md#using-syz-env
go list -f '{{.Stale}}' ./sys/syz-sysgen | grep -q false || go install ./sys/syz-sysgen
make .descriptions
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
bin/syz-sysgen
touch .descriptions
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=1c576c232f825266983096180b3603005edc458e -X 'github.com/google/syzkaller/prog.gitRevisionDate=20221121-163647'" "-tags=syz_target syz_os_linux syz_arch_amd64 " -o ./bin/linux_amd64/syz-fuzzer github.com/google/syzkaller/syz-fuzzer
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=1c576c232f825266983096180b3603005edc458e -X 'github.com/google/syzkaller/prog.gitRevisionDate=20221121-163647'" "-tags=syz_target syz_os_linux syz_arch_amd64 " -o ./bin/linux_amd64/syz-execprog github.com/google/syzkaller/tools/syz-execprog
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=1c576c232f825266983096180b3603005edc458e -X 'github.com/google/syzkaller/prog.gitRevisionDate=20221121-163647'" "-tags=syz_target syz_os_linux syz_arch_amd64 " -o ./bin/linux_amd64/syz-stress github.com/google/syzkaller/tools/syz-stress
mkdir -p ./bin/linux_amd64
gcc -o ./bin/linux_amd64/syz-executor executor/executor.cc \
-m64 -O2 -pthread -Wall -Werror -Wparentheses -Wunused-const-variable -Wframe-larger-than=16384 -Wno-stringop-overflow -Wno-array-bounds -Wno-format-overflow -static-pie -fpermissive -w -DGOOS_linux=1 -DGOARCH_amd64=1 \
-DHOSTGOOS_linux=1 -DGIT_REVISION=\"1c576c232f825266983096180b3603005edc458e\"
Error text is too large and was truncated, full error text is at:
https://syzkaller.appspot.com/x/error.txt?x=12be7ead180000
Tested on:
commit: 6c6e47d6 Merge tag 'firewire-fixes-6.9-rc2' of git://g..
git tree: upstream
kernel config: https://syzkaller.appspot.com/x/.config?x=84f10f559b1064f4
dashboard link: https://syzkaller.appspot.com/bug?extid=1bc2c2afd44f820a669f
compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
patch: https://syzkaller.appspot.com/x/patch.diff?x=117699a1180000
^ permalink raw reply [flat|nested] 4+ messages in thread
* WARNING in ar5523_cmd/usb_submit_urb
@ 2024-04-07 13:00 Nikita Zhandarovich
0 siblings, 0 replies; 4+ messages in thread
From: Nikita Zhandarovich @ 2024-04-07 13:00 UTC (permalink / raw)
To: syzbot+1bc2c2afd44f820a669f
Cc: Nikita Zhandarovich, syzkaller-bugs, linux-kernel
Enable endpoint checking.
#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git fe46a7dd189e
---
drivers/net/wireless/ath/ar5523/ar5523.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/net/wireless/ath/ar5523/ar5523.c b/drivers/net/wireless/ath/ar5523/ar5523.c
index 815f8f599f5d..5cac4a6452db 100644
--- a/drivers/net/wireless/ath/ar5523/ar5523.c
+++ b/drivers/net/wireless/ath/ar5523/ar5523.c
@@ -1594,6 +1594,20 @@ static int ar5523_probe(struct usb_interface *intf,
struct ar5523 *ar;
int error = -ENOMEM;
+ static u8 bulk_ep_addr[] = {
+ AR5523_CMD_TX_PIPE | USB_DIR_OUT,
+ AR5523_DATA_TX_PIPE | USB_DIR_OUT,
+ AR5523_CMD_RX_PIPE | USB_DIR_IN,
+ AR5523_DATA_RX_PIPE | USB_DIR_IN,
+ 0};
+
+ if (!usb_check_bulk_endpoints(intf, bulk_ep_addr)) {
+ dev_err(&dev->dev,
+ "Could not find all expected endpoints\n");
+ error = -ENODEV;
+ goto out;
+ }
+
/*
* Load firmware if the device requires it. This will return
* -ENXIO on success and we'll get called back afer the usb
^ permalink raw reply related [flat|nested] 4+ messages in thread
* WARNING in ar5523_cmd/usb_submit_urb
@ 2020-01-29 12:27 syzbot
0 siblings, 0 replies; 4+ messages in thread
From: syzbot @ 2020-01-29 12:27 UTC (permalink / raw)
To: andreyknvl, gregkh, ingrassia, linux-kernel, linux-usb, syzkaller-bugs
Hello,
syzbot found the following crash on:
HEAD commit: cd234325 usb: gadget: add raw-gadget interface
git tree: https://github.com/google/kasan.git usb-fuzzer
console output: https://syzkaller.appspot.com/x/log.txt?x=146bf3c9e00000
kernel config: https://syzkaller.appspot.com/x/.config?x=bb745005307bc641
dashboard link: https://syzkaller.appspot.com/bug?extid=1bc2c2afd44f820a669f
compiler: gcc (GCC) 9.0.0 20181231 (experimental)
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1646cf35e00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11017735e00000
IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+1bc2c2afd44f820a669f@syzkaller.appspotmail.com
usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
usb 1-1: Product: syz
usb 1-1: Manufacturer: syz
usb 1-1: SerialNumber: syz
------------[ cut here ]------------
usb 1-1: BOGUS urb xfer, pipe 3 != type 1
WARNING: CPU: 0 PID: 95 at drivers/usb/core/urb.c:478 usb_submit_urb+0x1188/0x1460 drivers/usb/core/urb.c:478
Kernel panic - not syncing: panic_on_warn set ...
CPU: 0 PID: 95 Comm: kworker/0:2 Not tainted 5.5.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0xef/0x16e lib/dump_stack.c:118
panic+0x2aa/0x6e1 kernel/panic.c:221
__warn.cold+0x2f/0x30 kernel/panic.c:582
report_bug+0x27b/0x2f0 lib/bug.c:195
fixup_bug arch/x86/kernel/traps.c:174 [inline]
fixup_bug arch/x86/kernel/traps.c:169 [inline]
do_error_trap+0x12b/0x1e0 arch/x86/kernel/traps.c:267
do_invalid_op+0x32/0x40 arch/x86/kernel/traps.c:286
invalid_op+0x23/0x30 arch/x86/entry/entry_64.S:1027
RIP: 0010:usb_submit_urb+0x1188/0x1460 drivers/usb/core/urb.c:478
Code: 4d 85 ed 74 46 e8 28 2d e1 fd 4c 89 f7 e8 d0 87 17 ff 41 89 d8 44 89 e1 4c 89 ea 48 89 c6 48 c7 c7 a0 2b 3b 86 e8 20 13 b6 fd <0f> 0b e9 20 f4 ff ff e8 fc 2c e1 fd 0f 1f 44 00 00 e8 f2 2c e1 fd
RSP: 0018:ffff8881d58cf0d8 EFLAGS: 00010286
RAX: 0000000000000000 RBX: 0000000000000001 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffffffff81295a0d RDI: ffffed103ab19e0d
RBP: ffff8881cd478050 R08: ffff8881d71ac980 R09: fffffbfff1269cae
R10: fffffbfff1269cad R11: ffffffff8934e56f R12: 0000000000000003
R13: ffff8881d098eee8 R14: ffff8881cda730a0 R15: ffff8881d5583b00
ar5523_cmd+0x438/0x7a0 drivers/net/wireless/ath/ar5523/ar5523.c:271
ar5523_cmd_read drivers/net/wireless/ath/ar5523/ar5523.c:298 [inline]
ar5523_host_available drivers/net/wireless/ath/ar5523/ar5523.c:1372 [inline]
ar5523_probe+0xc11/0x1ad0 drivers/net/wireless/ath/ar5523/ar5523.c:1652
usb_probe_interface+0x310/0x800 drivers/usb/core/driver.c:361
really_probe+0x290/0xad0 drivers/base/dd.c:548
driver_probe_device+0x223/0x350 drivers/base/dd.c:721
__device_attach_driver+0x1d1/0x290 drivers/base/dd.c:828
bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
__device_attach+0x217/0x390 drivers/base/dd.c:894
bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
device_add+0x1459/0x1bf0 drivers/base/core.c:2487
usb_set_configuration+0xe47/0x17d0 drivers/usb/core/message.c:2023
generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
usb_probe_device+0xaf/0x140 drivers/usb/core/driver.c:266
really_probe+0x290/0xad0 drivers/base/dd.c:548
driver_probe_device+0x223/0x350 drivers/base/dd.c:721
__device_attach_driver+0x1d1/0x290 drivers/base/dd.c:828
bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
__device_attach+0x217/0x390 drivers/base/dd.c:894
bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
device_add+0x1459/0x1bf0 drivers/base/core.c:2487
usb_new_device.cold+0x540/0xcd0 drivers/usb/core/hub.c:2538
hub_port_connect drivers/usb/core/hub.c:5185 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5325 [inline]
port_event drivers/usb/core/hub.c:5471 [inline]
hub_event+0x21cb/0x4300 drivers/usb/core/hub.c:5553
process_one_work+0x945/0x15c0 kernel/workqueue.c:2264
worker_thread+0x96/0xe20 kernel/workqueue.c:2410
kthread+0x318/0x420 kernel/kthread.c:255
ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352
Kernel Offset: disabled
Rebooting in 86400 seconds..
---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-07 13:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-05 14:06 WARNING in ar5523_cmd/usb_submit_urb Nikita Zhandarovich
2024-04-06 14:19 ` [syzbot] [usb?] [wireless?] " syzbot
-- strict thread matches above, loose matches on Subject: below --
2024-04-07 13:00 Nikita Zhandarovich
2020-01-29 12:27 syzbot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).