* linux-next: Fixes tag needs some work in the rcu tree
@ 2024-04-08 23:14 Stephen Rothwell
0 siblings, 0 replies; 17+ messages in thread
From: Stephen Rothwell @ 2024-04-08 23:14 UTC (permalink / raw)
To: Paul E. McKenney
Cc: Uladzislau Rezki (Sony),
Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 385 bytes --]
Hi all,
In commit
f994a33cbc33 ("rcu: Do not release a wait-head from a GP kthread")
Fixes tag
Fixes: 05a10b921000 ("rcu: Support direct wake-up of synchronize_rcu() users")
has these problem(s):
- Target SHA1 does not exist
Maybe you meant
Fixes: 667a5ebff394 ("rcu: Support direct wake-up of synchronize_rcu() users")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: Fixes tag needs some work in the rcu tree
@ 2024-04-03 21:39 Stephen Rothwell
2024-04-04 12:14 ` Uladzislau Rezki
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2024-04-03 21:39 UTC (permalink / raw)
To: Paul E. McKenney
Cc: Uladzislau Rezki (Sony),
Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 385 bytes --]
Hi all,
In commit
a55be9aacc45 ("rcu: Do not release a wait-head from a GP kthread")
Fixes tag
Fixes: 05a10b921000 ("rcu: Support direct wake-up of synchronize_rcu() users")
has these problem(s):
- Target SHA1 does not exist
Maybe you meant
Fixes: 654f59c6bc95 ("rcu: Support direct wake-up of synchronize_rcu() users")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: Fixes tag needs some work in the rcu tree
2024-04-03 21:39 Stephen Rothwell
@ 2024-04-04 12:14 ` Uladzislau Rezki
2024-04-04 14:35 ` Paul E. McKenney
0 siblings, 1 reply; 17+ messages in thread
From: Uladzislau Rezki @ 2024-04-04 12:14 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Paul E. McKenney, Uladzislau Rezki (Sony),
Linux Kernel Mailing List, Linux Next Mailing List
Hello!
> Hi all,
>
> In commit
>
> a55be9aacc45 ("rcu: Do not release a wait-head from a GP kthread")
>
> Fixes tag
>
> Fixes: 05a10b921000 ("rcu: Support direct wake-up of synchronize_rcu() users")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 654f59c6bc95 ("rcu: Support direct wake-up of synchronize_rcu() users")
>
I have a question. Could you please clarify why those commits are in the linux-next?
Those commits have to go over RCU tree. It looks like i am missing something but
please elaborate.
--
Uladzislau Rezki
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: Fixes tag needs some work in the rcu tree
2024-04-04 12:14 ` Uladzislau Rezki
@ 2024-04-04 14:35 ` Paul E. McKenney
2024-04-05 17:17 ` Uladzislau Rezki
0 siblings, 1 reply; 17+ messages in thread
From: Paul E. McKenney @ 2024-04-04 14:35 UTC (permalink / raw)
To: Uladzislau Rezki
Cc: Stephen Rothwell, Linux Kernel Mailing List, Linux Next Mailing List
On Thu, Apr 04, 2024 at 02:14:43PM +0200, Uladzislau Rezki wrote:
> Hello!
>
> > Hi all,
> >
> > In commit
> >
> > a55be9aacc45 ("rcu: Do not release a wait-head from a GP kthread")
> >
> > Fixes tag
> >
> > Fixes: 05a10b921000 ("rcu: Support direct wake-up of synchronize_rcu() users")
> >
> > has these problem(s):
> >
> > - Target SHA1 does not exist
> >
> > Maybe you meant
> >
> > Fixes: 654f59c6bc95 ("rcu: Support direct wake-up of synchronize_rcu() users")
> >
> I have a question. Could you please clarify why those commits are in the linux-next?
> Those commits have to go over RCU tree. It looks like i am missing something but
> please elaborate.
Stephen pulls the -rcu "rcu/next" tag into -next, and does similarly for
a large number of other trees. This serves to pre-test the commits that
are likely to show up in the upcoming merge window. The pre-testing
includes the build testing that Stephen does directly and additional
testing that others do on the -next tree (for example, I occasionally
run rcutorture on it).
So these commits are in -next because I told Stephen to include them.
But if you would like, I would be happy to pull your series out of the
portion covered by rcu/next for the time being.
Thanx, Paul
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: Fixes tag needs some work in the rcu tree
2024-04-04 14:35 ` Paul E. McKenney
@ 2024-04-05 17:17 ` Uladzislau Rezki
0 siblings, 0 replies; 17+ messages in thread
From: Uladzislau Rezki @ 2024-04-05 17:17 UTC (permalink / raw)
To: Paul E. McKenney
Cc: Uladzislau Rezki, Stephen Rothwell, Linux Kernel Mailing List,
Linux Next Mailing List
On Thu, Apr 04, 2024 at 07:35:31AM -0700, Paul E. McKenney wrote:
> On Thu, Apr 04, 2024 at 02:14:43PM +0200, Uladzislau Rezki wrote:
> > Hello!
> >
> > > Hi all,
> > >
> > > In commit
> > >
> > > a55be9aacc45 ("rcu: Do not release a wait-head from a GP kthread")
> > >
> > > Fixes tag
> > >
> > > Fixes: 05a10b921000 ("rcu: Support direct wake-up of synchronize_rcu() users")
> > >
> > > has these problem(s):
> > >
> > > - Target SHA1 does not exist
> > >
> > > Maybe you meant
> > >
> > > Fixes: 654f59c6bc95 ("rcu: Support direct wake-up of synchronize_rcu() users")
> > >
> > I have a question. Could you please clarify why those commits are in the linux-next?
> > Those commits have to go over RCU tree. It looks like i am missing something but
> > please elaborate.
>
> Stephen pulls the -rcu "rcu/next" tag into -next, and does similarly for
> a large number of other trees. This serves to pre-test the commits that
> are likely to show up in the upcoming merge window. The pre-testing
> includes the build testing that Stephen does directly and additional
> testing that others do on the -next tree (for example, I occasionally
> run rcutorture on it).
>
> So these commits are in -next because I told Stephen to include them.
>
> But if you would like, I would be happy to pull your series out of the
> portion covered by rcu/next for the time being.
>
Thanks for such information!
--
Uladzislau Rezki
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: Fixes tag needs some work in the rcu tree
@ 2024-04-01 21:03 Stephen Rothwell
0 siblings, 0 replies; 17+ messages in thread
From: Stephen Rothwell @ 2024-04-01 21:03 UTC (permalink / raw)
To: Paul E. McKenney
Cc: Uladzislau Rezki (Sony),
Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 385 bytes --]
Hi all,
In commit
e94061cfa1d6 ("rcu: Do not release a wait-head from a GP kthread")
Fixes tag
Fixes: 05a10b921000 ("rcu: Support direct wake-up of synchronize_rcu() users")
has these problem(s):
- Target SHA1 does not exist
Maybe you meant
Fixes: a2b9f1c8a1f1 ("rcu: Support direct wake-up of synchronize_rcu() users")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: Fixes tag needs some work in the rcu tree
@ 2023-04-05 22:36 Stephen Rothwell
2023-04-05 22:59 ` Paul E. McKenney
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2023-04-05 22:36 UTC (permalink / raw)
To: Paul E. McKenney
Cc: Ziwei Dai, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 499 bytes --]
Hi all,
In commit
acdc79917d65 ("rcu/kvfree: Avoid freeing new kfree_rcu() memory after old grace period")
Fixes tag
Fixes: 0392bebebf26 ("rcu/kvfree: Avoid freeing new kfree_rcu() memory after old grace period")
has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
Maybe you meant:
Fixes: 0392bebebf26 ("rcu: Add multiple in-flight batches of kfree_rcu() work")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: Fixes tag needs some work in the rcu tree
2023-04-05 22:36 Stephen Rothwell
@ 2023-04-05 22:59 ` Paul E. McKenney
0 siblings, 0 replies; 17+ messages in thread
From: Paul E. McKenney @ 2023-04-05 22:59 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Ziwei Dai, Linux Kernel Mailing List, Linux Next Mailing List
On Thu, Apr 06, 2023 at 08:36:19AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> acdc79917d65 ("rcu/kvfree: Avoid freeing new kfree_rcu() memory after old grace period")
>
> Fixes tag
>
> Fixes: 0392bebebf26 ("rcu/kvfree: Avoid freeing new kfree_rcu() memory after old grace period")
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
> Maybe you meant:
>
> Fixes: 0392bebebf26 ("rcu: Add multiple in-flight batches of kfree_rcu() work")
Hello, Stephen,
There is currently some debate as to exactly which commit(s) introduced
the bug, which will hopefully come to a conclusion before tomorrow's
-next. If they do not, I will use your correction as a placeholder.
Just for completeness, the current other two candidates (which appear
quite plausible to me) are these:
Fixes: 34c881745549 ("rcu: Support kfree_bulk() interface in kfree_rcu()")
Fixes: 5f3c8d620447 ("rcu/tree: Maintain separate array for vmalloc ptrs")
Ziwei Dai, what are your thoughts on this? This is from a mainline
perspective, my guess being that your investigation involved some other
Linux-kernel tree.
Thanx, Paul
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: Fixes tag needs some work in the rcu tree
@ 2020-10-05 11:53 Stephen Rothwell
2020-10-05 14:07 ` Paul E. McKenney
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2020-10-05 11:53 UTC (permalink / raw)
To: Paul E. McKenney
Cc: Linux Kernel Mailing List, Linux Next Mailing List, Nick Desaulniers
[-- Attachment #1: Type: text/plain, Size: 282 bytes --]
Hi all,
n commit
fe0d06f03320 ("srcu: Avoid escaped section names")
Fixes tag
Fixes: commit fe15b50cdeee ("srcu: Allocate per-CPU data for DEFINE_SRCU() in modules")
has these problem(s):
- leading word 'commit' unexpected
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: Fixes tag needs some work in the rcu tree
2020-10-05 11:53 Stephen Rothwell
@ 2020-10-05 14:07 ` Paul E. McKenney
0 siblings, 0 replies; 17+ messages in thread
From: Paul E. McKenney @ 2020-10-05 14:07 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Kernel Mailing List, Linux Next Mailing List, Nick Desaulniers
On Mon, Oct 05, 2020 at 10:53:15PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> n commit
>
> fe0d06f03320 ("srcu: Avoid escaped section names")
>
> Fixes tag
>
> Fixes: commit fe15b50cdeee ("srcu: Allocate per-CPU data for DEFINE_SRCU() in modules")
>
> has these problem(s):
>
> - leading word 'commit' unexpected
Will fix the Fixes, thank you!
Thanx, Paul
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: Fixes tag needs some work in the rcu tree
@ 2020-02-12 22:26 Stephen Rothwell
2020-02-13 10:35 ` Paul E. McKenney
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2020-02-12 22:26 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 429 bytes --]
Hi all,
In commit
71901ffaf70d ("locktorture: Print ratio of acquisitions, not failures")
Fixes tag
Fixes: 0af3fe1e ("locktorture: Add a lock-torture kernel module")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: Fixes tag needs some work in the rcu tree
2020-02-12 22:26 Stephen Rothwell
@ 2020-02-13 10:35 ` Paul E. McKenney
0 siblings, 0 replies; 17+ messages in thread
From: Paul E. McKenney @ 2020-02-13 10:35 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Linux Next Mailing List, Linux Kernel Mailing List
On Thu, Feb 13, 2020 at 09:26:13AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 71901ffaf70d ("locktorture: Print ratio of acquisitions, not failures")
>
> Fixes tag
>
> Fixes: 0af3fe1e ("locktorture: Add a lock-torture kernel module")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
Good catch, will fix, thank you!
Thanx, Paul
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: Fixes tag needs some work in the rcu tree
@ 2019-12-11 20:44 Stephen Rothwell
2019-12-11 22:52 ` Paul E. McKenney
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2019-12-11 20:44 UTC (permalink / raw)
To: Paul E. McKenney
Cc: Linux Next Mailing List, Linux Kernel Mailing List, kbuild test robot
[-- Attachment #1: Type: text/plain, Size: 410 bytes --]
Hi all,
In commit
3b570f534011 ("rcutorture: The rcu_boot_ended variable can be static")
Fixes tag
Fixes: 68ce6668914d ("rcutorture: Suppress forward-progress complaints during early boot")
has these problem(s):
- Target SHA1 does not exist
Did you mean
Fixes: 7e1204f7a29e ("rcutorture: Suppress forward-progress complaints during early boot")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: Fixes tag needs some work in the rcu tree
2019-12-11 20:44 Stephen Rothwell
@ 2019-12-11 22:52 ` Paul E. McKenney
0 siblings, 0 replies; 17+ messages in thread
From: Paul E. McKenney @ 2019-12-11 22:52 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, kbuild test robot
On Thu, Dec 12, 2019 at 07:44:51AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 3b570f534011 ("rcutorture: The rcu_boot_ended variable can be static")
>
> Fixes tag
>
> Fixes: 68ce6668914d ("rcutorture: Suppress forward-progress complaints during early boot")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Did you mean
>
> Fixes: 7e1204f7a29e ("rcutorture: Suppress forward-progress complaints during early boot")
You know, I should just fold those two commits together. Thank you for
catching this, Stephen!
Thanx, Paul
^ permalink raw reply [flat|nested] 17+ messages in thread
[parent not found: <20191029075041.7bf3f723@canb.auug.org.au>]
* Re: linux-next: Fixes tag needs some work in the rcu tree
[not found] <20191029075041.7bf3f723@canb.auug.org.au>
@ 2019-10-28 21:01 ` Stephen Rothwell
2019-10-29 0:36 ` Paul E. McKenney
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2019-10-28 21:01 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 594 bytes --]
Hi all,
[Resending with correct address syntax]
On Tue, 29 Oct 2019 07:50:41 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> [Resent with Paul's new (working) address]
>
> In commit
>
> 292d1bb21aba ("rcu: Several rcu_segcblist functions can be static")
>
> Fixes tag
>
> Fixes: ab2ef5c7b4d1 ("rcu/nocb: Atomic ->len field in rcu_segcblist structure")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Did you mean
>
> Fixes: eda669a6a2c5 ("rcu/nocb: Atomic ->len field in rcu_segcblist structure")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: Fixes tag needs some work in the rcu tree
2019-10-28 21:01 ` Stephen Rothwell
@ 2019-10-29 0:36 ` Paul E. McKenney
0 siblings, 0 replies; 17+ messages in thread
From: Paul E. McKenney @ 2019-10-29 0:36 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Paul E. McKenney, Linux Next Mailing List, Linux Kernel Mailing List
On Tue, Oct 29, 2019 at 08:01:16AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> [Resending with correct address syntax]
>
> On Tue, 29 Oct 2019 07:50:41 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > [Resent with Paul's new (working) address]
> >
> > In commit
> >
> > 292d1bb21aba ("rcu: Several rcu_segcblist functions can be static")
> >
> > Fixes tag
> >
> > Fixes: ab2ef5c7b4d1 ("rcu/nocb: Atomic ->len field in rcu_segcblist structure")
> >
> > has these problem(s):
> >
> > - Target SHA1 does not exist
> >
> > Did you mean
> >
> > Fixes: eda669a6a2c5 ("rcu/nocb: Atomic ->len field in rcu_segcblist structure")
Indeed I did, thank you, Stephen!
Thanx, Paul
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: Fixes tag needs some work in the rcu tree
@ 2019-10-28 20:48 Stephen Rothwell
0 siblings, 0 replies; 17+ messages in thread
From: Stephen Rothwell @ 2019-10-28 20:48 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
Hi all,
n commit
292d1bb21aba ("rcu: Several rcu_segcblist functions can be static")
Fixes tag
Fixes: ab2ef5c7b4d1 ("rcu/nocb: Atomic ->len field in rcu_segcblist structure")
has these problem(s):
- Target SHA1 does not exist
Did you mean
Fixes: eda669a6a2c5 ("rcu/nocb: Atomic ->len field in rcu_segcblist structure")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2024-04-08 23:14 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-08 23:14 linux-next: Fixes tag needs some work in the rcu tree Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2024-04-03 21:39 Stephen Rothwell
2024-04-04 12:14 ` Uladzislau Rezki
2024-04-04 14:35 ` Paul E. McKenney
2024-04-05 17:17 ` Uladzislau Rezki
2024-04-01 21:03 Stephen Rothwell
2023-04-05 22:36 Stephen Rothwell
2023-04-05 22:59 ` Paul E. McKenney
2020-10-05 11:53 Stephen Rothwell
2020-10-05 14:07 ` Paul E. McKenney
2020-02-12 22:26 Stephen Rothwell
2020-02-13 10:35 ` Paul E. McKenney
2019-12-11 20:44 Stephen Rothwell
2019-12-11 22:52 ` Paul E. McKenney
[not found] <20191029075041.7bf3f723@canb.auug.org.au>
2019-10-28 21:01 ` Stephen Rothwell
2019-10-29 0:36 ` Paul E. McKenney
2019-10-28 20:48 Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).