* [PATCH] parport: Increase buffer max length to avoid memory out of bounds overflow
@ 2024-04-28 7:27 huanglei
0 siblings, 0 replies; 5+ messages in thread
From: huanglei @ 2024-04-28 7:27 UTC (permalink / raw)
To: sudipm.mukherjee; +Cc: linux-kernel, huanglei
From: huanglei <huanglei@kylinos.cn>
Most of the time，will use 64 bit address.
such as port->base=0xffffffc010e21280 and then use
len += sprintf (buffer, "%lu\t%lu\n", port->base, port->base_hi),
port->base convert to string is "18446743799114896000" add
port->base_hi is "0" and "\t" "\n" len will be 23.
But buffer the original max length is 20, length 23 is out of buffer.
So to make sure 64 bit address will not experience buffer overflow,
need increase buffer size to 32.
Signed-off-by: huanglei <huanglei@kylinos.cn>
---
drivers/parport/procfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/parport/procfs.c b/drivers/parport/procfs.c
index bd388560ed59..6722ae620b68 100644
--- a/drivers/parport/procfs.c
+++ b/drivers/parport/procfs.c
@@ -117,7 +117,7 @@ static int do_hardware_base_addr(struct ctl_table *table, int write,
void *result, size_t *lenp, loff_t *ppos)
{
struct parport *port = (struct parport *)table->extra1;
- char buffer[20];
+ char buffer[32];
int len = 0;
if (*ppos) {
@@ -171,7 +171,7 @@ static int do_hardware_dma(struct ctl_table *table, int write,
void *result, size_t *lenp, loff_t *ppos)
{
struct parport *port = (struct parport *)table->extra1;
- char buffer[20];
+ char buffer[32];
int len = 0;
if (*ppos) {
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] parport: Increase buffer max length to avoid memory out of bounds overflow
@ 2024-05-22 7:36 huanglei814
0 siblings, 0 replies; 5+ messages in thread
From: huanglei814 @ 2024-05-22 7:36 UTC (permalink / raw)
To: sudipm.mukherjee; +Cc: linux-kernel, huanglei
From: huanglei <huanglei@kylinos.cn>
Most of the time，will use 64 bit address.
such as port->base=0xffffffc010e21280 and then use
len += sprintf (buffer, "%lu\t%lu\n", port->base, port->base_hi),
port->base convert to string is "18446743799114896000" add
port->base_hi is "0" and "\t" "\n" len will be 23.
But buffer the original max length is 20, length 23 is out of buffer.
So to make sure 64 bit address will not experience buffer overflow,
need increase buffer size to 32.
Signed-off-by: huanglei <huanglei@kylinos.cn>
---
drivers/parport/procfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/parport/procfs.c b/drivers/parport/procfs.c
index bd388560ed59..6722ae620b68 100644
--- a/drivers/parport/procfs.c
+++ b/drivers/parport/procfs.c
@@ -117,7 +117,7 @@ static int do_hardware_base_addr(struct ctl_table *table, int write,
void *result, size_t *lenp, loff_t *ppos)
{
struct parport *port = (struct parport *)table->extra1;
- char buffer[20];
+ char buffer[32];
int len = 0;
if (*ppos) {
@@ -171,7 +171,7 @@ static int do_hardware_dma(struct ctl_table *table, int write,
void *result, size_t *lenp, loff_t *ppos)
{
struct parport *port = (struct parport *)table->extra1;
- char buffer[20];
+ char buffer[32];
int len = 0;
if (*ppos) {
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] parport: Increase buffer max length to avoid memory out of bounds overflow
@ 2024-05-14 2:15 黄磊
0 siblings, 0 replies; 5+ messages in thread
From: 黄磊 @ 2024-05-14 2:15 UTC (permalink / raw)
To: sudipm.mukherjee; +Cc: linux-kernel
[-- Attachment #1: Type: text/html, Size: 1409 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] parport: Increase buffer max length to avoid memory out of bounds overflow
@ 2024-05-07 9:55 huanglei
0 siblings, 0 replies; 5+ messages in thread
From: huanglei @ 2024-05-07 9:55 UTC (permalink / raw)
To: sudipm.mukherjee; +Cc: linux-kernel, huanglei
From: huanglei <huanglei@kylinos.cn>
Most of the time，will use 64 bit address.
such as port->base=0xffffffc010e21280 and then use
len += sprintf (buffer, "%lu\t%lu\n", port->base, port->base_hi),
port->base convert to string is "18446743799114896000" add
port->base_hi is "0" and "\t" "\n" len will be 23.
But buffer the original max length is 20, length 23 is out of buffer.
So to make sure 64 bit address will not experience buffer overflow,
need increase buffer size to 32.
Signed-off-by: huanglei <huanglei@kylinos.cn>
---
drivers/parport/procfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/parport/procfs.c b/drivers/parport/procfs.c
index bd388560ed59..6722ae620b68 100644
--- a/drivers/parport/procfs.c
+++ b/drivers/parport/procfs.c
@@ -117,7 +117,7 @@ static int do_hardware_base_addr(struct ctl_table *table, int write,
void *result, size_t *lenp, loff_t *ppos)
{
struct parport *port = (struct parport *)table->extra1;
- char buffer[20];
+ char buffer[32];
int len = 0;
if (*ppos) {
@@ -171,7 +171,7 @@ static int do_hardware_dma(struct ctl_table *table, int write,
void *result, size_t *lenp, loff_t *ppos)
{
struct parport *port = (struct parport *)table->extra1;
- char buffer[20];
+ char buffer[32];
int len = 0;
if (*ppos) {
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] parport: Increase buffer max length to avoid memory out of bounds overflow
@ 2024-04-16 10:36 huanglei
0 siblings, 0 replies; 5+ messages in thread
From: huanglei @ 2024-04-16 10:36 UTC (permalink / raw)
To: sudipm.mukherjee; +Cc: linux-kernel, huanglei
From: huanglei <huanglei@kylinos.cn>
Most of the time，will use 64 bit address.
such as port->base=0xffffffc010e21280 and then use
len += sprintf (buffer, "%lu\t%lu\n", port->base, port->base_hi),
port->base convert to string is "18446743799114896000" add
port->base_hi is "0" and "\t" "\n" len will be 23.
But buffer the original max length is 20, length 23 is out of buffer.
So to make sure 64 bit address will not experience buffer overflow,
need increase buffer size to 32.
Signed-off-by: huanglei <huanglei@kylinos.cn>
---
drivers/parport/procfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/parport/procfs.c b/drivers/parport/procfs.c
index bd388560ed59..6722ae620b68 100644
--- a/drivers/parport/procfs.c
+++ b/drivers/parport/procfs.c
@@ -117,7 +117,7 @@ static int do_hardware_base_addr(struct ctl_table *table, int write,
void *result, size_t *lenp, loff_t *ppos)
{
struct parport *port = (struct parport *)table->extra1;
- char buffer[20];
+ char buffer[32];
int len = 0;
if (*ppos) {
@@ -171,7 +171,7 @@ static int do_hardware_dma(struct ctl_table *table, int write,
void *result, size_t *lenp, loff_t *ppos)
{
struct parport *port = (struct parport *)table->extra1;
- char buffer[20];
+ char buffer[32];
int len = 0;
if (*ppos) {
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-22 7:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-28 7:27 [PATCH] parport: Increase buffer max length to avoid memory out of bounds overflow huanglei
-- strict thread matches above, loose matches on Subject: below --
2024-05-22 7:36 huanglei814
2024-05-14 2:15 黄磊
2024-05-07 9:55 huanglei
2024-04-16 10:36 huanglei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).