From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Baoyou Xie <baoyou.xie@linaro.org>, <jejb@linux.vnet.ibm.com>,
<martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<arnd@linaro.org>, <xie.baoyou@zte.com.cn>
Subject: Re: [PATCH] scsi: move function declarationes to scsi_priv.h
Date: Mon, 29 Aug 2016 08:58:57 -0700 [thread overview]
Message-ID: <204f29e4-f582-5961-b62c-b0bf9de67b86@sandisk.com> (raw)
In-Reply-To: <1472317197-7865-1-git-send-email-baoyou.xie@linaro.org>
On 08/27/2016 09:59 AM, Baoyou Xie wrote:
> We get 2 warnings about global functions without a declaration
> in the scsi driver when building with W=1:
> drivers/scsi/scsi_lib.c:467:6: warning: no previous prototype for 'scsi_requeue_run_queue' [-Wmissing-prototypes]
> drivers/scsi/scsi_lib.c:2609:6: warning: no previous prototype for 'scsi_evt_thread' [-Wmissing-prototypes]
>
> in fact, both functiones are declared in drivers/scsi/scsi_scan.c
> but need to move the declarationes into scsi_priv.h.
Please fix the spelling in the patch title and description (functiones
-> functions and declarationes -> declarations). Anyway:
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
prev parent reply other threads:[~2016-08-29 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 16:59 [PATCH] scsi: move function declarationes to scsi_priv.h Baoyou Xie
2016-08-29 15:58 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=204f29e4-f582-5961-b62c-b0bf9de67b86@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=arnd@linaro.org \
--cc=baoyou.xie@linaro.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).