linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: arm: rockchip: fix Theobroma-System board bindings
@ 2019-09-17  8:34 Heiko Stuebner
  2019-09-17 14:16 ` Rob Herring
  2019-09-29 21:39 ` Heiko Stuebner
  0 siblings, 2 replies; 3+ messages in thread
From: Heiko Stuebner @ 2019-09-17  8:34 UTC (permalink / raw)
  To: linux-rockchip
  Cc: linux-kernel, devicetree, robh+dt, mark.rutland,
	christoph.muellner, Heiko Stuebner

The naming convention for the existing Theobroma boards is
soc-q7module-baseboard, so rk3399-puma-haikou and the in-kernel
devicetrees also follow that scheme.

For some reason in the binding a wrong or outdated naming slipped
in which does not match the used devicetrees and makes the dt-schema
complain now.

Fix this by using the names used in the wild by actual boards.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 7ecee58842f5..d85983de7919 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -501,12 +501,12 @@ properties:
 
       - description: Theobroma Systems RK3368-uQ7 with Haikou baseboard
         items:
-          - const: tsd,rk3368-uq7-haikou
+          - const: tsd,rk3368-lion-haikou
           - const: rockchip,rk3368
 
       - description: Theobroma Systems RK3399-Q7 with Haikou baseboard
         items:
-          - const: tsd,rk3399-q7-haikou
+          - const: tsd,rk3399-puma-haikou
           - const: rockchip,rk3399
 
       - description: Tronsmart Orion R68 Meta
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: arm: rockchip: fix Theobroma-System board bindings
  2019-09-17  8:34 [PATCH] dt-bindings: arm: rockchip: fix Theobroma-System board bindings Heiko Stuebner
@ 2019-09-17 14:16 ` Rob Herring
  2019-09-29 21:39 ` Heiko Stuebner
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2019-09-17 14:16 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: open list:ARM/Rockchip SoC...,
	linux-kernel, devicetree, Mark Rutland, Christoph Muellner

On Tue, Sep 17, 2019 at 3:35 AM Heiko Stuebner <heiko@sntech.de> wrote:
>
> The naming convention for the existing Theobroma boards is
> soc-q7module-baseboard, so rk3399-puma-haikou and the in-kernel
> devicetrees also follow that scheme.
>
> For some reason in the binding a wrong or outdated naming slipped
> in which does not match the used devicetrees and makes the dt-schema
> complain now.
>
> Fix this by using the names used in the wild by actual boards.

Perhaps a Fixes tag.

> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: arm: rockchip: fix Theobroma-System board bindings
  2019-09-17  8:34 [PATCH] dt-bindings: arm: rockchip: fix Theobroma-System board bindings Heiko Stuebner
  2019-09-17 14:16 ` Rob Herring
@ 2019-09-29 21:39 ` Heiko Stuebner
  1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2019-09-29 21:39 UTC (permalink / raw)
  To: linux-rockchip
  Cc: linux-kernel, devicetree, robh+dt, mark.rutland, christoph.muellner

Am Dienstag, 17. September 2019, 10:34:53 CEST schrieb Heiko Stuebner:
> The naming convention for the existing Theobroma boards is
> soc-q7module-baseboard, so rk3399-puma-haikou and the in-kernel
> devicetrees also follow that scheme.
> 
> For some reason in the binding a wrong or outdated naming slipped
> in which does not match the used devicetrees and makes the dt-schema
> complain now.
> 
> Fix this by using the names used in the wild by actual boards.
> 
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

added a Fixes tag and applies as fix for 5.4



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-09-29 21:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-17  8:34 [PATCH] dt-bindings: arm: rockchip: fix Theobroma-System board bindings Heiko Stuebner
2019-09-17 14:16 ` Rob Herring
2019-09-29 21:39 ` Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).