linux-next: build failure after merge of the fscache tree

linux-next: build failure after merge of the fscache tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 926 bytes --]

Hi David,

After merging the fscache tree, today's linux-next build (x86_64
allmodconfig) failed like this:

fs/cachefiles/bind.c: In function 'cachefiles_daemon_unbind':
fs/cachefiles/bind.c:361:4: error: too few arguments to function 'vfs_unlink'
    ret = vfs_unlink(cache->root->d_inode, dentry);
    ^
In file included from fs/cachefiles/bind.c:18:0:
include/linux/fs.h:1458:12: note: declared here
 extern int vfs_unlink(struct inode *, struct dentry *, struct inode **);
            ^

Caused by commit ab3d73f3ce3d ("Cachefiles: Add features that make sanity
checking easier") from the fscache tree interacting with commit
b21996e36c8e ("locks: break delegations on unlink") from Linus' tree
(which entered Linus' tree before v3.13-rc1).  Does this build for you?

I have used the fscache tree from next-20140205 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the fscache tree

[David Howells]

Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the fscache tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

Yep.  I'd forgotten that branch was in linux-next.  I've moved the patches to
fscache-experimental so that they don't pester Fengguang either.

David

linux-next: build failure after merge of the fscache tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 786 bytes --]

Hi all,

After merging the fscache tree, today's linux-next build (x86_64
allmodconfig) failed like this:

fs/cifs/fscache.c: In function 'cifs_fscache_get_inode_cookie':
fs/cifs/fscache.c:106:14: error: 'struct cifsInodeInfo' has no member named 'netfs_ctx'
  106 |         cifsi->netfs_ctx.cache =
      |              ^~
fs/cifs/fscache.c: In function 'cifs_fscache_release_inode_cookie':
fs/cifs/fscache.c:134:22: error: 'struct cifsInodeInfo' has no member named 'netfs_ctx'
  134 |                 cifsi->netfs_ctx.cache = NULL;
      |                      ^~

Caused by commit

  a3457aa9c40f ("netfs: Fix gcc-12 warning by embedding vfs inode in netfs_i_context")

I have used the fscache tree from next-20220519 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]