* [PATCH v3 0/2] media: hi846: minor build fixes
@ 2021-10-19 15:55 Martin Kepplinger
2021-10-19 15:55 ` [PATCH v3 1/2] media: hi846: include property.h instead of of_graph.h Martin Kepplinger
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Martin Kepplinger @ 2021-10-19 15:55 UTC (permalink / raw)
To: sakari.ailus
Cc: kernel, linux-kernel, linux-media, lkp, martin.kepplinger,
mchehab, paul.kocialkowski
Similar to many other drivers this basically should fix the build warning
where the const struct of_device_id we define can be unused. Reported
here:
https://lore.kernel.org/linux-media/202110170632.b6umsB8m-lkp@intel.com/
revision history
----------------
v3: (thank you Sakari)
* include property.h instead of of_graph.h and remove the of_match_ptr macro
v2 and v1:
https://lore.kernel.org/linux-media/20211018095859.255912-1-martin.kepplinger@puri.sm/
Martin Kepplinger (2):
media: hi846: include property.h instead of of_graph.h
media: hi846: remove the of_match_ptr macro
drivers/media/i2c/hi846.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.30.2
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v3 1/2] media: hi846: include property.h instead of of_graph.h
2021-10-19 15:55 [PATCH v3 0/2] media: hi846: minor build fixes Martin Kepplinger
@ 2021-10-19 15:55 ` Martin Kepplinger
2021-10-19 15:55 ` [PATCH v3 2/2] media: hi846: remove the of_match_ptr macro Martin Kepplinger
2021-10-20 12:57 ` [PATCH v3 0/2] media: hi846: minor build fixes Sakari Ailus
2 siblings, 0 replies; 6+ messages in thread
From: Martin Kepplinger @ 2021-10-19 15:55 UTC (permalink / raw)
To: sakari.ailus
Cc: kernel, linux-kernel, linux-media, lkp, martin.kepplinger,
mchehab, paul.kocialkowski
Include the more portable property.h instead of the OF specific of_graph.h
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
drivers/media/i2c/hi846.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/hi846.c b/drivers/media/i2c/hi846.c
index 822ce3021fde..614d55932903 100644
--- a/drivers/media/i2c/hi846.c
+++ b/drivers/media/i2c/hi846.c
@@ -7,9 +7,9 @@
#include <linux/gpio/consumer.h>
#include <linux/i2c.h>
#include <linux/module.h>
-#include <linux/of_graph.h>
#include <linux/pm_runtime.h>
#include <linux/pm.h>
+#include <linux/property.h>
#include <linux/regulator/consumer.h>
#include <media/v4l2-ctrls.h>
#include <media/v4l2-device.h>
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v3 2/2] media: hi846: remove the of_match_ptr macro
2021-10-19 15:55 [PATCH v3 0/2] media: hi846: minor build fixes Martin Kepplinger
2021-10-19 15:55 ` [PATCH v3 1/2] media: hi846: include property.h instead of of_graph.h Martin Kepplinger
@ 2021-10-19 15:55 ` Martin Kepplinger
2021-10-20 12:57 ` [PATCH v3 0/2] media: hi846: minor build fixes Sakari Ailus
2 siblings, 0 replies; 6+ messages in thread
From: Martin Kepplinger @ 2021-10-19 15:55 UTC (permalink / raw)
To: sakari.ailus
Cc: kernel, linux-kernel, linux-media, lkp, martin.kepplinger,
mchehab, paul.kocialkowski
Similar to other drivers, this should fix a Clang compilar warning when
building without CONFIG_OF in which case of_match_ptr() is NULL and
the const struct we would use otherwise is unused.
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Reported-by: kernel test robot <lkp@intel.com>
---
drivers/media/i2c/hi846.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/hi846.c b/drivers/media/i2c/hi846.c
index 614d55932903..48909faeced4 100644
--- a/drivers/media/i2c/hi846.c
+++ b/drivers/media/i2c/hi846.c
@@ -2176,7 +2176,7 @@ static struct i2c_driver hi846_i2c_driver = {
.driver = {
.name = "hi846",
.pm = &hi846_pm_ops,
- .of_match_table = of_match_ptr(hi846_of_match),
+ .of_match_table = hi846_of_match,
},
.probe_new = hi846_probe,
.remove = hi846_remove,
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v3 0/2] media: hi846: minor build fixes
2021-10-19 15:55 [PATCH v3 0/2] media: hi846: minor build fixes Martin Kepplinger
2021-10-19 15:55 ` [PATCH v3 1/2] media: hi846: include property.h instead of of_graph.h Martin Kepplinger
2021-10-19 15:55 ` [PATCH v3 2/2] media: hi846: remove the of_match_ptr macro Martin Kepplinger
@ 2021-10-20 12:57 ` Sakari Ailus
2021-11-04 10:53 ` Martin Kepplinger
2 siblings, 1 reply; 6+ messages in thread
From: Sakari Ailus @ 2021-10-20 12:57 UTC (permalink / raw)
To: Martin Kepplinger
Cc: kernel, linux-kernel, linux-media, lkp, mchehab, paul.kocialkowski
On Tue, Oct 19, 2021 at 05:55:07PM +0200, Martin Kepplinger wrote:
> Similar to many other drivers this basically should fix the build warning
> where the const struct of_device_id we define can be unused. Reported
> here:
> https://lore.kernel.org/linux-media/202110170632.b6umsB8m-lkp@intel.com/
Thanks, Martin!>
--
Sakari Ailus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 0/2] media: hi846: minor build fixes
2021-10-20 12:57 ` [PATCH v3 0/2] media: hi846: minor build fixes Sakari Ailus
@ 2021-11-04 10:53 ` Martin Kepplinger
2021-11-05 8:50 ` Sakari Ailus
0 siblings, 1 reply; 6+ messages in thread
From: Martin Kepplinger @ 2021-11-04 10:53 UTC (permalink / raw)
To: Sakari Ailus
Cc: kernel, linux-kernel, linux-media, lkp, mchehab, paul.kocialkowski
Am Mittwoch, dem 20.10.2021 um 15:57 +0300 schrieb Sakari Ailus:
> On Tue, Oct 19, 2021 at 05:55:07PM +0200, Martin Kepplinger wrote:
> > Similar to many other drivers this basically should fix the build
> > warning
> > where the const struct of_device_id we define can be unused.
> > Reported
> > here:
> > https://lore.kernel.org/linux-media/202110170632.b6umsB8m-lkp@intel.com/
>
> Thanks, Martin!>
>
since the Intel test robot just reminded me that the issue still
remains: are these patches queued somewhere already?
thanks!
martin
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3 0/2] media: hi846: minor build fixes
2021-11-04 10:53 ` Martin Kepplinger
@ 2021-11-05 8:50 ` Sakari Ailus
0 siblings, 0 replies; 6+ messages in thread
From: Sakari Ailus @ 2021-11-05 8:50 UTC (permalink / raw)
To: Martin Kepplinger
Cc: kernel, linux-kernel, linux-media, lkp, mchehab, paul.kocialkowski
Hi Martin,
On Thu, Nov 04, 2021 at 11:53:08AM +0100, Martin Kepplinger wrote:
> Am Mittwoch, dem 20.10.2021 um 15:57 +0300 schrieb Sakari Ailus:
> > On Tue, Oct 19, 2021 at 05:55:07PM +0200, Martin Kepplinger wrote:
> > > Similar to many other drivers this basically should fix the build
> > > warning
> > > where the const struct of_device_id we define can be unused.
> > > Reported
> > > here:
> > > https://lore.kernel.org/linux-media/202110170632.b6umsB8m-lkp@intel.com/
> >
> > Thanks, Martin!>
> >
>
> since the Intel test robot just reminded me that the issue still
> remains: are these patches queued somewhere already?
Not yet. And thanks for the ping. I had forgotten about these fixes and
wrote a fix for the same issue, so I'm taking these two instead.
--
Sakari Ailus
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-11-05 8:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-19 15:55 [PATCH v3 0/2] media: hi846: minor build fixes Martin Kepplinger
2021-10-19 15:55 ` [PATCH v3 1/2] media: hi846: include property.h instead of of_graph.h Martin Kepplinger
2021-10-19 15:55 ` [PATCH v3 2/2] media: hi846: remove the of_match_ptr macro Martin Kepplinger
2021-10-20 12:57 ` [PATCH v3 0/2] media: hi846: minor build fixes Sakari Ailus
2021-11-04 10:53 ` Martin Kepplinger
2021-11-05 8:50 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).