RE: [PATCH 3/4] power_supply: Introduce PSE compliant algorithm

From: "Tc, Jenny" <jenny.tc@intel.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
	Pavel Machek <pavel@ucw.cz>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Anton Vorontsov <anton.vorontsov@linaro.org>,
	David Woodhouse <dwmw2@infradead.org>,
	"David Cohen" <david.a.cohen@linux.intel.com>,
	"Pallala, Ramakrishna" <ramakrishna.pallala@intel.com>
Subject: RE: [PATCH 3/4] power_supply: Introduce PSE compliant algorithm
Date: Tue, 8 Jul 2014 06:07:29 +0000	[thread overview]
Message-ID: <20ADAB092842284E95860F279283C56422F95A3E@BGSMSX104.gar.corp.intel.com> (raw)
In-Reply-To: <20140703145617.GA23309@earth.universe>

> > +static int get_tempzone(struct psy_pse_chrg_prof *pse_mod_bprof,
> > +		int temp)
> > +{
> > +	int i = 0;
> > +	int temp_range_cnt;
> > +
> > +	temp_range_cnt =  min_t(u16, pse_mod_bprof->temp_mon_ranges,
> > +					BATT_TEMP_NR_RNG);
> > +	if ((temp < pse_mod_bprof->temp_low_lim) ||
> > +		(temp > pse_mod_bprof->temp_mon_range[0].temp_up_lim))
> > +		return -EINVAL;
> > +
> > +	for (i = 0; i < temp_range_cnt; ++i)
> > +		if (temp > pse_mod_bprof->temp_mon_range[i].temp_up_lim)
> > +			break;
> > +	return i-1;
> > +}
> 
> pse_mod_bprof->temp_mon_ranges > BATT_TEMP_NR_RNG is not allowed, so I
> suggest to print an error and return some error code.
> 
min_t takes care of the upper bound. The algorithm process BATT_TEMP_NR_RNG
even if the actual number of zones are greater than this. 
Agree to other comments

-Jenny