From: Pavel Machek <pavel@ucw.cz>
To: Jenny TC <jenny.tc@intel.com>
Cc: linux-kernel@vger.kernel.org,
"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
"Anton Vorontsov" <cbouatmailru@gmail.com>,
"Anton Vorontsov" <anton.vorontsov@linaro.org>,
"Kim Milo" <Milo.Kim@ti.com>, "Lee Jones" <lee.jones@linaro.org>,
"Jingoo Han" <jg1.han@samsung.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Sachin Kamat" <sachin.kamat@linaro.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Rhyland Klein" <rklein@nvidia.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"David Woodhouse" <dwmw2@infradead.org>,
"Tony Lindgren" <tony@atomide.com>,
"Russell King" <linux@arm.linux.org.uk>,
"Sebastian Reichel" <sre@ring0.de>,
aaro.koskinen@iki.fi,
"Pallala Ramakrishna" <ramakrishna.pallala@intel.com>,
freemangordon@abv.bg, linux-omap@vger.kernel.org
Subject: Re: [PATCH 3/4] power_supply: Introduce PSE compliant algorithm
Date: Tue, 4 Feb 2014 12:36:40 +0100 [thread overview]
Message-ID: <20140204113640.GD2450@amd.pavel.ucw.cz> (raw)
In-Reply-To: <1391490780-6141-4-git-send-email-jenny.tc@intel.com>
Hi!
> --- a/drivers/power/Kconfig
> +++ b/drivers/power/Kconfig
> @@ -22,6 +22,19 @@ config POWER_SUPPLY_CHARGER
> drivers to keep the charging logic outside and the charger driver
> just need to abstract the charger hardware.
>
> +config POWER_SUPPLY_CHARGING_ALGO_PSE
> + bool "PSE compliant charging algorithm"
> + help
> + Say Y here to select Product Safety Engineering (PSE) compliant
> + charging algorithm. As per PSE standard the battery characteristics
> + and thereby the charging rates can vary on different temperature
> + zones. This config will enable PSE compliant charging algorithm with
> + maintenance charging support. At runtime the algorithm will be
> + selected by the psy charger driver based on the type of the battery
> + charging profile.
Information where to expect PSE compliant chargers would be nice.
> +static inline bool __is_battery_full
> + (long volt, long cur, long iterm, unsigned long cv)
> +{
codingstyle.
> + pr_devel("%s:current=%ld pse_mod_bprof->chrg_term_mA =%ld voltage_now=%ld full_cond=%ld",
> + __func__, cur, iterm, volt * 100, (FULL_CV_MIN * cv));
> +
> + return (cur > 0) && (cur <= iterm) &&
> + ((volt * 100) >= (FULL_CV_MIN * cv));
Codingstyle. Just run checkpatch.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-02-04 11:36 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 5:12 [PATCH v5 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-02-04 5:12 ` [PATCH 1/4] power_supply: Add inlmt,iterm, min/max temp props Jenny TC
2014-02-04 5:12 ` [PATCH 2/4] power_supply: Introduce generic psy charging driver Jenny TC
2014-02-04 11:36 ` Pavel Machek
2014-02-05 8:14 ` Jenny Tc
2014-02-12 11:00 ` Pavel Machek
2014-02-13 0:51 ` Jingoo Han
2014-02-04 5:12 ` [PATCH 3/4] power_supply: Introduce PSE compliant algorithm Jenny TC
2014-02-04 11:36 ` Pavel Machek [this message]
2014-02-20 5:16 ` Jenny Tc
2014-02-21 14:45 ` Pavel Machek
2014-02-26 2:54 ` Jenny Tc
2014-02-27 19:47 ` Linus Walleij
2014-02-28 2:52 ` Jenny Tc
2014-02-27 20:46 ` Pavel Machek
2014-02-27 20:18 ` Linus Walleij
2014-02-28 3:07 ` Jenny Tc
2014-02-28 10:08 ` Pavel Machek
2014-03-03 3:11 ` Jenny Tc
2014-03-03 10:42 ` Pavel Machek
2014-03-07 3:34 ` Linus Walleij
2014-03-07 3:43 ` Jenny Tc
2014-02-04 5:13 ` [PATCH 4/4] power_supply: bq24261 charger driver Jenny TC
2014-02-04 11:36 ` Pavel Machek
2014-02-20 5:03 ` Jenny Tc
2014-02-21 14:44 ` Pavel Machek
2014-02-25 11:51 ` Jenny Tc
-- strict thread matches above, loose matches on Subject: below --
2014-07-08 6:04 [PATCHv11 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-07-08 6:04 ` [PATCH 3/4] power_supply: Introduce PSE compliant algorithm Jenny TC
2014-06-30 9:55 [PATCHv10 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-06-30 9:55 ` [PATCH 3/4] power_supply: Introduce PSE compliant algorithm Jenny TC
2014-07-03 14:56 ` Sebastian Reichel
2014-07-08 6:07 ` Tc, Jenny
2014-07-08 15:56 ` Sebastian Reichel
2014-07-11 2:46 ` Tc, Jenny
2014-07-17 21:13 ` Sebastian Reichel
2014-06-19 14:02 [PATCHv9 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-06-19 14:02 ` [PATCH 3/4] power_supply: Introduce PSE compliant algorithm Jenny TC
2014-02-20 5:53 [PATCH v6 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-02-20 5:53 ` [PATCH 3/4] power_supply: Introduce PSE compliant algorithm Jenny TC
2014-01-30 17:30 [PATCH v4 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-01-30 17:30 ` [PATCH 3/4] power_supply: Introduce PSE compliant algorithm Jenny TC
2014-01-22 17:19 [PATCH v3 0/4] power_supply: Introduce power supply charging driver Jenny TC
2014-01-22 17:19 ` [PATCH 3/4] power_supply: Introduce PSE compliant algorithm Jenny TC
2014-01-25 22:29 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140204113640.GD2450@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=Milo.Kim@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=anton.vorontsov@linaro.org \
--cc=cbouatmailru@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=freemangordon@abv.bg \
--cc=jenny.tc@intel.com \
--cc=jg1.han@samsung.com \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pali.rohar@gmail.com \
--cc=ramakrishna.pallala@intel.com \
--cc=rjw@rjwysocki.net \
--cc=rklein@nvidia.com \
--cc=sachin.kamat@linaro.org \
--cc=sre@ring0.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).