linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Archie Pusaka <apusaka@google.com>
Cc: linux-bluetooth <linux-bluetooth@vger.kernel.org>,
	CrosBT Upstreaming <chromeos-bluetooth-upstreaming@chromium.org>,
	Archie Pusaka <apusaka@chromium.org>,
	Miao-chen Chou <mcchou@chromium.org>,
	Yun-Hao Chung <howardchung@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	netdev@vger.kernel.org
Subject: Re: [PATCH v1 1/5] Bluetooth: advmon offload MSFT add rssi support
Date: Thu, 3 Dec 2020 15:03:31 +0100	[thread overview]
Message-ID: <20B6F2AD-1A60-4E3C-84C2-E3CB7294FABC@holtmann.org> (raw)
In-Reply-To: <20201203182903.v1.1.I92d2e2a87419730d60136680cbe27636baf94b15@changeid>

Hi Archie,

> MSFT needs rssi parameter for monitoring advertisement packet,
> therefore we should supply them from mgmt.
> 
> Signed-off-by: Archie Pusaka <apusaka@chromium.org>
> Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
> Reviewed-by: Yun-Hao Chung <howardchung@google.com>

I don’t need any Reviewed-by if they are not catching an obvious user API breakage.

> ---
> 
> include/net/bluetooth/hci_core.h | 9 +++++++++
> include/net/bluetooth/mgmt.h     | 9 +++++++++
> net/bluetooth/mgmt.c             | 8 ++++++++
> 3 files changed, 26 insertions(+)
> 
> diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
> index 9873e1c8cd16..42d446417817 100644
> --- a/include/net/bluetooth/hci_core.h
> +++ b/include/net/bluetooth/hci_core.h
> @@ -246,8 +246,17 @@ struct adv_pattern {
> 	__u8 value[HCI_MAX_AD_LENGTH];
> };
> 
> +struct adv_rssi_thresholds {
> +	__s8 low_threshold;
> +	__s8 high_threshold;
> +	__u16 low_threshold_timeout;
> +	__u16 high_threshold_timeout;
> +	__u8 sampling_period;
> +};
> +
> struct adv_monitor {
> 	struct list_head patterns;
> +	struct adv_rssi_thresholds rssi;
> 	bool		active;
> 	__u16		handle;
> };
> diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
> index d8367850e8cd..dc534837be0e 100644
> --- a/include/net/bluetooth/mgmt.h
> +++ b/include/net/bluetooth/mgmt.h
> @@ -763,9 +763,18 @@ struct mgmt_adv_pattern {
> 	__u8 value[31];
> } __packed;
> 
> +struct mgmt_adv_rssi_thresholds {
> +	__s8 high_threshold;
> +	__le16 high_threshold_timeout;
> +	__s8 low_threshold;
> +	__le16 low_threshold_timeout;
> +	__u8 sampling_period;
> +} __packed;
> +
> #define MGMT_OP_ADD_ADV_PATTERNS_MONITOR	0x0052
> struct mgmt_cp_add_adv_patterns_monitor {
> 	__u8 pattern_count;
> +	struct mgmt_adv_rssi_thresholds rssi;
> 	struct mgmt_adv_pattern patterns[];
> } __packed;

This is something we can not do. It breaks an userspace facing API. Is the mgmt opcode 0x0052 in an already released kernel?

Regards

Marcel


  reply	other threads:[~2020-12-03 14:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03 10:29 [PATCH v1 0/5] MSFT offloading support for advertisement monitor Archie Pusaka
2020-12-03 10:29 ` [PATCH v1 1/5] Bluetooth: advmon offload MSFT add rssi support Archie Pusaka
2020-12-03 14:03   ` Marcel Holtmann [this message]
2020-12-04  3:25     ` Archie Pusaka
2020-12-04  9:51       ` Marcel Holtmann
2020-12-04 16:34         ` Archie Pusaka
2020-12-07  9:56           ` Marcel Holtmann
2020-12-07 10:48             ` Archie Pusaka
2020-12-03 10:29 ` [PATCH v1 2/5] Bluetooth: advmon offload MSFT add monitor Archie Pusaka
2020-12-03 10:29 ` [PATCH v1 3/5] Bluetooth: advmon offload MSFT remove monitor Archie Pusaka
2020-12-03 10:29 ` [PATCH v1 4/5] Bluetooth: advmon offload MSFT handle controller reset Archie Pusaka
2020-12-03 10:29 ` [PATCH v1 5/5] Bluetooth: advmon offload MSFT handle filter enablement Archie Pusaka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20B6F2AD-1A60-4E3C-84C2-E3CB7294FABC@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=apusaka@chromium.org \
    --cc=apusaka@google.com \
    --cc=chromeos-bluetooth-upstreaming@chromium.org \
    --cc=davem@davemloft.net \
    --cc=howardchung@google.com \
    --cc=johan.hedberg@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcchou@chromium.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH v1 1/5] Bluetooth: advmon offload MSFT add rssi support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).