From: Marcel Holtmann <marcel@holtmann.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Pavel Machek <pavel@ucw.cz>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Baole Ni <baolex.ni@intel.com>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
chuansheng.liu@intel.com
Subject: Re: [PATCH] Add file permission mode helpers
Date: Wed, 3 Aug 2016 11:53:06 +0200 [thread overview]
Message-ID: <20EC504F-F679-4244-8C04-00165236D028@holtmann.org> (raw)
In-Reply-To: <20160803082855.GA32280@kroah.com>
Hi Greg,
>> An added advantage would be that during review it would stick out like a sore
>> thumb if anyone used a 'weird' permission variant.
>>
>> For example, if you saw these lines in a driver patch:
>>
>> + __ATTR(l1, 0444, driver_show_l4, NULL);
>> + __ATTR(l3, 0446, driver_show_l4, NULL);
>> + __ATTR(l2, 04444, driver_show_l4, NULL);
>> + __ATTR(l4, 0444, driver_show_l4, NULL);
>>
>> ... would you notice it at a glance that it contains two security holes?
>
> I've tried to deal with that in the past with the __ATTR_RW() and
> __ATTR_RO() and __ATTR_WO() macros that more should be using. I swept
> the tree a few years ago to try to fix up most of them, but I know I
> didn't catch them all, and more files have been added since then.
I said in another response that maybe module_param_rw and module_param_ro will make some sense. Not sure if they are easier to read or not. I mean for each usage, we could look at the tree and see what values are actually used. My bet is that for module_param only a few ones are used. I have the feeling it is 0444 or 0644 and nothing else. Maybe some outlaws with 0400 and 0600 that don't even need to be that secretive.
Regards
Marcel
next prev parent reply other threads:[~2016-08-03 9:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 20:58 Please don't replace numeric parameter like 0444 with macro Linus Torvalds
2016-08-02 21:53 ` Rob Landley
2016-08-02 23:39 ` [PATCH] checkpatch: Look for symbolic permissions and suggest octal instead Joe Perches
2016-08-03 0:15 ` Al Viro
2016-08-03 0:30 ` Joe Perches
2016-08-15 16:38 ` Joe Perches
2016-08-03 0:42 ` Please don't replace numeric parameter like 0444 with macro Al Viro
2016-08-03 8:07 ` Konstantin Khlebnikov
2016-08-03 8:30 ` Richard Weinberger
2016-08-03 8:11 ` [PATCH] Add file permission mode helpers Ingo Molnar
2016-08-03 8:28 ` Greg Kroah-Hartman
2016-08-03 8:39 ` Ingo Molnar
2016-08-03 9:21 ` Willy Tarreau
2016-08-03 9:53 ` Marcel Holtmann [this message]
2016-08-03 15:49 ` Joe Perches
2016-08-03 16:38 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20EC504F-F679-4244-8C04-00165236D028@holtmann.org \
--to=marcel@holtmann.org \
--cc=baolex.ni@intel.com \
--cc=chuansheng.liu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mingo@kernel.org \
--cc=pavel@ucw.cz \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).