* [PATCH] mfd: da9052: constify spi_device_id
@ 2017-08-21 17:55 Arvind Yadav
2017-08-22 7:41 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-08-21 17:55 UTC (permalink / raw)
To: lee.jones, support.opensource; +Cc: linux-kernel
spi_device_id are not supposed to change at runtime. All functions
working with spi_device_id provided by <linux/i2c.h> work with
const spi_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/mfd/da9052-spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/da9052-spi.c b/drivers/mfd/da9052-spi.c
index b9ea1b2..abfb118 100644
--- a/drivers/mfd/da9052-spi.c
+++ b/drivers/mfd/da9052-spi.c
@@ -67,7 +67,7 @@ static int da9052_spi_remove(struct spi_device *spi)
return 0;
}
-static struct spi_device_id da9052_spi_id[] = {
+static const struct spi_device_id da9052_spi_id[] = {
{"da9052", DA9052},
{"da9053-aa", DA9053_AA},
{"da9053-ba", DA9053_BA},
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: da9052: constify spi_device_id
2017-08-21 17:55 [PATCH] mfd: da9052: constify spi_device_id Arvind Yadav
@ 2017-08-22 7:41 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2017-08-22 7:41 UTC (permalink / raw)
To: Arvind Yadav; +Cc: support.opensource, linux-kernel
On Mon, 21 Aug 2017, Arvind Yadav wrote:
> spi_device_id are not supposed to change at runtime. All functions
> working with spi_device_id provided by <linux/i2c.h> work with
> const spi_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/mfd/da9052-spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-22 7:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-21 17:55 [PATCH] mfd: da9052: constify spi_device_id Arvind Yadav
2017-08-22 7:41 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).