From: Alexandre Torgue <alexandre.torgue@st.com>
To: <mani@kernel.org>, <robh+dt@kernel.org>, <mcoquelin.stm32@gmail.com>
Cc: <devicetree@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/6] ARM: dts: stm32mp1: Add IoT Box board support
Date: Wed, 29 Apr 2020 10:02:20 +0200 [thread overview]
Message-ID: <210a98b3-feea-8faf-316c-d45e1697ea21@st.com> (raw)
In-Reply-To: <20200420173124.27416-7-mani@kernel.org>
Hi Mani
On 4/20/20 7:31 PM, mani@kernel.org wrote:
> From: Manivannan Sadhasivam <mani@kernel.org>
>
> IoT Box is an IoT gateway device based on Stinger96 board powered by
> STM32MP1 SoC, designed and manufactured by Shiratech Solutions. This
> device makes use of Stinger96 board by having it as a base board with
> one additional mezzanine on top.
>
> Following are the features exposed by this device in addition to the
> Stinger96 board:
>
> * WiFi/BT
> * CCS811 VOC sensor
> * 2x Digital microphones IM69D130
> * 12x WS2812B LEDs
>
> Following peripherals are tested and known to work:
>
> * WiFi/BT
> * CCS811
>
> More information about this device can be found in Shiratech website:
> https://www.shiratech-solutions.com/products/iot-box/
>
> Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/stm32mp157a-iot-box.dts | 92 +++++++++++++++++++++++
> 2 files changed, 93 insertions(+)
> create mode 100644 arch/arm/boot/dts/stm32mp157a-iot-box.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 966b81dfffd6..455ec6eb6303 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1030,6 +1030,7 @@ dtb-$(CONFIG_ARCH_STM32) += \
> stm32h743i-disco.dtb \
> stm32mp157a-avenger96.dtb \
> stm32mp157a-dk1.dtb \
> + stm32mp157a-iot-box.dtb \
> stm32mp157a-stinger96.dtb \
> stm32mp157c-dhcom-pdk2.dtb \
> stm32mp157c-dk2.dtb \
> diff --git a/arch/arm/boot/dts/stm32mp157a-iot-box.dts b/arch/arm/boot/dts/stm32mp157a-iot-box.dts
> new file mode 100644
> index 000000000000..fa1c006ce531
> --- /dev/null
> +++ b/arch/arm/boot/dts/stm32mp157a-iot-box.dts
> @@ -0,0 +1,92 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (C) 2020 Manivannan Sadhasivam
> + */
> +
> +/dts-v1/;
> +#include "stm32mp157a-stinger96.dtsi"
> +
> +/ {
> + model = "Shiratech STM32MP157A IoT Box";
> + compatible = "shiratech,stm32mp157a-iot-box", "st,stm32mp157";
> +
> + wlan_pwr: regulator-wlan {
> + compatible = "regulator-fixed";
> +
> + regulator-name = "wl-reg";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> +
> + gpios = <&gpiog 3 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +};
> +
> +&i2c2 {
> + ccs811@5b {
> + compatible = "ams,ccs811";
> + reg = <0x5b>;
> + wakeup-gpios = <&gpioa 12 GPIO_ACTIVE_LOW>;
> + reset-gpios = <&gpioa 11 GPIO_ACTIVE_LOW>;
> + };
> +};
> +
> +&pinctrl {
Currently all pinmux definition are done in stm32mp15-pinctrl.dtsi file.
Can you move it ?
Otherwise (except commit title) it is ok for me.
thanks
alex
> + /*
> + * Note: The SDMMC2 pins lack external pullups on data lines. Hence,
> + * we need to enable it in the SoC.
> + */
> + sdmmc2_b4_pins_pull: sdmmc2-b4-pull {
> + pins1 {
> + pinmux = <STM32_PINMUX('B', 14, AF9)>, /* SDMMC2_D0 */
> + <STM32_PINMUX('B', 15, AF9)>, /* SDMMC2_D1 */
> + <STM32_PINMUX('B', 3, AF9)>, /* SDMMC2_D2 */
> + <STM32_PINMUX('B', 4, AF9)>, /* SDMMC2_D3 */
> + <STM32_PINMUX('G', 6, AF10)>; /* SDMMC2_CMD */
> + slew-rate = <1>;
> + bias-pull-up;
> + };
> + pins2 {
> + pinmux = <STM32_PINMUX('E', 3, AF9)>; /* SDMMC2_CK */
> + slew-rate = <2>;
> + drive-push-pull;
> + bias-disable;
> + };
> + };
> +};
> +
> +/* WiFi */
> +&sdmmc2 {
> + pinctrl-names = "default", "opendrain", "sleep";
> + pinctrl-0 = <&sdmmc2_b4_pins_pull>;
> + pinctrl-1 = <&sdmmc2_b4_od_pins_b>;
> + pinctrl-2 = <&sdmmc2_b4_sleep_pins_a>;
> + broken-cd;
> + non-removable;
> + st,neg-edge;
> + bus-width = <1>;
> + vmmc-supply = <&wlan_pwr>;
> + status = "okay";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> + brcmf: bcrmf@1 {
> + reg = <1>;
> + compatible = "brcm,bcm4329-fmac";
> + };
> +};
> +
> +/* Bluetooth */
> +&uart4 {
> + /* Note: HW flow control is broken, hence using custom CTS/RTS gpios */
> + /delete-property/st,hw-flow-ctrl;
> + cts-gpios = <&gpioa 15 GPIO_ACTIVE_LOW>;
> + rts-gpios = <&gpiob 0 GPIO_ACTIVE_LOW>;
> + status = "okay";
> +
> + bluetooth {
> + shutdown-gpios = <&gpiog 2 GPIO_ACTIVE_HIGH>;
> + compatible = "brcm,bcm43438-bt";
> + max-speed = <115200>;
> + };
> +};
>
prev parent reply other threads:[~2020-04-29 8:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 17:31 [PATCH 0/6] Add Stinger96 and IoT Box board support mani
2020-04-20 17:31 ` [PATCH 1/6] dt-bindings: Add vendor prefix for Shiratech Solutions mani
2020-04-20 17:31 ` [PATCH 2/6] ARM: dts: Add missing pinctrl entries for STM32MP15 mani
2020-04-21 11:16 ` Alexandre Torgue
2020-04-20 17:31 ` [PATCH 3/6] dt-bindings: arm: stm32: Document Stinger96 compatible mani
2020-04-20 17:31 ` [PATCH 4/6] ARM: dts: stm32mp1: Add Stinger96 board support mani
2020-04-20 17:31 ` [PATCH 5/6] dt-bindings: arm: stm32: Document IoT Box compatible mani
2020-04-20 17:31 ` [PATCH 6/6] ARM: dts: stm32mp1: Add IoT Box board support mani
2020-04-29 8:02 ` Alexandre Torgue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=210a98b3-feea-8faf-316c-d45e1697ea21@st.com \
--to=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mani@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).