From: Harvey Hunt <Harvey.Hunt@imgtec.com>
To: James Hogan <james.hogan@imgtec.com>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>, <matthias.bgg@gmail.com>, <kishon@ti.com>
Cc: John Crispin <john@phrozen.org>, <linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [V4 1/2] phy: ralink-usb: add driver for Mediatek/Ralink
Date: Thu, 10 Aug 2017 17:00:17 +0100 [thread overview]
Message-ID: <21122b7e-dd7d-1a83-f4c4-2fbd64622e8e@imgtec.com> (raw)
In-Reply-To: <F7B73EAF-B32D-4FBC-BE9D-855954027CC0@imgtec.com>
Hi James,
On 09/08/17 23:23, James Hogan wrote:
> On 9 August 2017 10:35:39 BST, Harvey Hunt <harvey.hunt@imgtec.com> wrote:
>> From: John Crispin <john@phrozen.org>
>>
>> Add a driver to setup the USB phy on Mediatek/Ralink SoCs.
>> The driver is trivial and only sets up power and host mode.
>>
>> Signed-off-by: John Crispin <john@phrozen.org>
>> Signed-off-by: Harvey Hunt <harvey.hunt@imgtec.com>
>> Cc: linux-kernel@vger.kernel.org
>> Cc: linux-mediatek@lists.infradead.org
>> ---
>> Changes in V4
>> * Remove Allwinner from comment
>> * Depend on COMPILE_TEST
>>
>> Changes in V3
>> * Separate DT bindings
>> * Update Kconfig text
>> * Modify John's email address
>> * Rebase onto v4.13-rc3
>>
>> Changes in V2
>> * remove refcounting
>> * drop empty functions
>> * dont use static globals
>> * use explicit compatible strings
>>
>> drivers/phy/Kconfig | 8 ++
>> drivers/phy/Makefile | 1 +
>> drivers/phy/phy-ralink-usb.c | 173
>> +++++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 182 insertions(+)
>> create mode 100644 drivers/phy/phy-ralink-usb.c
>>
>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>> index c1807d4..8fb5260 100644
>> --- a/drivers/phy/Kconfig
>> +++ b/drivers/phy/Kconfig
>> @@ -41,6 +41,14 @@ config PHY_PISTACHIO_USB
>> help
>> Enable this to support the USB2.0 PHY on the IMG Pistachio SoC.
>>
>> +config PHY_RALINK_USB
>> + tristate "Ralink USB PHY driver"
>> + select GENERIC_PHY
>> + depends on RALINK || COMPILE_TEST
>
> given that the driver includes a asm/mach-ralink header, the COMPILE_TEST bit may break x86 allmodconfig?
>
> maybe the header should be moved out of arch/mips or it should depend on MIPS only (so a mips allmodconfig catches it, but cant be enabled on x86 even with COMPILE_TEST=y)
>
> cheers
> James
>
[...]
Well spotted - the build does indeed fail for ARCH=x86 allmodconfig.
I could either use:
depends on RALINK || (COMPILE_TEST && MIPS)
or just drop the COMPILE_TEST altogether, as I don't know how many
people are running compile test only on MIPS.
Thanks,
Harvey
prev parent reply other threads:[~2017-08-10 16:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 9:35 [V4 1/2] phy: ralink-usb: add driver for Mediatek/Ralink Harvey Hunt
2017-08-09 9:35 ` [V4 2/2] dt-bindings: phy: Add bindings for ralink-usb PHY Harvey Hunt
2017-08-09 22:23 ` [V4 1/2] phy: ralink-usb: add driver for Mediatek/Ralink James Hogan
2017-08-10 16:00 ` Harvey Hunt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21122b7e-dd7d-1a83-f4c4-2fbd64622e8e@imgtec.com \
--to=harvey.hunt@imgtec.com \
--cc=james.hogan@imgtec.com \
--cc=john@phrozen.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).